From: Linus Walleij <linus.walleij@linaro.org> To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, OpenBMC Maillist <openbmc@lists.ozlabs.org>, Tomer Maimon <tmaimon77@gmail.com>, Joel Stanley <joel@jms.id.au>, linux-kernel <linux-kernel@vger.kernel.org>, Avi Fishman <avifishman70@gmail.com>, Tali Perry <tali.perry1@gmail.com>, Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com> Subject: Re: [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) Date: Fri, 4 Jun 2021 10:00:18 +0200 [thread overview] Message-ID: <CACRpkdaC8jzzE=9TSs-eRy3j3fk3=k_xhgjPXw7DW=rK=Csx0g@mail.gmail.com> (raw) In-Reply-To: <20210602120329.2444672-2-j.neuschaefer@gmx.net> On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and > version information. > > This patch adds a binding to describe this node. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> (...) > + gcr: gcr@800000 { > + compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd"; > + reg = <0x800000 0x1000>; > + }; gcr looks a bit idiomatic, isn't syscon: syscon@... better? Nitpicky though and looks good to me either way: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org> To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Tomer Maimon <tmaimon77@gmail.com>, Avi Fishman <avifishman70@gmail.com>, Patrick Venture <venture@google.com>, OpenBMC Maillist <openbmc@lists.ozlabs.org>, linux-kernel <linux-kernel@vger.kernel.org>, Tali Perry <tali.perry1@gmail.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Benjamin Fair <benjaminfair@google.com> Subject: Re: [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) Date: Fri, 4 Jun 2021 10:00:18 +0200 [thread overview] Message-ID: <CACRpkdaC8jzzE=9TSs-eRy3j3fk3=k_xhgjPXw7DW=rK=Csx0g@mail.gmail.com> (raw) In-Reply-To: <20210602120329.2444672-2-j.neuschaefer@gmx.net> On Wed, Jun 2, 2021 at 2:04 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and > version information. > > This patch adds a binding to describe this node. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> (...) > + gcr: gcr@800000 { > + compatible = "nuvoton,npcm750-gcr", "syscon", "simple-mfd"; > + reg = <0x800000 0x1000>; > + }; gcr looks a bit idiomatic, isn't syscon: syscon@... better? Nitpicky though and looks good to me either way: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
next prev parent reply other threads:[~2021-06-04 8:01 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 12:03 [PATCH 0/8] Nuvoton WPCM450 pinctrl and GPIO driver Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 8:00 ` Linus Walleij [this message] 2021-06-04 8:00 ` Linus Walleij 2021-06-13 9:20 ` Jonathan Neuschäfer 2021-06-13 9:20 ` Jonathan Neuschäfer 2021-06-15 23:43 ` Rob Herring 2021-06-15 23:43 ` Rob Herring 2021-06-19 10:08 ` Jonathan Neuschäfer 2021-06-19 10:08 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 2/8] MAINTAINERS: Match all of bindings/arm/npcm/ as part of NPCM architecture Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 8:01 ` Linus Walleij 2021-06-04 8:01 ` Linus Walleij 2021-06-13 9:23 ` Jonathan Neuschäfer 2021-06-13 9:23 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450 Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 9:35 ` Linus Walleij 2021-06-04 9:35 ` Linus Walleij 2021-06-13 9:53 ` Jonathan Neuschäfer 2021-06-13 9:53 ` Jonathan Neuschäfer 2021-06-15 23:45 ` Rob Herring 2021-06-15 23:45 ` Rob Herring 2021-06-19 10:17 ` Jonathan Neuschäfer 2021-06-19 10:17 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 5/8] pinctrl: nuvoton: Add driver for WPCM450 Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:50 ` Andy Shevchenko 2021-06-02 12:50 ` Andy Shevchenko 2021-06-12 23:20 ` Jonathan Neuschäfer 2021-06-12 23:20 ` Jonathan Neuschäfer 2021-06-13 10:06 ` Andy Shevchenko 2021-06-13 10:06 ` Andy Shevchenko 2021-06-13 19:08 ` Jonathan Neuschäfer 2021-06-13 19:08 ` Jonathan Neuschäfer 2021-06-02 14:31 ` kernel test robot 2021-06-02 14:31 ` kernel test robot 2021-06-02 14:31 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-04 9:31 ` Linus Walleij 2021-06-04 9:31 ` Linus Walleij 2021-06-13 10:26 ` Jonathan Neuschäfer 2021-06-13 10:26 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 6/8] ARM: dts: wpcm450: Add pinctrl node Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 7/8] ARM: dts: wpcm450: Add pin functions Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 8/8] ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add GPIO LEDs and buttons Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdaC8jzzE=9TSs-eRy3j3fk3=k_xhgjPXw7DW=rK=Csx0g@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=devicetree@vger.kernel.org \ --cc=j.neuschaefer@gmx.net \ --cc=joel@jms.id.au \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=tali.perry1@gmail.com \ --cc=tmaimon77@gmail.com \ --cc=venture@google.com \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.