From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: Rob Herring <robh@kernel.org> Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, "Linus Walleij" <linus.walleij@linaro.org>, openbmc@lists.ozlabs.org, "Tomer Maimon" <tmaimon77@gmail.com>, "Joel Stanley" <joel@jms.id.au>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450 Date: Sat, 19 Jun 2021 12:17:03 +0200 [thread overview] Message-ID: <YM3EH6Cu2GsLjd3O@latitude> (raw) In-Reply-To: <20210615234558.GA1684841@robh.at.kernel.org> [-- Attachment #1: Type: text/plain, Size: 1687 bytes --] On Tue, Jun 15, 2021 at 05:45:58PM -0600, Rob Herring wrote: > On Wed, Jun 02, 2021 at 02:03:25PM +0200, Jonathan Neuschäfer wrote: > > This binding is heavily based on the one for NPCM7xx, because the > > hardware is similar. One notable difference is that there are no > > sub-nodes for GPIO banks, because the GPIO registers are arranged > > differently. > > > > Certain pins support blink patterns in hardware. This is currently not > > modelled in the DT binding. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > --- [...] > > +properties: > > + compatible: > > + const: "nuvoton,wpcm450-pinctrl" > > Don't need quotes. Ok, I'll remove them. > > > + > > + reg: > > + maxItems: 1 > > + > > + gpio-controller: true > > + > > + '#gpio-cells': > > + const: 2 > > + > > + interrupt-controller: true > > + > > + "#interrupt-cells": > > + const: 2 and I just noticed the inconsistency in quotes here. I'll fix it. > > + > > + interrupts: true > > + > > +patternProperties: > > + # There are two kinds of subnodes: > > + # 1. a pinmux node configures pin muxing for a group of pins (e.g. rmii2) > > + # 2. a pinctrl node configures properties of a single pin > > + "^.*$": > > + if: > > + type: object > > + then: > > Don't do this hack for new bindings. Pick a node name pattern you can > match on. Ok. > > > + allOf: > > + - $ref: pincfg-node.yaml# > > + - $ref: pinmux-node.yaml# > > + properties: [...] > > + phandle: true > > Needing this should be fixed now. Ok, I'll drop it. Thanks, Jonathan Neuschäfer [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, "Tomer Maimon" <tmaimon77@gmail.com>, openbmc@lists.ozlabs.org, "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, "Linus Walleij" <linus.walleij@linaro.org> Subject: Re: [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450 Date: Sat, 19 Jun 2021 12:17:03 +0200 [thread overview] Message-ID: <YM3EH6Cu2GsLjd3O@latitude> (raw) In-Reply-To: <20210615234558.GA1684841@robh.at.kernel.org> [-- Attachment #1: Type: text/plain, Size: 1687 bytes --] On Tue, Jun 15, 2021 at 05:45:58PM -0600, Rob Herring wrote: > On Wed, Jun 02, 2021 at 02:03:25PM +0200, Jonathan Neuschäfer wrote: > > This binding is heavily based on the one for NPCM7xx, because the > > hardware is similar. One notable difference is that there are no > > sub-nodes for GPIO banks, because the GPIO registers are arranged > > differently. > > > > Certain pins support blink patterns in hardware. This is currently not > > modelled in the DT binding. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > --- [...] > > +properties: > > + compatible: > > + const: "nuvoton,wpcm450-pinctrl" > > Don't need quotes. Ok, I'll remove them. > > > + > > + reg: > > + maxItems: 1 > > + > > + gpio-controller: true > > + > > + '#gpio-cells': > > + const: 2 > > + > > + interrupt-controller: true > > + > > + "#interrupt-cells": > > + const: 2 and I just noticed the inconsistency in quotes here. I'll fix it. > > + > > + interrupts: true > > + > > +patternProperties: > > + # There are two kinds of subnodes: > > + # 1. a pinmux node configures pin muxing for a group of pins (e.g. rmii2) > > + # 2. a pinctrl node configures properties of a single pin > > + "^.*$": > > + if: > > + type: object > > + then: > > Don't do this hack for new bindings. Pick a node name pattern you can > match on. Ok. > > > + allOf: > > + - $ref: pincfg-node.yaml# > > + - $ref: pinmux-node.yaml# > > + properties: [...] > > + phandle: true > > Needing this should be fixed now. Ok, I'll drop it. Thanks, Jonathan Neuschäfer [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-19 10:17 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 12:03 [PATCH 0/8] Nuvoton WPCM450 pinctrl and GPIO driver Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 1/8] dt-bindings: arm/npcm: Add binding for global control registers (GCR) Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 8:00 ` Linus Walleij 2021-06-04 8:00 ` Linus Walleij 2021-06-13 9:20 ` Jonathan Neuschäfer 2021-06-13 9:20 ` Jonathan Neuschäfer 2021-06-15 23:43 ` Rob Herring 2021-06-15 23:43 ` Rob Herring 2021-06-19 10:08 ` Jonathan Neuschäfer 2021-06-19 10:08 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 2/8] MAINTAINERS: Match all of bindings/arm/npcm/ as part of NPCM architecture Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 3/8] ARM: dts: wpcm450: Add global control registers (GCR) node Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 8:01 ` Linus Walleij 2021-06-04 8:01 ` Linus Walleij 2021-06-13 9:23 ` Jonathan Neuschäfer 2021-06-13 9:23 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 4/8] dt-bindings: pinctrl: Add Nuvoton WPCM450 Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-04 9:35 ` Linus Walleij 2021-06-04 9:35 ` Linus Walleij 2021-06-13 9:53 ` Jonathan Neuschäfer 2021-06-13 9:53 ` Jonathan Neuschäfer 2021-06-15 23:45 ` Rob Herring 2021-06-15 23:45 ` Rob Herring 2021-06-19 10:17 ` Jonathan Neuschäfer [this message] 2021-06-19 10:17 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 5/8] pinctrl: nuvoton: Add driver for WPCM450 Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:50 ` Andy Shevchenko 2021-06-02 12:50 ` Andy Shevchenko 2021-06-12 23:20 ` Jonathan Neuschäfer 2021-06-12 23:20 ` Jonathan Neuschäfer 2021-06-13 10:06 ` Andy Shevchenko 2021-06-13 10:06 ` Andy Shevchenko 2021-06-13 19:08 ` Jonathan Neuschäfer 2021-06-13 19:08 ` Jonathan Neuschäfer 2021-06-02 14:31 ` kernel test robot 2021-06-02 14:31 ` kernel test robot 2021-06-02 14:31 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-03 18:33 ` kernel test robot 2021-06-04 9:31 ` Linus Walleij 2021-06-04 9:31 ` Linus Walleij 2021-06-13 10:26 ` Jonathan Neuschäfer 2021-06-13 10:26 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 6/8] ARM: dts: wpcm450: Add pinctrl node Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 7/8] ARM: dts: wpcm450: Add pin functions Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer 2021-06-02 12:03 ` [PATCH 8/8] ARM: dts: wpcm450-supermicro-x9sci-ln4f: Add GPIO LEDs and buttons Jonathan Neuschäfer 2021-06-02 12:03 ` Jonathan Neuschäfer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YM3EH6Cu2GsLjd3O@latitude \ --to=j.neuschaefer@gmx.net \ --cc=devicetree@vger.kernel.org \ --cc=joel@jms.id.au \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=openbmc@lists.ozlabs.org \ --cc=robh@kernel.org \ --cc=tmaimon77@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.