* [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option
@ 2022-11-10 11:37 Heinrich Schuchardt
2022-11-10 11:44 ` Ilias Apalodimas
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2022-11-10 11:37 UTC (permalink / raw)
To: Ilias Apalodimas; +Cc: Masahisa Kojima, u-boot, Heinrich Schuchardt
Goto for an immediately succeeding label is superfluous.
Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
Addresses-Coverity: 376202 ("Identical code for different branches")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
cmd/eficonfig.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
index 2595dd9563..0dc6e7b01e 100644
--- a/cmd/eficonfig.c
+++ b/cmd/eficonfig.c
@@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo
}
ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp);
- if (ret != EFI_SUCCESS)
- goto out;
out:
free(tmp);
free(bo->optional_data);
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option
2022-11-10 11:37 [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option Heinrich Schuchardt
@ 2022-11-10 11:44 ` Ilias Apalodimas
0 siblings, 0 replies; 2+ messages in thread
From: Ilias Apalodimas @ 2022-11-10 11:44 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Masahisa Kojima, u-boot
On Thu, 10 Nov 2022 at 13:37, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> Goto for an immediately succeeding label is superfluous.
>
> Fixes: 87d791423ac6 ("eficonfig: menu-driven addition of UEFI boot option")
> Addresses-Coverity: 376202 ("Identical code for different branches")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> cmd/eficonfig.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index 2595dd9563..0dc6e7b01e 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -1527,8 +1527,6 @@ static efi_status_t eficonfig_edit_boot_option(u16 *varname, struct eficonfig_bo
> }
>
> ret = eficonfig_set_boot_option(varname, final_dp, final_dp_size, bo->description, tmp);
> - if (ret != EFI_SUCCESS)
> - goto out;
> out:
> free(tmp);
> free(bo->optional_data);
> --
> 2.37.2
>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-10 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 11:37 [PATCH 1/1] cmd: remove superfluous if in eficonfig_edit_boot_option Heinrich Schuchardt
2022-11-10 11:44 ` Ilias Apalodimas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.