From: Keiichi Watanabe <keiichiw@chromium.org> To: Gerd Hoffmann <kraxel@redhat.com> Cc: "Tomasz Figa" <tfiga@chromium.org>, "Dmitry Sepp" <dmitry.sepp@opensynergy.com>, spice-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org, "Linux Media Mailing List" <linux-media@vger.kernel.org>, "Alexandre Courbot" <acourbot@chromium.org>, "Alex Lau" <alexlau@chromium.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Dylan Reid" <dgreid@chromium.org>, "Enrico Granata" <egranata@google.com>, "Frediano Ziglio" <fziglio@redhat.com>, "Hans Verkuil" <hverkuil@xs4all.nl>, "Stéphane Marchesin" <marcheu@chromium.org>, "Pawel Osciak" <posciak@chromium.org>, "David Stevens" <stevensd@chromium.org>, uril@redhat.com Subject: Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification Date: Tue, 21 Jan 2020 11:47:20 +0900 [thread overview] Message-ID: <CAD90Vcak0iohLny9UjkqtBmM0px7Rz1mqQE6jw1wdu66QB4U3Q@mail.gmail.com> (raw) In-Reply-To: <20200120104755.3hhxlx6x6o32bagf@sirius.home.kraxel.org> Hi, On Mon, Jan 20, 2020 at 7:48 PM Gerd Hoffmann <kraxel@redhat.com> wrote: > > Hi, > > > > Hmm, using (ii) the API, then check whenever your three plane buffers > > > happen to have the correct layout for (1) hardware looks somewhat > > > backwards to me. > > > > Can't this problem be solved by adding "offset" field in virtio_video_mem_entry? > > > > struct virtio_video_mem_entry { > > le64 addr; > > le32 length; > > le32 offset; > > u8 padding[4]; > > }; > > > > Here, "addr" must be the same in every mem_entry for (1) hardware. > > No. virtio_video_mem_entry is basically a scatter list entry, you use > an *array* of these entries to describe your buffer (unless you are > using CMA due to hardware requirements, in this special case you have > only one entry in your array). I see. I forgot about scatter list. However, I'm still not sure about the usage for CMA. if we're using CMA for a multiplanar format, how can the device know where the second plane start from? In my understanding, the number of entries in this case should be the same with the number of planes and "entries[0].addr + entries[0].length == entries[1].addr" should hold. > > > > I'd suggest to use (i) API and allow the device specify alignment > > > requirements. So (1) hardware would say "need_align=0", whereas (3) > > > hardware would probably say "need_align=PAGE_SIZE" so it can easily > > > split the single buffer into three per-plane buffers. > > > > Just to confirm, is "need_align" a field added in virtio_video_format_desc? > > Given that different formats might have different alignment > requirements this looks like a good place to me. Maybe rename to > plane_align to make clear what kind of alignment this is. "plane_align" sounds better. Thanks. Best regards, Keiichi > > cheers, > Gerd >
WARNING: multiple messages have this Message-ID (diff)
From: Keiichi Watanabe <keiichiw@chromium.org> To: Gerd Hoffmann <kraxel@redhat.com> Cc: "Tomasz Figa" <tfiga@chromium.org>, "Dmitry Sepp" <dmitry.sepp@opensynergy.com>, spice-devel@lists.freedesktop.org, virtio-dev@lists.oasis-open.org, "Linux Media Mailing List" <linux-media@vger.kernel.org>, "Alexandre Courbot" <acourbot@chromium.org>, "Alex Lau" <alexlau@chromium.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Dylan Reid" <dgreid@chromium.org>, "Enrico Granata" <egranata@google.com>, "Frediano Ziglio" <fziglio@redhat.com>, "Hans Verkuil" <hverkuil@xs4all.nl>, "Stéphane Marchesin" <marcheu@chromium.org>, "Pawel Osciak" <posciak@chromium.org>, "David Stevens" <stevensd@chromium.org>, uril@redhat.com Subject: Re: [virtio-dev] Re: [PATCH v2 0/1] VirtIO video device specification Date: Tue, 21 Jan 2020 11:47:20 +0900 [thread overview] Message-ID: <CAD90Vcak0iohLny9UjkqtBmM0px7Rz1mqQE6jw1wdu66QB4U3Q@mail.gmail.com> (raw) In-Reply-To: <20200120104755.3hhxlx6x6o32bagf@sirius.home.kraxel.org> Hi, On Mon, Jan 20, 2020 at 7:48 PM Gerd Hoffmann <kraxel@redhat.com> wrote: > > Hi, > > > > Hmm, using (ii) the API, then check whenever your three plane buffers > > > happen to have the correct layout for (1) hardware looks somewhat > > > backwards to me. > > > > Can't this problem be solved by adding "offset" field in virtio_video_mem_entry? > > > > struct virtio_video_mem_entry { > > le64 addr; > > le32 length; > > le32 offset; > > u8 padding[4]; > > }; > > > > Here, "addr" must be the same in every mem_entry for (1) hardware. > > No. virtio_video_mem_entry is basically a scatter list entry, you use > an *array* of these entries to describe your buffer (unless you are > using CMA due to hardware requirements, in this special case you have > only one entry in your array). I see. I forgot about scatter list. However, I'm still not sure about the usage for CMA. if we're using CMA for a multiplanar format, how can the device know where the second plane start from? In my understanding, the number of entries in this case should be the same with the number of planes and "entries[0].addr + entries[0].length == entries[1].addr" should hold. > > > > I'd suggest to use (i) API and allow the device specify alignment > > > requirements. So (1) hardware would say "need_align=0", whereas (3) > > > hardware would probably say "need_align=PAGE_SIZE" so it can easily > > > split the single buffer into three per-plane buffers. > > > > Just to confirm, is "need_align" a field added in virtio_video_format_desc? > > Given that different formats might have different alignment > requirements this looks like a good place to me. Maybe rename to > plane_align to make clear what kind of alignment this is. "plane_align" sounds better. Thanks. Best regards, Keiichi > > cheers, > Gerd > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2020-01-21 2:47 UTC|newest] Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-18 13:02 [PATCH v2 0/1] VirtIO video device specification Keiichi Watanabe 2019-12-18 13:02 ` [virtio-dev] " Keiichi Watanabe 2019-12-18 13:02 ` [PATCH v2 1/1] virtio-video: Add virtio " Keiichi Watanabe 2019-12-18 13:02 ` [virtio-dev] " Keiichi Watanabe 2019-12-18 13:40 ` Gerd Hoffmann 2019-12-18 13:40 ` [virtio-dev] " Gerd Hoffmann 2019-12-18 14:08 ` Tomasz Figa 2019-12-18 14:08 ` Tomasz Figa 2019-12-19 7:46 ` Gerd Hoffmann 2019-12-19 7:46 ` Gerd Hoffmann 2019-12-19 9:48 ` Dmitry Sepp 2019-12-19 9:48 ` Dmitry Sepp 2019-12-19 9:59 ` Tomasz Figa 2019-12-19 9:59 ` Tomasz Figa 2019-12-19 10:54 ` Dmitry Sepp 2019-12-19 10:54 ` Dmitry Sepp 2019-12-19 12:05 ` Tomasz Figa 2019-12-19 12:05 ` Tomasz Figa 2019-12-19 13:12 ` Gerd Hoffmann 2019-12-19 13:12 ` Gerd Hoffmann 2020-01-08 13:52 ` Keiichi Watanabe 2020-01-08 13:52 ` Keiichi Watanabe 2020-01-09 13:40 ` Gerd Hoffmann 2020-01-09 13:40 ` Gerd Hoffmann 2020-01-09 14:20 ` Tomasz Figa 2020-01-09 14:20 ` Tomasz Figa 2020-01-14 7:18 ` Keiichi Watanabe 2020-01-14 7:18 ` Keiichi Watanabe 2020-01-14 10:35 ` Dmitry Sepp 2020-01-14 10:35 ` Dmitry Sepp 2020-01-15 7:49 ` Keiichi Watanabe 2020-01-15 7:49 ` Keiichi Watanabe 2020-01-15 11:12 ` Tomasz Figa 2020-01-15 11:12 ` Tomasz Figa 2019-12-19 13:01 ` Gerd Hoffmann 2019-12-19 13:01 ` Gerd Hoffmann 2020-01-08 13:50 ` Keiichi Watanabe 2020-01-08 13:50 ` Keiichi Watanabe 2019-12-19 9:26 ` Dmitry Sepp 2019-12-19 9:26 ` [virtio-dev] " Dmitry Sepp 2019-12-19 9:59 ` Tomasz Figa 2019-12-19 9:59 ` [virtio-dev] " Tomasz Figa 2019-12-19 12:54 ` Gerd Hoffmann 2019-12-19 12:54 ` [virtio-dev] " Gerd Hoffmann 2019-12-18 17:29 ` Frediano Ziglio 2019-12-20 14:05 ` Keiichi Watanabe 2019-12-20 14:05 ` [virtio-dev] " Keiichi Watanabe 2019-12-20 15:33 ` Dmitry Sepp 2019-12-20 15:33 ` [virtio-dev] " Dmitry Sepp 2019-12-19 13:28 ` Dmitry Sepp 2019-12-19 13:28 ` [virtio-dev] " Dmitry Sepp 2019-12-20 15:26 ` Keiichi Watanabe 2019-12-20 15:26 ` [virtio-dev] " Keiichi Watanabe 2019-12-20 15:46 ` Dmitry Sepp 2019-12-21 6:46 ` Tomasz Figa 2019-12-21 6:46 ` [virtio-dev] " Tomasz Figa 2019-12-30 12:16 ` Dmitry Sepp 2019-12-30 12:16 ` Dmitry Sepp 2020-01-06 6:31 ` Tomasz Figa 2020-01-06 6:31 ` Tomasz Figa 2020-01-06 8:33 ` Gerd Hoffmann 2020-01-06 8:33 ` Gerd Hoffmann 2020-01-06 9:29 ` Dmitry Sepp 2020-01-06 9:29 ` Dmitry Sepp 2020-01-03 15:47 ` Dmitry Sepp 2020-01-03 15:47 ` [virtio-dev] " Dmitry Sepp 2020-01-06 8:47 ` Gerd Hoffmann 2020-01-06 8:47 ` [virtio-dev] " Gerd Hoffmann 2020-01-06 10:21 ` Keiichi Watanabe 2020-01-06 10:21 ` [virtio-dev] " Keiichi Watanabe 2020-01-06 14:59 ` Dmitry Sepp 2020-01-06 14:59 ` [virtio-dev] " Dmitry Sepp 2020-01-07 13:24 ` Keiichi Watanabe 2020-01-07 13:24 ` [virtio-dev] " Keiichi Watanabe 2020-01-07 16:50 ` Dmitry Sepp 2020-01-07 16:50 ` [virtio-dev] " Dmitry Sepp 2020-01-08 6:59 ` Keiichi Watanabe 2020-01-08 6:59 ` [virtio-dev] " Keiichi Watanabe 2020-01-08 10:00 ` Dmitry Sepp 2020-01-08 10:00 ` [virtio-dev] " Dmitry Sepp 2020-01-08 12:14 ` Keiichi Watanabe 2020-01-08 12:14 ` [virtio-dev] " Keiichi Watanabe 2020-01-08 12:46 ` Tomasz Figa 2020-01-08 12:46 ` [virtio-dev] " Tomasz Figa 2020-01-08 13:05 ` Keiichi Watanabe 2020-01-08 13:05 ` [virtio-dev] " Keiichi Watanabe 2020-01-08 13:11 ` Dmitry Sepp 2020-01-08 13:11 ` [virtio-dev] " Dmitry Sepp 2020-01-08 13:23 ` Keiichi Watanabe 2020-01-08 13:23 ` Keiichi Watanabe 2020-01-08 12:23 ` Keiichi Watanabe 2020-01-08 12:23 ` [virtio-dev] " Keiichi Watanabe 2019-12-20 15:58 ` [PATCH v2 0/1] VirtIO " Dmitry Sepp 2019-12-20 15:58 ` [virtio-dev] " Dmitry Sepp 2019-12-21 4:36 ` Keiichi Watanabe 2019-12-21 4:36 ` [virtio-dev] " Keiichi Watanabe 2019-12-21 6:18 ` Tomasz Figa 2019-12-21 6:18 ` [virtio-dev] " Tomasz Figa 2019-12-21 6:19 ` Tomasz Figa 2019-12-21 6:19 ` [virtio-dev] " Tomasz Figa 2020-01-03 13:05 ` Dmitry Sepp 2020-01-03 13:05 ` [virtio-dev] " Dmitry Sepp 2020-01-06 10:30 ` Keiichi Watanabe 2020-01-06 10:30 ` [virtio-dev] " Keiichi Watanabe 2020-01-06 11:28 ` Dmitry Sepp 2020-01-06 11:28 ` [virtio-dev] " Dmitry Sepp 2020-01-07 10:25 ` Keiichi Watanabe 2020-01-07 10:25 ` [virtio-dev] " Keiichi Watanabe 2020-01-09 14:56 ` Dmitry Sepp 2020-01-09 14:56 ` [virtio-dev] " Dmitry Sepp 2020-01-10 10:16 ` Dmitry Sepp 2020-01-10 10:16 ` Dmitry Sepp 2020-01-10 13:53 ` Keiichi Watanabe 2020-01-10 13:53 ` Keiichi Watanabe 2020-01-10 15:11 ` Dmitry Sepp 2020-01-10 15:11 ` Dmitry Sepp 2020-01-11 16:06 ` Tomasz Figa 2020-01-11 16:06 ` Tomasz Figa 2020-01-13 9:50 ` Dmitry Sepp 2020-01-13 9:50 ` Dmitry Sepp 2020-01-15 11:23 ` Keiichi Watanabe 2020-01-15 11:23 ` Keiichi Watanabe 2020-01-13 9:56 ` Gerd Hoffmann 2020-01-13 9:56 ` Gerd Hoffmann 2020-01-13 10:41 ` Dmitry Sepp 2020-01-13 11:05 ` Gerd Hoffmann 2020-01-13 11:05 ` Gerd Hoffmann 2020-01-13 11:59 ` Tomasz Figa 2020-01-13 11:59 ` Tomasz Figa 2020-01-13 13:26 ` Gerd Hoffmann 2020-01-13 13:26 ` Gerd Hoffmann 2020-01-15 11:00 ` Tomasz Figa 2020-01-15 11:00 ` Tomasz Figa 2020-01-15 11:23 ` Keiichi Watanabe 2020-01-15 11:23 ` Keiichi Watanabe 2020-01-15 11:26 ` Gerd Hoffmann 2020-01-15 11:26 ` Gerd Hoffmann 2020-01-20 7:20 ` Keiichi Watanabe 2020-01-20 7:20 ` Keiichi Watanabe 2020-01-20 10:47 ` Gerd Hoffmann 2020-01-20 10:47 ` Gerd Hoffmann 2020-01-21 2:47 ` Keiichi Watanabe [this message] 2020-01-21 2:47 ` Keiichi Watanabe 2020-01-21 6:44 ` Gerd Hoffmann 2020-01-21 6:44 ` Gerd Hoffmann 2020-01-21 8:56 ` Keiichi Watanabe 2020-01-21 8:56 ` Keiichi Watanabe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAD90Vcak0iohLny9UjkqtBmM0px7Rz1mqQE6jw1wdu66QB4U3Q@mail.gmail.com \ --to=keiichiw@chromium.org \ --cc=acourbot@chromium.org \ --cc=alexlau@chromium.org \ --cc=daniel@ffwll.ch \ --cc=dgreid@chromium.org \ --cc=dmitry.sepp@opensynergy.com \ --cc=egranata@google.com \ --cc=fziglio@redhat.com \ --cc=hverkuil@xs4all.nl \ --cc=kraxel@redhat.com \ --cc=linux-media@vger.kernel.org \ --cc=marcheu@chromium.org \ --cc=posciak@chromium.org \ --cc=spice-devel@lists.freedesktop.org \ --cc=stevensd@chromium.org \ --cc=tfiga@chromium.org \ --cc=uril@redhat.com \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.