* [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
@ 2019-03-07 2:58 Dengke Du
2019-03-07 14:00 ` Mark Hatle
2019-03-14 0:11 ` ddu
0 siblings, 2 replies; 11+ messages in thread
From: Dengke Du @ 2019-03-07 2:58 UTC (permalink / raw)
To: meta-virtualization
The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
so we should append it, not override.
Signed-off-by: Dengke Du <dengke.du@windriver.com>
---
meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
index b55f9a9..0b0f011 100644
--- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
+++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
@@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
inherit useradd
USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "--system libvirt"
+GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
do_install_append() {
sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
--
2.7.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-07 2:58 [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict Dengke Du
@ 2019-03-07 14:00 ` Mark Hatle
2019-03-08 2:44 ` ddu
2019-03-08 6:00 ` ddu
2019-03-14 0:11 ` ddu
1 sibling, 2 replies; 11+ messages in thread
From: Mark Hatle @ 2019-03-07 14:00 UTC (permalink / raw)
To: Dengke Du, meta-virtualization
On 3/6/19 8:58 PM, Dengke Du wrote:
> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> so we should append it, not override.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> index b55f9a9..0b0f011 100644
> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>
> inherit useradd
> USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM_${PN} = "--system libvirt"
> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
The __append should be fine then, but why the ';'? That part looks wrong, since
typically the PARAM is the parameters passed directly to the groupadd program.
I don't believe ';' is a valid parameter.
--Mark
> do_install_append() {
> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-07 14:00 ` Mark Hatle
@ 2019-03-08 2:44 ` ddu
2019-03-08 3:26 ` ddu
2019-03-08 6:00 ` ddu
1 sibling, 1 reply; 11+ messages in thread
From: ddu @ 2019-03-08 2:44 UTC (permalink / raw)
To: Mark Hatle, meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 2565 bytes --]
在 2019/3/7 下午10:00, Mark Hatle 写道:
> On 3/6/19 8:58 PM, Dengke Du wrote:
>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
>> so we should append it, not override.
>>
>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>> ---
>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> index b55f9a9..0b0f011 100644
>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>>
>> inherit useradd
>> USERADD_PACKAGES = "${PN}"
>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> The __append should be fine then, but why the ';'? That part looks wrong, since
> typically the PARAM is the parameters passed directly to the groupadd program.
> I don't believe ';' is a valid parameter.
First, adding ';' or not adding ';' are the same for building libvirt,
the group: qemu, kvm, libvirt are all created successfully.
Second, adding ';' just according to some processing rule from the link:
https://git.openembedded.org/openembedded-core/tree/meta/classes/useradd.bbclass#n54
-----------------------------------------------------------------------------------------------------------------------
if test "x`echo $GROUPADD_PARAM | tr -d '[:space:]'`" != "x"; then
echo "Running groupadd commands..."
# Invoke multiple instances of groupadd for parameter lists
# separated by ';'
opts=`echo "$GROUPADD_PARAM" | cut -d ';' -f 1 | sed -e 's#[ \t]*$##'`
remaining=`echo "$GROUPADD_PARAM" | cut -d ';' -f 2- | sed -e 's#[ \t]*$##'`
while test "x$opts" != "x"; do
perform_groupadd "$SYSROOT" "$OPT $opts"
if test "x$opts" = "x$remaining"; then
break
fi
opts=`echo "$remaining" | cut -d ';' -f 1 | sed -e 's#[ \t]*$##'`
remaining=`echo "$remaining" | cut -d ';' -f 2- | sed -e 's#[ \t]*$##'`
done
fi
-----------------------------------------------------------------------------------------------------------------------
Maybe in order to let the codes see more orderly.
>
> --Mark
>
>> do_install_append() {
>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>>
>
[-- Attachment #2: Type: text/html, Size: 4111 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-08 2:44 ` ddu
@ 2019-03-08 3:26 ` ddu
0 siblings, 0 replies; 11+ messages in thread
From: ddu @ 2019-03-08 3:26 UTC (permalink / raw)
To: meta-virtualization
[-- Attachment #1: Type: text/plain, Size: 2719 bytes --]
在 2019/3/8 上午10:44, ddu 写道:
>
>
> 在 2019/3/7 下午10:00, Mark Hatle 写道:
>> On 3/6/19 8:58 PM, Dengke Du wrote:
>>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
>>> so we should append it, not override.
>>>
>>> Signed-off-by: Dengke Du<dengke.du@windriver.com>
>>> ---
>>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> index b55f9a9..0b0f011 100644
>>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>>>
>>> inherit useradd
>>> USERADD_PACKAGES = "${PN}"
>>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
>> The __append should be fine then, but why the ';'? That part looks wrong, since
>> typically the PARAM is the parameters passed directly to the groupadd program.
>> I don't believe ';' is a valid parameter.
>
> First, adding ';' or not adding ';' are the same for building libvirt,
> the group: qemu, kvm, libvirt are all created successfully.
>
> Second, adding ';' just according to some processing rule from the link:
>
> https://git.openembedded.org/openembedded-core/tree/meta/classes/useradd.bbclass#n54
>
> -----------------------------------------------------------------------------------------------------------------------
>
> if test "x`echo $GROUPADD_PARAM | tr -d '[:space:]'`" != "x"; then
> echo "Running groupadd commands..."
> # Invoke multiple instances of groupadd for parameter lists
> # separated by ';'
> opts=`echo "$GROUPADD_PARAM" | cut -d ';' -f 1 | sed -e 's#[ \t]*$##'`
> remaining=`echo "$GROUPADD_PARAM" | cut -d ';' -f 2- | sed -e 's#[ \t]*$##'`
> while test "x$opts" != "x"; do
> perform_groupadd "$SYSROOT" "$OPT $opts"
> if test "x$opts" = "x$remaining"; then
> break
> fi
> opts=`echo "$remaining" | cut -d ';' -f 1 | sed -e 's#[ \t]*$##'`
> remaining=`echo "$remaining" | cut -d ';' -f 2- | sed -e 's#[ \t]*$##'`
> done
> fi
>
> -----------------------------------------------------------------------------------------------------------------------
>
> Maybe in order to let the codes see more orderly.
>
Please ignore this. Thanks.
>
>> --Mark
>>
>>> do_install_append() {
>>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>>>
>
[-- Attachment #2: Type: text/html, Size: 4723 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-07 14:00 ` Mark Hatle
2019-03-08 2:44 ` ddu
@ 2019-03-08 6:00 ` ddu
2019-03-14 8:33 ` ddu
1 sibling, 1 reply; 11+ messages in thread
From: ddu @ 2019-03-08 6:00 UTC (permalink / raw)
To: Mark Hatle, meta-virtualization
在 2019/3/7 下午10:00, Mark Hatle 写道:
> On 3/6/19 8:58 PM, Dengke Du wrote:
>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
>> so we should append it, not override.
>>
>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>> ---
>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> index b55f9a9..0b0f011 100644
>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>>
>> inherit useradd
>> USERADD_PACKAGES = "${PN}"
>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> The __append should be fine then, but why the ';'? That part looks wrong, since
> typically the PARAM is the parameters passed directly to the groupadd program.
> I don't believe ';' is a valid parameter.
Hi Mark
The GROUPADD_PARAM in useradd.bbclass using ';' to create pieces, and
pass each piece to groupadd command,
https://git.openembedded.org/openembedded-core/tree/meta/classes/useradd.bbclass#n54
such as "-r qemu; -r kvm; --system libvirt" into
'-r qemu'
'-r kvm'
'--system libvirt'
to groupadd command.
If we don't use the ';' like this:
'-r qemu -r kvm --system libvirt' pass to groupadd command will fail.
So we should add ';'
>
> --Mark
>
>> do_install_append() {
>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-07 2:58 [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict Dengke Du
2019-03-07 14:00 ` Mark Hatle
@ 2019-03-14 0:11 ` ddu
2019-03-14 2:59 ` Bruce Ashfield
1 sibling, 1 reply; 11+ messages in thread
From: ddu @ 2019-03-14 0:11 UTC (permalink / raw)
To: meta-virtualization
Ping.
在 2019/3/7 上午10:58, Dengke Du 写道:
> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> so we should append it, not override.
>
> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> ---
> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> index b55f9a9..0b0f011 100644
> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>
> inherit useradd
> USERADD_PACKAGES = "${PN}"
> -GROUPADD_PARAM_${PN} = "--system libvirt"
> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
>
> do_install_append() {
> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-14 0:11 ` ddu
@ 2019-03-14 2:59 ` Bruce Ashfield
2019-03-14 14:18 ` Mark Hatle
0 siblings, 1 reply; 11+ messages in thread
From: Bruce Ashfield @ 2019-03-14 2:59 UTC (permalink / raw)
To: ddu; +Cc: meta-virtualization
I'm waiting for Mark to reply to your explanation. He had the open
question, I'm waiting for him to ack it.
Bruce
On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
>
> Ping.
>
> 在 2019/3/7 上午10:58, Dengke Du 写道:
> > The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> > so we should append it, not override.
> >
> > Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > ---
> > meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > index b55f9a9..0b0f011 100644
> > --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
> >
> > inherit useradd
> > USERADD_PACKAGES = "${PN}"
> > -GROUPADD_PARAM_${PN} = "--system libvirt"
> > +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> >
> > do_install_append() {
> > sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> --
> _______________________________________________
> meta-virtualization mailing list
> meta-virtualization@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-virtualization
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-08 6:00 ` ddu
@ 2019-03-14 8:33 ` ddu
0 siblings, 0 replies; 11+ messages in thread
From: ddu @ 2019-03-14 8:33 UTC (permalink / raw)
To: meta-virtualization
在 2019/3/8 下午2:00, ddu 写道:
>
> 在 2019/3/7 下午10:00, Mark Hatle 写道:
>> On 3/6/19 8:58 PM, Dengke Du wrote:
>>> The libvirt recipe in meta-virtualization already define the
>>> GROUPADD_PARAM,
>>> so we should append it, not override.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> index b55f9a9..0b0f011 100644
>>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap
>>> libvirtd udev yajl \
>>> inherit useradd
>>> USERADD_PACKAGES = "${PN}"
>>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
>> The __append should be fine then, but why the ';'? That part looks
>> wrong, since
>> typically the PARAM is the parameters passed directly to the groupadd
>> program.
>> I don't believe ';' is a valid parameter.
Hi Mark
Do you have any questions on this still?
>
> Hi Mark
>
> The GROUPADD_PARAM in useradd.bbclass using ';' to create pieces, and
> pass each piece to groupadd command,
>
> https://git.openembedded.org/openembedded-core/tree/meta/classes/useradd.bbclass#n54
>
>
> such as "-r qemu; -r kvm; --system libvirt" into
>
> '-r qemu'
>
> '-r kvm'
>
> '--system libvirt'
>
> to groupadd command.
>
> If we don't use the ';' like this:
>
> '-r qemu -r kvm --system libvirt' pass to groupadd command will fail.
>
> So we should add ';'
>
>>
>> --Mark
>>
>>> do_install_append() {
>>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i
>>> ${D}/etc/libvirt/libvirtd.conf
>>>
>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-14 2:59 ` Bruce Ashfield
@ 2019-03-14 14:18 ` Mark Hatle
2019-03-15 1:33 ` Bruce Ashfield
0 siblings, 1 reply; 11+ messages in thread
From: Mark Hatle @ 2019-03-14 14:18 UTC (permalink / raw)
To: Bruce Ashfield, ddu; +Cc: meta-virtualization
On 3/13/19 9:59 PM, Bruce Ashfield wrote:
> I'm waiting for Mark to reply to your explanation. He had the open
> question, I'm waiting for him to ack it.
Sorry, I had nothing to add.. I was satisfied with the answer.
Ack.
--Mark
> Bruce
>
> On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
>>
>> Ping.
>>
>> 在 2019/3/7 上午10:58, Dengke Du 写道:
>>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
>>> so we should append it, not override.
>>>
>>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
>>> ---
>>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> index b55f9a9..0b0f011 100644
>>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
>>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
>>>
>>> inherit useradd
>>> USERADD_PACKAGES = "${PN}"
>>> -GROUPADD_PARAM_${PN} = "--system libvirt"
>>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
>>>
>>> do_install_append() {
>>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
>> --
>> _______________________________________________
>> meta-virtualization mailing list
>> meta-virtualization@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-virtualization
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-14 14:18 ` Mark Hatle
@ 2019-03-15 1:33 ` Bruce Ashfield
2019-03-17 0:22 ` Bruce Ashfield
0 siblings, 1 reply; 11+ messages in thread
From: Bruce Ashfield @ 2019-03-15 1:33 UTC (permalink / raw)
To: Mark Hatle; +Cc: meta-virtualization
On Thu, Mar 14, 2019 at 10:18 AM Mark Hatle <mark.hatle@windriver.com> wrote:
>
> On 3/13/19 9:59 PM, Bruce Ashfield wrote:
> > I'm waiting for Mark to reply to your explanation. He had the open
> > question, I'm waiting for him to ack it.
>
> Sorry, I had nothing to add.. I was satisfied with the answer.
>
> Ack.
ok. Sounds good. I'm traveling tomorrow, so I'll take care of
outstanding merges over the weekend.
Bruce
>
> --Mark
>
> > Bruce
> >
> > On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
> >>
> >> Ping.
> >>
> >> 在 2019/3/7 上午10:58, Dengke Du 写道:
> >>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> >>> so we should append it, not override.
> >>>
> >>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> >>> ---
> >>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> >>> index b55f9a9..0b0f011 100644
> >>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> >>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> >>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
> >>>
> >>> inherit useradd
> >>> USERADD_PACKAGES = "${PN}"
> >>> -GROUPADD_PARAM_${PN} = "--system libvirt"
> >>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> >>>
> >>> do_install_append() {
> >>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> >> --
> >> _______________________________________________
> >> meta-virtualization mailing list
> >> meta-virtualization@yoctoproject.org
> >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> >
> >
> >
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict
2019-03-15 1:33 ` Bruce Ashfield
@ 2019-03-17 0:22 ` Bruce Ashfield
0 siblings, 0 replies; 11+ messages in thread
From: Bruce Ashfield @ 2019-03-17 0:22 UTC (permalink / raw)
To: Mark Hatle; +Cc: meta-virtualization
This is now merged
Bruce
On Thu, Mar 14, 2019 at 9:33 PM Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
>
> On Thu, Mar 14, 2019 at 10:18 AM Mark Hatle <mark.hatle@windriver.com> wrote:
> >
> > On 3/13/19 9:59 PM, Bruce Ashfield wrote:
> > > I'm waiting for Mark to reply to your explanation. He had the open
> > > question, I'm waiting for him to ack it.
> >
> > Sorry, I had nothing to add.. I was satisfied with the answer.
> >
> > Ack.
>
> ok. Sounds good. I'm traveling tomorrow, so I'll take care of
> outstanding merges over the weekend.
>
> Bruce
>
> >
> > --Mark
> >
> > > Bruce
> > >
> > > On Wed, Mar 13, 2019 at 8:12 PM ddu <dengke.du@windriver.com> wrote:
> > >>
> > >> Ping.
> > >>
> > >> 在 2019/3/7 上午10:58, Dengke Du 写道:
> > >>> The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
> > >>> so we should append it, not override.
> > >>>
> > >>> Signed-off-by: Dengke Du <dengke.du@windriver.com>
> > >>> ---
> > >>> meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
> > >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> index b55f9a9..0b0f011 100644
> > >>> --- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> +++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
> > >>> @@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev yajl \
> > >>>
> > >>> inherit useradd
> > >>> USERADD_PACKAGES = "${PN}"
> > >>> -GROUPADD_PARAM_${PN} = "--system libvirt"
> > >>> +GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
> > >>>
> > >>> do_install_append() {
> > >>> sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i ${D}/etc/libvirt/libvirtd.conf
> > >> --
> > >> _______________________________________________
> > >> meta-virtualization mailing list
> > >> meta-virtualization@yoctoproject.org
> > >> https://lists.yoctoproject.org/listinfo/meta-virtualization
> > >
> > >
> > >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-17 0:23 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07 2:58 [m-c-s][PATCH] libvirt: fix GROUPADD_PARAM override conflict Dengke Du
2019-03-07 14:00 ` Mark Hatle
2019-03-08 2:44 ` ddu
2019-03-08 3:26 ` ddu
2019-03-08 6:00 ` ddu
2019-03-14 8:33 ` ddu
2019-03-14 0:11 ` ddu
2019-03-14 2:59 ` Bruce Ashfield
2019-03-14 14:18 ` Mark Hatle
2019-03-15 1:33 ` Bruce Ashfield
2019-03-17 0:22 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.