[PATCH] PCI: use dev_info rather than dev_err for rom validation

[PATCH] PCI: use dev_info rather than dev_err for rom validation

[Alex Deucher]

On AMD GPUs, we use several mechanisms to fetch the vbios
rom depending on the platform.  We try to read the rom
back via the rom BAR and fall back to other methods in
some cases.  This leads to spurious error messages
from the pci rom code which are harmless in our case.
This leads to bugs being files, etc.  Change these to
dev_info rather than dev_err to avoid that.

Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/pci/rom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
index b6edb187d160..7ab7c6bb17c6 100644
--- a/drivers/pci/rom.c
+++ b/drivers/pci/rom.c
@@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
 		void __iomem *pds;
 		/* Standard PCI ROMs start out with these bytes 55 AA */
 		if (readw(image) != 0xAA55) {
-			dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
+			dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
 				readw(image));
 			break;
 		}
 		/* get the PCI data structure and check its "PCIR" signature */
 		pds = image + readw(image + 24);
 		if (readl(pds) != 0x52494350) {
-			dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
+			dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
 				readl(pds));
 			break;
 		}
-- 
2.13.6

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Christian König]

Am 27.11.2017 um 18:21 schrieb Alex Deucher:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform.  We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases.  This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc.  Change these to
> dev_info rather than dev_err to avoid that.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/pci/rom.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
> index b6edb187d160..7ab7c6bb17c6 100644
> --- a/drivers/pci/rom.c
> +++ b/drivers/pci/rom.c
> @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
>   		void __iomem *pds;
>   		/* Standard PCI ROMs start out with these bytes 55 AA */
>   		if (readw(image) != 0xAA55) {
> -			dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> +			dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
>   				readw(image));
>   			break;
>   		}
>   		/* get the PCI data structure and check its "PCIR" signature */
>   		pds = image + readw(image + 24);
>   		if (readl(pds) != 0x52494350) {
> -			dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> +			dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
>   				readl(pds));
>   			break;
>   		}

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Michel Dänzer]

On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform.  We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases.  This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc.  Change these to
> dev_info rather than dev_err to avoid that.

Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Michel Dänzer]

On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform.  We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases.  This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc.  Change these to
> dev_info rather than dev_err to avoid that.

Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Alex Deucher]

On Mon, Nov 27, 2017 at 1:00 PM, Michel D=C3=A4nzer <michel@daenzer.net> wr=
ote:
> On 2017-11-27 06:21 PM, Alex Deucher wrote:
>> On AMD GPUs, we use several mechanisms to fetch the vbios
>> rom depending on the platform.  We try to read the rom
>> back via the rom BAR and fall back to other methods in
>> some cases.  This leads to spurious error messages
>> from the pci rom code which are harmless in our case.
>> This leads to bugs being files, etc.  Change these to
>> dev_info rather than dev_err to avoid that.
>
> Does dev_info still print the message by default though? If so, I wonder
> if this will change anything in practice...

It will still show up, just not as an error so if you are filtering on
errors, you won't see it.

Alex

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Alex Deucher]

On Mon, Nov 27, 2017 at 1:00 PM, Michel Dänzer <michel@daenzer.net> wrote:
> On 2017-11-27 06:21 PM, Alex Deucher wrote:
>> On AMD GPUs, we use several mechanisms to fetch the vbios
>> rom depending on the platform.  We try to read the rom
>> back via the rom BAR and fall back to other methods in
>> some cases.  This leads to spurious error messages
>> from the pci rom code which are harmless in our case.
>> This leads to bugs being files, etc.  Change these to
>> dev_info rather than dev_err to avoid that.
>
> Does dev_info still print the message by default though? If so, I wonder
> if this will change anything in practice...

It will still show up, just not as an error so if you are filtering on
errors, you won't see it.

Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation

[Bjorn Helgaas]

On Mon, Nov 27, 2017 at 12:21:10PM -0500, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform.  We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases.  This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc.  Change these to
> dev_info rather than dev_err to avoid that.
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Applied with Christian's reviewed-by to pci/resource for v4.16, thanks!
I also added links to several of the bug reports.

> ---
>  drivers/pci/rom.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
> index b6edb187d160..7ab7c6bb17c6 100644
> --- a/drivers/pci/rom.c
> +++ b/drivers/pci/rom.c
> @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
>  		void __iomem *pds;
>  		/* Standard PCI ROMs start out with these bytes 55 AA */
>  		if (readw(image) != 0xAA55) {
> -			dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> +			dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
>  				readw(image));
>  			break;
>  		}
>  		/* get the PCI data structure and check its "PCIR" signature */
>  		pds = image + readw(image + 24);
>  		if (readl(pds) != 0x52494350) {
> -			dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> +			dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
>  				readl(pds));
>  			break;
>  		}
> -- 
> 2.13.6
>