* [PATCH] PCI: use dev_info rather than dev_err for rom validation
@ 2017-11-27 17:21 Alex Deucher
2017-11-27 17:26 ` Christian König
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Alex Deucher @ 2017-11-27 17:21 UTC (permalink / raw)
To: dri-devel, linux-pci, helgaas; +Cc: Alex Deucher
On AMD GPUs, we use several mechanisms to fetch the vbios
rom depending on the platform. We try to read the rom
back via the rom BAR and fall back to other methods in
some cases. This leads to spurious error messages
from the pci rom code which are harmless in our case.
This leads to bugs being files, etc. Change these to
dev_info rather than dev_err to avoid that.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/pci/rom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
index b6edb187d160..7ab7c6bb17c6 100644
--- a/drivers/pci/rom.c
+++ b/drivers/pci/rom.c
@@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
void __iomem *pds;
/* Standard PCI ROMs start out with these bytes 55 AA */
if (readw(image) != 0xAA55) {
- dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
+ dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
readw(image));
break;
}
/* get the PCI data structure and check its "PCIR" signature */
pds = image + readw(image + 24);
if (readl(pds) != 0x52494350) {
- dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
+ dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
readl(pds));
break;
}
--
2.13.6
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
2017-11-27 17:21 [PATCH] PCI: use dev_info rather than dev_err for rom validation Alex Deucher
@ 2017-11-27 17:26 ` Christian König
2017-11-27 18:00 ` Michel Dänzer
2017-12-04 21:41 ` Bjorn Helgaas
2 siblings, 0 replies; 7+ messages in thread
From: Christian König @ 2017-11-27 17:26 UTC (permalink / raw)
To: Alex Deucher, dri-devel, linux-pci, helgaas; +Cc: Alex Deucher
Am 27.11.2017 um 18:21 schrieb Alex Deucher:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/pci/rom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
> index b6edb187d160..7ab7c6bb17c6 100644
> --- a/drivers/pci/rom.c
> +++ b/drivers/pci/rom.c
> @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
> void __iomem *pds;
> /* Standard PCI ROMs start out with these bytes 55 AA */
> if (readw(image) != 0xAA55) {
> - dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> + dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> readw(image));
> break;
> }
> /* get the PCI data structure and check its "PCIR" signature */
> pds = image + readw(image + 24);
> if (readl(pds) != 0x52494350) {
> - dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> + dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> readl(pds));
> break;
> }
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
2017-11-27 17:21 [PATCH] PCI: use dev_info rather than dev_err for rom validation Alex Deucher
@ 2017-11-27 18:00 ` Michel Dänzer
2017-11-27 18:00 ` Michel Dänzer
2017-12-04 21:41 ` Bjorn Helgaas
2 siblings, 0 replies; 7+ messages in thread
From: Michel Dänzer @ 2017-11-27 18:00 UTC (permalink / raw)
To: Alex Deucher, helgaas; +Cc: dri-devel, linux-pci, Alex Deucher
On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
@ 2017-11-27 18:00 ` Michel Dänzer
0 siblings, 0 replies; 7+ messages in thread
From: Michel Dänzer @ 2017-11-27 18:00 UTC (permalink / raw)
To: Alex Deucher, helgaas; +Cc: Alex Deucher, linux-pci, dri-devel
On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
2017-11-27 18:00 ` Michel Dänzer
@ 2017-11-27 18:05 ` Alex Deucher
-1 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2017-11-27 18:05 UTC (permalink / raw)
To: Michel Dänzer
Cc: Bjorn Helgaas, Maling list - DRI developers, Linux PCI, Alex Deucher
On Mon, Nov 27, 2017 at 1:00 PM, Michel D=C3=A4nzer <michel@daenzer.net> wr=
ote:
> On 2017-11-27 06:21 PM, Alex Deucher wrote:
>> On AMD GPUs, we use several mechanisms to fetch the vbios
>> rom depending on the platform. We try to read the rom
>> back via the rom BAR and fall back to other methods in
>> some cases. This leads to spurious error messages
>> from the pci rom code which are harmless in our case.
>> This leads to bugs being files, etc. Change these to
>> dev_info rather than dev_err to avoid that.
>
> Does dev_info still print the message by default though? If so, I wonder
> if this will change anything in practice...
It will still show up, just not as an error so if you are filtering on
errors, you won't see it.
Alex
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
@ 2017-11-27 18:05 ` Alex Deucher
0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2017-11-27 18:05 UTC (permalink / raw)
To: Michel Dänzer
Cc: Alex Deucher, Linux PCI, Bjorn Helgaas, Maling list - DRI developers
On Mon, Nov 27, 2017 at 1:00 PM, Michel Dänzer <michel@daenzer.net> wrote:
> On 2017-11-27 06:21 PM, Alex Deucher wrote:
>> On AMD GPUs, we use several mechanisms to fetch the vbios
>> rom depending on the platform. We try to read the rom
>> back via the rom BAR and fall back to other methods in
>> some cases. This leads to spurious error messages
>> from the pci rom code which are harmless in our case.
>> This leads to bugs being files, etc. Change these to
>> dev_info rather than dev_err to avoid that.
>
> Does dev_info still print the message by default though? If so, I wonder
> if this will change anything in practice...
It will still show up, just not as an error so if you are filtering on
errors, you won't see it.
Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
2017-11-27 17:21 [PATCH] PCI: use dev_info rather than dev_err for rom validation Alex Deucher
2017-11-27 17:26 ` Christian König
2017-11-27 18:00 ` Michel Dänzer
@ 2017-12-04 21:41 ` Bjorn Helgaas
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Helgaas @ 2017-12-04 21:41 UTC (permalink / raw)
To: Alex Deucher; +Cc: dri-devel, linux-pci, Alex Deucher
On Mon, Nov 27, 2017 at 12:21:10PM -0500, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Applied with Christian's reviewed-by to pci/resource for v4.16, thanks!
I also added links to several of the bug reports.
> ---
> drivers/pci/rom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
> index b6edb187d160..7ab7c6bb17c6 100644
> --- a/drivers/pci/rom.c
> +++ b/drivers/pci/rom.c
> @@ -92,14 +92,14 @@ size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
> void __iomem *pds;
> /* Standard PCI ROMs start out with these bytes 55 AA */
> if (readw(image) != 0xAA55) {
> - dev_err(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> + dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
> readw(image));
> break;
> }
> /* get the PCI data structure and check its "PCIR" signature */
> pds = image + readw(image + 24);
> if (readl(pds) != 0x52494350) {
> - dev_err(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> + dev_info(&pdev->dev, "Invalid PCI ROM data signature: expecting 0x52494350, got %#010x\n",
> readl(pds));
> break;
> }
> --
> 2.13.6
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-12-04 21:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 17:21 [PATCH] PCI: use dev_info rather than dev_err for rom validation Alex Deucher
2017-11-27 17:26 ` Christian König
2017-11-27 18:00 ` Michel Dänzer
2017-11-27 18:00 ` Michel Dänzer
2017-11-27 18:05 ` Alex Deucher
2017-11-27 18:05 ` Alex Deucher
2017-12-04 21:41 ` Bjorn Helgaas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.