From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, agross@kernel.org, airlied@gmail.com, andersson@kernel.org, daniel@ffwll.ch, devicetree@vger.kernel.org, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com, robh+dt@kernel.org, sean@poorly.run, vkoul@kernel.org Cc: quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 4/5] drm/msm/dp: parser link-frequencies as property of dp_out endpoint Date: Tue, 13 Dec 2022 15:18:02 -0800 [thread overview] Message-ID: <CAE-0n51G3sUbGftFr5RTsM2xwxCDW3y0N9KzAsZrSQX09_N0GA@mail.gmail.com> (raw) In-Reply-To: <1670967848-31475-5-git-send-email-quic_khsieh@quicinc.com> Quoting Kuogee Hsieh (2022-12-13 13:44:07) > Add capability to parser and retrieve max DP link supported rate from to parse > link-frequencies property of dp_out endpoint. > > Changes in v6: > -- second patch after split parser patch into two patches > > Changes in v7: > -- without checking cnt against DP_MAX_NUM_DP_LANES to retrieve link rate > > Changes in v9: > -- separate parser link-frequencies out of data-lanes > > Changes in v10: > -- add dp_parser_link_frequencies() > > Changes in v11: > -- return 0 if(!endpoint) > > Changes in v12: > -- replace khz with kbytes at dp_parser.h > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- Same parser in subject. > drivers/gpu/drm/msm/dp/dp_parser.c | 27 +++++++++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_parser.h | 2 ++ > 2 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c > index b5f7e70..5549495 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -91,6 +91,29 @@ static int dp_parser_ctrl_res(struct dp_parser *parser) > return 0; > } > > +static u32 dp_parser_link_frequencies(struct device_node *of_node) > +{ > + struct device_node *endpoint; > + u64 frequency = 0; > + int cnt = 0; 'cnt' doesn't need to be initialized here. > + > + endpoint = of_graph_get_endpoint_by_regs(of_node, 1, 0); /* port@1 */ > + if (!endpoint) > + return 0; > + > + cnt = of_property_count_u64_elems(endpoint, "link-frequencies"); > + > + if (cnt > 0) > + of_property_read_u64_index(endpoint, "link-frequencies", > + cnt - 1, &frequency); > + of_node_put(endpoint); > + > + frequency /= 10; /* from symbol rate to link rate */ > + frequency /= 1000; /* kbytes */ Use do_div(frequency, 10 * 1000)? If you want comments it could maybe be like this: do_div(frequency, 10 * /* from symbol rate to link rate */ 1000); /* kbytes */ > + > + return frequency; > +} > +
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Kuogee Hsieh <quic_khsieh@quicinc.com>, agross@kernel.org, airlied@gmail.com, andersson@kernel.org, daniel@ffwll.ch, devicetree@vger.kernel.org, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com, robh+dt@kernel.org, sean@poorly.run, vkoul@kernel.org Cc: linux-arm-msm@vger.kernel.org, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v12 4/5] drm/msm/dp: parser link-frequencies as property of dp_out endpoint Date: Tue, 13 Dec 2022 15:18:02 -0800 [thread overview] Message-ID: <CAE-0n51G3sUbGftFr5RTsM2xwxCDW3y0N9KzAsZrSQX09_N0GA@mail.gmail.com> (raw) In-Reply-To: <1670967848-31475-5-git-send-email-quic_khsieh@quicinc.com> Quoting Kuogee Hsieh (2022-12-13 13:44:07) > Add capability to parser and retrieve max DP link supported rate from to parse > link-frequencies property of dp_out endpoint. > > Changes in v6: > -- second patch after split parser patch into two patches > > Changes in v7: > -- without checking cnt against DP_MAX_NUM_DP_LANES to retrieve link rate > > Changes in v9: > -- separate parser link-frequencies out of data-lanes > > Changes in v10: > -- add dp_parser_link_frequencies() > > Changes in v11: > -- return 0 if(!endpoint) > > Changes in v12: > -- replace khz with kbytes at dp_parser.h > > Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- Same parser in subject. > drivers/gpu/drm/msm/dp/dp_parser.c | 27 +++++++++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_parser.h | 2 ++ > 2 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c > index b5f7e70..5549495 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -91,6 +91,29 @@ static int dp_parser_ctrl_res(struct dp_parser *parser) > return 0; > } > > +static u32 dp_parser_link_frequencies(struct device_node *of_node) > +{ > + struct device_node *endpoint; > + u64 frequency = 0; > + int cnt = 0; 'cnt' doesn't need to be initialized here. > + > + endpoint = of_graph_get_endpoint_by_regs(of_node, 1, 0); /* port@1 */ > + if (!endpoint) > + return 0; > + > + cnt = of_property_count_u64_elems(endpoint, "link-frequencies"); > + > + if (cnt > 0) > + of_property_read_u64_index(endpoint, "link-frequencies", > + cnt - 1, &frequency); > + of_node_put(endpoint); > + > + frequency /= 10; /* from symbol rate to link rate */ > + frequency /= 1000; /* kbytes */ Use do_div(frequency, 10 * 1000)? If you want comments it could maybe be like this: do_div(frequency, 10 * /* from symbol rate to link rate */ 1000); /* kbytes */ > + > + return frequency; > +} > +
next prev parent reply other threads:[~2022-12-13 23:18 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-13 21:44 [PATCH v12 0/5] Add data-lanes and link-frequencies to dp_out endpoint Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 21:44 ` [PATCH v12 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into " Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 23:31 ` Dmitry Baryshkov 2022-12-13 23:31 ` Dmitry Baryshkov 2022-12-13 21:44 ` [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 22:02 ` Dmitry Baryshkov 2022-12-13 22:02 ` Dmitry Baryshkov 2022-12-13 23:06 ` Stephen Boyd 2022-12-13 23:06 ` Stephen Boyd 2022-12-14 22:56 ` Kuogee Hsieh 2022-12-14 22:56 ` Kuogee Hsieh 2022-12-15 0:38 ` Stephen Boyd 2022-12-15 0:38 ` Stephen Boyd 2022-12-15 17:08 ` Kuogee Hsieh 2022-12-15 17:08 ` Kuogee Hsieh 2022-12-15 20:12 ` Stephen Boyd 2022-12-15 20:12 ` Stephen Boyd 2022-12-15 21:12 ` Dmitry Baryshkov 2022-12-15 21:12 ` Dmitry Baryshkov 2022-12-15 22:57 ` Doug Anderson 2022-12-15 22:57 ` Doug Anderson 2022-12-15 23:02 ` Dmitry Baryshkov 2022-12-15 23:02 ` Dmitry Baryshkov 2022-12-16 2:16 ` Stephen Boyd 2022-12-16 2:16 ` Stephen Boyd 2022-12-16 19:03 ` Kuogee Hsieh 2022-12-16 19:03 ` Kuogee Hsieh 2022-12-16 19:43 ` Dmitry Baryshkov 2022-12-16 19:43 ` Dmitry Baryshkov 2022-12-13 21:44 ` [PATCH v12 3/5] drm/msm/dp: parser data-lanes as property of dp_out endpoint Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 23:11 ` Stephen Boyd 2022-12-13 23:11 ` Stephen Boyd 2022-12-13 21:44 ` [PATCH v12 4/5] drm/msm/dp: parser link-frequencies " Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 22:07 ` Dmitry Baryshkov 2022-12-13 22:07 ` Dmitry Baryshkov 2022-12-13 23:18 ` Stephen Boyd [this message] 2022-12-13 23:18 ` Stephen Boyd 2022-12-13 21:44 ` [PATCH v12 5/5] drm/msm/dp: add support of max dp link rate Kuogee Hsieh 2022-12-13 21:44 ` Kuogee Hsieh 2022-12-13 22:06 ` Dmitry Baryshkov 2022-12-13 22:06 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAE-0n51G3sUbGftFr5RTsM2xwxCDW3y0N9KzAsZrSQX09_N0GA@mail.gmail.com \ --to=swboyd@chromium.org \ --cc=agross@kernel.org \ --cc=airlied@gmail.com \ --cc=andersson@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@somainline.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_khsieh@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.