All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>,
	agross@kernel.org, airlied@gmail.com, andersson@kernel.org,
	daniel@ffwll.ch, devicetree@vger.kernel.org,
	dianders@chromium.org, dmitry.baryshkov@linaro.org,
	dri-devel@lists.freedesktop.org, konrad.dybcio@somainline.org,
	krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com,
	robh+dt@kernel.org, sean@poorly.run, vkoul@kernel.org
Cc: quic_abhinavk@quicinc.com, quic_sbillaka@quicinc.com,
	freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property
Date: Thu, 15 Dec 2022 15:12:31 -0500	[thread overview]
Message-ID: <CAE-0n52j8vYYTRSpBo82MHqLiSjxikL=2P6NQwa0-DW__sc6WA@mail.gmail.com> (raw)
In-Reply-To: <98cc6d55-f9c7-a369-6004-42b242d01339@quicinc.com>

Quoting Kuogee Hsieh (2022-12-15 09:08:04)
>
> On 12/14/2022 4:38 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-12-14 14:56:23)
> >> On 12/13/2022 3:06 PM, Stephen Boyd wrote:
> >>> Quoting Kuogee Hsieh (2022-12-13 13:44:05)
> >
> >> Therefore I think add data-lanes and link-frequencies properties in the
> >> DP PHY binding directly will not helps.
> >>
> > I didn't follow your logic. Sorry.
>
> Sorry, probably i did not understand your proposal clearly.
>
> 1) move both data-lanes and link-frequencies property from dp controller
> endpoint to phy
>
> 2) phy_configure() return succeed if both data-lanes and link
> frequencies are supported. otherwise return failed.
>
> is above two summary items correct?

Yes.

>
> Currently phy_configure()  is part of link training process and called
> if link lanes or rate changes.
>
> however, since current phy_configure() implementation always return 0,
> the return value is not checking.
>
> This proposal is new, can we discuss more detail at meeting and decide
> to implement it or not.
>
> Meanwhile can we merge current implementation (both data-lanes and
> link-frequqncies at dp controller end point) first?
>

I don't think we can merge this patch because it depends on a DT binding
change. If the PHY approach works then I'd prefer we just go with that.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Kuogee Hsieh <quic_khsieh@quicinc.com>,
	agross@kernel.org, airlied@gmail.com,  andersson@kernel.org,
	daniel@ffwll.ch, devicetree@vger.kernel.org,
	 dianders@chromium.org, dmitry.baryshkov@linaro.org,
	 dri-devel@lists.freedesktop.org, konrad.dybcio@somainline.org,
	 krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com,
	robh+dt@kernel.org,  sean@poorly.run, vkoul@kernel.org
Cc: linux-arm-msm@vger.kernel.org, quic_sbillaka@quicinc.com,
	freedreno@lists.freedesktop.org, quic_abhinavk@quicinc.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property
Date: Thu, 15 Dec 2022 15:12:31 -0500	[thread overview]
Message-ID: <CAE-0n52j8vYYTRSpBo82MHqLiSjxikL=2P6NQwa0-DW__sc6WA@mail.gmail.com> (raw)
In-Reply-To: <98cc6d55-f9c7-a369-6004-42b242d01339@quicinc.com>

Quoting Kuogee Hsieh (2022-12-15 09:08:04)
>
> On 12/14/2022 4:38 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-12-14 14:56:23)
> >> On 12/13/2022 3:06 PM, Stephen Boyd wrote:
> >>> Quoting Kuogee Hsieh (2022-12-13 13:44:05)
> >
> >> Therefore I think add data-lanes and link-frequencies properties in the
> >> DP PHY binding directly will not helps.
> >>
> > I didn't follow your logic. Sorry.
>
> Sorry, probably i did not understand your proposal clearly.
>
> 1) move both data-lanes and link-frequencies property from dp controller
> endpoint to phy
>
> 2) phy_configure() return succeed if both data-lanes and link
> frequencies are supported. otherwise return failed.
>
> is above two summary items correct?

Yes.

>
> Currently phy_configure()  is part of link training process and called
> if link lanes or rate changes.
>
> however, since current phy_configure() implementation always return 0,
> the return value is not checking.
>
> This proposal is new, can we discuss more detail at meeting and decide
> to implement it or not.
>
> Meanwhile can we merge current implementation (both data-lanes and
> link-frequqncies at dp controller end point) first?
>

I don't think we can merge this patch because it depends on a DT binding
change. If the PHY approach works then I'd prefer we just go with that.

  reply	other threads:[~2022-12-15 20:12 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 21:44 [PATCH v12 0/5] Add data-lanes and link-frequencies to dp_out endpoint Kuogee Hsieh
2022-12-13 21:44 ` Kuogee Hsieh
2022-12-13 21:44 ` [PATCH v12 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into " Kuogee Hsieh
2022-12-13 21:44   ` Kuogee Hsieh
2022-12-13 23:31   ` Dmitry Baryshkov
2022-12-13 23:31     ` Dmitry Baryshkov
2022-12-13 21:44 ` [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property Kuogee Hsieh
2022-12-13 21:44   ` Kuogee Hsieh
2022-12-13 22:02   ` Dmitry Baryshkov
2022-12-13 22:02     ` Dmitry Baryshkov
2022-12-13 23:06   ` Stephen Boyd
2022-12-13 23:06     ` Stephen Boyd
2022-12-14 22:56     ` Kuogee Hsieh
2022-12-14 22:56       ` Kuogee Hsieh
2022-12-15  0:38       ` Stephen Boyd
2022-12-15  0:38         ` Stephen Boyd
2022-12-15 17:08         ` Kuogee Hsieh
2022-12-15 17:08           ` Kuogee Hsieh
2022-12-15 20:12           ` Stephen Boyd [this message]
2022-12-15 20:12             ` Stephen Boyd
2022-12-15 21:12         ` Dmitry Baryshkov
2022-12-15 21:12           ` Dmitry Baryshkov
2022-12-15 22:57           ` Doug Anderson
2022-12-15 22:57             ` Doug Anderson
2022-12-15 23:02             ` Dmitry Baryshkov
2022-12-15 23:02               ` Dmitry Baryshkov
2022-12-16  2:16           ` Stephen Boyd
2022-12-16  2:16             ` Stephen Boyd
2022-12-16 19:03             ` Kuogee Hsieh
2022-12-16 19:03               ` Kuogee Hsieh
2022-12-16 19:43             ` Dmitry Baryshkov
2022-12-16 19:43               ` Dmitry Baryshkov
2022-12-13 21:44 ` [PATCH v12 3/5] drm/msm/dp: parser data-lanes as property of dp_out endpoint Kuogee Hsieh
2022-12-13 21:44   ` Kuogee Hsieh
2022-12-13 23:11   ` Stephen Boyd
2022-12-13 23:11     ` Stephen Boyd
2022-12-13 21:44 ` [PATCH v12 4/5] drm/msm/dp: parser link-frequencies " Kuogee Hsieh
2022-12-13 21:44   ` Kuogee Hsieh
2022-12-13 22:07   ` Dmitry Baryshkov
2022-12-13 22:07     ` Dmitry Baryshkov
2022-12-13 23:18   ` Stephen Boyd
2022-12-13 23:18     ` Stephen Boyd
2022-12-13 21:44 ` [PATCH v12 5/5] drm/msm/dp: add support of max dp link rate Kuogee Hsieh
2022-12-13 21:44   ` Kuogee Hsieh
2022-12-13 22:06   ` Dmitry Baryshkov
2022-12-13 22:06     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE-0n52j8vYYTRSpBo82MHqLiSjxikL=2P6NQwa0-DW__sc6WA@mail.gmail.com' \
    --to=swboyd@chromium.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.