All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list
@ 2016-09-16 12:37 Stefan Roese
  2016-09-26  6:33 ` Bin Meng
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Roese @ 2016-09-16 12:37 UTC (permalink / raw)
  To: u-boot

With this addition, the eMMC device available on the congatec and DFI
BayTrail SoM is detected correctly.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
 arch/x86/cpu/baytrail/valleyview.c | 1 +
 include/pci_ids.h                  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/x86/cpu/baytrail/valleyview.c b/arch/x86/cpu/baytrail/valleyview.c
index b31f24e..9868de0 100644
--- a/arch/x86/cpu/baytrail/valleyview.c
+++ b/arch/x86/cpu/baytrail/valleyview.c
@@ -14,6 +14,7 @@
 static struct pci_device_id mmc_supported[] = {
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },
 	{},
 };
 
diff --git a/include/pci_ids.h b/include/pci_ids.h
index 17a01a0..e63b94f 100644
--- a/include/pci_ids.h
+++ b/include/pci_ids.h
@@ -2606,6 +2606,7 @@
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_IDE_ALT	0x0f21
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA	0x0f22
 #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA_ALT	0x0f23
+#define PCI_DEVICE_ID_INTEL_BYT_EMMC2	0x0f50
 #define PCI_DEVICE_ID_INTEL_82541ER	0x1078
 #define PCI_DEVICE_ID_INTEL_82541GI_LF	0x107c
 #define PCI_DEVICE_ID_INTEL_82542	0x1000
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list
  2016-09-16 12:37 [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list Stefan Roese
@ 2016-09-26  6:33 ` Bin Meng
  2016-09-26  6:39   ` Stefan Roese
  0 siblings, 1 reply; 4+ messages in thread
From: Bin Meng @ 2016-09-26  6:33 UTC (permalink / raw)
  To: u-boot

Hi Stefan,

On Fri, Sep 16, 2016 at 8:37 PM, Stefan Roese <sr@denx.de> wrote:
> With this addition, the eMMC device available on the congatec and DFI
> BayTrail SoM is detected correctly.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> ---
>  arch/x86/cpu/baytrail/valleyview.c | 1 +
>  include/pci_ids.h                  | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/arch/x86/cpu/baytrail/valleyview.c b/arch/x86/cpu/baytrail/valleyview.c
> index b31f24e..9868de0 100644
> --- a/arch/x86/cpu/baytrail/valleyview.c
> +++ b/arch/x86/cpu/baytrail/valleyview.c
> @@ -14,6 +14,7 @@
>  static struct pci_device_id mmc_supported[] = {
>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
> +       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },

pure nits, should we use VALLEYVIEW_EMMC2? or should we change
previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

>         {},
>  };
>
> diff --git a/include/pci_ids.h b/include/pci_ids.h
> index 17a01a0..e63b94f 100644
> --- a/include/pci_ids.h
> +++ b/include/pci_ids.h
> @@ -2606,6 +2606,7 @@
>  #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_IDE_ALT 0x0f21
>  #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA    0x0f22
>  #define PCI_DEVICE_ID_INTEL_VALLEYVIEW_SATA_ALT        0x0f23
> +#define PCI_DEVICE_ID_INTEL_BYT_EMMC2  0x0f50
>  #define PCI_DEVICE_ID_INTEL_82541ER    0x1078
>  #define PCI_DEVICE_ID_INTEL_82541GI_LF 0x107c
>  #define PCI_DEVICE_ID_INTEL_82542      0x1000
> --

Regards,
Bin

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list
  2016-09-26  6:33 ` Bin Meng
@ 2016-09-26  6:39   ` Stefan Roese
  2016-09-26  6:42     ` Bin Meng
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Roese @ 2016-09-26  6:39 UTC (permalink / raw)
  To: u-boot

Hi Bin,

On 26.09.2016 08:33, Bin Meng wrote:
> On Fri, Sep 16, 2016 at 8:37 PM, Stefan Roese <sr@denx.de> wrote:
>> With this addition, the eMMC device available on the congatec and DFI
>> BayTrail SoM is detected correctly.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>  arch/x86/cpu/baytrail/valleyview.c | 1 +
>>  include/pci_ids.h                  | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/cpu/baytrail/valleyview.c b/arch/x86/cpu/baytrail/valleyview.c
>> index b31f24e..9868de0 100644
>> --- a/arch/x86/cpu/baytrail/valleyview.c
>> +++ b/arch/x86/cpu/baytrail/valleyview.c
>> @@ -14,6 +14,7 @@
>>  static struct pci_device_id mmc_supported[] = {
>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
>> +       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },
>
> pure nits, should we use VALLEYVIEW_EMMC2? or should we change
> previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?

I've taken the new name from the Linux driver as you might have
already suspected. I would prefer to change the other (old) names
to the Linux ones. I can prepare a v2 of this patch or a follow-up
patch for this. What would you prefer?

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list
  2016-09-26  6:39   ` Stefan Roese
@ 2016-09-26  6:42     ` Bin Meng
  0 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2016-09-26  6:42 UTC (permalink / raw)
  To: u-boot

Hi Stefan,

On Mon, Sep 26, 2016 at 2:39 PM, Stefan Roese <sr@denx.de> wrote:
> Hi Bin,
>
> On 26.09.2016 08:33, Bin Meng wrote:
>>
>> On Fri, Sep 16, 2016 at 8:37 PM, Stefan Roese <sr@denx.de> wrote:
>>>
>>> With this addition, the eMMC device available on the congatec and DFI
>>> BayTrail SoM is detected correctly.
>>>
>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Bin Meng <bmeng.cn@gmail.com>
>>> ---
>>>  arch/x86/cpu/baytrail/valleyview.c | 1 +
>>>  include/pci_ids.h                  | 1 +
>>>  2 files changed, 2 insertions(+)
>>>
>>> diff --git a/arch/x86/cpu/baytrail/valleyview.c
>>> b/arch/x86/cpu/baytrail/valleyview.c
>>> index b31f24e..9868de0 100644
>>> --- a/arch/x86/cpu/baytrail/valleyview.c
>>> +++ b/arch/x86/cpu/baytrail/valleyview.c
>>> @@ -14,6 +14,7 @@
>>>  static struct pci_device_id mmc_supported[] = {
>>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDIO },
>>>         { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VALLEYVIEW_SDCARD },
>>> +       { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BYT_EMMC2 },
>>
>>
>> pure nits, should we use VALLEYVIEW_EMMC2? or should we change
>> previous VALLEYVIEW_SDIO/SDCARD to BYT_SDIO/SDCARD, for consistency?
>
>
> I've taken the new name from the Linux driver as you might have
> already suspected. I would prefer to change the other (old) names
> to the Linux ones. I can prepare a v2 of this patch or a follow-up
> patch for this. What would you prefer?
>

Sure, let's match Linux.

Regards,
Bin

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-26  6:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-16 12:37 [U-Boot] [PATCH] x86: baytrail: Add 2nd eMMC controller to the PCI probe list Stefan Roese
2016-09-26  6:33 ` Bin Meng
2016-09-26  6:39   ` Stefan Roese
2016-09-26  6:42     ` Bin Meng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.