From: Rob Clark <robdclark@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Shawn Guo <shawn.guo@linaro.org>, Joerg Roedel <joro@8bytes.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konradybcio@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,"
<iommu@lists.linux-foundation.org>
Subject: Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate
Date: Tue, 12 May 2020 11:35:01 -0700 [thread overview]
Message-ID: <CAF6AEGsod2L+VwJGhECpW8BhfexLgMMp_3V3AsnKjXcyLaT48w@mail.gmail.com> (raw)
In-Reply-To: <20200512055242.GJ1302550@yoga>
On Mon, May 11, 2020 at 10:52 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Sat 09 May 06:08 PDT 2020, Shawn Guo wrote:
>
> > On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock
> > needs to be on while doing TLB invalidate. Otherwise, TLBSYNC status
> > will not be correctly reflected, causing the system to go into a bad
> > state. Add it as an optional clock, so that platforms that have this
> > clock can pass it over DT.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
[snip]
> > @@ -839,6 +849,12 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> > return PTR_ERR(qcom_iommu->bus_clk);
> > }
> >
> > + qcom_iommu->tlb_clk = devm_clk_get(dev, "tlb");
>
> Wouldn't "tbu" be a better name for this clock? Given that seems the
> actually be the hardware block you're clocking.
>
>
> That said, I thought we used device links and pm_runtime to ensure that
> the TBUs are powered and clocked...
>
please don't rely on device-link for that, buffers can be freed (and
therefore need to be unmapped) at times when the gpu is off.
BR,
-R
WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Konrad Dybcio <konradybcio@gmail.com>,
"list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,
" <iommu@lists.linux-foundation.org>,
Andy Gross <agross@kernel.org>, Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] iommu/qcom: add optional clock for TLB invalidate
Date: Tue, 12 May 2020 11:35:01 -0700 [thread overview]
Message-ID: <CAF6AEGsod2L+VwJGhECpW8BhfexLgMMp_3V3AsnKjXcyLaT48w@mail.gmail.com> (raw)
In-Reply-To: <20200512055242.GJ1302550@yoga>
On Mon, May 11, 2020 at 10:52 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Sat 09 May 06:08 PDT 2020, Shawn Guo wrote:
>
> > On some SoCs like MSM8939 with A405 adreno, there is a gfx_tbu clock
> > needs to be on while doing TLB invalidate. Otherwise, TLBSYNC status
> > will not be correctly reflected, causing the system to go into a bad
> > state. Add it as an optional clock, so that platforms that have this
> > clock can pass it over DT.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
[snip]
> > @@ -839,6 +849,12 @@ static int qcom_iommu_device_probe(struct platform_device *pdev)
> > return PTR_ERR(qcom_iommu->bus_clk);
> > }
> >
> > + qcom_iommu->tlb_clk = devm_clk_get(dev, "tlb");
>
> Wouldn't "tbu" be a better name for this clock? Given that seems the
> actually be the hardware block you're clocking.
>
>
> That said, I thought we used device links and pm_runtime to ensure that
> the TBUs are powered and clocked...
>
please don't rely on device-link for that, buffers can be freed (and
therefore need to be unmapped) at times when the gpu is off.
BR,
-R
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-05-12 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 13:08 [PATCH] iommu/qcom: add optional clock for TLB invalidate Shawn Guo
2020-05-09 13:08 ` Shawn Guo
2020-05-09 13:21 ` Stanimir Varbanov
2020-05-09 13:21 ` Stanimir Varbanov
2020-05-10 14:30 ` Shawn Guo
2020-05-10 14:30 ` Shawn Guo
2020-05-12 5:52 ` Bjorn Andersson
2020-05-12 5:52 ` Bjorn Andersson
2020-05-12 18:35 ` Rob Clark [this message]
2020-05-12 18:35 ` Rob Clark
2020-05-14 14:39 ` Shawn Guo
2020-05-14 14:39 ` Shawn Guo
2020-05-14 15:15 ` Bjorn Andersson
2020-05-14 15:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF6AEGsod2L+VwJGhECpW8BhfexLgMMp_3V3AsnKjXcyLaT48w@mail.gmail.com \
--to=robdclark@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.