* [PATCH] README: add pkg kernel-devel to dnf command
@ 2020-05-15 17:30 william.c.roberts
2020-05-15 17:51 ` Paul Moore
` (3 more replies)
0 siblings, 4 replies; 19+ messages in thread
From: william.c.roberts @ 2020-05-15 17:30 UTC (permalink / raw)
To: selinux; +Cc: William Roberts
From: William Roberts <william.c.roberts@intel.com>
The text above states that kernel-devel is needed, but it's missing from
the dnf command.
Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index 1f7e5d92a100..a73e9cc0c06d 100644
--- a/README.md
+++ b/README.md
@@ -77,7 +77,8 @@ following command:
kernel-devel \
quota \
xfsprogs-devel \
- libuuid-devel
+ libuuid-devel \
+ kernel-devel-$(uname -r)
#### Debian
--
2.17.1
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 17:30 [PATCH] README: add pkg kernel-devel to dnf command william.c.roberts @ 2020-05-15 17:51 ` Paul Moore 2020-05-15 17:56 ` William Roberts 2020-05-15 17:58 ` Ondrej Mosnacek ` (2 subsequent siblings) 3 siblings, 1 reply; 19+ messages in thread From: Paul Moore @ 2020-05-15 17:51 UTC (permalink / raw) To: william.c.roberts; +Cc: selinux On Fri, May 15, 2020 at 1:30 PM <william.c.roberts@intel.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > The text above states that kernel-devel is needed, but it's missing from > the dnf command. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > README.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) It's not clear from the subject, diffstat, or your comments, but I'm assuming this is for selinux-testsuite, yes? > diff --git a/README.md b/README.md > index 1f7e5d92a100..a73e9cc0c06d 100644 > --- a/README.md > +++ b/README.md > @@ -77,7 +77,8 @@ following command: > kernel-devel \ > quota \ > xfsprogs-devel \ > - libuuid-devel > + libuuid-devel \ > + kernel-devel-$(uname -r) > > #### Debian > > -- > 2.17.1 > -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 17:51 ` Paul Moore @ 2020-05-15 17:56 ` William Roberts 0 siblings, 0 replies; 19+ messages in thread From: William Roberts @ 2020-05-15 17:56 UTC (permalink / raw) To: Paul Moore; +Cc: William Roberts, SElinux list On Fri, May 15, 2020 at 12:51 PM Paul Moore <paul@paul-moore.com> wrote: > > On Fri, May 15, 2020 at 1:30 PM <william.c.roberts@intel.com> wrote: > > > > From: William Roberts <william.c.roberts@intel.com> > > > > The text above states that kernel-devel is needed, but it's missing from > > the dnf command. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > README.md | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > It's not clear from the subject, diffstat, or your comments, but I'm > assuming this is for selinux-testsuite, yes? Yes, that is correct. > > > diff --git a/README.md b/README.md > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > --- a/README.md > > +++ b/README.md > > @@ -77,7 +77,8 @@ following command: > > kernel-devel \ > > quota \ > > xfsprogs-devel \ > > - libuuid-devel > > + libuuid-devel \ > > + kernel-devel-$(uname -r) > > > > #### Debian > > > > -- > > 2.17.1 > > > > > -- > paul moore > www.paul-moore.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 17:30 [PATCH] README: add pkg kernel-devel to dnf command william.c.roberts 2020-05-15 17:51 ` Paul Moore @ 2020-05-15 17:58 ` Ondrej Mosnacek 2020-05-15 18:08 ` William Roberts 2020-05-15 21:01 ` [PATCH v2] README: update kernel-devel package in " william.c.roberts 2020-05-15 21:21 ` [PATCH v3] " william.c.roberts 3 siblings, 1 reply; 19+ messages in thread From: Ondrej Mosnacek @ 2020-05-15 17:58 UTC (permalink / raw) To: Roberts, William C; +Cc: SElinux list On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > From: William Roberts <william.c.roberts@intel.com> > > The text above states that kernel-devel is needed, but it's missing from > the dnf command. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > README.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 1f7e5d92a100..a73e9cc0c06d 100644 > --- a/README.md > +++ b/README.md > @@ -77,7 +77,8 @@ following command: > kernel-devel \ It's actually right there already ^^ > quota \ > xfsprogs-devel \ > - libuuid-devel > + libuuid-devel \ > + kernel-devel-$(uname -r) I proposed adding the -$(uname -r) before, but there were some valid counterarguments. See the discussion here: https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > #### Debian > > -- > 2.17.1 > -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 17:58 ` Ondrej Mosnacek @ 2020-05-15 18:08 ` William Roberts 2020-05-15 18:51 ` Stephen Smalley 0 siblings, 1 reply; 19+ messages in thread From: William Roberts @ 2020-05-15 18:08 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: Roberts, William C, SElinux list On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > > > The text above states that kernel-devel is needed, but it's missing from > > the dnf command. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > README.md | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/README.md b/README.md > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > --- a/README.md > > +++ b/README.md > > @@ -77,7 +77,8 @@ following command: > > kernel-devel \ > > It's actually right there already ^^ Yeah that's the foot cannon, I thought I was good, but you need the specific ones as Ondrej pointed out to me. > > > quota \ > > xfsprogs-devel \ > > - libuuid-devel > > + libuuid-devel \ > > + kernel-devel-$(uname -r) > > I proposed adding the -$(uname -r) before, but there were some valid > counterarguments. See the discussion here: > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > Arguments for why the dnf command should have it with uname: 1. We tried to add it twice, it's bit people twice. 2. The README states "On a modern Fedora system you can install these dependencies with the following command:" - which is wrong, you need the specific package - If you're going to provide a "dnf install" or a apt-get install, it should just work - the apt-get example has uname -r in it. - so the precludes building your own kernel, if you do that as Paul stated, you're on your own. (lore comment) > > > > #### Debian > > > > -- > > 2.17.1 > > > > -- > Ondrej Mosnacek <omosnace at redhat dot com> > Software Engineer, Security Technologies > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 18:08 ` William Roberts @ 2020-05-15 18:51 ` Stephen Smalley 2020-05-15 19:27 ` William Roberts 0 siblings, 1 reply; 19+ messages in thread From: Stephen Smalley @ 2020-05-15 18:51 UTC (permalink / raw) To: William Roberts; +Cc: Ondrej Mosnacek, Roberts, William C, SElinux list On Fri, May 15, 2020 at 2:11 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > the dnf command. > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > --- > > > README.md | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/README.md b/README.md > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > --- a/README.md > > > +++ b/README.md > > > @@ -77,7 +77,8 @@ following command: > > > kernel-devel \ > > > > It's actually right there already ^^ > > Yeah that's the foot cannon, I thought I was good, but you need the > specific ones > as Ondrej pointed out to me. > > > > > > quota \ > > > xfsprogs-devel \ > > > - libuuid-devel > > > + libuuid-devel \ > > > + kernel-devel-$(uname -r) > > > > I proposed adding the -$(uname -r) before, but there were some valid > > counterarguments. See the discussion here: > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > Arguments for why the dnf command should have it with uname: > 1. We tried to add it twice, it's bit people twice. > 2. The README states "On a modern Fedora system you can install these > dependencies with the following command:" > - which is wrong, you need the specific package > - If you're going to provide a "dnf install" or a apt-get install, > it should just work > - the apt-get example has uname -r in it. > - so the precludes building your own kernel, if you do that as > Paul stated, you're on your own. (lore comment) I'm ok with adding it. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 18:51 ` Stephen Smalley @ 2020-05-15 19:27 ` William Roberts 2020-05-15 19:36 ` Stephen Smalley 2020-05-15 19:41 ` Ondrej Mosnacek 0 siblings, 2 replies; 19+ messages in thread From: William Roberts @ 2020-05-15 19:27 UTC (permalink / raw) To: Stephen Smalley; +Cc: Ondrej Mosnacek, Roberts, William C, SElinux list On Fri, May 15, 2020 at 1:51 PM Stephen Smalley <stephen.smalley.work@gmail.com> wrote: > > On Fri, May 15, 2020 at 2:11 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > the dnf command. > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > --- > > > > README.md | 3 ++- > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/README.md b/README.md > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > --- a/README.md > > > > +++ b/README.md > > > > @@ -77,7 +77,8 @@ following command: > > > > kernel-devel \ > > > > > > It's actually right there already ^^ > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > specific ones > > as Ondrej pointed out to me. > > > > > > > > > quota \ > > > > xfsprogs-devel \ > > > > - libuuid-devel > > > > + libuuid-devel \ > > > > + kernel-devel-$(uname -r) > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > counterarguments. See the discussion here: > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > Arguments for why the dnf command should have it with uname: > > 1. We tried to add it twice, it's bit people twice. > > 2. The README states "On a modern Fedora system you can install these > > dependencies with the following command:" > > - which is wrong, you need the specific package > > - If you're going to provide a "dnf install" or a apt-get install, > > it should just work > > - the apt-get example has uname -r in it. > > - so the precludes building your own kernel, if you do that as > > Paul stated, you're on your own. (lore comment) > > I'm ok with adding it. Does anyone want to ack this one? Ok I found another one, kernel-modules-extra is needed for the sctp module. The tests expect sctp support, should we conditionally skip these if sctp is not enabled? Whats the best way of checking for that proto if we want this? just an ls of /proc/sys/net: ls /proc/sys/net/ bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 19:27 ` William Roberts @ 2020-05-15 19:36 ` Stephen Smalley 2020-05-15 19:40 ` William Roberts 2020-05-15 19:41 ` Ondrej Mosnacek 1 sibling, 1 reply; 19+ messages in thread From: Stephen Smalley @ 2020-05-15 19:36 UTC (permalink / raw) To: William Roberts; +Cc: Ondrej Mosnacek, Roberts, William C, SElinux list On Fri, May 15, 2020 at 3:27 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > <stephen.smalley.work@gmail.com> wrote: > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > <bill.c.roberts@gmail.com> wrote: > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > the dnf command. > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > --- > > > > > README.md | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/README.md b/README.md > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > --- a/README.md > > > > > +++ b/README.md > > > > > @@ -77,7 +77,8 @@ following command: > > > > > kernel-devel \ > > > > > > > > It's actually right there already ^^ > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > specific ones > > > as Ondrej pointed out to me. > > > > > > > > > > > > quota \ > > > > > xfsprogs-devel \ > > > > > - libuuid-devel > > > > > + libuuid-devel \ > > > > > + kernel-devel-$(uname -r) > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > counterarguments. See the discussion here: > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > 1. We tried to add it twice, it's bit people twice. > > > 2. The README states "On a modern Fedora system you can install these > > > dependencies with the following command:" > > > - which is wrong, you need the specific package > > > - If you're going to provide a "dnf install" or a apt-get install, > > > it should just work > > > - the apt-get example has uname -r in it. > > > - so the precludes building your own kernel, if you do that as > > > Paul stated, you're on your own. (lore comment) > > > > I'm ok with adding it. > > Does anyone want to ack this one? To be clear, we should just replace "kernel-devel" in the dnf command with "kernel-devel-$(uname -r)" assuming that works. Not just add it in addition to the existing kernel-devel line. > Ok I found another one, kernel-modules-extra is needed for the sctp module. > > The tests expect sctp support, should we conditionally skip these if > sctp is not enabled? > Whats the best way of checking for that proto if we want this? just an > ls of /proc/sys/net: > ls /proc/sys/net/ > bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix Currently we require that the defconfig options are enabled (as per the README.md). Making sctp optional however might not be a bad idea since it is blacklisted these days by default in some distros. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 19:36 ` Stephen Smalley @ 2020-05-15 19:40 ` William Roberts 0 siblings, 0 replies; 19+ messages in thread From: William Roberts @ 2020-05-15 19:40 UTC (permalink / raw) To: Stephen Smalley; +Cc: Ondrej Mosnacek, Roberts, William C, SElinux list On Fri, May 15, 2020 at 2:36 PM Stephen Smalley <stephen.smalley.work@gmail.com> wrote: > > On Fri, May 15, 2020 at 3:27 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > > <stephen.smalley.work@gmail.com> wrote: > > > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > > the dnf command. > > > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > > --- > > > > > > README.md | 3 ++- > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/README.md b/README.md > > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > > --- a/README.md > > > > > > +++ b/README.md > > > > > > @@ -77,7 +77,8 @@ following command: > > > > > > kernel-devel \ > > > > > > > > > > It's actually right there already ^^ > > > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > > specific ones > > > > as Ondrej pointed out to me. > > > > > > > > > > > > > > > quota \ > > > > > > xfsprogs-devel \ > > > > > > - libuuid-devel > > > > > > + libuuid-devel \ > > > > > > + kernel-devel-$(uname -r) > > > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > > counterarguments. See the discussion here: > > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > > 1. We tried to add it twice, it's bit people twice. > > > > 2. The README states "On a modern Fedora system you can install these > > > > dependencies with the following command:" > > > > - which is wrong, you need the specific package > > > > - If you're going to provide a "dnf install" or a apt-get install, > > > > it should just work > > > > - the apt-get example has uname -r in it. > > > > - so the precludes building your own kernel, if you do that as > > > > Paul stated, you're on your own. (lore comment) > > > > > > I'm ok with adding it. > > > > Does anyone want to ack this one? > > To be clear, we should just replace "kernel-devel" in the dnf command > with "kernel-devel-$(uname -r)" assuming that works. > Not just add it in addition to the existing kernel-devel line. Ahh, Ok. > > > Ok I found another one, kernel-modules-extra is needed for the sctp module. > > > > The tests expect sctp support, should we conditionally skip these if > > sctp is not enabled? > > Whats the best way of checking for that proto if we want this? just an > > ls of /proc/sys/net: > > ls /proc/sys/net/ > > bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix > > Currently we require that the defconfig options are enabled (as per > the README.md). > Making sctp optional however might not be a bad idea since it is > blacklisted these days by default in some distros. Except defconfig has it as a module, so you need to have the module there and loaded. So for Fedora, you need the kernel modules package and modprobe it. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 19:27 ` William Roberts 2020-05-15 19:36 ` Stephen Smalley @ 2020-05-15 19:41 ` Ondrej Mosnacek 2020-05-15 20:46 ` William Roberts 1 sibling, 1 reply; 19+ messages in thread From: Ondrej Mosnacek @ 2020-05-15 19:41 UTC (permalink / raw) To: William Roberts; +Cc: Stephen Smalley, Roberts, William C, SElinux list On Fri, May 15, 2020 at 9:27 PM William Roberts <bill.c.roberts@gmail.com> wrote: > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > <stephen.smalley.work@gmail.com> wrote: > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > <bill.c.roberts@gmail.com> wrote: > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > the dnf command. > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > --- > > > > > README.md | 3 ++- > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/README.md b/README.md > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > --- a/README.md > > > > > +++ b/README.md > > > > > @@ -77,7 +77,8 @@ following command: > > > > > kernel-devel \ > > > > > > > > It's actually right there already ^^ > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > specific ones > > > as Ondrej pointed out to me. > > > > > > > > > > > > quota \ > > > > > xfsprogs-devel \ > > > > > - libuuid-devel > > > > > + libuuid-devel \ > > > > > + kernel-devel-$(uname -r) > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > counterarguments. See the discussion here: > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > 1. We tried to add it twice, it's bit people twice. > > > 2. The README states "On a modern Fedora system you can install these > > > dependencies with the following command:" > > > - which is wrong, you need the specific package > > > - If you're going to provide a "dnf install" or a apt-get install, > > > it should just work > > > - the apt-get example has uname -r in it. > > > - so the precludes building your own kernel, if you do that as > > > Paul stated, you're on your own. (lore comment) > > > > I'm ok with adding it. > > Does anyone want to ack this one? As Stephen already said while I was writing this message, please just update the existing kernel-devel line. > > Ok I found another one, kernel-modules-extra is needed for the sctp module. On Fedora it shouldn't be, only on RHEL/CentOS 8. > > The tests expect sctp support, should we conditionally skip these if > sctp is not enabled? > Whats the best way of checking for that proto if we want this? just an > ls of /proc/sys/net: > ls /proc/sys/net/ > bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix > -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 19:41 ` Ondrej Mosnacek @ 2020-05-15 20:46 ` William Roberts 2020-05-15 21:05 ` Ondrej Mosnacek 0 siblings, 1 reply; 19+ messages in thread From: William Roberts @ 2020-05-15 20:46 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: Stephen Smalley, Roberts, William C, SElinux list On Fri, May 15, 2020 at 2:41 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Fri, May 15, 2020 at 9:27 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > > <stephen.smalley.work@gmail.com> wrote: > > > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > > the dnf command. > > > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > > --- > > > > > > README.md | 3 ++- > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/README.md b/README.md > > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > > --- a/README.md > > > > > > +++ b/README.md > > > > > > @@ -77,7 +77,8 @@ following command: > > > > > > kernel-devel \ > > > > > > > > > > It's actually right there already ^^ > > > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > > specific ones > > > > as Ondrej pointed out to me. > > > > > > > > > > > > > > > quota \ > > > > > > xfsprogs-devel \ > > > > > > - libuuid-devel > > > > > > + libuuid-devel \ > > > > > > + kernel-devel-$(uname -r) > > > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > > counterarguments. See the discussion here: > > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > > 1. We tried to add it twice, it's bit people twice. > > > > 2. The README states "On a modern Fedora system you can install these > > > > dependencies with the following command:" > > > > - which is wrong, you need the specific package > > > > - If you're going to provide a "dnf install" or a apt-get install, > > > > it should just work > > > > - the apt-get example has uname -r in it. > > > > - so the precludes building your own kernel, if you do that as > > > > Paul stated, you're on your own. (lore comment) > > > > > > I'm ok with adding it. > > > > Does anyone want to ack this one? > > As Stephen already said while I was writing this message, please just > update the existing kernel-devel line. > > > > > Ok I found another one, kernel-modules-extra is needed for the sctp module. > > On Fedora it shouldn't be, only on RHEL/CentOS 8. Not on the cloud image, so I am assuming that desktop just has it already fulfilled. > > > > > The tests expect sctp support, should we conditionally skip these if > > sctp is not enabled? > > Whats the best way of checking for that proto if we want this? just an > > ls of /proc/sys/net: > > ls /proc/sys/net/ > > bridge core ipv4 ipv6 netfilter nf_conntrack_max sctp unix > > > > -- > Ondrej Mosnacek <omosnace at redhat dot com> > Software Engineer, Security Technologies > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 20:46 ` William Roberts @ 2020-05-15 21:05 ` Ondrej Mosnacek 2020-05-15 21:19 ` William Roberts 0 siblings, 1 reply; 19+ messages in thread From: Ondrej Mosnacek @ 2020-05-15 21:05 UTC (permalink / raw) To: William Roberts; +Cc: Stephen Smalley, Roberts, William C, SElinux list On Fri, May 15, 2020 at 10:46 PM William Roberts <bill.c.roberts@gmail.com> wrote: > On Fri, May 15, 2020 at 2:41 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Fri, May 15, 2020 at 9:27 PM William Roberts > > <bill.c.roberts@gmail.com> wrote: > > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > > > <stephen.smalley.work@gmail.com> wrote: > > > > > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > > > the dnf command. > > > > > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > > > --- > > > > > > > README.md | 3 ++- > > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/README.md b/README.md > > > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > > > --- a/README.md > > > > > > > +++ b/README.md > > > > > > > @@ -77,7 +77,8 @@ following command: > > > > > > > kernel-devel \ > > > > > > > > > > > > It's actually right there already ^^ > > > > > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > > > specific ones > > > > > as Ondrej pointed out to me. > > > > > > > > > > > > > > > > > > quota \ > > > > > > > xfsprogs-devel \ > > > > > > > - libuuid-devel > > > > > > > + libuuid-devel \ > > > > > > > + kernel-devel-$(uname -r) > > > > > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > > > counterarguments. See the discussion here: > > > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > > > 1. We tried to add it twice, it's bit people twice. > > > > > 2. The README states "On a modern Fedora system you can install these > > > > > dependencies with the following command:" > > > > > - which is wrong, you need the specific package > > > > > - If you're going to provide a "dnf install" or a apt-get install, > > > > > it should just work > > > > > - the apt-get example has uname -r in it. > > > > > - so the precludes building your own kernel, if you do that as > > > > > Paul stated, you're on your own. (lore comment) > > > > > > > > I'm ok with adding it. > > > > > > Does anyone want to ack this one? > > > > As Stephen already said while I was writing this message, please just > > update the existing kernel-devel line. > > > > > > > > Ok I found another one, kernel-modules-extra is needed for the sctp module. > > > > On Fedora it shouldn't be, only on RHEL/CentOS 8. > > Not on the cloud image, so I am assuming that desktop just has it already > fulfilled. That's strange... Was this with the 5.6.6-300.fc32.x86_64 kernel mentioned in the other thread? I just downloaded the RPMs for that build and sctp.ko was in kernel-modules, not kernel-modules-extra. -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] README: add pkg kernel-devel to dnf command 2020-05-15 21:05 ` Ondrej Mosnacek @ 2020-05-15 21:19 ` William Roberts 0 siblings, 0 replies; 19+ messages in thread From: William Roberts @ 2020-05-15 21:19 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: Stephen Smalley, Roberts, William C, SElinux list On Fri, May 15, 2020 at 4:06 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Fri, May 15, 2020 at 10:46 PM William Roberts > <bill.c.roberts@gmail.com> wrote: > > On Fri, May 15, 2020 at 2:41 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > On Fri, May 15, 2020 at 9:27 PM William Roberts > > > <bill.c.roberts@gmail.com> wrote: > > > > On Fri, May 15, 2020 at 1:51 PM Stephen Smalley > > > > <stephen.smalley.work@gmail.com> wrote: > > > > > > > > > > On Fri, May 15, 2020 at 2:11 PM William Roberts > > > > > <bill.c.roberts@gmail.com> wrote: > > > > > > > > > > > > On Fri, May 15, 2020 at 12:59 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > > > > > > > On Fri, May 15, 2020 at 7:31 PM <william.c.roberts@intel.com> wrote: > > > > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > > > > > > > The text above states that kernel-devel is needed, but it's missing from > > > > > > > > the dnf command. > > > > > > > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > > > > --- > > > > > > > > README.md | 3 ++- > > > > > > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > diff --git a/README.md b/README.md > > > > > > > > index 1f7e5d92a100..a73e9cc0c06d 100644 > > > > > > > > --- a/README.md > > > > > > > > +++ b/README.md > > > > > > > > @@ -77,7 +77,8 @@ following command: > > > > > > > > kernel-devel \ > > > > > > > > > > > > > > It's actually right there already ^^ > > > > > > > > > > > > Yeah that's the foot cannon, I thought I was good, but you need the > > > > > > specific ones > > > > > > as Ondrej pointed out to me. > > > > > > > > > > > > > > > > > > > > > quota \ > > > > > > > > xfsprogs-devel \ > > > > > > > > - libuuid-devel > > > > > > > > + libuuid-devel \ > > > > > > > > + kernel-devel-$(uname -r) > > > > > > > > > > > > > > I proposed adding the -$(uname -r) before, but there were some valid > > > > > > > counterarguments. See the discussion here: > > > > > > > https://lore.kernel.org/selinux/CAFqZXNs5jcOOnhzT8=DQgzaf9RtBZ1=oqTU83pjVLMqPb-rzHA@mail.gmail.com/ > > > > > > > > > > > > > > > > > > > Arguments for why the dnf command should have it with uname: > > > > > > 1. We tried to add it twice, it's bit people twice. > > > > > > 2. The README states "On a modern Fedora system you can install these > > > > > > dependencies with the following command:" > > > > > > - which is wrong, you need the specific package > > > > > > - If you're going to provide a "dnf install" or a apt-get install, > > > > > > it should just work > > > > > > - the apt-get example has uname -r in it. > > > > > > - so the precludes building your own kernel, if you do that as > > > > > > Paul stated, you're on your own. (lore comment) > > > > > > > > > > I'm ok with adding it. > > > > > > > > Does anyone want to ack this one? > > > > > > As Stephen already said while I was writing this message, please just > > > update the existing kernel-devel line. > > > > > > > > > > > Ok I found another one, kernel-modules-extra is needed for the sctp module. > > > > > > On Fedora it shouldn't be, only on RHEL/CentOS 8. > > > > Not on the cloud image, so I am assuming that desktop just has it already > > fulfilled. > > That's strange... Was this with the 5.6.6-300.fc32.x86_64 kernel > mentioned in the other thread? I just downloaded the RPMs for that > build and sctp.ko was in kernel-modules, not kernel-modules-extra. I say it was in kernel-modules-extra-$(uname -r), but what I should have said, that solved the issue od not having the sctp module, but it solved it buy being dependent on kernel-modules, so the correct line to add would be that one, not extra. I don't do really use fedora distros, so bear me with as I learn where to find info and poke the system. > > -- > Ondrej Mosnacek <omosnace at redhat dot com> > Software Engineer, Security Technologies > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2] README: update kernel-devel package in dnf command 2020-05-15 17:30 [PATCH] README: add pkg kernel-devel to dnf command william.c.roberts 2020-05-15 17:51 ` Paul Moore 2020-05-15 17:58 ` Ondrej Mosnacek @ 2020-05-15 21:01 ` william.c.roberts 2020-05-15 21:06 ` Paul Moore 2020-05-15 21:21 ` [PATCH v3] " william.c.roberts 3 siblings, 1 reply; 19+ messages in thread From: william.c.roberts @ 2020-05-15 21:01 UTC (permalink / raw) To: william.c.roberts; +Cc: selinux From: William Roberts <william.c.roberts@intel.com> The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32. Signed-off-by: William Roberts <william.c.roberts@intel.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1f7e5d92a100..4d5d6d22203a 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ following command: attr \ libbpf-devel \ keyutils-libs-devel \ - kernel-devel \ + kernel-devel-$(uname -r) quota \ xfsprogs-devel \ libuuid-devel -- 2.17.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2] README: update kernel-devel package in dnf command 2020-05-15 21:01 ` [PATCH v2] README: update kernel-devel package in " william.c.roberts @ 2020-05-15 21:06 ` Paul Moore 2020-05-15 21:20 ` William Roberts 0 siblings, 1 reply; 19+ messages in thread From: Paul Moore @ 2020-05-15 21:06 UTC (permalink / raw) To: william.c.roberts; +Cc: selinux On Fri, May 15, 2020 at 5:02 PM <william.c.roberts@intel.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > The README.md file in the selinux-testsuite states that kernel-devel > package is needed. However, for everything to work you need the > kernel-devel package specific to your kernel version. > Update the dnf command to include uname -r, so that a copy + paste > of the dnf command, results in a system with dependencies filled > for recent Fedora distro's like Fedora 32. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 1f7e5d92a100..4d5d6d22203a 100644 > --- a/README.md > +++ b/README.md > @@ -74,7 +74,7 @@ following command: > attr \ > libbpf-devel \ > keyutils-libs-devel \ > - kernel-devel \ > + kernel-devel-$(uname -r) I \ think \ you \ forgot \ the \ trailing \ slash \ > quota \ > xfsprogs-devel \ > libuuid-devel > -- > 2.17.1 -- paul moore www.paul-moore.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] README: update kernel-devel package in dnf command 2020-05-15 21:06 ` Paul Moore @ 2020-05-15 21:20 ` William Roberts 0 siblings, 0 replies; 19+ messages in thread From: William Roberts @ 2020-05-15 21:20 UTC (permalink / raw) To: Paul Moore; +Cc: William Roberts, SElinux list On Fri, May 15, 2020 at 4:09 PM Paul Moore <paul@paul-moore.com> wrote: > > On Fri, May 15, 2020 at 5:02 PM <william.c.roberts@intel.com> wrote: > > > > From: William Roberts <william.c.roberts@intel.com> > > > > The README.md file in the selinux-testsuite states that kernel-devel > > package is needed. However, for everything to work you need the > > kernel-devel package specific to your kernel version. > > Update the dnf command to include uname -r, so that a copy + paste > > of the dnf command, results in a system with dependencies filled > > for recent Fedora distro's like Fedora 32. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > README.md | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.md b/README.md > > index 1f7e5d92a100..4d5d6d22203a 100644 > > --- a/README.md > > +++ b/README.md > > @@ -74,7 +74,7 @@ following command: > > attr \ > > libbpf-devel \ > > keyutils-libs-devel \ > > - kernel-devel \ > > + kernel-devel-$(uname -r) > > I \ > think \ > you \ > forgot \ > the \ > trailing \ > slash \ fsck \ > > > quota \ > > xfsprogs-devel \ > > libuuid-devel > > -- > > 2.17.1 > > -- > paul moore > www.paul-moore.com ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3] README: update kernel-devel package in dnf command 2020-05-15 17:30 [PATCH] README: add pkg kernel-devel to dnf command william.c.roberts ` (2 preceding siblings ...) 2020-05-15 21:01 ` [PATCH v2] README: update kernel-devel package in " william.c.roberts @ 2020-05-15 21:21 ` william.c.roberts 2020-05-20 9:19 ` Ondrej Mosnacek 3 siblings, 1 reply; 19+ messages in thread From: william.c.roberts @ 2020-05-15 21:21 UTC (permalink / raw) To: william.c.roberts; +Cc: selinux From: William Roberts <william.c.roberts@intel.com> The README.md file in the selinux-testsuite states that kernel-devel package is needed. However, for everything to work you need the kernel-devel package specific to your kernel version. Update the dnf command to include uname -r, so that a copy + paste of the dnf command, results in a system with dependencies filled for recent Fedora distro's like Fedora 32. Signed-off-by: William Roberts <william.c.roberts@intel.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1f7e5d92a100..1bec9fe85c91 100644 --- a/README.md +++ b/README.md @@ -74,7 +74,7 @@ following command: attr \ libbpf-devel \ keyutils-libs-devel \ - kernel-devel \ + kernel-devel-$(uname -r) \ quota \ xfsprogs-devel \ libuuid-devel -- 2.17.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3] README: update kernel-devel package in dnf command 2020-05-15 21:21 ` [PATCH v3] " william.c.roberts @ 2020-05-20 9:19 ` Ondrej Mosnacek 2020-05-20 15:18 ` Ondrej Mosnacek 0 siblings, 1 reply; 19+ messages in thread From: Ondrej Mosnacek @ 2020-05-20 9:19 UTC (permalink / raw) To: Roberts, William C; +Cc: SElinux list On Fri, May 15, 2020 at 11:22 PM <william.c.roberts@intel.com> wrote: > From: William Roberts <william.c.roberts@intel.com> > > The README.md file in the selinux-testsuite states that kernel-devel > package is needed. However, for everything to work you need the > kernel-devel package specific to your kernel version. > Update the dnf command to include uname -r, so that a copy + paste > of the dnf command, results in a system with dependencies filled > for recent Fedora distro's like Fedora 32. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > README.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README.md b/README.md > index 1f7e5d92a100..1bec9fe85c91 100644 > --- a/README.md > +++ b/README.md > @@ -74,7 +74,7 @@ following command: > attr \ > libbpf-devel \ > keyutils-libs-devel \ > - kernel-devel \ > + kernel-devel-$(uname -r) \ > quota \ > xfsprogs-devel \ > libuuid-devel > -- > 2.17.1 > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc. ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3] README: update kernel-devel package in dnf command 2020-05-20 9:19 ` Ondrej Mosnacek @ 2020-05-20 15:18 ` Ondrej Mosnacek 0 siblings, 0 replies; 19+ messages in thread From: Ondrej Mosnacek @ 2020-05-20 15:18 UTC (permalink / raw) To: Roberts, William C; +Cc: SElinux list On Wed, May 20, 2020 at 11:19 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > On Fri, May 15, 2020 at 11:22 PM <william.c.roberts@intel.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > > > The README.md file in the selinux-testsuite states that kernel-devel > > package is needed. However, for everything to work you need the > > kernel-devel package specific to your kernel version. > > Update the dnf command to include uname -r, so that a copy + paste > > of the dnf command, results in a system with dependencies filled > > for recent Fedora distro's like Fedora 32. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > README.md | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README.md b/README.md > > index 1f7e5d92a100..1bec9fe85c91 100644 > > --- a/README.md > > +++ b/README.md > > @@ -74,7 +74,7 @@ following command: > > attr \ > > libbpf-devel \ > > keyutils-libs-devel \ > > - kernel-devel \ > > + kernel-devel-$(uname -r) \ > > quota \ > > xfsprogs-devel \ > > libuuid-devel > > -- > > 2.17.1 > > > > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> Applied. -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc. ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-05-20 15:18 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-15 17:30 [PATCH] README: add pkg kernel-devel to dnf command william.c.roberts 2020-05-15 17:51 ` Paul Moore 2020-05-15 17:56 ` William Roberts 2020-05-15 17:58 ` Ondrej Mosnacek 2020-05-15 18:08 ` William Roberts 2020-05-15 18:51 ` Stephen Smalley 2020-05-15 19:27 ` William Roberts 2020-05-15 19:36 ` Stephen Smalley 2020-05-15 19:40 ` William Roberts 2020-05-15 19:41 ` Ondrej Mosnacek 2020-05-15 20:46 ` William Roberts 2020-05-15 21:05 ` Ondrej Mosnacek 2020-05-15 21:19 ` William Roberts 2020-05-15 21:01 ` [PATCH v2] README: update kernel-devel package in " william.c.roberts 2020-05-15 21:06 ` Paul Moore 2020-05-15 21:20 ` William Roberts 2020-05-15 21:21 ` [PATCH v3] " william.c.roberts 2020-05-20 9:19 ` Ondrej Mosnacek 2020-05-20 15:18 ` Ondrej Mosnacek
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.