From: Jim Wilson <jimw@sifive.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-riscv@nongnu.org,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers.
Date: Mon, 28 Jan 2019 19:00:04 -0800 [thread overview]
Message-ID: <CAFyWVaa-L4pZXtJpUu7hom08LMx0q5pFmRyhO0TrmATD7CoRoA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKP3wOiHvpqyFZZCzy3c7sJP86P30JXUA0P2jAvRL7QgbQ@mail.gmail.com>
On Tue, Jan 22, 2019 at 1:45 PM Alistair Francis <alistair23@gmail.com> wrote:
> I think it makes more sense to just define the variable in the
> gdbstubs.c file then. Can you move it to patch 5?
Yes, that is no problem. That makes patch 3 a lot smaller and patch 5
a lot bigger, but it is the same code as before, just arranged
differently, so this shouldn't complicate the review too much.
Jim
WARNING: multiple messages have this Message-ID (diff)
From: Jim Wilson <jimw@sifive.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
qemu-riscv@nongnu.org,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-riscv] [Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers.
Date: Mon, 28 Jan 2019 19:00:04 -0800 [thread overview]
Message-ID: <CAFyWVaa-L4pZXtJpUu7hom08LMx0q5pFmRyhO0TrmATD7CoRoA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKP3wOiHvpqyFZZCzy3c7sJP86P30JXUA0P2jAvRL7QgbQ@mail.gmail.com>
On Tue, Jan 22, 2019 at 1:45 PM Alistair Francis <alistair23@gmail.com> wrote:
> I think it makes more sense to just define the variable in the
> gdbstubs.c file then. Can you move it to patch 5?
Yes, that is no problem. That makes patch 3 a lot smaller and patch 5
a lot bigger, but it is the same code as before, just arranged
differently, so this shouldn't complicate the review too much.
Jim
next prev parent reply other threads:[~2019-01-29 3:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 22:05 [Qemu-devel] [PATCH 0/5 v2] RISC-V: Add gdb xml files and gdbstub support Jim Wilson
2018-12-28 22:05 ` [Qemu-riscv] " Jim Wilson
2018-12-28 22:07 ` [Qemu-devel] [PATCH 1/5 v2] RISC-V: Add 32-bit gdb xml files Jim Wilson
2018-12-28 22:07 ` [Qemu-riscv] " Jim Wilson
2018-12-29 22:20 ` [Qemu-devel] " Richard Henderson
2018-12-29 22:20 ` [Qemu-riscv] " Richard Henderson
2018-12-30 19:56 ` Jim Wilson
2018-12-30 19:56 ` [Qemu-riscv] " Jim Wilson
2019-01-22 21:53 ` Alistair Francis
2019-01-22 21:53 ` [Qemu-riscv] " Alistair Francis
2018-12-28 22:08 ` [Qemu-devel] [PATCH 2/5 v2] RISC-V: Add 64-bit " Jim Wilson
2018-12-28 22:08 ` [Qemu-riscv] " Jim Wilson
2019-01-22 21:53 ` [Qemu-devel] " Alistair Francis
2019-01-22 21:53 ` [Qemu-riscv] " Alistair Francis
2018-12-28 22:09 ` [Qemu-devel] [PATCH 3/5 v2] RISC-V: Map gdb CSR reg numbers to hw reg numbers Jim Wilson
2018-12-28 22:09 ` [Qemu-riscv] " Jim Wilson
2018-12-29 22:23 ` [Qemu-devel] " Richard Henderson
2018-12-29 22:23 ` [Qemu-riscv] " Richard Henderson
2018-12-30 19:22 ` Jim Wilson
2018-12-30 19:22 ` [Qemu-riscv] " Jim Wilson
2019-01-22 21:45 ` Alistair Francis
2019-01-22 21:45 ` [Qemu-riscv] " Alistair Francis
2019-01-29 3:00 ` Jim Wilson [this message]
2019-01-29 3:00 ` Jim Wilson
2018-12-28 22:10 ` [Qemu-devel] [PATCH 4/5 v2] RISC-V: Add debug support for accessing CSRs Jim Wilson
2018-12-28 22:10 ` [Qemu-riscv] " Jim Wilson
2018-12-29 22:25 ` [Qemu-devel] " Richard Henderson
2018-12-29 22:25 ` [Qemu-riscv] " Richard Henderson
2019-01-22 21:46 ` Alistair Francis
2019-01-22 21:46 ` [Qemu-riscv] " Alistair Francis
2018-12-28 22:11 ` [Qemu-devel] [PATCH 5/5 v2] RISC-V: Add hooks to use the gdb xml files Jim Wilson
2018-12-28 22:11 ` [Qemu-riscv] " Jim Wilson
2019-01-22 21:52 ` [Qemu-devel] " Alistair Francis
2019-01-22 21:52 ` [Qemu-riscv] " Alistair Francis
2019-01-29 3:11 ` Jim Wilson
2019-01-29 3:11 ` [Qemu-riscv] " Jim Wilson
2019-01-29 23:21 ` Palmer Dabbelt
2019-01-29 23:21 ` [Qemu-riscv] " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyWVaa-L4pZXtJpUu7hom08LMx0q5pFmRyhO0TrmATD7CoRoA@mail.gmail.com \
--to=jimw@sifive.com \
--cc=alistair23@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.