From: Tali Perry <tali.perry1@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Tyrone Ting <warp5tw@gmail.com>, avifishman70@gmail.com, Tomer Maimon <tmaimon77@gmail.com>, Patrick Venture <venture@google.com>, Nancy Yuen <yuenn@google.com>, Benjamin Fair <benjaminfair@google.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, yangyicong@hisilicon.com, semen.protsenko@linaro.org, Wolfram Sang <wsa@kernel.org>, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, Tali Perry <tali.perry@nuvoton.com>, Avi Fishman <Avi.Fishman@nuvoton.com>, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, OpenBMC Maillist <openbmc@lists.ozlabs.org>, Linux I2C <linux-i2c@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts Date: Thu, 3 Mar 2022 14:48:20 +0200 [thread overview] Message-ID: <CAHb3i=sStqdSpLKtF_UGmTsOssR_swssTd3pv6c2-z_kiUPTTA@mail.gmail.com> (raw) In-Reply-To: <YiCaSSbbszm3qYIQ@smile.fi.intel.com> > On Thu, Mar 3, 2022 at 12:37 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Mar 03, 2022 at 04:31:39PM +0800, Tyrone Ting wrote: > > > From: Tali Perry <tali.perry1@gmail.com> > > > > > > In order to better handle spurious interrupts: > > > 1. Disable incoming interrupts in master only mode. > > > 2. Clear end of busy (EOB) after every interrupt. > > > 3. Return correct status during interrupt. > > > > This is bad commit message, it doesn't explain "why" you are doing these. > > > > ... BMC users connect a huge tree of i2c devices and muxes. This tree suffers from spikes, noise and double clocks. All these may cause spurious interrupts to the BMC. If the driver gets an IRQ which was not expected and was not handled by the IRQ handler, there is nothing left to do but to clear the interrupt and move on. If the transaction failed, driver has a recovery function. After that, user may retry to send the message. Indeed the commit message doesn't explain all this. We will fix and add to the next patchset. > > > > > + /* > > > + * if irq is not one of the above, make sure EOB is disabled and all > > > + * status bits are cleared. > > > > This does not explain why you hide the spurious interrupt. > > > > > + */ > > > + if (ret == IRQ_NONE) { > > > + npcm_i2c_eob_int(bus, false); > > > + npcm_i2c_clear_master_status(bus); > > > + } > > > + > > > + return IRQ_HANDLED; > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > Thanks Andy, BR, Tali Perry
WARNING: multiple messages have this Message-ID (diff)
From: Tali Perry <tali.perry1@gmail.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Tomer Maimon <tmaimon77@gmail.com>, devicetree <devicetree@vger.kernel.org>, yangyicong@hisilicon.com, Linux I2C <linux-i2c@vger.kernel.org>, Benjamin Fair <benjaminfair@google.com>, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>, OpenBMC Maillist <openbmc@lists.ozlabs.org>, JJLIU0@nuvoton.com, lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, bence98@sch.bme.hu, arnd@arndb.de, sven@svenpeter.dev, Rob Herring <robh+dt@kernel.org>, Avi Fishman <Avi.Fishman@nuvoton.com>, Tyrone Ting <warp5tw@gmail.com>, semen.protsenko@linaro.org, jie.deng@intel.com, avifishman70@gmail.com, Patrick Venture <venture@google.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Wolfram Sang <wsa@kernel.org>, kfting@nuvoton.com, Tali Perry <tali.perry@nuvoton.com>, olof@lixom.net Subject: Re: [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts Date: Thu, 3 Mar 2022 14:48:20 +0200 [thread overview] Message-ID: <CAHb3i=sStqdSpLKtF_UGmTsOssR_swssTd3pv6c2-z_kiUPTTA@mail.gmail.com> (raw) In-Reply-To: <YiCaSSbbszm3qYIQ@smile.fi.intel.com> > On Thu, Mar 3, 2022 at 12:37 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > > On Thu, Mar 03, 2022 at 04:31:39PM +0800, Tyrone Ting wrote: > > > From: Tali Perry <tali.perry1@gmail.com> > > > > > > In order to better handle spurious interrupts: > > > 1. Disable incoming interrupts in master only mode. > > > 2. Clear end of busy (EOB) after every interrupt. > > > 3. Return correct status during interrupt. > > > > This is bad commit message, it doesn't explain "why" you are doing these. > > > > ... BMC users connect a huge tree of i2c devices and muxes. This tree suffers from spikes, noise and double clocks. All these may cause spurious interrupts to the BMC. If the driver gets an IRQ which was not expected and was not handled by the IRQ handler, there is nothing left to do but to clear the interrupt and move on. If the transaction failed, driver has a recovery function. After that, user may retry to send the message. Indeed the commit message doesn't explain all this. We will fix and add to the next patchset. > > > > > + /* > > > + * if irq is not one of the above, make sure EOB is disabled and all > > > + * status bits are cleared. > > > > This does not explain why you hide the spurious interrupt. > > > > > + */ > > > + if (ret == IRQ_NONE) { > > > + npcm_i2c_eob_int(bus, false); > > > + npcm_i2c_clear_master_status(bus); > > > + } > > > + > > > + return IRQ_HANDLED; > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > Thanks Andy, BR, Tali Perry
next prev parent reply other threads:[~2022-03-03 12:48 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-03 8:31 [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 01/11] arm: dts: add new property for NPCM i2c module Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-18 20:28 ` Wolfram Sang 2022-03-18 20:28 ` Wolfram Sang 2022-03-20 9:34 ` Tyrone Ting 2022-03-20 9:42 ` Wolfram Sang 2022-03-20 9:42 ` Wolfram Sang 2022-03-03 8:31 ` [PATCH v3 02/11] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:37 ` Krzysztof Kozlowski 2022-03-03 10:37 ` Krzysztof Kozlowski 2022-03-04 13:30 ` Tyrone Ting 2022-03-04 13:30 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 03/11] i2c: npcm: Fix client address calculation Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:30 ` Andy Shevchenko 2022-03-03 10:30 ` Andy Shevchenko 2022-03-04 13:39 ` Tyrone Ting 2022-03-04 13:39 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 04/11] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:38 ` Krzysztof Kozlowski 2022-03-03 10:38 ` Krzysztof Kozlowski 2022-03-04 13:32 ` Tyrone Ting 2022-03-04 13:32 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 05/11] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 06/11] i2c: npcm: Fix timeout calculation Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 07/11] i2c: npcm: Add tx complete counter Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 08/11] i2c: npcm: Correct register access width Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:33 ` Andy Shevchenko 2022-03-03 10:33 ` Andy Shevchenko 2022-03-03 12:54 ` Tali Perry 2022-03-03 12:54 ` Tali Perry 2022-03-03 14:15 ` Andy Shevchenko 2022-03-03 14:15 ` Andy Shevchenko 2022-03-04 20:42 ` Jonathan Neuschäfer 2022-03-04 20:42 ` Jonathan Neuschäfer 2022-03-22 17:18 ` Avi Fishman 2022-03-22 17:18 ` Avi Fishman 2022-03-22 17:51 ` Jonathan Neuschäfer 2022-03-22 17:51 ` Jonathan Neuschäfer 2022-03-03 8:31 ` [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:36 ` Andy Shevchenko 2022-03-03 10:36 ` Andy Shevchenko 2022-03-03 12:48 ` Tali Perry [this message] 2022-03-03 12:48 ` Tali Perry 2022-03-03 14:13 ` Andy Shevchenko 2022-03-03 14:13 ` Andy Shevchenko 2022-04-04 17:03 ` Avi Fishman 2022-04-04 17:03 ` Avi Fishman 2022-04-05 7:13 ` Andy Shevchenko 2022-04-05 7:13 ` Andy Shevchenko 2022-04-10 7:33 ` Avi Fishman 2022-04-10 7:33 ` Avi Fishman 2022-03-03 8:31 ` [PATCH v3 10/11] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 8:31 ` [PATCH v3 11/11] i2c: npcm: Support NPCM845 Tyrone Ting 2022-03-03 8:31 ` Tyrone Ting 2022-03-03 10:43 ` Andy Shevchenko 2022-03-03 10:43 ` Andy Shevchenko 2022-03-03 12:35 ` Tali Perry 2022-03-03 12:35 ` Tali Perry 2022-03-03 14:10 ` Andy Shevchenko 2022-03-03 14:10 ` Andy Shevchenko 2022-03-06 13:33 ` Tomer Maimon 2022-03-07 9:43 ` Andy Shevchenko 2022-03-07 9:43 ` Andy Shevchenko 2022-03-07 19:47 ` Tomer Maimon 2022-03-03 10:26 ` [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Andy Shevchenko 2022-03-03 10:26 ` Andy Shevchenko 2022-03-03 13:03 ` Tali Perry 2022-03-03 13:03 ` Tali Perry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAHb3i=sStqdSpLKtF_UGmTsOssR_swssTd3pv6c2-z_kiUPTTA@mail.gmail.com' \ --to=tali.perry1@gmail.com \ --cc=Avi.Fishman@nuvoton.com \ --cc=JJLIU0@nuvoton.com \ --cc=KWLIU@nuvoton.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=bence98@sch.bme.hu \ --cc=benjaminfair@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jie.deng@intel.com \ --cc=kfting@nuvoton.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ --cc=olof@lixom.net \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=sven@svenpeter.dev \ --cc=tali.perry@nuvoton.com \ --cc=tmaimon77@gmail.com \ --cc=tomer.maimon@nuvoton.com \ --cc=venture@google.com \ --cc=warp5tw@gmail.com \ --cc=wsa@kernel.org \ --cc=yangyicong@hisilicon.com \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.