From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tyrone Ting <warp5tw@gmail.com>
Cc: avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, robh+dt@kernel.org,
krzysztof.kozlowski@canonical.com, yangyicong@hisilicon.com,
semen.protsenko@linaro.org, wsa@kernel.org, jie.deng@intel.com,
sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com,
arnd@arndb.de, olof@lixom.net, tali.perry@nuvoton.com,
Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com,
openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/11] i2c: npcm: Correct register access width
Date: Thu, 3 Mar 2022 12:33:58 +0200 [thread overview]
Message-ID: <YiCZlhJoXPLpQ6/D@smile.fi.intel.com> (raw)
In-Reply-To: <20220303083141.8742-9-warp5tw@gmail.com>
On Thu, Mar 03, 2022 at 04:31:38PM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@nuvoton.com>
>
> Use ioread8 instead of ioread32 to access the SMBnCTL3 register since
> the register is only 8-bit wide.
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
No, this is bad commit message, since you have bitwise masks and there is
nothing to fix from functional point of view. So, why is this a fix?
> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
This is wrong SoB chain.
...
> - return !!(I2CCTL3_SCL_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> + return !!(I2CCTL3_SCL_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
...
> - return !!(I2CCTL3_SDA_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> + return !!(I2CCTL3_SDA_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tyrone Ting <warp5tw@gmail.com>
Cc: tmaimon77@gmail.com, devicetree@vger.kernel.org,
tali.perry1@gmail.com, linux-i2c@vger.kernel.org,
benjaminfair@google.com, krzysztof.kozlowski@canonical.com,
openbmc@lists.ozlabs.org, JJLIU0@nuvoton.com,
lukas.bulwahn@gmail.com, tomer.maimon@nuvoton.com,
KWLIU@nuvoton.com, bence98@sch.bme.hu, arnd@arndb.de,
sven@svenpeter.dev, robh+dt@kernel.org, Avi.Fishman@nuvoton.com,
yangyicong@hisilicon.com, semen.protsenko@linaro.org,
jie.deng@intel.com, avifishman70@gmail.com, venture@google.com,
linux-kernel@vger.kernel.org, wsa@kernel.org, kfting@nuvoton.com,
tali.perry@nuvoton.com, olof@lixom.net
Subject: Re: [PATCH v3 08/11] i2c: npcm: Correct register access width
Date: Thu, 3 Mar 2022 12:33:58 +0200 [thread overview]
Message-ID: <YiCZlhJoXPLpQ6/D@smile.fi.intel.com> (raw)
In-Reply-To: <20220303083141.8742-9-warp5tw@gmail.com>
On Thu, Mar 03, 2022 at 04:31:38PM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@nuvoton.com>
>
> Use ioread8 instead of ioread32 to access the SMBnCTL3 register since
> the register is only 8-bit wide.
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
No, this is bad commit message, since you have bitwise masks and there is
nothing to fix from functional point of view. So, why is this a fix?
> Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
> Signed-off-by: Tali Perry <tali.perry1@gmail.com>
This is wrong SoB chain.
...
> - return !!(I2CCTL3_SCL_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> + return !!(I2CCTL3_SCL_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
...
> - return !!(I2CCTL3_SDA_LVL & ioread32(bus->reg + NPCM_I2CCTL3));
> + return !!(I2CCTL3_SDA_LVL & ioread8(bus->reg + NPCM_I2CCTL3));
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-03-03 10:35 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 8:31 [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 01/11] arm: dts: add new property for NPCM i2c module Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-18 20:28 ` Wolfram Sang
2022-03-18 20:28 ` Wolfram Sang
2022-03-20 9:34 ` Tyrone Ting
2022-03-20 9:42 ` Wolfram Sang
2022-03-20 9:42 ` Wolfram Sang
2022-03-03 8:31 ` [PATCH v3 02/11] dt-bindings: i2c: npcm: support NPCM845 Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:37 ` Krzysztof Kozlowski
2022-03-03 10:37 ` Krzysztof Kozlowski
2022-03-04 13:30 ` Tyrone Ting
2022-03-04 13:30 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 03/11] i2c: npcm: Fix client address calculation Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:30 ` Andy Shevchenko
2022-03-03 10:30 ` Andy Shevchenko
2022-03-04 13:39 ` Tyrone Ting
2022-03-04 13:39 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 04/11] i2c: npcm: Change the way of getting GCR regmap Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:38 ` Krzysztof Kozlowski
2022-03-03 10:38 ` Krzysztof Kozlowski
2022-03-04 13:32 ` Tyrone Ting
2022-03-04 13:32 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 05/11] i2c: npcm: Remove unused variable clk_regmap Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 06/11] i2c: npcm: Fix timeout calculation Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 07/11] i2c: npcm: Add tx complete counter Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 08/11] i2c: npcm: Correct register access width Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:33 ` Andy Shevchenko [this message]
2022-03-03 10:33 ` Andy Shevchenko
2022-03-03 12:54 ` Tali Perry
2022-03-03 12:54 ` Tali Perry
2022-03-03 14:15 ` Andy Shevchenko
2022-03-03 14:15 ` Andy Shevchenko
2022-03-04 20:42 ` Jonathan Neuschäfer
2022-03-04 20:42 ` Jonathan Neuschäfer
2022-03-22 17:18 ` Avi Fishman
2022-03-22 17:18 ` Avi Fishman
2022-03-22 17:51 ` Jonathan Neuschäfer
2022-03-22 17:51 ` Jonathan Neuschäfer
2022-03-03 8:31 ` [PATCH v3 09/11] i2c: npcm: Handle spurious interrupts Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:36 ` Andy Shevchenko
2022-03-03 10:36 ` Andy Shevchenko
2022-03-03 12:48 ` Tali Perry
2022-03-03 12:48 ` Tali Perry
2022-03-03 14:13 ` Andy Shevchenko
2022-03-03 14:13 ` Andy Shevchenko
2022-04-04 17:03 ` Avi Fishman
2022-04-04 17:03 ` Avi Fishman
2022-04-05 7:13 ` Andy Shevchenko
2022-04-05 7:13 ` Andy Shevchenko
2022-04-10 7:33 ` Avi Fishman
2022-04-10 7:33 ` Avi Fishman
2022-03-03 8:31 ` [PATCH v3 10/11] i2c: npcm: Remove own slave addresses 2:10 Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 8:31 ` [PATCH v3 11/11] i2c: npcm: Support NPCM845 Tyrone Ting
2022-03-03 8:31 ` Tyrone Ting
2022-03-03 10:43 ` Andy Shevchenko
2022-03-03 10:43 ` Andy Shevchenko
2022-03-03 12:35 ` Tali Perry
2022-03-03 12:35 ` Tali Perry
2022-03-03 14:10 ` Andy Shevchenko
2022-03-03 14:10 ` Andy Shevchenko
2022-03-06 13:33 ` Tomer Maimon
2022-03-07 9:43 ` Andy Shevchenko
2022-03-07 9:43 ` Andy Shevchenko
2022-03-07 19:47 ` Tomer Maimon
2022-03-03 10:26 ` [PATCH v3 00/11] i2c: npcm: Bug fixes timeout, spurious interrupts Andy Shevchenko
2022-03-03 10:26 ` Andy Shevchenko
2022-03-03 13:03 ` Tali Perry
2022-03-03 13:03 ` Tali Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiCZlhJoXPLpQ6/D@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Avi.Fishman@nuvoton.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=bence98@sch.bme.hu \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jie.deng@intel.com \
--cc=kfting@nuvoton.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sven@svenpeter.dev \
--cc=tali.perry1@gmail.com \
--cc=tali.perry@nuvoton.com \
--cc=tmaimon77@gmail.com \
--cc=tomer.maimon@nuvoton.com \
--cc=venture@google.com \
--cc=warp5tw@gmail.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.