* [PATCH 1/2] libmnl: add recpie
@ 2017-08-29 7:25 Yi Zhao
2017-08-29 7:25 ` [PATCH 2/2] iproute2: enable build tipc by default Yi Zhao
2017-08-30 10:53 ` [PATCH 1/2] libmnl: add recpie Burton, Ross
0 siblings, 2 replies; 9+ messages in thread
From: Yi Zhao @ 2017-08-29 7:25 UTC (permalink / raw)
To: openembedded-core, mark.hatle, raj.khem, randy.macleod
libmnl is a minimalistic user-space library oriented to Netlink
developers. There are a lot of common tasks in parsing, validating,
constructing of both the Netlink header and TLVs that are repetitive
and easy to get wrong.
Move it from meta-networking to oe-core as it is a dependency for
iproute2 to support tipc.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
meta/recipes-support/libmnl/libmnl_1.0.4.bb | 13 +++++++++++++
1 file changed, 13 insertions(+)
create mode 100644 meta/recipes-support/libmnl/libmnl_1.0.4.bb
diff --git a/meta/recipes-support/libmnl/libmnl_1.0.4.bb b/meta/recipes-support/libmnl/libmnl_1.0.4.bb
new file mode 100644
index 0000000..b458799
--- /dev/null
+++ b/meta/recipes-support/libmnl/libmnl_1.0.4.bb
@@ -0,0 +1,13 @@
+SUMMARY = "Minimalistic user-space Netlink utility library"
+DESCRIPTION = "Minimalistic user-space library oriented to Netlink developers, providing \
+ functions for common tasks in parsing, validating, and constructing both the Netlink header and TLVs."
+HOMEPAGE = "http://www.netfilter.org/projects/libmnl/index.html"
+SECTION = "libs"
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
+
+SRC_URI = "http://www.netfilter.org/projects/libmnl/files/libmnl-${PV}.tar.bz2;name=tar"
+SRC_URI[tar.md5sum] = "be9b4b5328c6da1bda565ac5dffadb2d"
+SRC_URI[tar.sha256sum] = "171f89699f286a5854b72b91d06e8f8e3683064c5901fb09d954a9ab6f551f81"
+
+inherit autotools pkgconfig
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] iproute2: enable build tipc by default
2017-08-29 7:25 [PATCH 1/2] libmnl: add recpie Yi Zhao
@ 2017-08-29 7:25 ` Yi Zhao
2017-08-29 16:13 ` Burton, Ross
2017-08-30 10:53 ` [PATCH 1/2] libmnl: add recpie Burton, Ross
1 sibling, 1 reply; 9+ messages in thread
From: Yi Zhao @ 2017-08-29 7:25 UTC (permalink / raw)
To: openembedded-core, mark.hatle, raj.khem, randy.macleod
By default, TIPC is enabled as a module in Yocto Kernel:
CONFIG_TIPC=m
CONFIG_TIPC_MEDIA_UDP=y
So we can enable build tipc by default in iproute2.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
---
meta/recipes-connectivity/iproute2/iproute2.inc | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-connectivity/iproute2/iproute2.inc b/meta/recipes-connectivity/iproute2/iproute2.inc
index 57309b7..79ea635 100644
--- a/meta/recipes-connectivity/iproute2/iproute2.inc
+++ b/meta/recipes-connectivity/iproute2/iproute2.inc
@@ -9,14 +9,11 @@ LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
file://ip/ip.c;beginline=3;endline=8;md5=689d691d0410a4b64d3899f8d6e31817"
-DEPENDS = "flex-native bison-native iptables elfutils"
+DEPENDS = "flex-native bison-native iptables elfutils libmnl"
inherit update-alternatives bash-completion pkgconfig
-PACKAGECONFIG ??= ""
-PACKAGECONFIG[tipc] = ",,libmnl,"
-
-EXTRA_OEMAKE = "CC='${CC}' KERNEL_INCLUDE=${STAGING_INCDIR} DOCDIR=${docdir}/iproute2 SUBDIRS='lib tc ip bridge misc genl ${@bb.utils.contains('PACKAGECONFIG', 'tipc', 'tipc', '', d)}' SBINDIR='${base_sbindir}' LIBDIR='${libdir}'"
+EXTRA_OEMAKE = "CC='${CC}' KERNEL_INCLUDE=${STAGING_INCDIR} DOCDIR=${docdir}/iproute2 SUBDIRS='lib tc ip bridge misc genl tipc' SBINDIR='${base_sbindir}' LIBDIR='${libdir}'"
do_configure_append () {
sh configure ${STAGING_INCDIR}
@@ -35,7 +32,7 @@ do_install () {
# The .so files in iproute2-tc are modules, not traditional libraries
INSANE_SKIP_${PN}-tc = "dev-so"
-PACKAGES =+ "${PN}-tc ${PN}-lnstat ${PN}-ifstat ${PN}-genl ${PN}-rtacct ${PN}-nstat ${PN}-ss ${@bb.utils.contains('PACKAGECONFIG', 'tipc', '${PN}-tipc', '', d)}"
+PACKAGES =+ "${PN}-tc ${PN}-lnstat ${PN}-ifstat ${PN}-genl ${PN}-rtacct ${PN}-nstat ${PN}-ss ${PN}-tipc"
FILES_${PN}-tc = "${base_sbindir}/tc* \
${libdir}/tc/*.so"
FILES_${PN}-lnstat = "${base_sbindir}/lnstat ${base_sbindir}/ctstat ${base_sbindir}/rtstat"
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] iproute2: enable build tipc by default
2017-08-29 7:25 ` [PATCH 2/2] iproute2: enable build tipc by default Yi Zhao
@ 2017-08-29 16:13 ` Burton, Ross
2017-08-30 0:35 ` Yi Zhao
0 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2017-08-29 16:13 UTC (permalink / raw)
To: Yi Zhao; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com> wrote:
> -PACKAGECONFIG ??= ""
> -PACKAGECONFIG[tipc] = ",,libmnl,"
>
Surely it would be a lot better to just add tipc to the default
PACKAGECONFIG, so this support and dependencies can be turned off if
required?
Ross
[-- Attachment #2: Type: text/html, Size: 639 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] iproute2: enable build tipc by default
2017-08-29 16:13 ` Burton, Ross
@ 2017-08-30 0:35 ` Yi Zhao
2017-08-30 7:43 ` Jussi Kukkonen
0 siblings, 1 reply; 9+ messages in thread
From: Yi Zhao @ 2017-08-30 0:35 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
在 2017年08月30日 00:13, Burton, Ross 写道:
> On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com
> <mailto:yi.zhao@windriver.com>> wrote:
>
> -PACKAGECONFIG ??= ""
> -PACKAGECONFIG[tipc] = ",,libmnl,"
>
>
> Surely it would be a lot better to just add tipc to the default
> PACKAGECONFIG, so this support and dependencies can be turned off if
> required?
There is no easy way to turn off the support with this patch. User
should remove tipc from EXTRA_OEMAKE manually.
The package isn't installed to rootfs by default if no package requires it.
Yi
>
> Ross
[-- Attachment #2: Type: text/html, Size: 1970 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] iproute2: enable build tipc by default
2017-08-30 0:35 ` Yi Zhao
@ 2017-08-30 7:43 ` Jussi Kukkonen
2017-08-31 0:53 ` Yi Zhao
0 siblings, 1 reply; 9+ messages in thread
From: Jussi Kukkonen @ 2017-08-30 7:43 UTC (permalink / raw)
To: Yi Zhao; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On 30 August 2017 at 03:35, Yi Zhao <yi.zhao@windriver.com> wrote:
>
>
> 在 2017年08月30日 00:13, Burton, Ross 写道:
>
> On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com> wrote:
>
>> -PACKAGECONFIG ??= ""
>> -PACKAGECONFIG[tipc] = ",,libmnl,"
>>
>
> Surely it would be a lot better to just add tipc to the default
> PACKAGECONFIG, so this support and dependencies can be turned off if
> required?
>
>
> There is no easy way to turn off the support with this patch. User should
> remove tipc from EXTRA_OEMAKE manually.
> The package isn't installed to rootfs by default if no package requires it.
>
The question is why not leave the PACKAGECONFIG there so there would be an
easy way to turn it off?
Jussi
[-- Attachment #2: Type: text/html, Size: 1848 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] libmnl: add recpie
2017-08-29 7:25 [PATCH 1/2] libmnl: add recpie Yi Zhao
2017-08-29 7:25 ` [PATCH 2/2] iproute2: enable build tipc by default Yi Zhao
@ 2017-08-30 10:53 ` Burton, Ross
2017-08-30 15:13 ` Trevor Woerner
1 sibling, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2017-08-30 10:53 UTC (permalink / raw)
To: Yi Zhao; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1977 bytes --]
Note that we've reached feature freeze for 2.4 so this will have to wait
for 2.5.
Ross
On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com> wrote:
> libmnl is a minimalistic user-space library oriented to Netlink
> developers. There are a lot of common tasks in parsing, validating,
> constructing of both the Netlink header and TLVs that are repetitive
> and easy to get wrong.
>
> Move it from meta-networking to oe-core as it is a dependency for
> iproute2 to support tipc.
>
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
> meta/recipes-support/libmnl/libmnl_1.0.4.bb | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
> create mode 100644 meta/recipes-support/libmnl/libmnl_1.0.4.bb
>
> diff --git a/meta/recipes-support/libmnl/libmnl_1.0.4.bb
> b/meta/recipes-support/libmnl/libmnl_1.0.4.bb
> new file mode 100644
> index 0000000..b458799
> --- /dev/null
> +++ b/meta/recipes-support/libmnl/libmnl_1.0.4.bb
> @@ -0,0 +1,13 @@
> +SUMMARY = "Minimalistic user-space Netlink utility library"
> +DESCRIPTION = "Minimalistic user-space library oriented to Netlink
> developers, providing \
> + functions for common tasks in parsing, validating, and constructing
> both the Netlink header and TLVs."
> +HOMEPAGE = "http://www.netfilter.org/projects/libmnl/index.html"
> +SECTION = "libs"
> +LICENSE = "LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c"
> +
> +SRC_URI = "http://www.netfilter.org/projects/libmnl/files/libmnl-$
> {PV}.tar.bz2;name=tar"
> +SRC_URI[tar.md5sum] = "be9b4b5328c6da1bda565ac5dffadb2d"
> +SRC_URI[tar.sha256sum] = "171f89699f286a5854b72b91d06e8f
> 8e3683064c5901fb09d954a9ab6f551f81"
> +
> +inherit autotools pkgconfig
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 3403 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] libmnl: add recpie
2017-08-30 10:53 ` [PATCH 1/2] libmnl: add recpie Burton, Ross
@ 2017-08-30 15:13 ` Trevor Woerner
2017-08-30 15:22 ` Burton, Ross
0 siblings, 1 reply; 9+ messages in thread
From: Trevor Woerner @ 2017-08-30 15:13 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On Wed, Aug 30, 2017 at 6:53 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Note that we've reached feature freeze for 2.4 so this will have to wait for
> 2.5.
A lot of my builds failed last night because I'm not including
meta-networking (which pulls in meta-python) because they weren't
needed previously for what I was building. But with libmnl now being
needed by iproute2, maybe this is a stronger argument for needing it
in oecore for this release? oecore should stand on its own, unless
there's a way to make this dependency a non-default packageconfig?
It's not a big deal, I can just add meta-networking and meta-python
and "solve" the problem.
>> Move it from meta-networking to oe-core as it is a dependency for
>> iproute2 to support tipc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] libmnl: add recpie
2017-08-30 15:13 ` Trevor Woerner
@ 2017-08-30 15:22 ` Burton, Ross
0 siblings, 0 replies; 9+ messages in thread
From: Burton, Ross @ 2017-08-30 15:22 UTC (permalink / raw)
To: Trevor Woerner; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On 30 August 2017 at 16:13, Trevor Woerner <twoerner@gmail.com> wrote:
> On Wed, Aug 30, 2017 at 6:53 AM, Burton, Ross <ross.burton@intel.com>
> wrote:
> > Note that we've reached feature freeze for 2.4 so this will have to wait
> for
> > 2.5.
>
> A lot of my builds failed last night because I'm not including
> meta-networking (which pulls in meta-python) because they weren't
> needed previously for what I was building. But with libmnl now being
> needed by iproute2, maybe this is a stronger argument for needing it
> in oecore for this release? oecore should stand on its own, unless
> there's a way to make this dependency a non-default packageconfig?
>
> It's not a big deal, I can just add meta-networking and meta-python
> and "solve" the problem.
How and why does oe-core need libmnl?
Ross
[-- Attachment #2: Type: text/html, Size: 1279 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] iproute2: enable build tipc by default
2017-08-30 7:43 ` Jussi Kukkonen
@ 2017-08-31 0:53 ` Yi Zhao
0 siblings, 0 replies; 9+ messages in thread
From: Yi Zhao @ 2017-08-31 0:53 UTC (permalink / raw)
To: Jussi Kukkonen; +Cc: OE-core
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
在 2017年08月30日 15:43, Jussi Kukkonen 写道:
> On 30 August 2017 at 03:35, Yi Zhao <yi.zhao@windriver.com
> <mailto:yi.zhao@windriver.com>> wrote:
>
>
>
> 在 2017年08月30日 00:13, Burton, Ross 写道:
>> On 29 August 2017 at 08:25, Yi Zhao <yi.zhao@windriver.com
>> <mailto:yi.zhao@windriver.com>> wrote:
>>
>> -PACKAGECONFIG ??= ""
>> -PACKAGECONFIG[tipc] = ",,libmnl,"
>>
>>
>> Surely it would be a lot better to just add tipc to the default
>> PACKAGECONFIG, so this support and dependencies can be turned off
>> if required?
>
> There is no easy way to turn off the support with this patch. User
> should remove tipc from EXTRA_OEMAKE manually.
> The package isn't installed to rootfs by default if no package
> requires it.
>
>
> The question is why not leave the PACKAGECONFIG there so there would
> be an easy way to turn it off?
I just thought this would make the code more clear. The source doesn't
build with autotools, PACKAGECONFIG[tipc] = ",,libmnl," looks a little
strange.
If it is not a good idea, I will send a v2 patch to keep the PACKAGECONFIG.
Thanks,
Yi
>
> Jussi
[-- Attachment #2: Type: text/html, Size: 3843 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-08-31 0:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 7:25 [PATCH 1/2] libmnl: add recpie Yi Zhao
2017-08-29 7:25 ` [PATCH 2/2] iproute2: enable build tipc by default Yi Zhao
2017-08-29 16:13 ` Burton, Ross
2017-08-30 0:35 ` Yi Zhao
2017-08-30 7:43 ` Jussi Kukkonen
2017-08-31 0:53 ` Yi Zhao
2017-08-30 10:53 ` [PATCH 1/2] libmnl: add recpie Burton, Ross
2017-08-30 15:13 ` Trevor Woerner
2017-08-30 15:22 ` Burton, Ross
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.