All of
 help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Eduardo Valentin <>,
	Stefan Wahren <>,
	Guenter Roeck <>
Cc: Rui Zhang <>,
	ACPI Devel Maling List <>,
	Linux PM <>,
	LKML <>
Subject: Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1
Date: Thu, 16 May 2019 08:07:54 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20190516044313.GA17751@localhost.localdomain>

On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin <> wrote:
> - thermal core has a new devm_* API for registering cooling devices, thanks to Guenter R.
>   I took the entire series, that is why you see changes on drivers/hwmon in this pull.

This clashed badly with commit 6b1ec4789fb1 ("hwmon: (pwm-fan) Add RPM
support via external interrupt"), which added a timer to the pwm-fan

In particular, that timer now needed the same kind of cleanup changes,
and I'd like you guys (particularly Guenther, who was involved on both
sides) to double-check my merge.

The way I solved it was to just make the pwm_fan_pwm_disable()
callback do both the pwm_diable() _and_ the del_timer_sync() on the
new timer. That seemed to be the simplest solution that meshed with
the new devm cleanup model, but while I build-tested the result, I
obviously did no actual use testing. And maybe there's some reason why
that approach is flawed.



  reply	other threads:[~2019-05-16 15:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  4:43 Eduardo Valentin
2019-05-16 15:07 ` Linus Torvalds [this message]
2019-05-16 16:11   ` Stefan Wahren
2019-05-17 12:25     ` Stefan Wahren
2019-05-16 16:55   ` Guenter Roeck
2019-05-24  2:37     ` Eduardo Valentin
2019-05-16 15:10 ` pr-tracker-bot
2019-05-23  9:46 ` Tomeu Vizoso
2019-05-24  2:40   ` Eduardo Valentin
2019-05-24  8:23     ` Tomeu Vizoso
2019-05-24 13:54       ` Eduardo Valentin
2019-05-27 11:26         ` Tomeu Vizoso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \
    --subject='Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.