From: Guenter Roeck <firstname.lastname@example.org> To: Linus Torvalds <email@example.com>, Eduardo Valentin <firstname.lastname@example.org>, Stefan Wahren <email@example.com> Cc: Rui Zhang <firstname.lastname@example.org>, ACPI Devel Maling List <email@example.com>, Linux PM <firstname.lastname@example.org>, LKML <email@example.com> Subject: Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1 Date: Thu, 16 May 2019 09:55:33 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <CAHk-=wiaO_8SiEB9QM3vOTniiT67K6CBH0uHJ82-Dp_+6kxH3g@mail.gmail.com> On 5/16/19 8:07 AM, Linus Torvalds wrote: > On Wed, May 15, 2019 at 9:43 PM Eduardo Valentin <email@example.com> wrote: >> >> - thermal core has a new devm_* API for registering cooling devices, thanks to Guenter R. >> I took the entire series, that is why you see changes on drivers/hwmon in this pull. > > This clashed badly with commit 6b1ec4789fb1 ("hwmon: (pwm-fan) Add RPM > support via external interrupt"), which added a timer to the pwm-fan > handling. > > In particular, that timer now needed the same kind of cleanup changes, > and I'd like you guys (particularly Guenther, who was involved on both > sides) to double-check my merge. > > The way I solved it was to just make the pwm_fan_pwm_disable() > callback do both the pwm_diable() _and_ the del_timer_sync() on the > new timer. That seemed to be the simplest solution that meshed with > the new devm cleanup model, but while I build-tested the result, I > obviously did no actual use testing. And maybe there's some reason why > that approach is flawed. > > Guenther? Sorry for the trouble. Looks like I did too much cleanup this time around. Looks ok. I'll have to send a follow-up patch - we should check the return value of devm_add_action_or_reset(). No idea why I didn't do that in this series. I'll do that after the commit window closes (and after I am back from vacation). Thanks a lot for sorting this out. Guenter
next prev parent reply other threads:[~2019-05-16 16:55 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-16 4:43 Eduardo Valentin 2019-05-16 15:07 ` Linus Torvalds 2019-05-16 16:11 ` Stefan Wahren 2019-05-17 12:25 ` Stefan Wahren 2019-05-16 16:55 ` Guenter Roeck [this message] 2019-05-24 2:37 ` Eduardo Valentin 2019-05-16 15:10 ` pr-tracker-bot 2019-05-23 9:46 ` Tomeu Vizoso 2019-05-24 2:40 ` Eduardo Valentin 2019-05-24 8:23 ` Tomeu Vizoso 2019-05-24 13:54 ` Eduardo Valentin 2019-05-27 11:26 ` Tomeu Vizoso
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [GIT PULL] Thermal-SoC management changes for v5.2-rc1' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.