All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Helge Deller <deller@gmx.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	Sven Schnelle <svens@stackframe.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Ilia Mirkin <imirkin@alum.mit.edu>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Pavel Machek <pavel@ucw.cz>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Sam Ravnborg <sam@ravnborg.org>, Claudio Suarez <cssk@net-c.es>
Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"
Date: Wed, 19 Jan 2022 16:01:01 +0200	[thread overview]
Message-ID: <CAHk-=wikFKjwdUBWCLCu=iL3rFq4BDDF0aBGdXC6ay74yJb+5Q@mail.gmail.com> (raw)
In-Reply-To: <4d8950c7-5f51-ca2b-4c93-741c7805a214@gmx.de>

On Wed, Jan 19, 2022 at 2:29 PM Helge Deller <deller@gmx.de> wrote:
>
> >>
> >> Ah, no, that was just the soft scrollback code I was thinking of, which
>
> Right.
> That was commit 973c096f6a85 and it was about vgacon, not fbcon.

No, fbcon had some bug too, although I've paged out the details. See
commit 50145474f6ef ("fbcon: remove soft scrollback code").

If I remember correctly (and it's entirely possible that I don't), the
whole "softback_lines" logic had serious problems with resizing the
console (or maybe changing the font size).

There may have been some other bad interaction with
foreground/background consoles too, I forget.

       Linus

WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Helge Deller <deller@gmx.de>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
	Pavel Machek <pavel@ucw.cz>, Sam Ravnborg <sam@ravnborg.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Javier Martinez Canillas <javierm@redhat.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Claudio Suarez <cssk@net-c.es>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sven Schnelle <svens@stackframe.org>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"
Date: Wed, 19 Jan 2022 16:01:01 +0200	[thread overview]
Message-ID: <CAHk-=wikFKjwdUBWCLCu=iL3rFq4BDDF0aBGdXC6ay74yJb+5Q@mail.gmail.com> (raw)
In-Reply-To: <4d8950c7-5f51-ca2b-4c93-741c7805a214@gmx.de>

On Wed, Jan 19, 2022 at 2:29 PM Helge Deller <deller@gmx.de> wrote:
>
> >>
> >> Ah, no, that was just the soft scrollback code I was thinking of, which
>
> Right.
> That was commit 973c096f6a85 and it was about vgacon, not fbcon.

No, fbcon had some bug too, although I've paged out the details. See
commit 50145474f6ef ("fbcon: remove soft scrollback code").

If I remember correctly (and it's entirely possible that I don't), the
whole "softback_lines" logic had serious problems with resizing the
console (or maybe changing the font size).

There may have been some other bad interaction with
foreground/background consoles too, I forget.

       Linus

  reply	other threads:[~2022-01-19 14:08 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 11:08 [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Helge Deller
2022-01-19 11:08 ` [PATCH 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Helge Deller
2022-01-19 11:08 ` [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Helge Deller
2022-01-19 11:22   ` Greg Kroah-Hartman
2022-01-19 11:22     ` Greg Kroah-Hartman
2022-01-19 11:28     ` Greg Kroah-Hartman
2022-01-19 11:28       ` Greg Kroah-Hartman
2022-01-19 11:47       ` Geert Uytterhoeven
2022-01-19 11:47         ` Geert Uytterhoeven
2022-01-19 12:28         ` Helge Deller
2022-01-19 12:28           ` Helge Deller
2022-01-19 14:01           ` Linus Torvalds [this message]
2022-01-19 14:01             ` Linus Torvalds
2022-01-19 14:11             ` Helge Deller
2022-01-19 14:11               ` Helge Deller
2022-01-19 14:34             ` Daniel Vetter
2022-01-19 14:34               ` Daniel Vetter
2022-01-19 15:05               ` Sven Schnelle
2022-01-19 15:05                 ` Sven Schnelle
2022-01-19 15:37                 ` Thomas Zimmermann
2022-01-19 15:37                   ` Thomas Zimmermann
2022-01-19 16:55                   ` Helge Deller
2022-01-19 16:55                     ` Helge Deller
2022-01-19 15:42                 ` Daniel Vetter
2022-01-19 15:42                   ` Daniel Vetter
2022-01-19 15:54                   ` Helge Deller
2022-01-19 15:54                     ` Helge Deller
2022-01-19 16:13                     ` Jani Nikula
2022-01-19 16:13                       ` Jani Nikula
2022-01-19 16:31                       ` Daniel Vetter
2022-01-19 16:31                         ` Daniel Vetter
2022-01-19 15:18               ` Helge Deller
2022-01-19 15:18                 ` Helge Deller
2022-01-19 13:01       ` Sven Schnelle
2022-01-19 13:01         ` Sven Schnelle
2022-01-19 13:35         ` Greg Kroah-Hartman
2022-01-19 13:35           ` Greg Kroah-Hartman
2022-01-20 14:30   ` Daniel Vetter
2022-01-20 14:30     ` Daniel Vetter
2022-01-20 17:01     ` Helge Deller
2022-01-21  7:20       ` Gerd Hoffmann
2022-01-21  7:20         ` Gerd Hoffmann
2022-01-24 11:10         ` Helge Deller
2022-01-24 11:10           ` Helge Deller
2022-01-24 11:28           ` Javier Martinez Canillas
2022-01-24 11:28             ` Javier Martinez Canillas
2022-01-24 11:33           ` Thomas Zimmermann
2022-01-24 11:33             ` Thomas Zimmermann
2022-01-24 11:50             ` Javier Martinez Canillas
2022-01-24 11:50               ` Javier Martinez Canillas
2022-01-24 15:29               ` Helge Deller
2022-01-24 15:29                 ` Helge Deller
2022-01-24 15:45                 ` Thomas Zimmermann
2022-01-24 15:45                   ` Thomas Zimmermann
2022-01-24 15:50                 ` Geert Uytterhoeven
2022-01-24 15:50                   ` Geert Uytterhoeven
2022-01-24 15:58                 ` Daniel Vetter
2022-01-24 15:58                   ` Daniel Vetter
2022-01-24 15:50             ` Geert Uytterhoeven
2022-01-24 15:50               ` Geert Uytterhoeven
2022-01-24 16:11               ` Thomas Zimmermann
2022-01-24 16:11                 ` Thomas Zimmermann
2022-01-19 12:45 ` [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Geert Uytterhoeven
2022-01-19 12:45   ` Geert Uytterhoeven
2022-01-19 13:02 ` Sven Schnelle
2022-01-19 13:02   ` Sven Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wikFKjwdUBWCLCu=iL3rFq4BDDF0aBGdXC6ay74yJb+5Q@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=cssk@net-c.es \
    --cc=daniel.vetter@intel.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imirkin@alum.mit.edu \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sam@ravnborg.org \
    --cc=svens@stackframe.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.