From: Thomas Zimmermann <tzimmermann@suse.de> To: Sven Schnelle <svens@stackframe.org>, Daniel Vetter <daniel@ffwll.ch> Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>, Sam Ravnborg <sam@ravnborg.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Helge Deller <deller@gmx.de>, Javier Martinez Canillas <javierm@redhat.com>, DRI Development <dri-devel@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Claudio Suarez <cssk@net-c.es>, Gerd Hoffmann <kraxel@redhat.com>, Pavel Machek <pavel@ucw.cz>, Daniel Vetter <daniel.vetter@intel.com>, Linus Torvalds <torvalds@linux-foundation.org> Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Date: Wed, 19 Jan 2022 16:37:01 +0100 [thread overview] Message-ID: <ccec8635-6ec6-89c3-6738-65bd07a48508@suse.de> (raw) In-Reply-To: <8735ljkboo.fsf@x1.stackframe.org> [-- Attachment #1.1: Type: text/plain, Size: 2748 bytes --] Hi Am 19.01.22 um 16:05 schrieb Sven Schnelle: > Daniel Vetter <daniel@ffwll.ch> writes: > >> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds >> <torvalds@linux-foundation.org> wrote: >> Irrespective of this code being buggy or not buggy I think the bigger >> pictures, and really the reason I want to see as much code ditched >> from the fbdev/fbcon stack as we possible can, are very clear: >> >> - it's full of bugs >> - there's no test coverage/CI to speak of >> - it's very arcane code which is damn hard to understand and fix issues within >> - the locking is busted (largely thanks to console_lock, and the >> effort to make that reasonable from -rt folks has been slowly creeping >> forward for years). >> >> Iow this subsystem is firmly stuck in the 90s, and I think it's best >> to just leave it there. There's also not been anyone actually capable >> and willing to put in the work to change this (pretty much all actual >> changes/fixes have been done by drm folks anyway, like me having a >> small pet project to make the fbdev vs fbcon locking slightly less >> busted). > > Saying it's stuck in the 90ies, and actively trying to prevent > Helge from taking over maintainership at the same time looks odd. The issues are in the design itself. It's impossible to model today's hardware and constraints with fbdev. It's impossible to change configuration in a reliable way (i.e., what DRM calls atomic). Fbdev mmaps plain video ram to userspace, which is one of the reasons why DRM's fbdev support is hard to improve. > I think Helge should at least get a chance to fix the issues. If the > state is still the same in a year or so it should be discussed again. You cannot fix that in 10yrs. > >> The other side is that being a maintainer is about collaboration, and >> this entire fbdev maintainership takeover has been a demonstration of >> anything but that. MAINTAINERS entry was a bit confusing since defacto >> drm has been maintaining it for years. > > It was marked as 'Orphaned'. Anyone is free to send a Patch/PR to take > over maintainership. If you have strong opinions about that code (And you > obviously have reading your mail, set it to 'maintained' and care about > it. Everything else is just wrong in my opinion. No, it's not wrong. Helge takes fbdev over the weekend, without noteworthy experience, and ignores advice from the people that have kept it alive over the past years. This isn't going to work in the long term. Best regards Thomas > > /Sven -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Zimmermann <tzimmermann@suse.de> To: Sven Schnelle <svens@stackframe.org>, Daniel Vetter <daniel@ffwll.ch> Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>, Daniel Vetter <daniel.vetter@intel.com>, Linus Torvalds <torvalds@linux-foundation.org>, Helge Deller <deller@gmx.de>, Javier Martinez Canillas <javierm@redhat.com>, DRI Development <dri-devel@lists.freedesktop.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Claudio Suarez <cssk@net-c.es>, Gerd Hoffmann <kraxel@redhat.com>, Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Date: Wed, 19 Jan 2022 16:37:01 +0100 [thread overview] Message-ID: <ccec8635-6ec6-89c3-6738-65bd07a48508@suse.de> (raw) In-Reply-To: <8735ljkboo.fsf@x1.stackframe.org> [-- Attachment #1.1: Type: text/plain, Size: 2748 bytes --] Hi Am 19.01.22 um 16:05 schrieb Sven Schnelle: > Daniel Vetter <daniel@ffwll.ch> writes: > >> On Wed, Jan 19, 2022 at 3:01 PM Linus Torvalds >> <torvalds@linux-foundation.org> wrote: >> Irrespective of this code being buggy or not buggy I think the bigger >> pictures, and really the reason I want to see as much code ditched >> from the fbdev/fbcon stack as we possible can, are very clear: >> >> - it's full of bugs >> - there's no test coverage/CI to speak of >> - it's very arcane code which is damn hard to understand and fix issues within >> - the locking is busted (largely thanks to console_lock, and the >> effort to make that reasonable from -rt folks has been slowly creeping >> forward for years). >> >> Iow this subsystem is firmly stuck in the 90s, and I think it's best >> to just leave it there. There's also not been anyone actually capable >> and willing to put in the work to change this (pretty much all actual >> changes/fixes have been done by drm folks anyway, like me having a >> small pet project to make the fbdev vs fbcon locking slightly less >> busted). > > Saying it's stuck in the 90ies, and actively trying to prevent > Helge from taking over maintainership at the same time looks odd. The issues are in the design itself. It's impossible to model today's hardware and constraints with fbdev. It's impossible to change configuration in a reliable way (i.e., what DRM calls atomic). Fbdev mmaps plain video ram to userspace, which is one of the reasons why DRM's fbdev support is hard to improve. > I think Helge should at least get a chance to fix the issues. If the > state is still the same in a year or so it should be discussed again. You cannot fix that in 10yrs. > >> The other side is that being a maintainer is about collaboration, and >> this entire fbdev maintainership takeover has been a demonstration of >> anything but that. MAINTAINERS entry was a bit confusing since defacto >> drm has been maintaining it for years. > > It was marked as 'Orphaned'. Anyone is free to send a Patch/PR to take > over maintainership. If you have strong opinions about that code (And you > obviously have reading your mail, set it to 'maintained' and care about > it. Everything else is just wrong in my opinion. No, it's not wrong. Helge takes fbdev over the weekend, without noteworthy experience, and ignores advice from the people that have kept it alive over the past years. This isn't going to work in the long term. Best regards Thomas > > /Sven -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Ivo Totev [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-01-19 15:37 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-19 11:08 [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Helge Deller 2022-01-19 11:08 ` [PATCH 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)" Helge Deller 2022-01-19 11:08 ` [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling" Helge Deller 2022-01-19 11:22 ` Greg Kroah-Hartman 2022-01-19 11:22 ` Greg Kroah-Hartman 2022-01-19 11:28 ` Greg Kroah-Hartman 2022-01-19 11:28 ` Greg Kroah-Hartman 2022-01-19 11:47 ` Geert Uytterhoeven 2022-01-19 11:47 ` Geert Uytterhoeven 2022-01-19 12:28 ` Helge Deller 2022-01-19 12:28 ` Helge Deller 2022-01-19 14:01 ` Linus Torvalds 2022-01-19 14:01 ` Linus Torvalds 2022-01-19 14:11 ` Helge Deller 2022-01-19 14:11 ` Helge Deller 2022-01-19 14:34 ` Daniel Vetter 2022-01-19 14:34 ` Daniel Vetter 2022-01-19 15:05 ` Sven Schnelle 2022-01-19 15:05 ` Sven Schnelle 2022-01-19 15:37 ` Thomas Zimmermann [this message] 2022-01-19 15:37 ` Thomas Zimmermann 2022-01-19 16:55 ` Helge Deller 2022-01-19 16:55 ` Helge Deller 2022-01-19 15:42 ` Daniel Vetter 2022-01-19 15:42 ` Daniel Vetter 2022-01-19 15:54 ` Helge Deller 2022-01-19 15:54 ` Helge Deller 2022-01-19 16:13 ` Jani Nikula 2022-01-19 16:13 ` Jani Nikula 2022-01-19 16:31 ` Daniel Vetter 2022-01-19 16:31 ` Daniel Vetter 2022-01-19 15:18 ` Helge Deller 2022-01-19 15:18 ` Helge Deller 2022-01-19 13:01 ` Sven Schnelle 2022-01-19 13:01 ` Sven Schnelle 2022-01-19 13:35 ` Greg Kroah-Hartman 2022-01-19 13:35 ` Greg Kroah-Hartman 2022-01-20 14:30 ` Daniel Vetter 2022-01-20 14:30 ` Daniel Vetter 2022-01-20 17:01 ` Helge Deller 2022-01-21 7:20 ` Gerd Hoffmann 2022-01-21 7:20 ` Gerd Hoffmann 2022-01-24 11:10 ` Helge Deller 2022-01-24 11:10 ` Helge Deller 2022-01-24 11:28 ` Javier Martinez Canillas 2022-01-24 11:28 ` Javier Martinez Canillas 2022-01-24 11:33 ` Thomas Zimmermann 2022-01-24 11:33 ` Thomas Zimmermann 2022-01-24 11:50 ` Javier Martinez Canillas 2022-01-24 11:50 ` Javier Martinez Canillas 2022-01-24 15:29 ` Helge Deller 2022-01-24 15:29 ` Helge Deller 2022-01-24 15:45 ` Thomas Zimmermann 2022-01-24 15:45 ` Thomas Zimmermann 2022-01-24 15:50 ` Geert Uytterhoeven 2022-01-24 15:50 ` Geert Uytterhoeven 2022-01-24 15:58 ` Daniel Vetter 2022-01-24 15:58 ` Daniel Vetter 2022-01-24 15:50 ` Geert Uytterhoeven 2022-01-24 15:50 ` Geert Uytterhoeven 2022-01-24 16:11 ` Thomas Zimmermann 2022-01-24 16:11 ` Thomas Zimmermann 2022-01-19 12:45 ` [PATCH 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon Geert Uytterhoeven 2022-01-19 12:45 ` Geert Uytterhoeven 2022-01-19 13:02 ` Sven Schnelle 2022-01-19 13:02 ` Sven Schnelle
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ccec8635-6ec6-89c3-6738-65bd07a48508@suse.de \ --to=tzimmermann@suse.de \ --cc=cssk@net-c.es \ --cc=daniel.vetter@intel.com \ --cc=daniel@ffwll.ch \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=javierm@redhat.com \ --cc=kraxel@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=sam@ravnborg.org \ --cc=svens@stackframe.org \ --cc=tomi.valkeinen@ti.com \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.