Re: [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: "Richard Purdie" <rpurdie@rpsys.net>,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Anthony Wong" <anthony.wong@canonical.com>,
	linux-leds@vger.kernel.org,
	"Platform Driver" <platform-driver-x86@vger.kernel.org>,
	"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues
Date: Wed, 18 Jan 2017 21:06:00 +0200	[thread overview]
Message-ID: <CAHp75Vc3LnFGPjMt8uYQeqHWPqMM-rFzsdLA94C5bJQgq++K6w@mail.gmail.com> (raw)
In-Reply-To: <20170117071714.21594-1-kernel@kempniu.pl>

On Tue, Jan 17, 2017 at 9:17 AM, Michał Kępień <kernel@kempniu.pl> wrote:
> Fix coding style issues in dell-wmi-led which checkpatch complains about
> to make sure the module gets a clean start in the x86 platform driver
> subsystem.

> +       status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
>

You may remove extra line.

>         if (ACPI_FAILURE(status))
>                 return status;

> -       if (0 == on_eighths)
> +       if (on_eighths == 0)
>                 on_eighths = 1;
>         if (on_eighths > 255)
>                 on_eighths = 255;

> -       if (0 == off_eighths)
> +       if (off_eighths == 0)
>                 off_eighths = 1;
>         if (off_eighths > 255)
>                 off_eighths = 255;

Obviously they both are custom clamp{_t}().

-- 
With Best Regards,
Andy Shevchenko