Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

From: Alex Hung <alex.hung@canonical.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: "platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	"Anthony Wong" <anthony.wong@canonical.com>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Richard Purdie" <rpurdie@rpsys.net>,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Linux LED Subsystem" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86
Date: Wed, 15 Feb 2017 19:56:52 +0800	[thread overview]
Message-ID: <CAJ=jqua0W3fmoJFqqVgG2Eq=9E-4toXC0UyQH3TyxZiTtNsODw@mail.gmail.com> (raw)
In-Reply-To: <20170213112640.GA1188@ozzy.nask.waw.pl>

Hi,

I tested the patches with the following setup. Please note I tested
the microphone mute led by GUI, as the hotkey does not work on this
system.

1. Downloaded the below patches from patchwork

9518737 Awaiting Upstream [v2,1/6] dell-led: remove GUID check from
dell_micmute_led_set()
9518761 Awaiting Upstream [v2,2/6] ALSA: hda - use
dell_micmute_led_set() instead of dell_app_wmi_led_set()
9518741 Awaiting Upstream [v2,3/6] ALSA: hda - rename
dell_led_set_func to dell_micmute_led_set_func
9518725 Awaiting Upstream [v2,4/6] platform/x86: dell-laptop: import
dell_micmute_led_set() from drivers/leds/dell-led.c
9518727 Awaiting Upstream [v2,5/6] dell-led: remove code related to mic mute LED
9518735 Awaiting Upstream [v2,6/6] dell-led: move driver to
drivers/platform/x86/dell-wmi-led.c
9520053 Awaiting Upstream [v2,6+/6] platform/x86: dell-wmi-led: fix
coding style issues

2. Installed Ubuntu 16.10 (Linux kernel 4.8) on Dell Latitude 7180

  -> Microphone mute led works as expected

3. Applied downloaded patches to kernel 4.8 without any conflicts, but
kernel will not compile successfully.

4. Installed Ubuntu Zesty kernel (Linux kernel 4.9)

  -> Microphone mute led works as expected

5. Applied and compiled downloaded patches to kernel 4.9

  -> Microphone mute led does not work

6. Compiled and installed Linux kernel 4.10 rc8

  -> Microphone mute led does not work

7. Applied and compiled downloaded patches to kernel 4.10 rc8

  -> Microphone mute led does not work

On Mon, Feb 13, 2017 at 7:26 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> Hi everyone,
>
> It has been almost a month since I posted v2, so I hope sending a
> reminder is okay.
>
> Jaroslav, Takashi, could you please ack this patch series from the sound
> subsystem perspective?  Patches 2-4 touch it.
>
> Anthony, have you and your team perhaps had a chance to test this patch
> series on actual hardware?
>
> Thanks,
>
> --
> Best regards,
> Michał Kępień

-- 
Cheers,
Alex Hung
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel