From: Alex Hung <alex.hung@canonical.com> To: "Michał Kępień" <kernel@kempniu.pl> Cc: "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, "Anthony Wong" <anthony.wong@canonical.com>, "Takashi Iwai" <tiwai@suse.com>, "Andy Shevchenko" <andy.shevchenko@gmail.com>, "Richard Purdie" <rpurdie@rpsys.net>, "Jacek Anaszewski" <jacek.anaszewski@gmail.com>, "Pavel Machek" <pavel@ucw.cz>, "Pali Rohár" <pali.rohar@gmail.com>, "Darren Hart" <dvhart@infradead.org>, "Linux LED Subsystem" <linux-leds@vger.kernel.org> Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Date: Wed, 15 Feb 2017 22:31:39 +0800 [thread overview] Message-ID: <CAJ=jquaJazMKRsKdq=tpPNq=CBtFPcau6SW3nr738v-zTXfC4g@mail.gmail.com> (raw) In-Reply-To: <20170215135455.GA2014@ozzy.nask.waw.pl> On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień <kernel@kempniu.pl> wrote: > Alex, > >> I tested the patches with the following setup. Please note I tested >> the microphone mute led by GUI, as the hotkey does not work on this >> system. > > Thank you for taking the time to test this series, it is appreciated. I > would not expect the switching method (GUI/hotkey) to matter here, as > long as we can compare behavior of two kernel versions by consistently > using one of them. > >> >> 1. Downloaded the below patches from patchwork >> >> 9518737 Awaiting Upstream [v2,1/6] dell-led: remove GUID check from >> dell_micmute_led_set() >> 9518761 Awaiting Upstream [v2,2/6] ALSA: hda - use >> dell_micmute_led_set() instead of dell_app_wmi_led_set() >> 9518741 Awaiting Upstream [v2,3/6] ALSA: hda - rename >> dell_led_set_func to dell_micmute_led_set_func >> 9518725 Awaiting Upstream [v2,4/6] platform/x86: dell-laptop: import >> dell_micmute_led_set() from drivers/leds/dell-led.c >> 9518727 Awaiting Upstream [v2,5/6] dell-led: remove code related to mic mute LED >> 9518735 Awaiting Upstream [v2,6/6] dell-led: move driver to >> drivers/platform/x86/dell-wmi-led.c >> 9520053 Awaiting Upstream [v2,6+/6] platform/x86: dell-wmi-led: fix >> coding style issues >> >> 2. Installed Ubuntu 16.10 (Linux kernel 4.8) on Dell Latitude 7180 > > Just to be sure, I assume you meant 7280? This is a typo, and it should be 7480, which should be the same as 7280. > >> >> -> Microphone mute led works as expected >> >> 3. Applied downloaded patches to kernel 4.8 without any conflicts, but >> kernel will not compile successfully. > > I am confused. This patch series should apply cleanly to 4.9 and its > surroundings. Between 4.8 and 4.9, commit 4875a5f72180 ("ALSA: hda - > Fix a failure of micmute led when having multi adcs") happened. This > makes it impossible to apply this patch series cleanly on top of 4.8 > without reducing context to one line. > > Moreover, I applied this patch series (with reduced context) to 4.8 and > successfully compiled the kernel. Could you shed some light on where > exactly did your build crash? The error messages such as below, so it is probably not "fails to compile". Since 4.9 works better, I probably will focus on 4.9 & 4.10, though. find /home/alexhung/src/kernel/ubuntu-yakkety/debian/build/build-generic/ -name \*.ko | \ sed -e 's/.*\/\([^\/]*\)\.ko/\1/' | sort > /home/alexhung/src/kernel/ubuntu-yakkety/debian.master/abi/4.8.0-37.39/amd64/generic.modules II: Checking modules for generic... reading new modules...read 4821 modules. reading old modules... MISS: dell-led NEW : dell-wmi-led read 4821 modules : new(1) missing(1) EE: Missing modules (start begging for mercy) debian/rules.d/4-checks.mk:12: recipe for target 'module-check-generic' failed make: *** [module-check-generic] Error 1 > >> >> 4. Installed Ubuntu Zesty kernel (Linux kernel 4.9) >> >> -> Microphone mute led works as expected >> >> 5. Applied and compiled downloaded patches to kernel 4.9 >> >> -> Microphone mute led does not work > > Any chance of a git bisect? Certainly. Give me some time. > >> >> 6. Compiled and installed Linux kernel 4.10 rc8 >> >> -> Microphone mute led does not work > > This is even more confusing. Between 4.9, which you claim works fine, > and 4.10-rc8, which you claim does not work, I can see no changes to > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c. > Kernel configuration issue? I was surprised too, and I compiled it twice and installed on both Ubuntu 16.04 and 16.10. I would guess it is config too. On 4.9, it was using Ubuntu default. On 4.10rc8, I am pretty much using the instruction on https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is available @ http://paste.ubuntu.com/24001113/ > >> >> 7. Applied and compiled downloaded patches to kernel 4.10 rc8 >> >> -> Microphone mute led does not work > > No surprises here if it really does not work with 4.10-rc8. > > -- > Best regards, > Michał Kępień -- Cheers, Alex Hung _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Hung <alex.hung@canonical.com> To: "Michał Kępień" <kernel@kempniu.pl> Cc: "Jaroslav Kysela" <perex@perex.cz>, "Takashi Iwai" <tiwai@suse.com>, "Anthony Wong" <anthony.wong@canonical.com>, "Richard Purdie" <rpurdie@rpsys.net>, "Jacek Anaszewski" <jacek.anaszewski@gmail.com>, "Pavel Machek" <pavel@ucw.cz>, "Pali Rohár" <pali.rohar@gmail.com>, "Darren Hart" <dvhart@infradead.org>, "Andy Shevchenko" <andy.shevchenko@gmail.com>, "Linux LED Subsystem" <linux-leds@vger.kernel.org>, "platform-driver-x86@vger.kernel.org" <platform-driver-x86@vger.kernel.org>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Date: Wed, 15 Feb 2017 22:31:39 +0800 [thread overview] Message-ID: <CAJ=jquaJazMKRsKdq=tpPNq=CBtFPcau6SW3nr738v-zTXfC4g@mail.gmail.com> (raw) In-Reply-To: <20170215135455.GA2014@ozzy.nask.waw.pl> On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień <kernel@kempniu.pl> wrote: > Alex, > >> I tested the patches with the following setup. Please note I tested >> the microphone mute led by GUI, as the hotkey does not work on this >> system. > > Thank you for taking the time to test this series, it is appreciated. I > would not expect the switching method (GUI/hotkey) to matter here, as > long as we can compare behavior of two kernel versions by consistently > using one of them. > >> >> 1. Downloaded the below patches from patchwork >> >> 9518737 Awaiting Upstream [v2,1/6] dell-led: remove GUID check from >> dell_micmute_led_set() >> 9518761 Awaiting Upstream [v2,2/6] ALSA: hda - use >> dell_micmute_led_set() instead of dell_app_wmi_led_set() >> 9518741 Awaiting Upstream [v2,3/6] ALSA: hda - rename >> dell_led_set_func to dell_micmute_led_set_func >> 9518725 Awaiting Upstream [v2,4/6] platform/x86: dell-laptop: import >> dell_micmute_led_set() from drivers/leds/dell-led.c >> 9518727 Awaiting Upstream [v2,5/6] dell-led: remove code related to mic mute LED >> 9518735 Awaiting Upstream [v2,6/6] dell-led: move driver to >> drivers/platform/x86/dell-wmi-led.c >> 9520053 Awaiting Upstream [v2,6+/6] platform/x86: dell-wmi-led: fix >> coding style issues >> >> 2. Installed Ubuntu 16.10 (Linux kernel 4.8) on Dell Latitude 7180 > > Just to be sure, I assume you meant 7280? This is a typo, and it should be 7480, which should be the same as 7280. > >> >> -> Microphone mute led works as expected >> >> 3. Applied downloaded patches to kernel 4.8 without any conflicts, but >> kernel will not compile successfully. > > I am confused. This patch series should apply cleanly to 4.9 and its > surroundings. Between 4.8 and 4.9, commit 4875a5f72180 ("ALSA: hda - > Fix a failure of micmute led when having multi adcs") happened. This > makes it impossible to apply this patch series cleanly on top of 4.8 > without reducing context to one line. > > Moreover, I applied this patch series (with reduced context) to 4.8 and > successfully compiled the kernel. Could you shed some light on where > exactly did your build crash? The error messages such as below, so it is probably not "fails to compile". Since 4.9 works better, I probably will focus on 4.9 & 4.10, though. find /home/alexhung/src/kernel/ubuntu-yakkety/debian/build/build-generic/ -name \*.ko | \ sed -e 's/.*\/\([^\/]*\)\.ko/\1/' | sort > /home/alexhung/src/kernel/ubuntu-yakkety/debian.master/abi/4.8.0-37.39/amd64/generic.modules II: Checking modules for generic... reading new modules...read 4821 modules. reading old modules... MISS: dell-led NEW : dell-wmi-led read 4821 modules : new(1) missing(1) EE: Missing modules (start begging for mercy) debian/rules.d/4-checks.mk:12: recipe for target 'module-check-generic' failed make: *** [module-check-generic] Error 1 > >> >> 4. Installed Ubuntu Zesty kernel (Linux kernel 4.9) >> >> -> Microphone mute led works as expected >> >> 5. Applied and compiled downloaded patches to kernel 4.9 >> >> -> Microphone mute led does not work > > Any chance of a git bisect? Certainly. Give me some time. > >> >> 6. Compiled and installed Linux kernel 4.10 rc8 >> >> -> Microphone mute led does not work > > This is even more confusing. Between 4.9, which you claim works fine, > and 4.10-rc8, which you claim does not work, I can see no changes to > either drivers/leds/dell-led.c or sound/pci/hda/dell_wmi_helper.c. > Kernel configuration issue? I was surprised too, and I compiled it twice and installed on both Ubuntu 16.04 and 16.10. I would guess it is config too. On 4.9, it was using Ubuntu default. On 4.10rc8, I am pretty much using the instruction on https://wiki.ubuntu.com/KernelTeam/GitKernelBuild. The .config is available @ http://paste.ubuntu.com/24001113/ > >> >> 7. Applied and compiled downloaded patches to kernel 4.10 rc8 >> >> -> Microphone mute led does not work > > No surprises here if it really does not work with 4.10-rc8. > > -- > Best regards, > Michał Kępień -- Cheers, Alex Hung
next prev parent reply other threads:[~2017-02-15 14:31 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-16 13:21 [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Michał Kępień 2017-01-16 13:21 ` [PATCH v2 1/6] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień 2017-01-16 13:22 ` [PATCH v2 2/6] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień 2017-01-16 13:22 ` [PATCH v2 3/6] ALSA: hda - rename dell_led_set_func to dell_micmute_led_set_func Michał Kępień 2017-01-17 11:12 ` Pali Rohár 2017-01-17 21:20 ` Jacek Anaszewski 2017-01-16 13:22 ` [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień 2017-01-17 11:23 ` Pali Rohár 2017-01-18 19:12 ` Andy Shevchenko 2017-01-16 13:22 ` [PATCH v2 5/6] dell-led: remove code related to mic mute LED Michał Kępień 2017-01-17 11:24 ` Pali Rohár 2017-01-16 13:22 ` [PATCH v2 6/6] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień 2017-01-16 20:49 ` Jacek Anaszewski 2017-01-17 11:08 ` Pavel Machek 2017-01-17 11:28 ` Pali Rohár 2017-01-18 19:08 ` Andy Shevchenko 2017-01-17 7:17 ` [PATCH v2 6+/6] platform/x86: dell-wmi-led: fix coding style issues Michał Kępień 2017-01-17 8:21 ` Joe Perches 2017-01-17 9:19 ` Michał Kępień 2017-01-17 21:20 ` Jacek Anaszewski 2017-01-17 11:08 ` Pavel Machek 2017-01-18 19:06 ` Andy Shevchenko 2017-01-17 21:20 ` [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Jacek Anaszewski 2017-02-13 11:26 ` Michał Kępień 2017-02-15 11:56 ` Alex Hung 2017-02-15 11:56 ` Alex Hung 2017-02-15 13:54 ` Michał Kępień 2017-02-15 14:31 ` Alex Hung [this message] 2017-02-15 14:31 ` Alex Hung 2017-02-15 15:12 ` Pali Rohár 2017-02-16 9:33 ` Michał Kępień 2017-02-16 9:33 ` Michał Kępień 2017-02-16 9:27 ` Michał Kępień 2017-02-16 10:35 ` Alex Hung 2017-02-16 11:32 ` Michał Kępień 2017-02-16 11:38 ` Alex Hung 2017-02-16 11:41 ` Andy Shevchenko 2017-02-16 12:01 ` Michał Kępień 2017-02-16 13:11 ` Andy Shevchenko 2017-02-16 13:11 ` Andy Shevchenko 2017-02-16 22:11 ` Jacek Anaszewski 2017-02-15 20:28 ` Takashi Iwai 2017-02-15 20:28 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJ=jquaJazMKRsKdq=tpPNq=CBtFPcau6SW3nr738v-zTXfC4g@mail.gmail.com' \ --to=alex.hung@canonical.com \ --cc=alsa-devel@alsa-project.org \ --cc=andy.shevchenko@gmail.com \ --cc=anthony.wong@canonical.com \ --cc=dvhart@infradead.org \ --cc=jacek.anaszewski@gmail.com \ --cc=kernel@kempniu.pl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=pali.rohar@gmail.com \ --cc=pavel@ucw.cz \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rpurdie@rpsys.net \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.