Re: [OE-core][PATCH] README.skeleton: add readme to meta-skeleton layer

Re: [OE-core][PATCH] README.skeleton: add readme to meta-skeleton layer

[Scott Weaver]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

I didn't see that this patch was picked up (but maybe I'm looking in the
wrong place) and I received the email from Stephen that the issue should be
moved to 3.4 M2.
Did I send this to the wrong mailing list or is it not the solution you're
looking for?

I elaborated in bugzilla on why I think just adding the readme file to
close this issue is enough but you may not have seen that comment or agree.
:)
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612

Scott

On Tue, Jun 8, 2021 at 9:46 PM Scott Weaver via lists.openembedded.org
<weaverjs=gmail.com@lists.openembedded.org> wrote:

> Added to satisfy the yocto-check-layer tool readme file test.
>
> [YOCTO #13612]
>
> Signed-off-by: Scott Weaver <weaverjs@gmail.com>
> ---
>  meta-skeleton/README.skeleton | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 meta-skeleton/README.skeleton
>
> diff --git a/meta-skeleton/README.skeleton b/meta-skeleton/README.skeleton
> new file mode 100644
> index 0000000000..25468dc87a
> --- /dev/null
> +++ b/meta-skeleton/README.skeleton
> @@ -0,0 +1,7 @@
> +meta-skeleton
> +=============
> +
> +The meta-skeleton layer contains example recipes and configuration files.
> +
> +This layer is not intended to demonstrate a Yocto Project Compatible
> software layer.
> +Disable the signature check when testing this layer using the
> yocto-check-layer tool.
> --
> 2.25.1
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2055 bytes --]

Re: [OE-core][PATCH] README.skeleton: add readme to meta-skeleton layer

[Richard Purdie]

On Tue, 2021-06-22 at 17:50 -0400, Scott Weaver wrote:
> I didn't see that this patch was picked up (but maybe I'm looking in the wrong place) and I received the email
> from Stephen that the issue should be moved to 3.4 M2.
> Did I send this to the wrong mailing list or is it not the solution you're looking for?
> 
> I elaborated in bugzilla on why I think just adding the readme file to close this issue is enough but you may
> not have seen that comment or agree. :)
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612
> 
> Scott 
> 
> On Tue, Jun 8, 2021 at 9:46 PM Scott Weaver via lists.openembedded.org <
> weaverjs=gmail.com@lists.openembedded.org> wrote:
> > Added to satisfy the yocto-check-layer tool readme file test.
> > 
> > [YOCTO #13612]
> > 
> > Signed-off-by: Scott Weaver <weaverjs@gmail.com>
> > ---
> >  meta-skeleton/README.skeleton | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >  create mode 100644 meta-skeleton/README.skeleton
> > 
> > diff --git a/meta-skeleton/README.skeleton b/meta-skeleton/README.skeleton
> > new file mode 100644
> > index 0000000000..25468dc87a
> > --- /dev/null
> > +++ b/meta-skeleton/README.skeleton
> > @@ -0,0 +1,7 @@
> > +meta-skeleton
> > +=============
> > +
> > +The meta-skeleton layer contains example recipes and configuration files.
> > +
> > +This layer is not intended to demonstrate a Yocto Project Compatible software layer.
> > +Disable the signature check when testing this layer using the yocto-check-layer tool.

Sorry, it takes time to page in the context for this.

I think we should fix meta-skeleton to work with yocto-check-layer. I think this
may be relatively simple, we can change the busybox bbappend that is causing the
signature failure to be 'distro' specific, e.g. something like:

-SRC_URI += " \
+SRC_URI_append_mydistro = " \

and then an example is still there but it doesn't break the checks (and isn't
enabled by default). We could add a comment about it being enabled by a custom
distro called 'mydistro'.

That change, along with your README addition should allow the layer tests to pass.

Cheers,

Richard

Re: [OE-core][PATCH] README.skeleton: add readme to meta-skeleton layer

[Scott Weaver]

[-- Attachment #1: Type: text/plain, Size: 2698 bytes --]

Thanks, Richard.
The issue noted that the distro specific update wasn't working but it's
because they tried SRC_URI_append_poky (which correctly failed) so I didn't
even think to try anything else.
My mistake. I'll make the changes you suggested.

Thanks again for your time!
Scott


On Wed, Jun 23, 2021 at 5:12 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2021-06-22 at 17:50 -0400, Scott Weaver wrote:
> > I didn't see that this patch was picked up (but maybe I'm looking in the
> wrong place) and I received the email
> > from Stephen that the issue should be moved to 3.4 M2.
> > Did I send this to the wrong mailing list or is it not the solution
> you're looking for?
> >
> > I elaborated in bugzilla on why I think just adding the readme file to
> close this issue is enough but you may
> > not have seen that comment or agree. :)
> > https://bugzilla.yoctoproject.org/show_bug.cgi?id=13612
> >
> > Scott
> >
> > On Tue, Jun 8, 2021 at 9:46 PM Scott Weaver via lists.openembedded.org <
> > weaverjs=gmail.com@lists.openembedded.org> wrote:
> > > Added to satisfy the yocto-check-layer tool readme file test.
> > >
> > > [YOCTO #13612]
> > >
> > > Signed-off-by: Scott Weaver <weaverjs@gmail.com>
> > > ---
> > >  meta-skeleton/README.skeleton | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >  create mode 100644 meta-skeleton/README.skeleton
> > >
> > > diff --git a/meta-skeleton/README.skeleton
> b/meta-skeleton/README.skeleton
> > > new file mode 100644
> > > index 0000000000..25468dc87a
> > > --- /dev/null
> > > +++ b/meta-skeleton/README.skeleton
> > > @@ -0,0 +1,7 @@
> > > +meta-skeleton
> > > +=============
> > > +
> > > +The meta-skeleton layer contains example recipes and configuration
> files.
> > > +
> > > +This layer is not intended to demonstrate a Yocto Project Compatible
> software layer.
> > > +Disable the signature check when testing this layer using the
> yocto-check-layer tool.
>
> Sorry, it takes time to page in the context for this.
>
> I think we should fix meta-skeleton to work with yocto-check-layer. I
> think this
> may be relatively simple, we can change the busybox bbappend that is
> causing the
> signature failure to be 'distro' specific, e.g. something like:
>
> -SRC_URI += " \
> +SRC_URI_append_mydistro = " \
>
> and then an example is still there but it doesn't break the checks (and
> isn't
> enabled by default). We could add a comment about it being enabled by a
> custom
> distro called 'mydistro'.
>
> That change, along with your README addition should allow the layer tests
> to pass.
>
> Cheers,
>
> Richard
>
>
>

[-- Attachment #2: Type: text/html, Size: 3735 bytes --]

[OE-core][PATCH] README.skeleton: add readme to meta-skeleton layer

[Scott Weaver]

Added to satisfy the yocto-check-layer tool readme file test.

[YOCTO #13612]

Signed-off-by: Scott Weaver <weaverjs@gmail.com>
---
 meta-skeleton/README.skeleton | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 meta-skeleton/README.skeleton

diff --git a/meta-skeleton/README.skeleton b/meta-skeleton/README.skeleton
new file mode 100644
index 0000000000..25468dc87a
--- /dev/null
+++ b/meta-skeleton/README.skeleton
@@ -0,0 +1,7 @@
+meta-skeleton
+=============
+
+The meta-skeleton layer contains example recipes and configuration files.
+
+This layer is not intended to demonstrate a Yocto Project Compatible software layer.
+Disable the signature check when testing this layer using the yocto-check-layer tool.
-- 
2.25.1