From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Hal Feng <hal.feng@starfivetech.com>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Conor Dooley <conor@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/14] dt-bindings: clock: Add StarFive JH7110 always-on clock and reset generator Date: Mon, 21 Nov 2022 12:38:17 +0100 [thread overview] Message-ID: <CAJM55Z9ouj=jD2Otx3fK4W1wgnPjecUgFuKksw5CmU6SraM_Nw@mail.gmail.com> (raw) In-Reply-To: <8153973d-e8ad-e47a-3808-bbcdbfd169a5@linaro.org> On Mon, 21 Nov 2022 at 09:49, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 18/11/2022 02:06, Hal Feng wrote: > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > Add bindings for the always-on clock and reset generator (AONCRG) on the > > JH7110 RISC-V SoC by StarFive Ltd. > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > --- > > .../clock/starfive,jh7110-aoncrg.yaml | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > new file mode 100644 > > index 000000000000..afbb205e294f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/starfive,jh7110-aoncrg.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive JH7110 Always-On Clock and Reset Generator > > + > > +maintainers: > > + - Emil Renner Berthing <kernel@esmil.dk> > > + > > +properties: > > + compatible: > > + const: starfive,jh7110-aoncrg > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Main Oscillator > > + - description: RTC clock > > Real Time Clock clock? :) I don't think the input to clock controller is > the output of RTC... The description is bad, but even the documentation calls it "clk_rtc" even though it's really an optional input from a 32k oscillator. > Best regards, > Krzysztof > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Hal Feng <hal.feng@starfivetech.com>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Conor Dooley <conor@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 10/14] dt-bindings: clock: Add StarFive JH7110 always-on clock and reset generator Date: Mon, 21 Nov 2022 12:38:17 +0100 [thread overview] Message-ID: <CAJM55Z9ouj=jD2Otx3fK4W1wgnPjecUgFuKksw5CmU6SraM_Nw@mail.gmail.com> (raw) In-Reply-To: <8153973d-e8ad-e47a-3808-bbcdbfd169a5@linaro.org> On Mon, 21 Nov 2022 at 09:49, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 18/11/2022 02:06, Hal Feng wrote: > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > Add bindings for the always-on clock and reset generator (AONCRG) on the > > JH7110 RISC-V SoC by StarFive Ltd. > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > --- > > .../clock/starfive,jh7110-aoncrg.yaml | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > new file mode 100644 > > index 000000000000..afbb205e294f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/starfive,jh7110-aoncrg.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive JH7110 Always-On Clock and Reset Generator > > + > > +maintainers: > > + - Emil Renner Berthing <kernel@esmil.dk> > > + > > +properties: > > + compatible: > > + const: starfive,jh7110-aoncrg > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Main Oscillator > > + - description: RTC clock > > Real Time Clock clock? :) I don't think the input to clock controller is > the output of RTC... The description is bad, but even the documentation calls it "clk_rtc" even though it's really an optional input from a 32k oscillator. > Best regards, > Krzysztof >
next prev parent reply other threads:[~2022-11-21 11:38 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-18 1:06 [PATCH v2 00/14] Basic clock and reset support for StarFive JH7110 RISC-V SoC Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 01/14] clk: starfive: Factor out common JH7100 and JH7110 code Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:22 ` Emil Renner Berthing 2022-11-18 16:22 ` Emil Renner Berthing 2022-11-21 6:25 ` Hal Feng 2022-11-21 6:25 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 02/14] clk: starfive: Rename "jh7100" to "jh71x0" for the common code Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:26 ` Emil Renner Berthing 2022-11-18 16:26 ` Emil Renner Berthing 2022-11-21 7:16 ` Hal Feng 2022-11-21 7:16 ` Hal Feng 2022-11-21 11:32 ` Emil Renner Berthing 2022-11-21 11:32 ` Emil Renner Berthing 2022-11-21 13:13 ` Hal Feng 2022-11-21 13:13 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 03/14] reset: Create subdirectory for StarFive drivers Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:29 ` Emil Renner Berthing 2022-11-18 16:29 ` Emil Renner Berthing 2022-11-18 1:06 ` [PATCH v2 04/14] reset: starfive: Factor out common JH71X0 reset code Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:39 ` Emil Renner Berthing 2022-11-18 16:39 ` Emil Renner Berthing 2022-11-21 9:23 ` Hal Feng 2022-11-21 9:23 ` Hal Feng 2022-11-21 11:26 ` Emil Renner Berthing 2022-11-21 11:26 ` Emil Renner Berthing 2022-11-18 1:06 ` [PATCH v2 05/14] reset: starfive: Rename "jh7100" to "jh71x0" for the common code Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 06/14] reset: starfive: jh71x0: Use 32bit I/O on 32bit registers Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 07/14] dt-bindings: clock: Add StarFive JH7110 system and always-on clock definitions Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-21 8:45 ` Krzysztof Kozlowski 2022-11-21 8:45 ` Krzysztof Kozlowski 2022-11-22 1:02 ` Hal Feng 2022-11-22 1:02 ` Hal Feng 2022-11-22 7:41 ` Krzysztof Kozlowski 2022-11-22 7:41 ` Krzysztof Kozlowski 2022-11-22 8:04 ` Hal Feng 2022-11-22 8:04 ` Hal Feng 2022-11-23 9:34 ` Krzysztof Kozlowski 2022-11-23 9:34 ` Krzysztof Kozlowski 2022-11-18 1:06 ` [PATCH v2 08/14] dt-bindings: reset: Add StarFive JH7110 system and always-on reset definitions Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:47 ` Emil Renner Berthing 2022-11-18 16:47 ` Emil Renner Berthing 2022-11-22 1:20 ` Hal Feng 2022-11-22 1:20 ` Hal Feng 2022-11-21 8:45 ` Krzysztof Kozlowski 2022-11-21 8:45 ` Krzysztof Kozlowski 2022-11-21 8:50 ` Krzysztof Kozlowski 2022-11-21 8:50 ` Krzysztof Kozlowski 2022-11-22 1:26 ` Hal Feng 2022-11-22 1:26 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 09/14] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 16:50 ` Emil Renner Berthing 2022-11-18 16:50 ` Emil Renner Berthing 2022-11-21 8:47 ` Krzysztof Kozlowski 2022-11-21 8:47 ` Krzysztof Kozlowski 2022-11-22 1:45 ` Hal Feng 2022-11-22 1:45 ` Hal Feng 2022-11-21 8:47 ` Krzysztof Kozlowski 2022-11-21 8:47 ` Krzysztof Kozlowski 2022-11-25 6:41 ` Hal Feng 2022-11-25 6:41 ` Hal Feng 2022-11-30 9:47 ` Hal Feng 2022-11-30 9:47 ` Hal Feng 2022-11-30 11:48 ` Krzysztof Kozlowski 2022-11-30 11:48 ` Krzysztof Kozlowski 2022-11-30 15:12 ` Hal Feng 2022-11-30 15:12 ` Hal Feng 2022-11-30 15:19 ` Krzysztof Kozlowski 2022-11-30 15:19 ` Krzysztof Kozlowski 2022-11-30 18:05 ` Hal Feng 2022-11-30 18:05 ` Hal Feng 2022-12-01 10:21 ` Krzysztof Kozlowski 2022-12-01 10:21 ` Krzysztof Kozlowski 2022-12-02 2:06 ` Hal Feng 2022-12-02 2:06 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 10/14] dt-bindings: clock: Add StarFive JH7110 always-on " Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-21 8:49 ` Krzysztof Kozlowski 2022-11-21 8:49 ` Krzysztof Kozlowski 2022-11-21 11:38 ` Emil Renner Berthing [this message] 2022-11-21 11:38 ` Emil Renner Berthing 2022-11-21 13:24 ` Krzysztof Kozlowski 2022-11-21 13:24 ` Krzysztof Kozlowski 2022-11-18 1:06 ` [PATCH v2 11/14] clk: starfive: Add StarFive JH7110 system clock driver Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 17:03 ` Emil Renner Berthing 2022-11-18 17:03 ` Emil Renner Berthing 2022-11-25 2:33 ` Hal Feng 2022-11-25 2:33 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 12/14] clk: starfive: Add StarFive JH7110 always-on " Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 13/14] reset: starfive: Add StarFive JH7110 reset driver Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 17:14 ` Emil Renner Berthing 2022-11-18 17:14 ` Emil Renner Berthing 2022-11-22 5:55 ` Hal Feng 2022-11-22 5:55 ` Hal Feng 2022-11-18 1:06 ` [PATCH v2 14/14] clk: starfive: jh71x0: Don't register aux devices if JH7110 reset is disabled Hal Feng 2022-11-18 1:06 ` Hal Feng 2022-11-18 17:18 ` Emil Renner Berthing 2022-11-18 17:18 ` Emil Renner Berthing 2022-11-22 6:12 ` Hal Feng 2022-11-22 6:12 ` Hal Feng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJM55Z9ouj=jD2Otx3fK4W1wgnPjecUgFuKksw5CmU6SraM_Nw@mail.gmail.com' \ --to=emil.renner.berthing@canonical.com \ --cc=conor@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=hal.feng@starfivetech.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=mturquette@baylibre.com \ --cc=p.zabel@pengutronix.de \ --cc=palmer@dabbelt.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.