From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Jisheng Zhang <jszhang@kernel.org>, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Emil Renner Berthing <kernel@esmil.dk>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>, Aurelien Jarno <aurelien@aurel32.net> Subject: Re: [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Date: Fri, 19 Apr 2024 15:11:47 -0700 [thread overview] Message-ID: <CAJM55Z_BemQoQ8Qrcz_vYOJ3n+-3DKn_iu==58euv9HWa99dEw@mail.gmail.com> (raw) In-Reply-To: <ZgrIXHNRTB_NeDeF@xhacker> Jisheng Zhang wrote: > On Mon, Apr 01, 2024 at 03:28:33PM +0200, Heinrich Schuchardt wrote: > > On 3/29/24 03:31, Jisheng Zhang wrote: > > > On Thu, Mar 28, 2024 at 10:28:28PM +0100, Heinrich Schuchardt wrote: > > > > On 2/6/24 20:13, Conor Dooley wrote: > > > > > On Wed, Jan 31, 2024 at 09:26:00PM +0800, Jisheng Zhang wrote: > > > > > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > > > > > The board features: > > > > > > > > > > > > - JH7110 SoC > > > > > > - 1/2/4/8 GiB LPDDR4 DRAM > > > > > > - AXP15060 PMIC > > > > > > - 40 pin GPIO header > > > > > > - 3x USB 3.0 host port > > > > > > - 1x USB 2.0 host port > > > > > > - 1x M.2 E-Key > > > > > > - 1x eMMC slot > > > > > > - 1x MicroSD slot > > > > > > - 1x QSPI Flash > > > > > > - 1x 1Gbps Ethernet port > > > > > > - 1x HDMI port > > > > > > - 1x 2-lane DSI and 1x 4-lane DSI > > > > > > - 1x 2-lane CSI > > > > > > > > > > > > Add the devicetree file describing the currently supported features, > > > > > > namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > > > > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> ... > > > > > > + > > > > > > +&mmc1 { > > > > > > + disable-wp; > > > > > > > > Due to which difference is 'disable-wp' necessary for the Mars board and not > > > > necessary for the VisionFive 2 board? > > > > > > Mars doesn't have wp pin, but dunno vf2 case since I don't have a VF2 > > > board ;) The schematic is available here: https://doc-en.rvspace.org/VisionFive2/PDF/RV002_V1.3B_20230208.PDF > > > > If the Milk-V Mars does not have a WP GPIO, we should be able to drop this > > property. The VisionFive 2 does not need it either. > > Nope, dropping this property would result in RO sdcard on vf2. > > > > > > > > > > > > + cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>; > > > > > > > > On my VisionFive 2 1.2B, and 1.3A boards GPIO 41 reflects if an SD-card is > > > > inserted (as shown in U-Boot by gpio status -a). So shouldn't this value be > > > > moved to the common include "jh7110-visionfive2-mars-common.dtsi" and > > > > broken-cd removed from the VisionFive2 board? > > > > > > I tested the CD pin and can confirm it works on Mars, but I dunno whether > > > this works on VF2 since I have no VF2 board. > > > Could you please check whether it works or not on VF2? > > > > As mentioned in my prior mail the card detect GPIO is working on the > > VisionFive 2. StarFive acknowledged my U-Boot patch: > > > > https://lore.kernel.org/u-boot/SHXPR01MB086314C47C281B3DDDF7BAE9E63AA@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn/ > > Thanks for confirmation. Actually comparing the schematic for the VF2 above and the Mars board[1] I don't see any differences in how the SD-card is connected, so if I'm right the mmc1 node could be fully defined in the jh7110-common.dtsi. [1]: https://github.com/milkv-mars/mars-files/blob/main/Mars_hardware_schematics/Mars_V1.11_20230821.pdf /Emil > > > > > Best regards > > > > Heinrich > > > > > > > > > > > > > https://doc-en.rvspace.org/VisionFive2/PDF/SCH_RV002_V1.2A_20221216.pdf > > > > has a line > > > > > > > > GPIO41 | SD_SDIO0_CD_GPIO41 | Micro SD:J10 > > > > > > > > Best regards > > > > > > > > Heinrich > > > > > > > > > > +}; > > > > > > -- > > > > > > 2.43.0 > > > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Emil Renner Berthing <emil.renner.berthing@canonical.com> To: Jisheng Zhang <jszhang@kernel.org>, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Emil Renner Berthing <kernel@esmil.dk>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Conor Dooley <conor@kernel.org>, Aurelien Jarno <aurelien@aurel32.net> Subject: Re: [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Date: Fri, 19 Apr 2024 15:11:47 -0700 [thread overview] Message-ID: <CAJM55Z_BemQoQ8Qrcz_vYOJ3n+-3DKn_iu==58euv9HWa99dEw@mail.gmail.com> (raw) In-Reply-To: <ZgrIXHNRTB_NeDeF@xhacker> Jisheng Zhang wrote: > On Mon, Apr 01, 2024 at 03:28:33PM +0200, Heinrich Schuchardt wrote: > > On 3/29/24 03:31, Jisheng Zhang wrote: > > > On Thu, Mar 28, 2024 at 10:28:28PM +0100, Heinrich Schuchardt wrote: > > > > On 2/6/24 20:13, Conor Dooley wrote: > > > > > On Wed, Jan 31, 2024 at 09:26:00PM +0800, Jisheng Zhang wrote: > > > > > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > > > > > The board features: > > > > > > > > > > > > - JH7110 SoC > > > > > > - 1/2/4/8 GiB LPDDR4 DRAM > > > > > > - AXP15060 PMIC > > > > > > - 40 pin GPIO header > > > > > > - 3x USB 3.0 host port > > > > > > - 1x USB 2.0 host port > > > > > > - 1x M.2 E-Key > > > > > > - 1x eMMC slot > > > > > > - 1x MicroSD slot > > > > > > - 1x QSPI Flash > > > > > > - 1x 1Gbps Ethernet port > > > > > > - 1x HDMI port > > > > > > - 1x 2-lane DSI and 1x 4-lane DSI > > > > > > - 1x 2-lane CSI > > > > > > > > > > > > Add the devicetree file describing the currently supported features, > > > > > > namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > > > > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> ... > > > > > > + > > > > > > +&mmc1 { > > > > > > + disable-wp; > > > > > > > > Due to which difference is 'disable-wp' necessary for the Mars board and not > > > > necessary for the VisionFive 2 board? > > > > > > Mars doesn't have wp pin, but dunno vf2 case since I don't have a VF2 > > > board ;) The schematic is available here: https://doc-en.rvspace.org/VisionFive2/PDF/RV002_V1.3B_20230208.PDF > > > > If the Milk-V Mars does not have a WP GPIO, we should be able to drop this > > property. The VisionFive 2 does not need it either. > > Nope, dropping this property would result in RO sdcard on vf2. > > > > > > > > > > > > + cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>; > > > > > > > > On my VisionFive 2 1.2B, and 1.3A boards GPIO 41 reflects if an SD-card is > > > > inserted (as shown in U-Boot by gpio status -a). So shouldn't this value be > > > > moved to the common include "jh7110-visionfive2-mars-common.dtsi" and > > > > broken-cd removed from the VisionFive2 board? > > > > > > I tested the CD pin and can confirm it works on Mars, but I dunno whether > > > this works on VF2 since I have no VF2 board. > > > Could you please check whether it works or not on VF2? > > > > As mentioned in my prior mail the card detect GPIO is working on the > > VisionFive 2. StarFive acknowledged my U-Boot patch: > > > > https://lore.kernel.org/u-boot/SHXPR01MB086314C47C281B3DDDF7BAE9E63AA@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn/ > > Thanks for confirmation. Actually comparing the schematic for the VF2 above and the Mars board[1] I don't see any differences in how the SD-card is connected, so if I'm right the mmc1 node could be fully defined in the jh7110-common.dtsi. [1]: https://github.com/milkv-mars/mars-files/blob/main/Mars_hardware_schematics/Mars_V1.11_20230821.pdf /Emil > > > > > Best regards > > > > Heinrich > > > > > > > > > > > > > https://doc-en.rvspace.org/VisionFive2/PDF/SCH_RV002_V1.2A_20221216.pdf > > > > has a line > > > > > > > > GPIO41 | SD_SDIO0_CD_GPIO41 | Micro SD:J10 > > > > > > > > Best regards > > > > > > > > Heinrich > > > > > > > > > > +}; > > > > > > -- > > > > > > 2.43.0 > > > > > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-04-19 22:11 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-31 13:25 [PATCH v3 0/6] riscv: dts: starfive: add Milkv Mars board device tree Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-01-31 13:25 ` [PATCH v3 1/6] riscv: dts: starfive: add 'cpus' label to jh7110 and jh7100 soc dtsi Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:04 ` Emil Renner Berthing 2024-04-19 22:04 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 2/6] dt-bindings: riscv: starfive: add Milkv Mars board Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:04 ` Emil Renner Berthing 2024-04-19 22:04 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 3/6] riscv: dts: starfive: visionfive 2: update sound and codec dt node name Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:05 ` Emil Renner Berthing 2024-04-19 22:05 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 4/6] riscv: dts: starfive: visionfive 2: use cpus label for timebase freq Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:05 ` Emil Renner Berthing 2024-04-19 22:05 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 5/6] riscv: dts: starfive: introduce a common board dtsi for jh7110 based boards Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-01-31 13:26 ` [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Jisheng Zhang 2024-01-31 13:26 ` Jisheng Zhang 2024-02-06 19:13 ` Conor Dooley 2024-02-06 19:13 ` Conor Dooley 2024-03-27 18:06 ` Conor Dooley 2024-03-27 18:06 ` Conor Dooley 2024-03-28 10:08 ` Jisheng Zhang 2024-03-28 10:08 ` Jisheng Zhang 2024-03-28 12:45 ` Emil Renner Berthing 2024-03-28 12:45 ` Emil Renner Berthing 2024-03-29 2:32 ` Jisheng Zhang 2024-03-29 2:32 ` Jisheng Zhang 2024-03-28 21:28 ` Heinrich Schuchardt 2024-03-28 21:28 ` Heinrich Schuchardt 2024-03-29 2:31 ` Jisheng Zhang 2024-03-29 2:31 ` Jisheng Zhang 2024-04-01 13:28 ` Heinrich Schuchardt 2024-04-01 13:28 ` Heinrich Schuchardt 2024-04-01 14:44 ` Jisheng Zhang 2024-04-01 14:44 ` Jisheng Zhang 2024-04-19 22:11 ` Emil Renner Berthing [this message] 2024-04-19 22:11 ` Emil Renner Berthing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJM55Z_BemQoQ8Qrcz_vYOJ3n+-3DKn_iu==58euv9HWa99dEw@mail.gmail.com' \ --to=emil.renner.berthing@canonical.com \ --cc=aou@eecs.berkeley.edu \ --cc=aurelien@aurel32.net \ --cc=conor@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=heinrich.schuchardt@canonical.com \ --cc=jszhang@kernel.org \ --cc=kernel@esmil.dk \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.