From: Jisheng Zhang <jszhang@kernel.org> To: Conor Dooley <conor@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Emil Renner Berthing <kernel@esmil.dk>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Date: Thu, 28 Mar 2024 18:08:58 +0800 [thread overview] Message-ID: <ZgVBurohYRDzFjgb@xhacker> (raw) In-Reply-To: <20240327-cotton-fang-37f6d8fde0e5@spud> On Wed, Mar 27, 2024 at 06:06:58PM +0000, Conor Dooley wrote: > Yo, > > On Tue, Feb 06, 2024 at 07:13:48PM +0000, Conor Dooley wrote: > > On Wed, Jan 31, 2024 at 09:26:00PM +0800, Jisheng Zhang wrote: > > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > > The board features: > > > > > > - JH7110 SoC > > > - 1/2/4/8 GiB LPDDR4 DRAM > > > - AXP15060 PMIC > > > - 40 pin GPIO header > > > - 3x USB 3.0 host port > > > - 1x USB 2.0 host port > > > - 1x M.2 E-Key > > > - 1x eMMC slot > > > - 1x MicroSD slot > > > - 1x QSPI Flash > > > - 1x 1Gbps Ethernet port > > > - 1x HDMI port > > > - 1x 2-lane DSI and 1x 4-lane DSI > > > - 1x 2-lane CSI > > > > > > Add the devicetree file describing the currently supported features, > > > namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > > Got a dtbs_check issue in the patchwork CI: > > > > +arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dtb: gmac1-rgmii-rxin-clock: 'clock-frequency' is a required property > > + from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# > > +arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dtb: gmac1-rmii-refin-clock: 'clock-frequency' is a required property > > + from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# > > > > Can you fix that please? Also, I applied some patches the other day that > > seem to conflict quite a bit with the common board dts patch. Would you > > please do a rebase on top of that please? > > Been going through stuff on my todo list now that the merge window is > closed. Could you please resend this with the rebase done? Thanks for the reminding, I will rebase on 6.9-rc1 then send out the patches. > > Thanks, > Conor.
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org> To: Conor Dooley <conor@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Emil Renner Berthing <kernel@esmil.dk>, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Date: Thu, 28 Mar 2024 18:08:58 +0800 [thread overview] Message-ID: <ZgVBurohYRDzFjgb@xhacker> (raw) In-Reply-To: <20240327-cotton-fang-37f6d8fde0e5@spud> On Wed, Mar 27, 2024 at 06:06:58PM +0000, Conor Dooley wrote: > Yo, > > On Tue, Feb 06, 2024 at 07:13:48PM +0000, Conor Dooley wrote: > > On Wed, Jan 31, 2024 at 09:26:00PM +0800, Jisheng Zhang wrote: > > > The Milkv Mars is a development board based on the Starfive JH7110 SoC. > > > The board features: > > > > > > - JH7110 SoC > > > - 1/2/4/8 GiB LPDDR4 DRAM > > > - AXP15060 PMIC > > > - 40 pin GPIO header > > > - 3x USB 3.0 host port > > > - 1x USB 2.0 host port > > > - 1x M.2 E-Key > > > - 1x eMMC slot > > > - 1x MicroSD slot > > > - 1x QSPI Flash > > > - 1x 1Gbps Ethernet port > > > - 1x HDMI port > > > - 1x 2-lane DSI and 1x 4-lane DSI > > > - 1x 2-lane CSI > > > > > > Add the devicetree file describing the currently supported features, > > > namely PMIC, UART, I2C, GPIO, SD card, QSPI Flash, eMMC and Ethernet. > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > > > > Got a dtbs_check issue in the patchwork CI: > > > > +arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dtb: gmac1-rgmii-rxin-clock: 'clock-frequency' is a required property > > + from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# > > +arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dtb: gmac1-rmii-refin-clock: 'clock-frequency' is a required property > > + from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# > > > > Can you fix that please? Also, I applied some patches the other day that > > seem to conflict quite a bit with the common board dts patch. Would you > > please do a rebase on top of that please? > > Been going through stuff on my todo list now that the merge window is > closed. Could you please resend this with the rebase done? Thanks for the reminding, I will rebase on 6.9-rc1 then send out the patches. > > Thanks, > Conor. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-28 10:22 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-31 13:25 [PATCH v3 0/6] riscv: dts: starfive: add Milkv Mars board device tree Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-01-31 13:25 ` [PATCH v3 1/6] riscv: dts: starfive: add 'cpus' label to jh7110 and jh7100 soc dtsi Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:04 ` Emil Renner Berthing 2024-04-19 22:04 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 2/6] dt-bindings: riscv: starfive: add Milkv Mars board Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:04 ` Emil Renner Berthing 2024-04-19 22:04 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 3/6] riscv: dts: starfive: visionfive 2: update sound and codec dt node name Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:05 ` Emil Renner Berthing 2024-04-19 22:05 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 4/6] riscv: dts: starfive: visionfive 2: use cpus label for timebase freq Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-04-19 22:05 ` Emil Renner Berthing 2024-04-19 22:05 ` Emil Renner Berthing 2024-01-31 13:25 ` [PATCH v3 5/6] riscv: dts: starfive: introduce a common board dtsi for jh7110 based boards Jisheng Zhang 2024-01-31 13:25 ` Jisheng Zhang 2024-01-31 13:26 ` [PATCH v3 6/6] riscv: dts: starfive: add Milkv Mars board device tree Jisheng Zhang 2024-01-31 13:26 ` Jisheng Zhang 2024-02-06 19:13 ` Conor Dooley 2024-02-06 19:13 ` Conor Dooley 2024-03-27 18:06 ` Conor Dooley 2024-03-27 18:06 ` Conor Dooley 2024-03-28 10:08 ` Jisheng Zhang [this message] 2024-03-28 10:08 ` Jisheng Zhang 2024-03-28 12:45 ` Emil Renner Berthing 2024-03-28 12:45 ` Emil Renner Berthing 2024-03-29 2:32 ` Jisheng Zhang 2024-03-29 2:32 ` Jisheng Zhang 2024-03-28 21:28 ` Heinrich Schuchardt 2024-03-28 21:28 ` Heinrich Schuchardt 2024-03-29 2:31 ` Jisheng Zhang 2024-03-29 2:31 ` Jisheng Zhang 2024-04-01 13:28 ` Heinrich Schuchardt 2024-04-01 13:28 ` Heinrich Schuchardt 2024-04-01 14:44 ` Jisheng Zhang 2024-04-01 14:44 ` Jisheng Zhang 2024-04-19 22:11 ` Emil Renner Berthing 2024-04-19 22:11 ` Emil Renner Berthing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZgVBurohYRDzFjgb@xhacker \ --to=jszhang@kernel.org \ --cc=aou@eecs.berkeley.edu \ --cc=conor@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@esmil.dk \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.