From: "Turquette, Mike" <mturquette@ti.com>
To: Saravana Kannan <skannan@codeaurora.org>
Cc: Russell King <linux@arm.linux.org.uk>,
Paul Walmsley <paul@pwsan.com>,
Linus Walleij <linus.walleij@stericsson.com>,
patches@linaro.org, Stephen Boyd <sboyd@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
Richard Zhao <richard.zhao@linaro.org>,
Grant Likely <grant.likely@secretlab.ca>,
Deepak Saxena <dsaxena@linaro.org>,
Shawn Guo <shawn.guo@freescale.com>,
linaro-dev@lists.linaro.org,
Jeremy Kerr <jeremy.kerr@canonical.com>,
Arnd Bergman <arnd.bergmann@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 2/3] clk: introduce the common clock framework
Date: Mon, 19 Mar 2012 12:33:05 -0700 [thread overview]
Message-ID: <CAJOA=zN2cSSpM92oRnW0RyU_ZzyoQ=jthc-fAkf-P3z37uWt7w@mail.gmail.com> (raw)
In-Reply-To: <4F678561.3040105@codeaurora.org>
On Mon, Mar 19, 2012 at 12:13 PM, Saravana Kannan
<skannan@codeaurora.org> wrote:
> I saw some responses from you over the weekend but not to mine. So, I
> assumed you were busy with other stuff and I started working on a patch on
> top of v7.
I only answer trivial emails on the weekend ;-)
> I will send that out if I get around to finishing it before you
> do. Hope that's alright with you.
I'm happy to for you to take a crack at it. I don't know what your
implementation looks like, but here are a couple concerns I have:
1) if you're copying the data from the initializer over to the struct
clk then make sure you handle the __init data aspects of it properly
2) are the members of struct clk_hw visible to the rest of the world?
Are they modifiable (i.e., not const)? This is undesirable.
Thanks,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: mturquette@ti.com (Turquette, Mike)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 2/3] clk: introduce the common clock framework
Date: Mon, 19 Mar 2012 12:33:05 -0700 [thread overview]
Message-ID: <CAJOA=zN2cSSpM92oRnW0RyU_ZzyoQ=jthc-fAkf-P3z37uWt7w@mail.gmail.com> (raw)
In-Reply-To: <4F678561.3040105@codeaurora.org>
On Mon, Mar 19, 2012 at 12:13 PM, Saravana Kannan
<skannan@codeaurora.org> wrote:
> I saw some responses from you over the weekend but not to mine. So, I
> assumed you were busy with other stuff and I started working on a patch on
> top of v7.
I only answer trivial emails on the weekend ;-)
> I will send that out if I get around to finishing it before you
> do. Hope that's alright with you.
I'm happy to for you to take a crack at it. I don't know what your
implementation looks like, but here are a couple concerns I have:
1) if you're copying the data from the initializer over to the struct
clk then make sure you handle the __init data aspects of it properly
2) are the members of struct clk_hw visible to the rest of the world?
Are they modifiable (i.e., not const)? This is undesirable.
Thanks,
Mike
next prev parent reply other threads:[~2012-03-19 19:33 UTC|newest]
Thread overview: 242+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 6:11 [PATCH v7 0/3] common clk framework Mike Turquette
2012-03-16 6:11 ` Mike Turquette
2012-03-16 6:11 ` [PATCH v7 1/3] Documentation: common clk API Mike Turquette
2012-03-16 6:11 ` Mike Turquette
2012-03-16 8:25 ` Linus Walleij
2012-03-16 8:25 ` Linus Walleij
2012-03-16 10:29 ` Thomas Gleixner
2012-03-16 10:29 ` Thomas Gleixner
2012-03-16 11:14 ` Amit Kucheria
2012-03-16 11:14 ` Amit Kucheria
2012-03-16 12:18 ` Arnd Bergmann
2012-03-16 12:18 ` Arnd Bergmann
2012-03-16 20:57 ` Arnd Bergmann
2012-03-16 20:57 ` Arnd Bergmann
2012-03-16 21:40 ` Turquette, Mike
2012-03-16 21:40 ` Turquette, Mike
2012-03-16 21:50 ` Nicolas Pitre
2012-03-16 21:50 ` Nicolas Pitre
2012-03-16 22:21 ` Paul Walmsley
2012-03-16 22:21 ` Paul Walmsley
2012-03-16 22:21 ` Paul Walmsley
2012-03-16 22:33 ` Turquette, Mike
2012-03-16 22:33 ` Turquette, Mike
2012-03-17 9:05 ` Arnd Bergmann
2012-03-17 9:05 ` Arnd Bergmann
2012-03-17 9:05 ` Arnd Bergmann
2012-03-17 18:02 ` Turquette, Mike
2012-03-17 18:02 ` Turquette, Mike
2012-03-17 18:02 ` Turquette, Mike
2012-03-17 18:33 ` Arnd Bergmann
2012-03-17 18:33 ` Arnd Bergmann
2012-03-17 18:33 ` Arnd Bergmann
2012-03-17 20:29 ` Sascha Hauer
2012-03-17 20:29 ` Sascha Hauer
2012-03-17 20:29 ` Sascha Hauer
2012-03-17 21:13 ` Arnd Bergmann
2012-03-17 21:13 ` Arnd Bergmann
2012-03-17 21:13 ` Arnd Bergmann
2012-03-20 23:40 ` Paul Walmsley
2012-03-20 23:40 ` Paul Walmsley
2012-03-21 8:59 ` Arnd Bergmann
2012-03-21 8:59 ` Arnd Bergmann
2012-03-16 23:47 ` Sascha Hauer
2012-03-16 23:47 ` Sascha Hauer
2012-03-16 23:47 ` Sascha Hauer
2012-03-17 0:54 ` Rob Herring
2012-03-17 0:54 ` Rob Herring
2012-03-17 0:54 ` Rob Herring
2012-03-17 3:38 ` Saravana Kannan
2012-03-17 3:38 ` Saravana Kannan
2012-03-17 3:38 ` Saravana Kannan
2012-03-20 23:31 ` Paul Walmsley
2012-03-20 23:31 ` Paul Walmsley
2012-03-20 23:31 ` Paul Walmsley
2012-03-21 3:15 ` Nicolas Pitre
2012-03-21 3:15 ` Nicolas Pitre
2012-03-21 3:15 ` Nicolas Pitre
2012-03-21 3:26 ` Saravana Kannan
2012-03-21 3:26 ` Saravana Kannan
2012-03-21 3:26 ` Saravana Kannan
2012-03-21 7:44 ` Paul Walmsley
2012-03-21 7:44 ` Paul Walmsley
2012-03-21 7:44 ` Paul Walmsley
2012-03-21 9:10 ` Sascha Hauer
2012-03-21 9:10 ` Sascha Hauer
2012-03-21 9:10 ` Sascha Hauer
2012-03-21 18:38 ` Saravana Kannan
2012-03-21 18:38 ` Saravana Kannan
2012-03-21 18:38 ` Saravana Kannan
2012-03-21 19:07 ` Mark Brown
2012-03-21 19:07 ` Mark Brown
2012-03-21 19:07 ` Mark Brown
2012-03-21 19:33 ` Tony Lindgren
2012-03-21 19:33 ` Tony Lindgren
2012-03-21 19:33 ` Tony Lindgren
2012-03-21 19:41 ` Saravana Kannan
2012-03-21 19:41 ` Saravana Kannan
2012-03-21 19:41 ` Saravana Kannan
2012-03-21 19:56 ` Mark Brown
2012-03-21 19:56 ` Mark Brown
2012-03-21 19:56 ` Mark Brown
2012-03-21 20:04 ` Saravana Kannan
2012-03-21 20:04 ` Saravana Kannan
2012-03-21 20:04 ` Saravana Kannan
2012-03-21 20:10 ` Mark Brown
2012-03-21 20:10 ` Mark Brown
2012-03-21 20:10 ` Mark Brown
2012-03-22 0:42 ` Russell King - ARM Linux
2012-03-22 0:42 ` Russell King - ARM Linux
2012-03-22 0:42 ` Russell King - ARM Linux
2012-03-21 7:30 ` Paul Walmsley
2012-03-21 7:30 ` Paul Walmsley
2012-03-21 7:30 ` Paul Walmsley
2012-03-21 13:23 ` Nicolas Pitre
2012-03-21 13:23 ` Nicolas Pitre
2012-03-21 13:23 ` Nicolas Pitre
2012-03-16 6:11 ` [PATCH v7 2/3] clk: introduce the common clock framework Mike Turquette
2012-03-16 6:11 ` Mike Turquette
2012-03-17 3:28 ` Saravana Kannan
2012-03-17 3:28 ` Saravana Kannan
2012-03-19 18:56 ` Turquette, Mike
2012-03-19 18:56 ` Turquette, Mike
2012-03-19 19:13 ` Saravana Kannan
2012-03-19 19:13 ` Saravana Kannan
2012-03-19 19:33 ` Turquette, Mike [this message]
2012-03-19 19:33 ` Turquette, Mike
2012-03-19 19:49 ` Saravana Kannan
2012-03-19 19:49 ` Saravana Kannan
2012-03-20 3:38 ` [PATCH 1/2] clk: Fix error handling in fixed clock hardware type register fn Saravana Kannan
2012-03-20 3:38 ` Saravana Kannan
2012-03-20 3:38 ` [PATCH 2/2] clk: Move init fields from clk to clk_hw Saravana Kannan
2012-03-20 3:38 ` Saravana Kannan
2012-03-20 7:20 ` Shawn Guo
2012-03-20 7:20 ` Shawn Guo
2012-03-20 7:54 ` Saravana Kannan
2012-03-20 7:54 ` Saravana Kannan
2012-03-20 7:54 ` Saravana Kannan
2012-03-20 8:13 ` Shawn Guo
2012-03-20 8:13 ` Shawn Guo
2012-03-20 9:40 ` Sascha Hauer
2012-03-20 9:40 ` Sascha Hauer
2012-03-20 10:17 ` Saravana Kannan
2012-03-20 10:17 ` Saravana Kannan
2012-03-20 10:17 ` Saravana Kannan
2012-03-20 18:14 ` Sascha Hauer
2012-03-20 18:14 ` Sascha Hauer
2012-03-20 20:14 ` Saravana Kannan
2012-03-20 20:14 ` Saravana Kannan
2012-03-20 22:40 ` Sascha Hauer
2012-03-20 22:40 ` Sascha Hauer
2012-03-22 3:23 ` Shawn Guo
2012-03-22 3:23 ` Shawn Guo
2012-03-20 14:18 ` Shawn Guo
2012-03-20 14:18 ` Shawn Guo
2012-03-20 18:10 ` Sascha Hauer
2012-03-20 18:10 ` Sascha Hauer
2012-03-20 20:06 ` Saravana Kannan
2012-03-20 20:06 ` Saravana Kannan
2012-03-20 23:12 ` Sascha Hauer
2012-03-20 23:12 ` Sascha Hauer
2012-03-21 1:47 ` Turquette, Mike
2012-03-21 1:47 ` Turquette, Mike
2012-03-21 3:01 ` Saravana Kannan
2012-03-21 3:01 ` Saravana Kannan
2012-03-27 4:35 ` Saravana Kannan
2012-03-27 4:35 ` Saravana Kannan
2012-03-27 18:49 ` Turquette, Mike
2012-03-27 18:49 ` Turquette, Mike
2012-03-27 22:27 ` Saravana Kannan
2012-03-27 22:27 ` Saravana Kannan
2012-04-06 1:30 ` Saravana Kannan
2012-04-06 1:30 ` Saravana Kannan
2012-04-11 17:59 ` Turquette, Mike
2012-04-11 17:59 ` Turquette, Mike
2012-04-11 19:57 ` Saravana Kannan
2012-04-11 19:57 ` Saravana Kannan
2012-04-11 19:57 ` Saravana Kannan
2012-04-11 20:17 ` Turquette, Mike
2012-04-11 20:17 ` Turquette, Mike
2012-04-11 20:21 ` Saravana Kannan
2012-04-11 20:21 ` Saravana Kannan
2012-04-11 20:21 ` Saravana Kannan
2012-03-20 23:47 ` Paul Walmsley
2012-03-20 23:47 ` Paul Walmsley
2012-03-21 9:16 ` Sascha Hauer
2012-03-21 9:16 ` Sascha Hauer
2012-03-20 7:19 ` [PATCH 1/2] clk: Fix error handling in fixed clock hardware type register fn Sascha Hauer
2012-03-20 7:19 ` Sascha Hauer
2012-03-20 7:46 ` Saravana Kannan
2012-03-20 7:46 ` Saravana Kannan
2012-03-20 7:46 ` Saravana Kannan
2012-03-21 0:13 ` Turquette, Mike
2012-03-21 0:13 ` Turquette, Mike
2012-03-21 2:32 ` Saravana Kannan
2012-03-21 2:32 ` Saravana Kannan
2012-03-21 5:45 ` Turquette, Mike
2012-03-21 5:45 ` Turquette, Mike
2012-03-21 6:33 ` Saravana Kannan
2012-03-21 6:33 ` Saravana Kannan
2012-03-21 6:33 ` Saravana Kannan
2012-03-21 9:07 ` Russell King - ARM Linux
2012-03-21 9:07 ` Russell King - ARM Linux
2012-03-21 19:56 ` Turquette, Mike
2012-03-21 19:56 ` Turquette, Mike
2012-03-18 13:46 ` [PATCH v7 2/3] clk: introduce the common clock framework Shawn Guo
2012-03-18 13:46 ` Shawn Guo
2012-03-19 18:58 ` Turquette, Mike
2012-03-19 18:58 ` Turquette, Mike
2012-03-18 14:07 ` Shawn Guo
2012-03-18 14:07 ` Shawn Guo
2012-03-19 19:00 ` Turquette, Mike
2012-03-19 19:00 ` Turquette, Mike
2012-03-19 11:22 ` Rajendra Nayak
2012-03-19 11:22 ` Rajendra Nayak
2012-03-19 11:28 ` Sascha Hauer
2012-03-19 11:28 ` Sascha Hauer
2012-03-19 19:09 ` Turquette, Mike
2012-03-19 19:09 ` Turquette, Mike
2012-03-19 19:53 ` Turquette, Mike
2012-03-19 19:53 ` Turquette, Mike
2012-03-20 14:02 ` Shawn Guo
2012-03-20 14:02 ` Shawn Guo
2012-03-20 17:46 ` Saravana Kannan
2012-03-20 17:46 ` Saravana Kannan
2012-03-20 23:53 ` Turquette, Mike
2012-03-20 23:53 ` Turquette, Mike
2012-03-21 3:10 ` Saravana Kannan
2012-03-21 3:10 ` Saravana Kannan
2012-03-23 21:33 ` Saravana Kannan
2012-03-23 21:33 ` Saravana Kannan
2012-03-23 21:39 ` Turquette, Mike
2012-03-23 21:39 ` Turquette, Mike
2012-03-23 21:51 ` Saravana Kannan
2012-03-23 21:51 ` Saravana Kannan
2012-03-23 22:12 ` Saravana Kannan
2012-03-23 22:12 ` Saravana Kannan
2012-03-23 22:32 ` Turquette, Mike
2012-03-23 22:32 ` Turquette, Mike
2012-03-23 23:04 ` Saravana Kannan
2012-03-23 23:04 ` Saravana Kannan
2012-03-23 23:28 ` Turquette, Mike
2012-03-23 23:28 ` Turquette, Mike
2012-03-28 3:06 ` Saravana Kannan
2012-03-28 3:06 ` Saravana Kannan
2012-03-28 17:08 ` Turquette, Mike
2012-03-28 17:08 ` Turquette, Mike
2012-03-28 22:25 ` Saravana Kannan
2012-03-28 22:25 ` Saravana Kannan
2012-03-28 23:49 ` Turquette, Mike
2012-03-28 23:49 ` Turquette, Mike
2012-03-20 23:46 ` Turquette, Mike
2012-03-20 23:46 ` Turquette, Mike
2012-03-21 5:46 ` Shawn Guo
2012-03-21 5:46 ` Shawn Guo
2012-03-16 6:11 ` [PATCH v7 3/3] clk: basic clock hardware types Mike Turquette
2012-03-16 6:11 ` Mike Turquette
2012-03-16 12:25 ` Richard Zhao
2012-03-16 12:25 ` Richard Zhao
2012-03-16 16:51 ` Turquette, Mike
2012-03-16 16:51 ` Turquette, Mike
2012-03-16 10:57 ` [PATCH v7 0/3] common clk framework Sascha Hauer
2012-03-16 10:57 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJOA=zN2cSSpM92oRnW0RyU_ZzyoQ=jthc-fAkf-P3z37uWt7w@mail.gmail.com' \
--to=mturquette@ti.com \
--cc=amit.kucheria@linaro.org \
--cc=arnd.bergmann@linaro.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dsaxena@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=jeremy.kerr@canonical.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=patches@linaro.org \
--cc=paul@pwsan.com \
--cc=richard.zhao@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@codeaurora.org \
--cc=shawn.guo@freescale.com \
--cc=skannan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.