[PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

This updates libusb1 from 1.0.19 to 1.0.20

2015-09-13: v1.0.20
* Add Haiku support
* Fix multiple memory and resource leaks (#16, #52, #76, #81)
* Fix possible deadlock when executing transfer callback
* New libusb_free_pollfds() API
* Darwin: Fix devices not being detected on OS X 10.8 (#48)
* Linux: Allow larger isochronous transfer submission (#23)
* Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
* Windows: Fix broken bus number lookup
* Windows: Improve submission of control requests for composite devices
* Examples: Add two-stage load support to fxload (#12)
* Correctly report cancellations due to timeouts
* Improve efficiency of event handling
* Improve speed of transfer submission in multi-threaded environments
* Various other bug fixes and improvements
The (#xx) numbers are libusb issue numbers, see ie:
https://github.com/libusb/libusb/issues/16

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
 rename meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} (85%)

diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb b/meta/recipes-support/libusb/libusb1_1.0.20.bb
similarity index 85%
rename from meta/recipes-support/libusb/libusb1_1.0.19.bb
rename to meta/recipes-support/libusb/libusb1_1.0.20.bb
index a20e1fc..21b8b45 100644
--- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
+++ b/meta/recipes-support/libusb/libusb1_1.0.20.bb
@@ -11,8 +11,8 @@ BBCLASSEXTEND = "native nativesdk"
 SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
           "
 
-SRC_URI[md5sum] = "f9e2bb5879968467e5ca756cb4e1fa7e"
-SRC_URI[sha256sum] = "6c502c816002f90d4f76050a6429c3a7e0d84204222cbff2dce95dd773ba6840"
+SRC_URI[md5sum] = "1d4eb194eaaa2bcfbba28102768c7dbf"
+SRC_URI[sha256sum] = "cb057190ba0a961768224e4dc6883104c6f945b2bf2ef90d7da39e7c1834f7ff"
 
 S = "${WORKDIR}/libusb-${PV}"
 
-- 
2.4.3

-- 
Jens Rehsack - rehsack@gmail.com

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

> Am 08.10.2015 um 16:36 schrieb Jens Rehsack <rehsack@gmail.com>:
> 
> This updates libusb1 from 1.0.19 to 1.0.20
> 
> 2015-09-13: v1.0.20
> * Add Haiku support
> * Fix multiple memory and resource leaks (#16, #52, #76, #81)
> * Fix possible deadlock when executing transfer callback
> * New libusb_free_pollfds() API
> * Darwin: Fix devices not being detected on OS X 10.8 (#48)
> * Linux: Allow larger isochronous transfer submission (#23)
> * Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
> * Windows: Fix broken bus number lookup
> * Windows: Improve submission of control requests for composite devices
> * Examples: Add two-stage load support to fxload (#12)
> * Correctly report cancellations due to timeouts
> * Improve efficiency of event handling
> * Improve speed of transfer submission in multi-threaded environments
> * Various other bug fixes and improvements
> The (#xx) numbers are libusb issue numbers, see ie:
> https://github.com/libusb/libusb/issues/16
> 
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
> meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> rename meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} (85%)
> 
> diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb b/meta/recipes-support/libusb/libusb1_1.0.20.bb
> similarity index 85%
> rename from meta/recipes-support/libusb/libusb1_1.0.19.bb
> rename to meta/recipes-support/libusb/libusb1_1.0.20.bb
> index a20e1fc..21b8b45 100644
> --- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
> +++ b/meta/recipes-support/libusb/libusb1_1.0.20.bb
> @@ -11,8 +11,8 @@ BBCLASSEXTEND = "native nativesdk"
> SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>           "
> 
> -SRC_URI[md5sum] = "f9e2bb5879968467e5ca756cb4e1fa7e"
> -SRC_URI[sha256sum] = "6c502c816002f90d4f76050a6429c3a7e0d84204222cbff2dce95dd773ba6840"
> +SRC_URI[md5sum] = "1d4eb194eaaa2bcfbba28102768c7dbf"
> +SRC_URI[sha256sum] = "cb057190ba0a961768224e4dc6883104c6f945b2bf2ef90d7da39e7c1834f7ff"
> 
> S = "${WORKDIR}/libusb-${PV}"
> 
> -- 
> 2.4.3

Ping :)
-- 
Jens Rehsack - rehsack@gmail.com

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Paul Eggleton]

Hi Jens,

On Thursday 29 October 2015 12:47:18 Jens Rehsack wrote:
> > Am 08.10.2015 um 16:36 schrieb Jens Rehsack <rehsack@gmail.com>:
> > 
> > This updates libusb1 from 1.0.19 to 1.0.20
> > 
> > 2015-09-13: v1.0.20
> > * Add Haiku support
> > * Fix multiple memory and resource leaks (#16, #52, #76, #81)
> > * Fix possible deadlock when executing transfer callback
> > * New libusb_free_pollfds() API
> > * Darwin: Fix devices not being detected on OS X 10.8 (#48)
> > * Linux: Allow larger isochronous transfer submission (#23)
> > * Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
> > * Windows: Fix broken bus number lookup
> > * Windows: Improve submission of control requests for composite devices
> > * Examples: Add two-stage load support to fxload (#12)
> > * Correctly report cancellations due to timeouts
> > * Improve efficiency of event handling
> > * Improve speed of transfer submission in multi-threaded environments
> > * Various other bug fixes and improvements
> > The (#xx) numbers are libusb issue numbers, see ie:
> > https://github.com/libusb/libusb/issues/16
> > 
> > Signed-off-by: Jens Rehsack <sno@netbsd.org>
> > ---
> > meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} | 4
> > ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
> > rename meta/recipes-support/libusb/{libusb1_1.0.19.bb =>
> > libusb1_1.0.20.bb} (85%)
> > 
> > diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb
> > b/meta/recipes-support/libusb/libusb1_1.0.20.bb similarity index 85%
> > rename from meta/recipes-support/libusb/libusb1_1.0.19.bb
> > rename to meta/recipes-support/libusb/libusb1_1.0.20.bb
> > index a20e1fc..21b8b45 100644
> > --- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
> > +++ b/meta/recipes-support/libusb/libusb1_1.0.20.bb
> > @@ -11,8 +11,8 @@ BBCLASSEXTEND = "native nativesdk"
> > SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
> > 
> >           "
> > 
> > -SRC_URI[md5sum] = "f9e2bb5879968467e5ca756cb4e1fa7e"
> > -SRC_URI[sha256sum] =
> > "6c502c816002f90d4f76050a6429c3a7e0d84204222cbff2dce95dd773ba6840"
> > +SRC_URI[md5sum] = "1d4eb194eaaa2bcfbba28102768c7dbf"
> > +SRC_URI[sha256sum] =
> > "cb057190ba0a961768224e4dc6883104c6f945b2bf2ef90d7da39e7c1834f7ff"
> > 
> > S = "${WORKDIR}/libusb-${PV}"
> 
> Ping :)

At this point in the release it's too late for version upgrades unless the 
upgrade fixes a critical issue and applying the patch to fix that issue is more 
risky than the upgrade. I should imagine Ross has this queued for master when 
the release happens and we diverge.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Otavio Salvador]

On Thu, Oct 29, 2015 at 10:27 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> On Thursday 29 October 2015 12:47:18 Jens Rehsack wrote:
>> > Am 08.10.2015 um 16:36 schrieb Jens Rehsack <rehsack@gmail.com>:
>> >
>> > This updates libusb1 from 1.0.19 to 1.0.20
>> >
>> > 2015-09-13: v1.0.20
>> > * Add Haiku support
>> > * Fix multiple memory and resource leaks (#16, #52, #76, #81)
>> > * Fix possible deadlock when executing transfer callback
>> > * New libusb_free_pollfds() API
>> > * Darwin: Fix devices not being detected on OS X 10.8 (#48)
>> > * Linux: Allow larger isochronous transfer submission (#23)
>> > * Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
>> > * Windows: Fix broken bus number lookup
>> > * Windows: Improve submission of control requests for composite devices
>> > * Examples: Add two-stage load support to fxload (#12)
>> > * Correctly report cancellations due to timeouts
>> > * Improve efficiency of event handling
>> > * Improve speed of transfer submission in multi-threaded environments
>> > * Various other bug fixes and improvements
>> > The (#xx) numbers are libusb issue numbers, see ie:
>> > https://github.com/libusb/libusb/issues/16
>> >
>> > Signed-off-by: Jens Rehsack <sno@netbsd.org>
>> > ---
>> > meta/recipes-support/libusb/{libusb1_1.0.19.bb => libusb1_1.0.20.bb} | 4
>> > ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
>> > rename meta/recipes-support/libusb/{libusb1_1.0.19.bb =>
>> > libusb1_1.0.20.bb} (85%)
>> >
>> > diff --git a/meta/recipes-support/libusb/libusb1_1.0.19.bb
>> > b/meta/recipes-support/libusb/libusb1_1.0.20.bb similarity index 85%
>> > rename from meta/recipes-support/libusb/libusb1_1.0.19.bb
>> > rename to meta/recipes-support/libusb/libusb1_1.0.20.bb
>> > index a20e1fc..21b8b45 100644
>> > --- a/meta/recipes-support/libusb/libusb1_1.0.19.bb
>> > +++ b/meta/recipes-support/libusb/libusb1_1.0.20.bb
>> > @@ -11,8 +11,8 @@ BBCLASSEXTEND = "native nativesdk"
>> > SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
>> >
>> >           "
>> >
>> > -SRC_URI[md5sum] = "f9e2bb5879968467e5ca756cb4e1fa7e"
>> > -SRC_URI[sha256sum] =
>> > "6c502c816002f90d4f76050a6429c3a7e0d84204222cbff2dce95dd773ba6840"
>> > +SRC_URI[md5sum] = "1d4eb194eaaa2bcfbba28102768c7dbf"
>> > +SRC_URI[sha256sum] =
>> > "cb057190ba0a961768224e4dc6883104c6f945b2bf2ef90d7da39e7c1834f7ff"
>> >
>> > S = "${WORKDIR}/libusb-${PV}"
>>
>> Ping :)
>
> At this point in the release it's too late for version upgrades unless the
> upgrade fixes a critical issue and applying the patch to fix that issue is more
> risky than the upgrade. I should imagine Ross has this queued for master when
> the release happens and we diverge.

Due the memory leak fixes, I think we could consider the backport for
2.0.1 after it proves stable in master for some time.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On 29 October 2015 at 12:37, Otavio Salvador <
otavio.salvador@ossystems.com.br> wrote:

> Due the memory leak fixes, I think we could consider the backport for
> 2.0.1 after it proves stable in master for some time.
>

Standard practise would be to cherry-pick the leak fixes, unless you can
convince the jethro stable maintainer (whoever that ends up being) that
nothing will break with an upgrade.

Ross

[-- Attachment #2: Type: text/html, Size: 831 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On 29 October 2015 at 12:27, Paul Eggleton <paul.eggleton@linux.intel.com>
wrote:

> At this point in the release it's too late for version upgrades unless the
> upgrade fixes a critical issue and applying the patch to fix that issue is
> more
> risky than the upgrade. I should imagine Ross has this queued for master
> when
> the release happens and we diverge.
>

Indeed I do (poky-contrib:ross/mut).

Ross

[-- Attachment #2: Type: text/html, Size: 843 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]

On 8 October 2015 at 15:36, Jens Rehsack <rehsack@gmail.com> wrote:

> This updates libusb1 from 1.0.19 to 1.0.20
>
> 2015-09-13: v1.0.20
> * Add Haiku support
> * Fix multiple memory and resource leaks (#16, #52, #76, #81)
> * Fix possible deadlock when executing transfer callback
> * New libusb_free_pollfds() API
> * Darwin: Fix devices not being detected on OS X 10.8 (#48)
> * Linux: Allow larger isochronous transfer submission (#23)
> * Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
> * Windows: Fix broken bus number lookup
> * Windows: Improve submission of control requests for composite devices
> * Examples: Add two-stage load support to fxload (#12)
> * Correctly report cancellations due to timeouts
> * Improve efficiency of event handling
> * Improve speed of transfer submission in multi-threaded environments
> * Various other bug fixes and improvements
> The (#xx) numbers are libusb issue numbers, see ie:
> https://github.com/libusb/libusb/issues/16
>

And apparently introduces a parallel make race :(

mv: cannot stat `libusb_1_0_la-sync.loT': No such file or directory
mv: cannot stat `libusb_1_0_la-descriptor.loT': No such file or directory
mv: cannot stat `libusb_1_0_la-core.loT': No such file or directory
mv: cannot stat `libusb_1_0_la-hotplug.loT': No such file or directory
mv: cannot stat `libusb_1_0_la-io.loT': No such file or directory
i686-poky-linux-libtool:   error: 'os/libusb_1_0_la-linux_usbfs.lo' is not
a valid libtool object
make[3]: *** [libusb-1.0.la] Error 1
make[3]: Leaving directory
`/home/pokybuild/yocto-autobuilder/yocto-worker/ptest-x86/build/build/tmp/work/core2-32-poky-linux/libusb1/1.0.20-r0/build/libusb'
make[2]: *** [all-recursive] Error 1

(full log at http://errors.yoctoproject.org/Errors/Details/21443/)

Ross

[-- Attachment #2: Type: text/html, Size: 2710 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

> Am 06.11.2015 um 11:36 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> 
> On 8 October 2015 at 15:36, Jens Rehsack <rehsack@gmail.com> wrote:
> This updates libusb1 from 1.0.19 to 1.0.20
> 
> 2015-09-13: v1.0.20
> * Add Haiku support
> * Fix multiple memory and resource leaks (#16, #52, #76, #81)
> * Fix possible deadlock when executing transfer callback
> * New libusb_free_pollfds() API
> * Darwin: Fix devices not being detected on OS X 10.8 (#48)
> * Linux: Allow larger isochronous transfer submission (#23)
> * Windows: Fix broken builds Cygwin/MinGW builds and compiler warnings
> * Windows: Fix broken bus number lookup
> * Windows: Improve submission of control requests for composite devices
> * Examples: Add two-stage load support to fxload (#12)
> * Correctly report cancellations due to timeouts
> * Improve efficiency of event handling
> * Improve speed of transfer submission in multi-threaded environments
> * Various other bug fixes and improvements
> The (#xx) numbers are libusb issue numbers, see ie:
> https://github.com/libusb/libusb/issues/16
> 
> And apparently introduces a parallel make race :(
> 
> mv: cannot stat `libusb_1_0_la-sync.loT': No such file or directory
> mv: cannot stat `libusb_1_0_la-descriptor.loT': No such file or directory
> mv: cannot stat `libusb_1_0_la-core.loT': No such file or directory
> mv: cannot stat `libusb_1_0_la-hotplug.loT': No such file or directory
> mv: cannot stat `libusb_1_0_la-io.loT': No such file or directory
> i686-poky-linux-libtool:   error: 'os/libusb_1_0_la-linux_usbfs.lo' is not a valid libtool object
> make[3]: *** [libusb-1.0.la] Error 1
> make[3]: Leaving directory `/home/pokybuild/yocto-autobuilder/yocto-worker/ptest-x86/build/build/tmp/work/core2-32-poky-linux/libusb1/1.0.20-r0/build/libusb'
> make[2]: *** [all-recursive] Error 1
> 
> (full log at http://errors.yoctoproject.org/Errors/Details/21443/)

I look into it and send a v2, if necessary

Cheers
-- 
Jens Rehsack - rehsack@gmail.com

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

On 7 November 2015 at 10:36, Jens Rehsack <rehsack@gmail.com> wrote:

> I look into it and send a v2, if necessary
>

Thanks Jens!

Ross

[-- Attachment #2: Type: text/html, Size: 549 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

> Am 08.11.2015 um 00:31 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> 
> On 7 November 2015 at 10:36, Jens Rehsack <rehsack@gmail.com> wrote:
> I look into it and send a v2, if necessary
> 
> Thanks Jens!

Since I couldn't reproduce it (on a 12-core machine using different -j settings),
I proved the Makefile.am and resulting Makefile - looks fine for me, libusb-1.0.la
has among other things ...linux-netlink.lo as dependency.

Cheers
-- 
Jens Rehsack - rehsack@gmail.com

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

On 10 November 2015 at 09:14, Jens Rehsack <rehsack@gmail.com> wrote:

> Since I couldn't reproduce it (on a 12-core machine using different -j
> settings),
> I proved the Makefile.am and resulting Makefile - looks fine for me,
> libusb-1.0.la
> has among other things ...linux-netlink.lo as dependency.
>

I can't see anything obviously wrong with the makefile.  I'll merge it and
give it another run on the AB.

Ross

[-- Attachment #2: Type: text/html, Size: 898 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On 10 November 2015 at 13:14, Burton, Ross <ross.burton@intel.com> wrote:

> I can't see anything obviously wrong with the makefile.  I'll merge it and
> give it another run on the AB.
>

http://errors.yoctoproject.org/Errors/Latest/Autobuilder/?filter=libusb1&type=recipe

Failed twice last night.  There's definitely a race in there.

Ross

[-- Attachment #2: Type: text/html, Size: 1019 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

> Am 13.11.2015 um 10:53 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> 
> On 10 November 2015 at 13:14, Burton, Ross <ross.burton@intel.com> wrote:
> I can't see anything obviously wrong with the makefile.  I'll merge it and give it another run on the AB.
> 
> http://errors.yoctoproject.org/Errors/Latest/Autobuilder/?filter=libusb1&type=recipe
> 
> Failed twice last night.  There's definitely a race in there.

Since we both didn't see something, I send a v2 with PARALLEL_MAKE = ""

Cheers
-- 
Jens Rehsack - rehsack@gmail.com

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

On 13 November 2015 at 12:18, Jens Rehsack <rehsack@gmail.com> wrote:

> Since we both didn't see something, I send a v2 with PARALLEL_MAKE = ""
>

I'm not letting a makefile defeat me! :)

Ross

[-- Attachment #2: Type: text/html, Size: 604 bytes --]

Re: [PATCH 1/1] Update libusb1 from 1.0.19 to 1.0.20

[Jens Rehsack]

> Am 13.11.2015 um 13:20 schrieb Burton, Ross <ross.burton@intel.com>:
> 
> 
> On 13 November 2015 at 12:18, Jens Rehsack <rehsack@gmail.com> wrote:
> Since we both didn't see something, I send a v2 with PARALLEL_MAKE = ""
> 
> I'm not letting a makefile defeat me! :)

Yeah, but I have in openjdk-8 enough challenges to accept, so no waste
time on such a tiny thing.

Cheers
-- 
Jens Rehsack - rehsack@gmail.com