All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Manuel Luís Reis" <mluis.reis@gmail.com>
To: u-boot@lists.denx.de
Subject: SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94
Date: Mon, 5 Apr 2021 16:42:14 +0100	[thread overview]
Message-ID: <CAJYnj0jGqPJpbawR98eouXxjQKYRm=xMK7ffxWqtAnOO2WNA3Q@mail.gmail.com> (raw)
In-Reply-To: <6ba90f91-30fd-cf91-153c-ccf9d87e81b1@microchip.com>

Hi Eugen,

> Does the node have the property
>
> u-boot,dm-pre-reloc;
>
> Maybe try to add this and see if it changes anything ?

Thanks. Indeed it didn't have those properties. I have added them and also
had to remove the udelay call in ddr2_init for the fix to work.
The udelay call in ddr2_init was also failing (maybe too early for a timer
call!?), but it seems to be redundant as it sits between two nops,
and is working well as far as I can tell. If extra time is needed in that
place, maybe extra NOPs could be considered instead.

I am sending a patch for the fix. Could you review it please?

Let me know if you'd like me to change anything.

Thanks again,
--------------------------------------------------------------------------------------------------------

  reply	other threads:[~2021-04-05 15:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 11:06 SAMA5D3 Xplained: SPL broken after panic added to /lib/time.c:94 Manuel Luís Reis
2021-03-23 11:14 ` Eugen.Hristev at microchip.com
2021-03-23 11:28   ` Manuel Luís Reis
2021-03-23 11:38     ` Eugen.Hristev at microchip.com
2021-03-23 13:20       ` Manuel Luís Reis
2021-03-23 16:08         ` Manuel Luís Reis
2021-03-23 16:26           ` Eugen.Hristev at microchip.com
2021-03-23 16:54             ` Manuel Luís Reis
2021-03-24  0:34               ` Sean Anderson
2021-03-25 10:25               ` Claudiu.Beznea at microchip.com
2021-04-02 17:12                 ` Manuel Luís Reis
2021-04-02 17:15                   ` Manuel Luís Reis
2021-04-04 16:25                     ` Manuel Reis
2021-04-05 12:44                       ` Eugen.Hristev at microchip.com
2021-04-05 12:47                         ` Manuel Luís Reis
2021-04-05 13:58                           ` Eugen.Hristev at microchip.com
2021-04-05 15:42                             ` Manuel Luís Reis [this message]
2021-04-05 16:00                               ` Eugen.Hristev at microchip.com
2021-04-05 17:50                                 ` Manuel Luís Reis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJYnj0jGqPJpbawR98eouXxjQKYRm=xMK7ffxWqtAnOO2WNA3Q@mail.gmail.com' \
    --to=mluis.reis@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.