From: "Clément Péron" <peron.clem@gmail.com> To: Maxime Ripard <maxime@cerno.tech> Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com> Subject: Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table Date: Mon, 6 Apr 2020 10:58:44 +0200 [thread overview] Message-ID: <CAJiuCceK40JVf7SDm5s-JAL1g_bMPuuhF7cc-yCSN7epUV7V=w@mail.gmail.com> (raw) In-Reply-To: <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> Hi Maxime, On Mon, 6 Apr 2020 at 10:16, Maxime Ripard <maxime@cerno.tech> wrote: > > On Sun, Apr 05, 2020 at 07:35:58PM +0200, Clément Péron wrote: > > Add an Operating Performance Points table for the GPU to > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > new file mode 100644 > > index 000000000000..4a1814844fe0 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > @@ -0,0 +1,74 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +// Copyright (C) 2020 Clément Péron <peron.clem@gmail.com> > > + > > +/ { > > + gpu_opp_table: opp_table1 { > > A node name is supposed to be a generic description, so what about > using gpu-opp-table (and cpu-opp-table) instead? > > > + compatible = "operating-points-v2"; > > + > > + opp@756000000 { > > + opp-hz = /bits/ 64 <756000000>; > > + opp-microvolt = <1040000>; > > + }; > > + opp@624000000 { > > + opp-hz = /bits/ 64 <624000000>; > > + opp-microvolt = <950000>; > > + }; > > Ordering by ascending frequency would be great here. Indeed will fix it. > > Also, why did you need to create a new DTSI for it? Is there some > downside to enabling it for all the users? I didn't want to enable it for all boards as I can't test them and not all board have a dedicated regulator for VDD-GPU. Hence my question in the cover, But with Jernej Škrabec test on Tanix TX6 I think it can be safely enable on all boards. Regards, Clement > > Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com> To: Maxime Ripard <maxime@cerno.tech> Cc: devicetree <devicetree@vger.kernel.org>, Chen-Yu Tsai <wens@csie.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, Rob Herring <robh+dt@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU Operating Performance Points table Date: Mon, 6 Apr 2020 10:58:44 +0200 [thread overview] Message-ID: <CAJiuCceK40JVf7SDm5s-JAL1g_bMPuuhF7cc-yCSN7epUV7V=w@mail.gmail.com> (raw) In-Reply-To: <20200406081601.3y6fwb7czr2xdkep@gilmour.lan> Hi Maxime, On Mon, 6 Apr 2020 at 10:16, Maxime Ripard <maxime@cerno.tech> wrote: > > On Sun, Apr 05, 2020 at 07:35:58PM +0200, Clément Péron wrote: > > Add an Operating Performance Points table for the GPU to > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com> > > --- > > .../boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi | 74 +++++++++++++++++++ > > 1 file changed, 74 insertions(+) > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > new file mode 100644 > > index 000000000000..4a1814844fe0 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-gpu-opp.dtsi > > @@ -0,0 +1,74 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +// Copyright (C) 2020 Clément Péron <peron.clem@gmail.com> > > + > > +/ { > > + gpu_opp_table: opp_table1 { > > A node name is supposed to be a generic description, so what about > using gpu-opp-table (and cpu-opp-table) instead? > > > + compatible = "operating-points-v2"; > > + > > + opp@756000000 { > > + opp-hz = /bits/ 64 <756000000>; > > + opp-microvolt = <1040000>; > > + }; > > + opp@624000000 { > > + opp-hz = /bits/ 64 <624000000>; > > + opp-microvolt = <950000>; > > + }; > > Ordering by ascending frequency would be great here. Indeed will fix it. > > Also, why did you need to create a new DTSI for it? Is there some > downside to enabling it for all the users? I didn't want to enable it for all boards as I can't test them and not all board have a dedicated regulator for VDD-GPU. Hence my question in the cover, But with Jernej Škrabec test on Tanix TX6 I think it can be safely enable on all boards. Regards, Clement > > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-06 8:59 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-05 17:35 [PATCH v2 0/7] Add support for Allwinner H6 DVFS Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-05 17:35 ` [PATCH v2 1/7] arm64: dts: allwinner: h6: Add clock to CPU cores Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-05 17:35 ` [PATCH v2 2/7] arm64: dts: allwinner: h6: Add thermal trip points/cooling map Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-05 17:35 ` [PATCH v2 3/7] arm64: dts: allwinner: h6: Add CPU Operating Performance Points table Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-06 8:14 ` Maxime Ripard 2020-04-06 8:14 ` Maxime Ripard 2020-04-06 18:03 ` Clément Péron 2020-04-06 18:03 ` Clément Péron 2020-04-07 8:47 ` Maxime Ripard 2020-04-07 8:47 ` Maxime Ripard 2020-04-05 17:35 ` [PATCH v2 4/7] arm64: dts: allwinner: h6: Add GPU " Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-06 8:16 ` Maxime Ripard 2020-04-06 8:16 ` Maxime Ripard 2020-04-06 8:58 ` Clément Péron [this message] 2020-04-06 8:58 ` Clément Péron 2020-04-05 17:35 ` [PATCH v2 5/7] arm64: configs: Enable sun50i cpufreq nvmem Clément Péron 2020-04-05 17:35 ` Clément Péron 2020-04-06 8:16 ` Maxime Ripard 2020-04-06 8:16 ` Maxime Ripard 2020-04-05 17:36 ` [PATCH v2 6/7] arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Beelink GS1 Clément Péron 2020-04-05 17:36 ` Clément Péron 2020-04-05 17:36 ` [PATCH v2 7/7] arm64: dts: allwinner: h6: Enable CPU and GPU opp tables for Orange Pi boards Clément Péron 2020-04-05 17:36 ` Clément Péron 2020-04-06 9:10 ` Clément Péron 2020-04-06 9:10 ` Clément Péron 2020-04-06 8:10 ` [PATCH v2 0/7] Add support for Allwinner H6 DVFS Maxime Ripard 2020-04-06 8:10 ` Maxime Ripard 2020-04-06 9:07 ` Clément Péron 2020-04-06 9:07 ` Clément Péron 2020-04-13 13:37 ` Clément Péron 2020-04-13 13:37 ` Clément Péron 2020-04-15 10:28 ` Maxime Ripard 2020-04-15 10:28 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJiuCceK40JVf7SDm5s-JAL1g_bMPuuhF7cc-yCSN7epUV7V=w@mail.gmail.com' \ --to=peron.clem@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=maxime@cerno.tech \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.