Re: [PATCH 6/6] 6lowpan: return the dev_queue_xmit() return value from lowpan_xmit()

From: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
Cc: "open list:NETWORKING \[GENERAL\]"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-zigbee-devel
	<linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 6/6] 6lowpan: return the dev_queue_xmit() return value from lowpan_xmit()
Date: Tue, 2 Apr 2013 23:27:00 +0400	[thread overview]
Message-ID: <CAJmB2rAqc=YVF5t2rxRso7jPYWr7zSSd7oRXvuf6Sq=yEiMGPg@mail.gmail.com> (raw)
In-Reply-To: <1364928481-1813-7-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1055 bytes --]

2013/4/2 Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>

> dev_queue_xmit() will return a positive value if the packet could not be
> queued, often because the real network device (in our case the mac802154
> wpan device) has its queue stopped.  lowpan_xmit() should return that value
> to the higher layer so the higher layer will retry sending the packet.
>
> Signed-off-by: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
> ---
>  net/ieee802154/6lowpan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c
> index a68c792..55e1fd5 100644
> --- a/net/ieee802154/6lowpan.c
> +++ b/net/ieee802154/6lowpan.c
> @@ -1142,7 +1142,7 @@ out:
>         if (err)
>                 pr_debug("ERROR: xmit failed\n");
>
> -       return (err < 0 ? NETDEV_TX_BUSY : NETDEV_TX_OK);
> +       return (err < 0) ? NET_XMIT_DROP : err;
>  }
>
>  static struct wpan_phy *lowpan_get_phy(const struct net_device *dev)
> --
> 1.7.11.2
>
> this patch should be a part of previous one.

[-- Attachment #1.2: Type: text/html, Size: 1585 bytes --]

[-- Attachment #2: Type: text/plain, Size: 351 bytes --]

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html

[-- Attachment #3: Type: text/plain, Size: 213 bytes --]

_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel