From: Alan Ott <alan@signal11.us> To: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, "David S. Miller" <davem@davemloft.net> Cc: linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alan Ott <alan@signal11.us> Subject: [PATCH 6/6] 6lowpan: return the dev_queue_xmit() return value from lowpan_xmit() Date: Tue, 2 Apr 2013 14:48:01 -0400 [thread overview] Message-ID: <1364928481-1813-7-git-send-email-alan@signal11.us> (raw) In-Reply-To: <1364928481-1813-1-git-send-email-alan@signal11.us> dev_queue_xmit() will return a positive value if the packet could not be queued, often because the real network device (in our case the mac802154 wpan device) has its queue stopped. lowpan_xmit() should return that value to the higher layer so the higher layer will retry sending the packet. Signed-off-by: Alan Ott <alan@signal11.us> --- net/ieee802154/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index a68c792..55e1fd5 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -1142,7 +1142,7 @@ out: if (err) pr_debug("ERROR: xmit failed\n"); - return (err < 0 ? NETDEV_TX_BUSY : NETDEV_TX_OK); + return (err < 0) ? NET_XMIT_DROP : err; } static struct wpan_phy *lowpan_get_phy(const struct net_device *dev) -- 1.7.11.2
WARNING: multiple messages have this Message-ID (diff)
From: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> To: Alexander Smirnov <alex.bluesman.smirnov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Dmitry Eremin-Solenikov <dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> Cc: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Subject: [PATCH 6/6] 6lowpan: return the dev_queue_xmit() return value from lowpan_xmit() Date: Tue, 2 Apr 2013 14:48:01 -0400 [thread overview] Message-ID: <1364928481-1813-7-git-send-email-alan@signal11.us> (raw) In-Reply-To: <1364928481-1813-1-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> dev_queue_xmit() will return a positive value if the packet could not be queued, often because the real network device (in our case the mac802154 wpan device) has its queue stopped. lowpan_xmit() should return that value to the higher layer so the higher layer will retry sending the packet. Signed-off-by: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> --- net/ieee802154/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan.c b/net/ieee802154/6lowpan.c index a68c792..55e1fd5 100644 --- a/net/ieee802154/6lowpan.c +++ b/net/ieee802154/6lowpan.c @@ -1142,7 +1142,7 @@ out: if (err) pr_debug("ERROR: xmit failed\n"); - return (err < 0 ? NETDEV_TX_BUSY : NETDEV_TX_OK); + return (err < 0) ? NET_XMIT_DROP : err; } static struct wpan_phy *lowpan_get_phy(const struct net_device *dev) -- 1.7.11.2 ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html
next prev parent reply other threads:[~2013-04-02 18:48 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-04-02 18:47 [PATCH 0/6] 802.15.4 and 6LoWPAN Buffering Fixes Alan Ott 2013-04-02 18:47 ` Alan Ott 2013-04-02 18:47 ` [PATCH 1/6] mac802154: Immediately retry sending failed packets Alan Ott 2013-04-02 18:47 ` Alan Ott [not found] ` <1364928481-1813-2-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> 2013-04-02 19:11 ` Alexander Smirnov 2013-04-02 20:28 ` Alan Ott 2013-04-02 20:28 ` Alan Ott 2013-04-02 21:28 ` Alan Ott 2013-04-02 22:35 ` Alan Ott 2013-04-02 22:35 ` Alan Ott 2013-04-02 23:13 ` [Linux-zigbee-devel] " Werner Almesberger 2013-04-02 23:13 ` Werner Almesberger 2013-04-03 1:24 ` [Linux-zigbee-devel] " Alan Ott 2013-04-03 1:24 ` Alan Ott 2013-04-03 1:56 ` [Linux-zigbee-devel] " David Miller 2013-04-03 1:59 ` Alan Ott 2013-04-03 1:59 ` Alan Ott 2013-04-03 2:03 ` [Linux-zigbee-devel] " David Miller 2013-04-03 2:03 ` David Miller 2013-04-03 2:25 ` [Linux-zigbee-devel] " Alan Ott 2013-04-03 2:25 ` Alan Ott 2013-04-03 2:30 ` [Linux-zigbee-devel] " David Miller 2013-04-03 2:30 ` David Miller 2013-04-03 2:57 ` [Linux-zigbee-devel] " Alan Ott 2013-04-03 2:38 ` Werner Almesberger 2013-04-02 18:47 ` [PATCH 2/6] mac802154: Move xmit_attemps to stack Alan Ott 2013-04-02 18:47 ` Alan Ott 2013-04-02 18:47 ` [PATCH 3/6] mac802154: Use netif flow control Alan Ott 2013-04-02 18:47 ` Alan Ott 2013-04-02 21:21 ` Sergei Shtylyov 2013-04-02 18:47 ` [PATCH 4/6] mac802154: Increase tx_buffer_len Alan Ott 2013-04-02 18:47 ` Alan Ott 2013-04-02 18:48 ` [PATCH 5/6] 6lowpan: handle dev_queue_xmit error code properly Alan Ott 2013-04-02 18:48 ` Alan Ott [not found] ` <1364928481-1813-6-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> 2013-04-02 19:21 ` Alexander Smirnov [not found] ` <CAJmB2rB+9-gLV=SVvr4JUc2swjmTaWxD0gYM5VLw8PL1d455JA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2013-04-02 19:30 ` Alan Ott 2013-04-02 18:48 ` Alan Ott [this message] 2013-04-02 18:48 ` [PATCH 6/6] 6lowpan: return the dev_queue_xmit() return value from lowpan_xmit() Alan Ott [not found] ` <1364928481-1813-7-git-send-email-alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org> 2013-04-02 19:27 ` Alexander Smirnov 2013-04-03 14:00 ` [PATCH v2 0/4] 802.15.4 and 6LoWPAN Buffering Fixes Alan Ott 2013-04-03 14:00 ` Alan Ott 2013-04-03 14:00 ` [PATCH v2 1/4] mac802154: Do not try to resend failed packets Alan Ott 2013-04-03 14:00 ` [PATCH v2 2/4] mac802154: Use netif flow control Alan Ott 2013-04-03 14:00 ` Alan Ott 2013-04-03 14:00 ` [PATCH v2 3/4] mac802154: Increase tx_buffer_len Alan Ott 2013-04-03 14:00 ` Alan Ott 2013-04-03 14:00 ` [PATCH v2 4/4] 6lowpan: handle dev_queue_xmit() error code properly Alan Ott 2013-04-03 14:00 ` Alan Ott 2013-04-07 21:06 ` [PATCH v2 0/4] 802.15.4 and 6LoWPAN Buffering Fixes David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1364928481-1813-7-git-send-email-alan@signal11.us \ --to=alan@signal11.us \ --cc=alex.bluesman.smirnov@gmail.com \ --cc=davem@davemloft.net \ --cc=dbaryshkov@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-zigbee-devel@lists.sourceforge.net \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.