All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Joel Stanley <joel@jms.id.au>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup
Date: Fri, 9 Jun 2017 11:19:13 +0200	[thread overview]
Message-ID: <CAK8P3a23XpDQhnM=j8FBS8NGck2ZfaAotVo191NEOttP2GDCYA@mail.gmail.com> (raw)
In-Reply-To: <20170609073037.21871-1-andrew@aj.id.au>

On Fri, Jun 9, 2017 at 9:30 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Add the clock-names property in init_timer() to work-around Aspeed
> devicetrees from times prior to merging the Moxart/Aspeed and Faraday
> drivers.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Well, here's an implementation I knocked up. It's a fair chunk of code for
> marginal benefit. Joel is against it.
>
> At least it's something to debate.
>
> Tested under QEMU for both AST2400 and AST2500 SoCs.

Right, I think having the one-line fixup in the driver makes way more sense
here, and that is what we usually do, but we could do this if Daniel has good
reasons to keep the driver free of backwards-compatibility support.

It also depends a bit on how common the old binding version already
is, and if anyone is shipping systems with that.

       Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup
Date: Fri, 9 Jun 2017 11:19:13 +0200	[thread overview]
Message-ID: <CAK8P3a23XpDQhnM=j8FBS8NGck2ZfaAotVo191NEOttP2GDCYA@mail.gmail.com> (raw)
In-Reply-To: <20170609073037.21871-1-andrew@aj.id.au>

On Fri, Jun 9, 2017 at 9:30 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Add the clock-names property in init_timer() to work-around Aspeed
> devicetrees from times prior to merging the Moxart/Aspeed and Faraday
> drivers.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Well, here's an implementation I knocked up. It's a fair chunk of code for
> marginal benefit. Joel is against it.
>
> At least it's something to debate.
>
> Tested under QEMU for both AST2400 and AST2500 SoCs.

Right, I think having the one-line fixup in the driver makes way more sense
here, and that is what we usually do, but we could do this if Daniel has good
reasons to keep the driver free of backwards-compatibility support.

It also depends a bit on how common the old binding version already
is, and if anyone is shipping systems with that.

       Arnd

  reply	other threads:[~2017-06-09  9:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05  7:48 [PATCH] arm: aspeed: Add clock-names property to timer node Andrew Jeffery
2017-06-05  7:48 ` Andrew Jeffery
2017-06-05  8:59 ` Joel Stanley
2017-06-05  8:59   ` Joel Stanley
2017-06-05 21:11   ` Daniel Lezcano
2017-06-05 21:11     ` Daniel Lezcano
2017-06-06  2:18     ` Joel Stanley
2017-06-06  2:18       ` Joel Stanley
2017-06-06  9:41   ` Arnd Bergmann
2017-06-06  9:41     ` Arnd Bergmann
2017-06-07 12:52     ` Daniel Lezcano
2017-06-07 12:52       ` Daniel Lezcano
2017-06-07 14:29       ` Arnd Bergmann
2017-06-07 14:29         ` Arnd Bergmann
2017-06-08 13:26         ` Daniel Lezcano
2017-06-08 13:26           ` Daniel Lezcano
2017-06-08 14:34           ` Arnd Bergmann
2017-06-08 14:34             ` Arnd Bergmann
2017-06-09  7:30             ` [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup Andrew Jeffery
2017-06-09  7:30               ` Andrew Jeffery
2017-06-09  9:19               ` Arnd Bergmann [this message]
2017-06-09  9:19                 ` Arnd Bergmann
2017-06-09 12:52                 ` Andrew Jeffery
2017-06-09 12:52                   ` Andrew Jeffery
2017-06-20  8:06                   ` Linus Walleij
2017-06-20  8:06                     ` Linus Walleij
2017-06-20  9:26                     ` Jonas Jensen
2017-06-20  9:26                       ` Jonas Jensen
2017-06-09 13:44     ` [PATCH] arm: aspeed: Add clock-names property to timer node Linus Walleij
2017-06-09 13:44       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a23XpDQhnM=j8FBS8NGck2ZfaAotVo191NEOttP2GDCYA@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=andrew@aj.id.au \
    --cc=daniel.lezcano@linaro.org \
    --cc=joel@jms.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.