All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node
Date: Tue, 6 Jun 2017 11:41:11 +0200	[thread overview]
Message-ID: <CAK8P3a2d=T9igbhe1u3MBUF2F1TMLC7z0DQ2AmHX-LkiBAy2Ww@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XeM6fBztHwfrPUD+ewpMf==tBqgfj61B-k=SwT3ABTiZw@mail.gmail.com>

On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley <joel@jms.id.au> wrote:
> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>> The merging of a number of clocksource drivers into fttmr010 means we
>> require clock-names to be specified in the Aspeed timer node, else the
>> clocksource fails to probe and boot hangs.
>
> Arnd,
>
> Linus' reworked timer driver will go into 4.13.
>
> Can we get this patch merged into 4.12 as a fix so we don't end up
> with a broken boot at any stage?

Hmm, can't we make the driver backward-compatible and have it fall
back on the first clock if no clk named "PCLK" is found? Otherwise
you still have an incompatible change in the DT binding and it will
break if someone uses an older dtb with a newer kernel.

        Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: aspeed: Add clock-names property to timer node
Date: Tue, 6 Jun 2017 11:41:11 +0200	[thread overview]
Message-ID: <CAK8P3a2d=T9igbhe1u3MBUF2F1TMLC7z0DQ2AmHX-LkiBAy2Ww@mail.gmail.com> (raw)
In-Reply-To: <CACPK8XeM6fBztHwfrPUD+ewpMf==tBqgfj61B-k=SwT3ABTiZw@mail.gmail.com>

On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley <joel@jms.id.au> wrote:
> On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
>> The merging of a number of clocksource drivers into fttmr010 means we
>> require clock-names to be specified in the Aspeed timer node, else the
>> clocksource fails to probe and boot hangs.
>
> Arnd,
>
> Linus' reworked timer driver will go into 4.13.
>
> Can we get this patch merged into 4.12 as a fix so we don't end up
> with a broken boot at any stage?

Hmm, can't we make the driver backward-compatible and have it fall
back on the first clock if no clk named "PCLK" is found? Otherwise
you still have an incompatible change in the DT binding and it will
break if someone uses an older dtb with a newer kernel.

        Arnd

  parent reply	other threads:[~2017-06-06  9:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05  7:48 [PATCH] arm: aspeed: Add clock-names property to timer node Andrew Jeffery
2017-06-05  7:48 ` Andrew Jeffery
2017-06-05  8:59 ` Joel Stanley
2017-06-05  8:59   ` Joel Stanley
2017-06-05 21:11   ` Daniel Lezcano
2017-06-05 21:11     ` Daniel Lezcano
2017-06-06  2:18     ` Joel Stanley
2017-06-06  2:18       ` Joel Stanley
2017-06-06  9:41   ` Arnd Bergmann [this message]
2017-06-06  9:41     ` Arnd Bergmann
2017-06-07 12:52     ` Daniel Lezcano
2017-06-07 12:52       ` Daniel Lezcano
2017-06-07 14:29       ` Arnd Bergmann
2017-06-07 14:29         ` Arnd Bergmann
2017-06-08 13:26         ` Daniel Lezcano
2017-06-08 13:26           ` Daniel Lezcano
2017-06-08 14:34           ` Arnd Bergmann
2017-06-08 14:34             ` Arnd Bergmann
2017-06-09  7:30             ` [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup Andrew Jeffery
2017-06-09  7:30               ` Andrew Jeffery
2017-06-09  9:19               ` Arnd Bergmann
2017-06-09  9:19                 ` Arnd Bergmann
2017-06-09 12:52                 ` Andrew Jeffery
2017-06-09 12:52                   ` Andrew Jeffery
2017-06-20  8:06                   ` Linus Walleij
2017-06-20  8:06                     ` Linus Walleij
2017-06-20  9:26                     ` Jonas Jensen
2017-06-20  9:26                       ` Jonas Jensen
2017-06-09 13:44     ` [PATCH] arm: aspeed: Add clock-names property to timer node Linus Walleij
2017-06-09 13:44       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a2d=T9igbhe1u3MBUF2F1TMLC7z0DQ2AmHX-LkiBAy2Ww@mail.gmail.com' \
    --to=arnd@arndb.de \
    --cc=andrew@aj.id.au \
    --cc=daniel.lezcano@linaro.org \
    --cc=joel@jms.id.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.