From: Anup Patel <apatel@ventanamicro.com> To: Rob Herring <robh@kernel.org> Cc: Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Frank Rowand <frowand.list@gmail.com>, Conor Dooley <conor+dt@kernel.org>, Atish Patra <atishp@atishpatra.org>, Andrew Jones <ajones@ventanamicro.com>, Sunil V L <sunilvl@ventanamicro.com>, Saravana Kannan <saravanak@google.com>, Anup Patel <anup@brainfault.org>, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 02/14] of: property: Add fw_devlink support for msi-parent Date: Thu, 20 Jul 2023 17:25:03 +0530 [thread overview] Message-ID: <CAK9=C2Ui3H8jOXZbSd_CCmtxVLWR=-JrTDK8kDbrLhJ4uUi+9g@mail.gmail.com> (raw) In-Reply-To: <20230719223758.GA892809-robh@kernel.org> On Thu, Jul 20, 2023 at 4:08 AM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jul 19, 2023 at 05:05:30PM +0530, Anup Patel wrote: > > This allows fw_devlink to create device links between consumers of > > a MSI and the supplier of the MSI. > > > > Signed-off-by: Anup Patel <apatel@ventanamicro.com> > > --- > > drivers/of/property.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index ddc75cd50825..e4096b79a872 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1325,6 +1325,37 @@ static struct device_node *parse_interrupts(struct device_node *np, > > return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.np; > > } > > > > +static struct device_node *parse_msi_parent(struct device_node *np, > > + const char *prop_name, int index) > > +{ > > + struct of_phandle_args sup_args; > > + struct device_node *msi_np; > > + > > + if (!IS_ENABLED(CONFIG_OF_IRQ)) > > + return NULL; > > Why do we need this? Sparc is not going to have MSI properties to begin > with. I guess it saves a little bit of code. Though Sparc doesn't need > any of this file. Or maybe there's a better kconfig symbol to use here > if MSIs are not supported? I can't think of a better kconfig symbol over here but since Sparc does not have MSI properties, I think following is better: if (IS_ENABLED(CONFIG_SPARC)) return NULL; Any other suggestions ? Regards, Anup > > > + > > + if (strcmp(prop_name, "msi-parent")) > > + return NULL; > > + > > + msi_np = of_parse_phandle(np, prop_name, 0); > > + if (msi_np) { > > + if (!of_property_read_bool(msi_np, "#msi-cells")) { > > + if (index) { > > + of_node_put(msi_np); > > + return NULL; > > + } > > + return msi_np; > > + } > > + of_node_put(msi_np); > > + } > > + > > + if (of_parse_phandle_with_args(np, prop_name, "#msi-cells", index, > > + &sup_args)) > > + return NULL; > > + > > + return sup_args.np; > > +} > > + > > static const struct supplier_bindings of_supplier_bindings[] = { > > { .parse_prop = parse_clocks, }, > > { .parse_prop = parse_interconnects, }, > > @@ -1359,6 +1390,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > > { .parse_prop = parse_regulators, }, > > { .parse_prop = parse_gpio, }, > > { .parse_prop = parse_gpios, }, > > + { .parse_prop = parse_msi_parent, }, > > {} > > }; > > > > -- > > 2.34.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Anup Patel <apatel@ventanamicro.com> To: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>, Saravana Kannan <saravanak@google.com>, Marc Zyngier <maz@kernel.org>, Anup Patel <anup@brainfault.org>, Atish Patra <atishp@atishpatra.org>, linux-kernel@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Thomas Gleixner <tglx@linutronix.de>, Frank Rowand <frowand.list@gmail.com>, linux-riscv@lists.infradead.org, Andrew Jones <ajones@ventanamicro.com> Subject: Re: [PATCH v6 02/14] of: property: Add fw_devlink support for msi-parent Date: Thu, 20 Jul 2023 17:25:03 +0530 [thread overview] Message-ID: <CAK9=C2Ui3H8jOXZbSd_CCmtxVLWR=-JrTDK8kDbrLhJ4uUi+9g@mail.gmail.com> (raw) In-Reply-To: <20230719223758.GA892809-robh@kernel.org> On Thu, Jul 20, 2023 at 4:08 AM Rob Herring <robh@kernel.org> wrote: > > On Wed, Jul 19, 2023 at 05:05:30PM +0530, Anup Patel wrote: > > This allows fw_devlink to create device links between consumers of > > a MSI and the supplier of the MSI. > > > > Signed-off-by: Anup Patel <apatel@ventanamicro.com> > > --- > > drivers/of/property.c | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index ddc75cd50825..e4096b79a872 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1325,6 +1325,37 @@ static struct device_node *parse_interrupts(struct device_node *np, > > return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.np; > > } > > > > +static struct device_node *parse_msi_parent(struct device_node *np, > > + const char *prop_name, int index) > > +{ > > + struct of_phandle_args sup_args; > > + struct device_node *msi_np; > > + > > + if (!IS_ENABLED(CONFIG_OF_IRQ)) > > + return NULL; > > Why do we need this? Sparc is not going to have MSI properties to begin > with. I guess it saves a little bit of code. Though Sparc doesn't need > any of this file. Or maybe there's a better kconfig symbol to use here > if MSIs are not supported? I can't think of a better kconfig symbol over here but since Sparc does not have MSI properties, I think following is better: if (IS_ENABLED(CONFIG_SPARC)) return NULL; Any other suggestions ? Regards, Anup > > > + > > + if (strcmp(prop_name, "msi-parent")) > > + return NULL; > > + > > + msi_np = of_parse_phandle(np, prop_name, 0); > > + if (msi_np) { > > + if (!of_property_read_bool(msi_np, "#msi-cells")) { > > + if (index) { > > + of_node_put(msi_np); > > + return NULL; > > + } > > + return msi_np; > > + } > > + of_node_put(msi_np); > > + } > > + > > + if (of_parse_phandle_with_args(np, prop_name, "#msi-cells", index, > > + &sup_args)) > > + return NULL; > > + > > + return sup_args.np; > > +} > > + > > static const struct supplier_bindings of_supplier_bindings[] = { > > { .parse_prop = parse_clocks, }, > > { .parse_prop = parse_interconnects, }, > > @@ -1359,6 +1390,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > > { .parse_prop = parse_regulators, }, > > { .parse_prop = parse_gpio, }, > > { .parse_prop = parse_gpios, }, > > + { .parse_prop = parse_msi_parent, }, > > {} > > }; > > > > -- > > 2.34.1 > > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-20 11:55 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-19 11:35 [PATCH v6 00/14] Linux RISC-V AIA Support Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 01/14] RISC-V: Add riscv_get_intc_hartid() function Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 02/14] of: property: Add fw_devlink support for msi-parent Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 22:25 ` Saravana Kannan 2023-07-19 22:25 ` Saravana Kannan 2023-07-20 5:21 ` Anup Patel 2023-07-20 5:21 ` Anup Patel 2023-07-19 22:37 ` Rob Herring 2023-07-19 22:37 ` Rob Herring 2023-07-20 11:55 ` Anup Patel [this message] 2023-07-20 11:55 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 03/14] drivers: irqchip/riscv-intc: Mark all INTC nodes as initialized Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 22:14 ` Saravana Kannan 2023-07-19 22:14 ` Saravana Kannan 2023-07-20 5:21 ` Anup Patel 2023-07-20 5:21 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 04/14] irqchip/sifive-plic: Use platform driver probing for PLIC Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-27 8:41 ` Sunil V L 2023-07-27 8:41 ` Sunil V L 2023-08-02 12:25 ` Anup Patel 2023-08-02 12:25 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 05/14] irqchip/riscv-intc: Add support for RISC-V AIA Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 06/14] dt-bindings: interrupt-controller: Add RISC-V incoming MSI controller Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 07/14] irqchip: Add RISC-V incoming MSI controller early driver Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 08/14] irqchip/riscv-imsic: Add support for platform MSI irqdomain Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 09/14] irqchip/riscv-imsic: Add support for PCI " Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 10/14] dt-bindings: interrupt-controller: Add RISC-V advanced PLIC Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 11/14] irqchip: Add RISC-V advanced PLIC driver for direct-mode Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 12/14] irqchip/riscv-aplic: Add support for MSI-mode Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 13/14] RISC-V: Select APLIC and IMSIC drivers Anup Patel 2023-07-19 11:35 ` Anup Patel 2023-07-19 11:35 ` [PATCH v6 14/14] MAINTAINERS: Add entry for RISC-V AIA drivers Anup Patel 2023-07-19 11:35 ` Anup Patel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAK9=C2Ui3H8jOXZbSd_CCmtxVLWR=-JrTDK8kDbrLhJ4uUi+9g@mail.gmail.com' \ --to=apatel@ventanamicro.com \ --cc=ajones@ventanamicro.com \ --cc=anup@brainfault.org \ --cc=atishp@atishpatra.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=maz@kernel.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh@kernel.org \ --cc=saravanak@google.com \ --cc=sunilvl@ventanamicro.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.