All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: xuwei5@hisilicon.com, Rob Herring <robh+dt@kernel.org>,
	rob.herring@linaro.org, Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	xinliang.liu@linaro.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	jh80.chung@samsung.com, John Stultz <john.stultz@linaro.org>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Thu, 27 Oct 2016 15:56:59 +0200	[thread overview]
Message-ID: <CAKfTPtB0FtGbm4C5z+LJizrsHikKt_BGFti5XY+LN3w7zO1Vjw@mail.gmail.com> (raw)
In-Reply-To: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org>

Hi,

My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
have bisected the issue to this patch. Once reverted, the sdcard is
detected again.

Regards,
Vincent

On 25 August 2016 at 05:00, Guodong Xu <guodong.xu@linaro.org> wrote:
> Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220
>
> Code and documentation to this property were confirmed by maintainers.
> See:
> [1] https://patchwork.kernel.org/patch/9276607/
> [2] https://patchwork.kernel.org/patch/8487151/
> [3] https://lkml.org/lkml/2016/8/12/91
>
> cc: Jaehoon Chung <jh80.chung@samsung.com>
> cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index d0b887a..63608e9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -771,6 +771,7 @@
>                         interrupts = <0x0 0x48 0x4>;
>                         clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
>                         bus-width = <0x8>;
>                         vmmc-supply = <&ldo19>;
>                         pinctrl-names = "default";
> @@ -790,6 +791,7 @@
>                         #size-cells = <0x0>;
>                         clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
>                         vqmmc-supply = <&ldo7>;
>                         vmmc-supply = <&ldo10>;
>                         bus-width = <0x4>;
> @@ -807,6 +809,7 @@
>                         interrupts = <0x0 0x4a 0x4>;
>                         clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
>                         bus-width = <0x4>;
>                         broken-cd;
>                         pinctrl-names = "default", "idle";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	rob.herring@linaro.org,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	xinliang.liu@linaro.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	xuwei5@hisilicon.com, jh80.chung@samsung.com,
	Rob Herring <robh+dt@kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Thu, 27 Oct 2016 15:56:59 +0200	[thread overview]
Message-ID: <CAKfTPtB0FtGbm4C5z+LJizrsHikKt_BGFti5XY+LN3w7zO1Vjw@mail.gmail.com> (raw)
In-Reply-To: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org>

Hi,

My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
have bisected the issue to this patch. Once reverted, the sdcard is
detected again.

Regards,
Vincent

On 25 August 2016 at 05:00, Guodong Xu <guodong.xu@linaro.org> wrote:
> Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220
>
> Code and documentation to this property were confirmed by maintainers.
> See:
> [1] https://patchwork.kernel.org/patch/9276607/
> [2] https://patchwork.kernel.org/patch/8487151/
> [3] https://lkml.org/lkml/2016/8/12/91
>
> cc: Jaehoon Chung <jh80.chung@samsung.com>
> cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index d0b887a..63608e9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -771,6 +771,7 @@
>                         interrupts = <0x0 0x48 0x4>;
>                         clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
>                         bus-width = <0x8>;
>                         vmmc-supply = <&ldo19>;
>                         pinctrl-names = "default";
> @@ -790,6 +791,7 @@
>                         #size-cells = <0x0>;
>                         clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
>                         vqmmc-supply = <&ldo7>;
>                         vmmc-supply = <&ldo10>;
>                         bus-width = <0x4>;
> @@ -807,6 +809,7 @@
>                         interrupts = <0x0 0x4a 0x4>;
>                         clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
>                         bus-width = <0x4>;
>                         broken-cd;
>                         pinctrl-names = "default", "idle";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: vincent.guittot@linaro.org (Vincent Guittot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Thu, 27 Oct 2016 15:56:59 +0200	[thread overview]
Message-ID: <CAKfTPtB0FtGbm4C5z+LJizrsHikKt_BGFti5XY+LN3w7zO1Vjw@mail.gmail.com> (raw)
In-Reply-To: <1472094041-5357-2-git-send-email-guodong.xu@linaro.org>

Hi,

My hikey board failed to detect and mount sdcard with v4.9-rc1 and i
have bisected the issue to this patch. Once reverted, the sdcard is
detected again.

Regards,
Vincent

On 25 August 2016 at 05:00, Guodong Xu <guodong.xu@linaro.org> wrote:
> Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220
>
> Code and documentation to this property were confirmed by maintainers.
> See:
> [1] https://patchwork.kernel.org/patch/9276607/
> [2] https://patchwork.kernel.org/patch/8487151/
> [3] https://lkml.org/lkml/2016/8/12/91
>
> cc: Jaehoon Chung <jh80.chung@samsung.com>
> cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Guodong Xu <guodong.xu@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index d0b887a..63608e9 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -771,6 +771,7 @@
>                         interrupts = <0x0 0x48 0x4>;
>                         clocks = <&sys_ctrl 2>, <&sys_ctrl 1>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>;
>                         bus-width = <0x8>;
>                         vmmc-supply = <&ldo19>;
>                         pinctrl-names = "default";
> @@ -790,6 +791,7 @@
>                         #size-cells = <0x0>;
>                         clocks = <&sys_ctrl 4>, <&sys_ctrl 3>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>;
>                         vqmmc-supply = <&ldo7>;
>                         vmmc-supply = <&ldo10>;
>                         bus-width = <0x4>;
> @@ -807,6 +809,7 @@
>                         interrupts = <0x0 0x4a 0x4>;
>                         clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>;
>                         clock-names = "ciu", "biu";
> +                       resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>;
>                         bus-width = <0x4>;
>                         broken-cd;
>                         pinctrl-names = "default", "idle";
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2016-10-27 13:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  3:00 [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
2016-08-25  3:00 ` Guodong Xu
2016-08-25  3:00 ` Guodong Xu
2016-08-25  3:00 ` [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Guodong Xu
2016-08-25  3:00   ` Guodong Xu
2016-08-25  3:00   ` Guodong Xu
2016-10-27 13:56   ` Vincent Guittot [this message]
2016-10-27 13:56     ` Vincent Guittot
2016-10-27 13:56     ` Vincent Guittot
2016-10-27 20:23     ` John Stultz
2016-10-27 20:23       ` John Stultz
2016-10-27 20:23       ` John Stultz
2016-10-28  6:43       ` Vincent Guittot
2016-10-28  6:43         ` Vincent Guittot
2016-10-28  7:26         ` Leo Yan
2016-10-28  7:26           ` Leo Yan
2016-10-28  7:33           ` Jaehoon Chung
2016-10-28  7:33             ` Jaehoon Chung
2016-10-28  7:33             ` Jaehoon Chung
2016-10-28  7:38             ` Leo Yan
2016-10-28  7:38               ` Leo Yan
2016-10-28  9:43               ` Jaehoon Chung
2016-10-28  9:43                 ` Jaehoon Chung
2016-10-28  9:54                 ` Jaehoon Chung
2016-10-28  9:54                   ` Jaehoon Chung
2016-10-28  9:54                   ` Jaehoon Chung
2016-10-28 10:19                   ` Leo Yan
2016-10-28 10:19                     ` Leo Yan
2016-10-28 10:19                     ` Leo Yan
2016-10-28 11:52                     ` Jaehoon Chung
2016-10-28 11:52                       ` Jaehoon Chung
2016-10-28 12:34                       ` Leo Yan
2016-10-28 12:34                         ` Leo Yan
2016-10-28 21:12                         ` John Stultz
2016-10-28 21:12                           ` John Stultz
2016-10-28 21:12                           ` John Stultz
2016-08-30 15:56 ` [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Wei Xu
2016-08-30 15:56   ` Wei Xu
2016-08-30 15:56   ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKfTPtB0FtGbm4C5z+LJizrsHikKt_BGFti5XY+LN3w7zO1Vjw@mail.gmail.com \
    --to=vincent.guittot@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fathi.boudra@linaro.org \
    --cc=guodong.xu@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=xinliang.liu@linaro.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.