All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@linaro.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Guodong Xu <guodong.xu@linaro.org>, Wei Xu <xuwei5@hisilicon.com>,
	Rob Herring <robh+dt@kernel.org>,
	Rob Herring <rob.herring@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Xinliang Liu <xinliang.liu@linaro.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Fathi Boudra <fathi.boudra@linaro.org>,
	LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Fri, 28 Oct 2016 18:19:19 +0800	[thread overview]
Message-ID: <20161028101919.GA25564@leoy-linaro> (raw)
In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com>

On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:

[...]

> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> > 
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> > 
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
> 
> Could you check the below thing..
> 
>         /* find reset controller when exist */
> -       pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> +       pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>         if (IS_ERR(pdata->rstc)) {
>                 if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>                         return ERR_PTR(-EPROBE_DEFER);

Confirmed with this fixing, the kernel can bootup successfully.

Thanks for this.

> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
> 
> 
> Best Regards,
> Jaehoon Chung

WARNING: multiple messages have this Message-ID (diff)
From: Leo Yan <leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Jaehoon Chung <jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Vincent Guittot
	<vincent.guittot-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Guodong Xu <guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Wei Xu <xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Rob Herring <rob.herring-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Xinliang Liu
	<xinliang.liu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Fathi Boudra
	<fathi.boudra-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	LAK
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Fri, 28 Oct 2016 18:19:19 +0800	[thread overview]
Message-ID: <20161028101919.GA25564@leoy-linaro> (raw)
In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:

[...]

> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> > 
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> > 
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
> 
> Could you check the below thing..
> 
>         /* find reset controller when exist */
> -       pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> +       pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>         if (IS_ERR(pdata->rstc)) {
>                 if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>                         return ERR_PTR(-EPROBE_DEFER);

Confirmed with this fixing, the kernel can bootup successfully.

Thanks for this.

> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
> 
> 
> Best Regards,
> Jaehoon Chung
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Date: Fri, 28 Oct 2016 18:19:19 +0800	[thread overview]
Message-ID: <20161028101919.GA25564@leoy-linaro> (raw)
In-Reply-To: <95e22336-0465-f1e1-71b8-548d0e6ee8b7@samsung.com>

On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:

[...]

> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> > 
> > It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> > 
> > I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER..
> 
> Could you check the below thing..
> 
>         /* find reset controller when exist */
> -       pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> +       pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>         if (IS_ERR(pdata->rstc)) {
>                 if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>                         return ERR_PTR(-EPROBE_DEFER);

Confirmed with this fixing, the kernel can bootup successfully.

Thanks for this.

> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller?
> 
> 
> Best Regards,
> Jaehoon Chung

  reply	other threads:[~2016-10-28 10:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  3:00 [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu
2016-08-25  3:00 ` Guodong Xu
2016-08-25  3:00 ` Guodong Xu
2016-08-25  3:00 ` [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Guodong Xu
2016-08-25  3:00   ` Guodong Xu
2016-08-25  3:00   ` Guodong Xu
2016-10-27 13:56   ` Vincent Guittot
2016-10-27 13:56     ` Vincent Guittot
2016-10-27 13:56     ` Vincent Guittot
2016-10-27 20:23     ` John Stultz
2016-10-27 20:23       ` John Stultz
2016-10-27 20:23       ` John Stultz
2016-10-28  6:43       ` Vincent Guittot
2016-10-28  6:43         ` Vincent Guittot
2016-10-28  7:26         ` Leo Yan
2016-10-28  7:26           ` Leo Yan
2016-10-28  7:33           ` Jaehoon Chung
2016-10-28  7:33             ` Jaehoon Chung
2016-10-28  7:33             ` Jaehoon Chung
2016-10-28  7:38             ` Leo Yan
2016-10-28  7:38               ` Leo Yan
2016-10-28  9:43               ` Jaehoon Chung
2016-10-28  9:43                 ` Jaehoon Chung
2016-10-28  9:54                 ` Jaehoon Chung
2016-10-28  9:54                   ` Jaehoon Chung
2016-10-28  9:54                   ` Jaehoon Chung
2016-10-28 10:19                   ` Leo Yan [this message]
2016-10-28 10:19                     ` Leo Yan
2016-10-28 10:19                     ` Leo Yan
2016-10-28 11:52                     ` Jaehoon Chung
2016-10-28 11:52                       ` Jaehoon Chung
2016-10-28 12:34                       ` Leo Yan
2016-10-28 12:34                         ` Leo Yan
2016-10-28 21:12                         ` John Stultz
2016-10-28 21:12                           ` John Stultz
2016-10-28 21:12                           ` John Stultz
2016-08-30 15:56 ` [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Wei Xu
2016-08-30 15:56   ` Wei Xu
2016-08-30 15:56   ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028101919.GA25564@leoy-linaro \
    --to=leo.yan@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fathi.boudra@linaro.org \
    --cc=guodong.xu@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=will.deacon@arm.com \
    --cc=xinliang.liu@linaro.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.