From: Jaehoon Chung <jh80.chung@samsung.com> To: Leo Yan <leo.yan@linaro.org> Cc: Vincent Guittot <vincent.guittot@linaro.org>, John Stultz <john.stultz@linaro.org>, Guodong Xu <guodong.xu@linaro.org>, Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>, Rob Herring <rob.herring@linaro.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Xinliang Liu <xinliang.liu@linaro.org>, linux-kernel <linux-kernel@vger.kernel.org>, Fathi Boudra <fathi.boudra@linaro.org>, LAK <linux-arm-kernel@lists.infradead.org>, Ulf Hansson <ulf.hansson@linaro.org> Subject: Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Date: Fri, 28 Oct 2016 20:52:49 +0900 [thread overview] Message-ID: <f5dfafbb-39df-4edb-03b8-57c0e34c912f@samsung.com> (raw) In-Reply-To: <20161028101919.GA25564@leoy-linaro> Hi, On 10/28/2016 07:19 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: > > [...] > >>>>> Could you share the log? Is there any log about failure? >>>> >>>> Sure, please see below log: >>> >>> It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. >>> Maybe hi6220 has handled the reset controller(?)... >>> >>> I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. >> >> Could you check the below thing.. >> >> /* find reset controller when exist */ >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL); >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset"); >> if (IS_ERR(pdata->rstc)) { >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER) >> return ERR_PTR(-EPROBE_DEFER); > > Confirmed with this fixing, the kernel can bootup successfully. > > Thanks for this. Thanks for checking this..If this approach is not bad, i will send the patch. Or if there are other good approaches, let me know, plz. Best Regards, Jaehoon Chung > >> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller? >> >> >> Best Regards, >> Jaehoon Chung > > >
WARNING: multiple messages have this Message-ID (diff)
From: jh80.chung@samsung.com (Jaehoon Chung) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Date: Fri, 28 Oct 2016 20:52:49 +0900 [thread overview] Message-ID: <f5dfafbb-39df-4edb-03b8-57c0e34c912f@samsung.com> (raw) In-Reply-To: <20161028101919.GA25564@leoy-linaro> Hi, On 10/28/2016 07:19 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote: > > [...] > >>>>> Could you share the log? Is there any log about failure? >>>> >>>> Sure, please see below log: >>> >>> It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. >>> Maybe hi6220 has handled the reset controller(?)... >>> >>> I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. >> >> Could you check the below thing.. >> >> /* find reset controller when exist */ >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL); >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset"); >> if (IS_ERR(pdata->rstc)) { >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER) >> return ERR_PTR(-EPROBE_DEFER); > > Confirmed with this fixing, the kernel can bootup successfully. > > Thanks for this. Thanks for checking this..If this approach is not bad, i will send the patch. Or if there are other good approaches, let me know, plz. Best Regards, Jaehoon Chung > >> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc controller? >> >> >> Best Regards, >> Jaehoon Chung > > >
next prev parent reply other threads:[~2016-10-28 11:53 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-25 3:00 [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Guodong Xu 2016-08-25 3:00 ` Guodong Xu 2016-08-25 3:00 ` Guodong Xu 2016-08-25 3:00 ` [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes Guodong Xu 2016-08-25 3:00 ` Guodong Xu 2016-08-25 3:00 ` Guodong Xu 2016-10-27 13:56 ` Vincent Guittot 2016-10-27 13:56 ` Vincent Guittot 2016-10-27 13:56 ` Vincent Guittot 2016-10-27 20:23 ` John Stultz 2016-10-27 20:23 ` John Stultz 2016-10-27 20:23 ` John Stultz 2016-10-28 6:43 ` Vincent Guittot 2016-10-28 6:43 ` Vincent Guittot 2016-10-28 7:26 ` Leo Yan 2016-10-28 7:26 ` Leo Yan 2016-10-28 7:33 ` Jaehoon Chung 2016-10-28 7:33 ` Jaehoon Chung 2016-10-28 7:33 ` Jaehoon Chung 2016-10-28 7:38 ` Leo Yan 2016-10-28 7:38 ` Leo Yan 2016-10-28 9:43 ` Jaehoon Chung 2016-10-28 9:43 ` Jaehoon Chung 2016-10-28 9:54 ` Jaehoon Chung 2016-10-28 9:54 ` Jaehoon Chung 2016-10-28 9:54 ` Jaehoon Chung 2016-10-28 10:19 ` Leo Yan 2016-10-28 10:19 ` Leo Yan 2016-10-28 10:19 ` Leo Yan 2016-10-28 11:52 ` Jaehoon Chung [this message] 2016-10-28 11:52 ` Jaehoon Chung 2016-10-28 12:34 ` Leo Yan 2016-10-28 12:34 ` Leo Yan 2016-10-28 21:12 ` John Stultz 2016-10-28 21:12 ` John Stultz 2016-10-28 21:12 ` John Stultz 2016-08-30 15:56 ` [PATCH v2 1/2] arm64: dts: hikey: extend default cma size to 128MB Wei Xu 2016-08-30 15:56 ` Wei Xu 2016-08-30 15:56 ` Wei Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f5dfafbb-39df-4edb-03b8-57c0e34c912f@samsung.com \ --to=jh80.chung@samsung.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=fathi.boudra@linaro.org \ --cc=guodong.xu@linaro.org \ --cc=john.stultz@linaro.org \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=rob.herring@linaro.org \ --cc=robh+dt@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=vincent.guittot@linaro.org \ --cc=will.deacon@arm.com \ --cc=xinliang.liu@linaro.org \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.