From: Vincent Guittot <vincent.guittot@linaro.org> To: Tony Lindgren <tony@atomide.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, Ulf Hansson <ulf.hansson@linaro.org>, "open list:THERMAL" <linux-pm@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>, LAK <linux-arm-kernel@lists.infradead.org>, Linux OMAP Mailing List <linux-omap@vger.kernel.org>, Ladislav Michl <ladis@linux-mips.org> Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers Date: Wed, 9 Jan 2019 17:48:23 +0100 [thread overview] Message-ID: <CAKfTPtBzE9fqDgUOJ4uTj_Dtfe2KCp+R4FajAaQqpV02upQZJA@mail.gmail.com> (raw) In-Reply-To: <20190109162846.GP5544@atomide.com> On Wed, 9 Jan 2019 at 17:28, Tony Lindgren <tony@atomide.com> wrote: > > * Rafael J. Wysocki <rafael@kernel.org> [190109 09:44]: > > On Wed, Jan 9, 2019 at 2:51 AM Tony Lindgren <tony@atomide.com> wrote: > > > > > > * Vincent Guittot <vincent.guittot@linaro.org> [190109 01:42]: > > > > Le Tuesday 08 Jan 2019 à 13:37:43 (-0800), Tony Lindgren a écrit : > > > > > Lowering the autosuspend_delay_ms to 2100 ms makes things work again. > > > > > Anything higher than 2200 ms seems to somehow time out immediately > > > > > now :) > > > > > > > > This is quite close to the max ns of an int on arm 32bits > > > > > > > > Could you try the patch below ? > > > > > > Yup great thanks, that's it: > > > > > > Tested-by: Tony Lindgren <tony@atomide.com> > > > > Cool. Thanks for getting to the bottom of this! > > No problem. > > One more thing I noticed: The 25% slack can get noticeable > for larger values. For things like a 3 second uart console > timeout slack of 750 ms is quite large variation. > > Should we have a limit of max 100 ms for the slack? Keep in mind that when jiffies were used, expires was rounded to a full second when delay was greater than a second. So you could already have difference of up 990ms on arm before this patch And i don't take into account the rework of timer infra which add another level of variation, something like up to 640 ms more when the timer is greater than 2880 ms for arm IIRC > > Regards, > > Tony
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Guittot <vincent.guittot@linaro.org> To: Tony Lindgren <tony@atomide.com> Cc: Ulf Hansson <ulf.hansson@linaro.org>, Ladislav Michl <ladis@linux-mips.org>, "open list:THERMAL" <linux-pm@vger.kernel.org>, "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>, linux-kernel <linux-kernel@vger.kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Linux OMAP Mailing List <linux-omap@vger.kernel.org>, LAK <linux-arm-kernel@lists.infradead.org> Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers Date: Wed, 9 Jan 2019 17:48:23 +0100 [thread overview] Message-ID: <CAKfTPtBzE9fqDgUOJ4uTj_Dtfe2KCp+R4FajAaQqpV02upQZJA@mail.gmail.com> (raw) In-Reply-To: <20190109162846.GP5544@atomide.com> On Wed, 9 Jan 2019 at 17:28, Tony Lindgren <tony@atomide.com> wrote: > > * Rafael J. Wysocki <rafael@kernel.org> [190109 09:44]: > > On Wed, Jan 9, 2019 at 2:51 AM Tony Lindgren <tony@atomide.com> wrote: > > > > > > * Vincent Guittot <vincent.guittot@linaro.org> [190109 01:42]: > > > > Le Tuesday 08 Jan 2019 à 13:37:43 (-0800), Tony Lindgren a écrit : > > > > > Lowering the autosuspend_delay_ms to 2100 ms makes things work again. > > > > > Anything higher than 2200 ms seems to somehow time out immediately > > > > > now :) > > > > > > > > This is quite close to the max ns of an int on arm 32bits > > > > > > > > Could you try the patch below ? > > > > > > Yup great thanks, that's it: > > > > > > Tested-by: Tony Lindgren <tony@atomide.com> > > > > Cool. Thanks for getting to the bottom of this! > > No problem. > > One more thing I noticed: The 25% slack can get noticeable > for larger values. For things like a 3 second uart console > timeout slack of 750 ms is quite large variation. > > Should we have a limit of max 100 ms for the slack? Keep in mind that when jiffies were used, expires was rounded to a full second when delay was greater than a second. So you could already have difference of up 990ms on arm before this patch And i don't take into account the rework of timer infra which add another level of variation, something like up to 640 ms more when the timer is greater than 2880 ms for arm IIRC > > Regards, > > Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-09 16:48 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-07 23:38 Regression in v5.0-rc1 with autosuspend hrtimers Tony Lindgren 2019-01-07 23:38 ` Tony Lindgren 2019-01-08 7:59 ` Vincent Guittot 2019-01-08 7:59 ` Vincent Guittot 2019-01-08 15:53 ` Tony Lindgren 2019-01-08 15:53 ` Tony Lindgren 2019-01-08 16:42 ` Vincent Guittot 2019-01-08 16:42 ` Vincent Guittot 2019-01-08 21:37 ` Tony Lindgren 2019-01-08 21:37 ` Tony Lindgren 2019-01-09 1:42 ` Vincent Guittot 2019-01-09 1:42 ` Vincent Guittot 2019-01-09 1:51 ` Tony Lindgren 2019-01-09 1:51 ` Tony Lindgren 2019-01-09 9:43 ` Rafael J. Wysocki 2019-01-09 9:43 ` Rafael J. Wysocki 2019-01-09 16:28 ` Tony Lindgren 2019-01-09 16:28 ` Tony Lindgren 2019-01-09 16:48 ` Vincent Guittot [this message] 2019-01-09 16:48 ` Vincent Guittot 2019-01-09 16:50 ` Tony Lindgren 2019-01-09 16:50 ` Tony Lindgren 2019-01-09 16:55 ` Vincent Guittot 2019-01-09 16:55 ` Vincent Guittot 2019-01-09 17:02 ` Tony Lindgren 2019-01-09 17:02 ` Tony Lindgren 2019-01-09 11:17 ` Ladislav Michl 2019-01-09 11:17 ` Ladislav Michl 2019-01-09 11:27 ` Vincent Guittot 2019-01-09 11:27 ` Vincent Guittot [not found] ` <20190109115824.GA1353@lenoch> 2019-01-09 13:24 ` Vincent Guittot 2019-01-09 13:24 ` Vincent Guittot [not found] ` <20190109133337.GA13579@lenoch> 2019-01-09 14:12 ` Vincent Guittot 2019-01-09 14:12 ` Vincent Guittot 2019-01-09 16:07 ` Ladislav Michl 2019-01-09 16:07 ` Ladislav Michl 2019-01-09 16:32 ` Vincent Guittot 2019-01-09 16:32 ` Vincent Guittot 2019-01-09 17:26 ` Ladislav Michl 2019-01-09 17:26 ` Ladislav Michl 2019-01-09 18:04 ` Vincent Guittot 2019-01-09 18:04 ` Vincent Guittot 2019-01-09 22:06 ` Rafael J. Wysocki 2019-01-09 22:06 ` Rafael J. Wysocki 2019-01-10 7:45 ` Ladislav Michl 2019-01-10 7:45 ` Ladislav Michl 2019-01-10 7:50 ` Vincent Guittot 2019-01-10 7:50 ` Vincent Guittot 2019-01-10 7:54 ` Ladislav Michl 2019-01-10 7:54 ` Ladislav Michl
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKfTPtBzE9fqDgUOJ4uTj_Dtfe2KCp+R4FajAaQqpV02upQZJA@mail.gmail.com \ --to=vincent.guittot@linaro.org \ --cc=ladis@linux-mips.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=rafael@kernel.org \ --cc=tony@atomide.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.