From: Vincent Guittot <vincent.guittot@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
LAK <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org
Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers
Date: Tue, 8 Jan 2019 17:42:09 +0100 [thread overview]
Message-ID: <CAKfTPtCoOK-cYLXJ--sOfpVa9RVmzOAEN1+zB2qHMCzkJN0qaQ@mail.gmail.com> (raw)
In-Reply-To: <20190108155354.GL5544@atomide.com>
On Tue, 8 Jan 2019 at 16:53, Tony Lindgren <tony@atomide.com> wrote:
>
> * Vincent Guittot <vincent.guittot@linaro.org> [190108 08:00]:
> > Hi Tony,
> >
> > On Tue, 8 Jan 2019 at 00:38, Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > Hi all,
> > >
> > > Looks like commit 8234f6734c5d ("PM-runtime: Switch autosuspend
> > > over to using hrtimers") caused a regression on at least
> > > omap5-uevm where 8250 UART rx wake no longer works. I have not
> > > noticed this happening on others so far.
> > >
> > > The devices I've tested all are using 8250 with dedicated
> > > wakeirqs configured for the rx pin. I can see the interrupt
> > > increase on omap5-uevm after some one or more keypresses,
> > > but then nothing. It seems that the uart just falls back
> > > asleep right away or something.
> > >
> > > Any ideas what might be going wrong?
> >
> > What is the autosuspend value ? Can it be that the autosuspend is set
> > to a short value but was finally greater than 10-20ms on arm32. And
> > now the autosuspend happens before and this has changed the sequence ?
>
> It's set to 3 seconds. The difference between let's say
> C-A9 pandaboard (that is working) compared to C-A15 omap5-uevm
> is that the C-A15 has arch_timer in use. Other than that things
> should behave more or less the same way.
>
> Hmm so could it be that we now rely on timers that that may
> not be capable of waking up the system from idle states with
> hrtimer?
With nohz and hrtimer enabled, timer relies on hrtimer to generate
the tick so you should use the same interrupt.
>
> Regards,
>
> Tony
>
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Guittot <vincent.guittot@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org,
LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: Regression in v5.0-rc1 with autosuspend hrtimers
Date: Tue, 8 Jan 2019 17:42:09 +0100 [thread overview]
Message-ID: <CAKfTPtCoOK-cYLXJ--sOfpVa9RVmzOAEN1+zB2qHMCzkJN0qaQ@mail.gmail.com> (raw)
In-Reply-To: <20190108155354.GL5544@atomide.com>
On Tue, 8 Jan 2019 at 16:53, Tony Lindgren <tony@atomide.com> wrote:
>
> * Vincent Guittot <vincent.guittot@linaro.org> [190108 08:00]:
> > Hi Tony,
> >
> > On Tue, 8 Jan 2019 at 00:38, Tony Lindgren <tony@atomide.com> wrote:
> > >
> > > Hi all,
> > >
> > > Looks like commit 8234f6734c5d ("PM-runtime: Switch autosuspend
> > > over to using hrtimers") caused a regression on at least
> > > omap5-uevm where 8250 UART rx wake no longer works. I have not
> > > noticed this happening on others so far.
> > >
> > > The devices I've tested all are using 8250 with dedicated
> > > wakeirqs configured for the rx pin. I can see the interrupt
> > > increase on omap5-uevm after some one or more keypresses,
> > > but then nothing. It seems that the uart just falls back
> > > asleep right away or something.
> > >
> > > Any ideas what might be going wrong?
> >
> > What is the autosuspend value ? Can it be that the autosuspend is set
> > to a short value but was finally greater than 10-20ms on arm32. And
> > now the autosuspend happens before and this has changed the sequence ?
>
> It's set to 3 seconds. The difference between let's say
> C-A9 pandaboard (that is working) compared to C-A15 omap5-uevm
> is that the C-A15 has arch_timer in use. Other than that things
> should behave more or less the same way.
>
> Hmm so could it be that we now rely on timers that that may
> not be capable of waking up the system from idle states with
> hrtimer?
With nohz and hrtimer enabled, timer relies on hrtimer to generate
the tick so you should use the same interrupt.
>
> Regards,
>
> Tony
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-08 16:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:38 Regression in v5.0-rc1 with autosuspend hrtimers Tony Lindgren
2019-01-07 23:38 ` Tony Lindgren
2019-01-08 7:59 ` Vincent Guittot
2019-01-08 7:59 ` Vincent Guittot
2019-01-08 15:53 ` Tony Lindgren
2019-01-08 15:53 ` Tony Lindgren
2019-01-08 16:42 ` Vincent Guittot [this message]
2019-01-08 16:42 ` Vincent Guittot
2019-01-08 21:37 ` Tony Lindgren
2019-01-08 21:37 ` Tony Lindgren
2019-01-09 1:42 ` Vincent Guittot
2019-01-09 1:42 ` Vincent Guittot
2019-01-09 1:51 ` Tony Lindgren
2019-01-09 1:51 ` Tony Lindgren
2019-01-09 9:43 ` Rafael J. Wysocki
2019-01-09 9:43 ` Rafael J. Wysocki
2019-01-09 16:28 ` Tony Lindgren
2019-01-09 16:28 ` Tony Lindgren
2019-01-09 16:48 ` Vincent Guittot
2019-01-09 16:48 ` Vincent Guittot
2019-01-09 16:50 ` Tony Lindgren
2019-01-09 16:50 ` Tony Lindgren
2019-01-09 16:55 ` Vincent Guittot
2019-01-09 16:55 ` Vincent Guittot
2019-01-09 17:02 ` Tony Lindgren
2019-01-09 17:02 ` Tony Lindgren
2019-01-09 11:17 ` Ladislav Michl
2019-01-09 11:17 ` Ladislav Michl
2019-01-09 11:27 ` Vincent Guittot
2019-01-09 11:27 ` Vincent Guittot
[not found] ` <20190109115824.GA1353@lenoch>
2019-01-09 13:24 ` Vincent Guittot
2019-01-09 13:24 ` Vincent Guittot
[not found] ` <20190109133337.GA13579@lenoch>
2019-01-09 14:12 ` Vincent Guittot
2019-01-09 14:12 ` Vincent Guittot
2019-01-09 16:07 ` Ladislav Michl
2019-01-09 16:07 ` Ladislav Michl
2019-01-09 16:32 ` Vincent Guittot
2019-01-09 16:32 ` Vincent Guittot
2019-01-09 17:26 ` Ladislav Michl
2019-01-09 17:26 ` Ladislav Michl
2019-01-09 18:04 ` Vincent Guittot
2019-01-09 18:04 ` Vincent Guittot
2019-01-09 22:06 ` Rafael J. Wysocki
2019-01-09 22:06 ` Rafael J. Wysocki
2019-01-10 7:45 ` Ladislav Michl
2019-01-10 7:45 ` Ladislav Michl
2019-01-10 7:50 ` Vincent Guittot
2019-01-10 7:50 ` Vincent Guittot
2019-01-10 7:54 ` Ladislav Michl
2019-01-10 7:54 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtCoOK-cYLXJ--sOfpVa9RVmzOAEN1+zB2qHMCzkJN0qaQ@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.