From: Alistair Francis <alistair23@gmail.com> To: "Philippe Mathieu-Daudé" <f4bug@amsat.org> Cc: "Paul Burton" <pburton@wavecomp.com>, "Sagar Karandikar" <sagark@eecs.berkeley.edu>, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Alistair Francis" <Alistair.Francis@wdc.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Peter Maydell" <peter.maydell@linaro.org>, "Markus Armbruster" <armbru@redhat.com>, "Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>, "open list:New World" <qemu-ppc@nongnu.org>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Richard Henderson" <rth@twiddle.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, "Alistair Francis" <alistair@alistair23.me>, qemu-arm <qemu-arm@nongnu.org>, "David Gibson" <david@gibson.dropbear.id.au>, "open list:RISC-V" <qemu-riscv@nongnu.org>, "Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>, "Andrew Baumann" <Andrew.Baumann@microsoft.com>, "Jean-Christophe Dubois" <jcd@tribudubois.net>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net> Subject: Re: [PATCH-for-5.0 06/12] hw/dma/xilinx_axidma: Add missing error-propagation code Date: Wed, 25 Mar 2020 13:52:06 -0700 [thread overview] Message-ID: <CAKmqyKNqYcTkxi8S56quu2L19+B73XNEzdFe44D1cNBFvjDPCQ@mail.gmail.com> (raw) In-Reply-To: <20200325191830.16553-7-f4bug@amsat.org> On Wed, Mar 25, 2020 at 12:24 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \ > --keep-comments --smpl-spacing --dir hw > > [[manual check required: error_propagate() might be missing in object_property_set_link() hw//dma/xilinx_axidma.c:542:4]] > > Add the missing error_propagate() after manual review. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/dma/xilinx_axidma.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c > index 018f36991b..6e3406321c 100644 > --- a/hw/dma/xilinx_axidma.c > +++ b/hw/dma/xilinx_axidma.c > @@ -521,39 +521,42 @@ static const MemoryRegionOps axidma_ops = { > static void xilinx_axidma_realize(DeviceState *dev, Error **errp) > { > XilinxAXIDMA *s = XILINX_AXI_DMA(dev); > XilinxAXIDMAStreamSlave *ds = XILINX_AXI_DMA_DATA_STREAM(&s->rx_data_dev); > XilinxAXIDMAStreamSlave *cs = XILINX_AXI_DMA_CONTROL_STREAM( > &s->rx_control_dev); > Error *local_err = NULL; > > object_property_add_link(OBJECT(ds), "dma", TYPE_XILINX_AXI_DMA, > (Object **)&ds->dma, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG, > &local_err); > object_property_add_link(OBJECT(cs), "dma", TYPE_XILINX_AXI_DMA, > (Object **)&cs->dma, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG, > &local_err); > if (local_err) { > goto xilinx_axidma_realize_fail; > } > object_property_set_link(OBJECT(ds), OBJECT(s), "dma", &local_err); > + if (local_err) { > + goto xilinx_axidma_realize_fail; > + } > object_property_set_link(OBJECT(cs), OBJECT(s), "dma", &local_err); > if (local_err) { > goto xilinx_axidma_realize_fail; > } > > int i; > > for (i = 0; i < 2; i++) { > struct Stream *st = &s->streams[i]; > > st->nr = i; > st->ptimer = ptimer_init(timer_hit, st, PTIMER_POLICY_DEFAULT); > ptimer_transaction_begin(st->ptimer); > ptimer_set_freq(st->ptimer, s->freqhz); > ptimer_transaction_commit(st->ptimer); > } > return; > -- > 2.21.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com> To: "Philippe Mathieu-Daudé" <f4bug@amsat.org> Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, "Paul Burton" <pburton@wavecomp.com>, "Sagar Karandikar" <sagark@eecs.berkeley.edu>, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>, "Alistair Francis" <Alistair.Francis@wdc.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Peter Maydell" <peter.maydell@linaro.org>, "Markus Armbruster" <armbru@redhat.com>, "Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>, "Palmer Dabbelt" <palmer@dabbelt.com>, "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>, "Richard Henderson" <rth@twiddle.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Eduardo Habkost" <ehabkost@redhat.com>, "Alistair Francis" <alistair@alistair23.me>, qemu-arm <qemu-arm@nongnu.org>, "David Gibson" <david@gibson.dropbear.id.au>, "open list:RISC-V" <qemu-riscv@nongnu.org>, "Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>, "Andrew Baumann" <Andrew.Baumann@microsoft.com>, "Jean-Christophe Dubois" <jcd@tribudubois.net>, "open list:New World" <qemu-ppc@nongnu.org>, "Paolo Bonzini" <pbonzini@redhat.com>, "Aurelien Jarno" <aurelien@aurel32.net> Subject: Re: [PATCH-for-5.0 06/12] hw/dma/xilinx_axidma: Add missing error-propagation code Date: Wed, 25 Mar 2020 13:52:06 -0700 [thread overview] Message-ID: <CAKmqyKNqYcTkxi8S56quu2L19+B73XNEzdFe44D1cNBFvjDPCQ@mail.gmail.com> (raw) In-Reply-To: <20200325191830.16553-7-f4bug@amsat.org> On Wed, Mar 25, 2020 at 12:24 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/object_property_missing_error_propagate.cocci \ > --keep-comments --smpl-spacing --dir hw > > [[manual check required: error_propagate() might be missing in object_property_set_link() hw//dma/xilinx_axidma.c:542:4]] > > Add the missing error_propagate() after manual review. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/dma/xilinx_axidma.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/dma/xilinx_axidma.c b/hw/dma/xilinx_axidma.c > index 018f36991b..6e3406321c 100644 > --- a/hw/dma/xilinx_axidma.c > +++ b/hw/dma/xilinx_axidma.c > @@ -521,39 +521,42 @@ static const MemoryRegionOps axidma_ops = { > static void xilinx_axidma_realize(DeviceState *dev, Error **errp) > { > XilinxAXIDMA *s = XILINX_AXI_DMA(dev); > XilinxAXIDMAStreamSlave *ds = XILINX_AXI_DMA_DATA_STREAM(&s->rx_data_dev); > XilinxAXIDMAStreamSlave *cs = XILINX_AXI_DMA_CONTROL_STREAM( > &s->rx_control_dev); > Error *local_err = NULL; > > object_property_add_link(OBJECT(ds), "dma", TYPE_XILINX_AXI_DMA, > (Object **)&ds->dma, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG, > &local_err); > object_property_add_link(OBJECT(cs), "dma", TYPE_XILINX_AXI_DMA, > (Object **)&cs->dma, > object_property_allow_set_link, > OBJ_PROP_LINK_STRONG, > &local_err); > if (local_err) { > goto xilinx_axidma_realize_fail; > } > object_property_set_link(OBJECT(ds), OBJECT(s), "dma", &local_err); > + if (local_err) { > + goto xilinx_axidma_realize_fail; > + } > object_property_set_link(OBJECT(cs), OBJECT(s), "dma", &local_err); > if (local_err) { > goto xilinx_axidma_realize_fail; > } > > int i; > > for (i = 0; i < 2; i++) { > struct Stream *st = &s->streams[i]; > > st->nr = i; > st->ptimer = ptimer_init(timer_hit, st, PTIMER_POLICY_DEFAULT); > ptimer_transaction_begin(st->ptimer); > ptimer_set_freq(st->ptimer, s->freqhz); > ptimer_transaction_commit(st->ptimer); > } > return; > -- > 2.21.1 > >
next prev parent reply other threads:[~2020-03-25 21:02 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-25 19:18 [PATCH-for-5.0 00/12] hw: Add missing error-propagation code Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 19:18 ` [PATCH-for-5.0 01/12] scripts/coccinelle: Add script to catch missing error_propagate() calls Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:32 ` Peter Maydell 2020-03-26 21:32 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 02/12] hw/arm/bcm2835_peripherals: Add missing error-propagation code Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:34 ` Peter Maydell 2020-03-26 21:34 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 03/12] hw/arm/fsl-imx: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:35 ` Peter Maydell 2020-03-26 21:35 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 04/12] hw/arm/stm32fx05_soc: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 20:51 ` Alistair Francis 2020-03-25 20:51 ` Alistair Francis 2020-03-26 21:45 ` Peter Maydell 2020-03-26 21:45 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 05/12] hw/i386/x86: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:38 ` Peter Maydell 2020-03-26 21:38 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 06/12] hw/dma/xilinx_axidma: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 20:52 ` Alistair Francis [this message] 2020-03-25 20:52 ` Alistair Francis 2020-03-26 21:46 ` Peter Maydell 2020-03-26 21:46 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 07/12] hw/mips/cps: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:43 ` Peter Maydell 2020-03-26 21:43 ` Peter Maydell 2020-03-26 22:48 ` Aleksandar Markovic 2020-03-26 22:48 ` Aleksandar Markovic 2020-03-25 19:18 ` [PATCH-for-5.0 08/12] hw/mips/boston: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:47 ` Peter Maydell 2020-03-26 21:47 ` Peter Maydell 2020-03-26 22:50 ` Aleksandar Markovic 2020-03-26 22:50 ` Aleksandar Markovic 2020-03-25 19:18 ` [PATCH-for-5.0 09/12] hw/mips/mips_malta: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-26 21:49 ` Peter Maydell 2020-03-26 21:49 ` Peter Maydell 2020-03-26 22:49 ` Aleksandar Markovic 2020-03-26 22:49 ` Aleksandar Markovic 2020-03-25 19:18 ` [PATCH-for-5.0 10/12] hw/misc/macio/macio: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 23:55 ` David Gibson 2020-03-25 23:55 ` David Gibson 2020-03-26 21:50 ` Peter Maydell 2020-03-26 21:50 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 11/12] hw/net/xilinx_axienet: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 20:52 ` Alistair Francis 2020-03-25 20:52 ` Alistair Francis 2020-03-26 21:51 ` Peter Maydell 2020-03-26 21:51 ` Peter Maydell 2020-03-25 19:18 ` [PATCH-for-5.0 12/12] hw/riscv/sifive_u: " Philippe Mathieu-Daudé 2020-03-25 19:18 ` Philippe Mathieu-Daudé 2020-03-25 20:52 ` Alistair Francis 2020-03-25 20:52 ` Alistair Francis 2020-03-26 21:55 ` Peter Maydell 2020-03-26 21:55 ` Peter Maydell 2020-03-31 17:02 ` Philippe Mathieu-Daudé 2020-03-31 17:02 ` Philippe Mathieu-Daudé 2020-03-31 17:03 ` Peter Maydell 2020-03-31 17:03 ` Peter Maydell 2020-03-25 19:20 ` [PATCH-for-5.0 00/12] hw: " Philippe Mathieu-Daudé 2020-03-25 19:20 ` Philippe Mathieu-Daudé 2020-03-30 9:21 ` Stefan Hajnoczi 2020-03-30 9:21 ` Stefan Hajnoczi 2020-04-06 17:47 ` Philippe Mathieu-Daudé 2020-04-06 17:47 ` Philippe Mathieu-Daudé 2020-03-31 13:23 ` Markus Armbruster 2020-03-31 13:23 ` Markus Armbruster 2020-04-03 17:53 ` Philippe Mathieu-Daudé 2020-04-03 17:53 ` Philippe Mathieu-Daudé 2020-04-04 5:55 ` Markus Armbruster 2020-04-04 5:55 ` Markus Armbruster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKmqyKNqYcTkxi8S56quu2L19+B73XNEzdFe44D1cNBFvjDPCQ@mail.gmail.com \ --to=alistair23@gmail.com \ --cc=Alistair.Francis@wdc.com \ --cc=Andrew.Baumann@microsoft.com \ --cc=aleksandar.qemu.devel@gmail.com \ --cc=aleksandar.rikalo@rt-rk.com \ --cc=alistair@alistair23.me \ --cc=armbru@redhat.com \ --cc=aurelien@aurel32.net \ --cc=david@gibson.dropbear.id.au \ --cc=edgar.iglesias@gmail.com \ --cc=ehabkost@redhat.com \ --cc=f4bug@amsat.org \ --cc=jasowang@redhat.com \ --cc=jcd@tribudubois.net \ --cc=kbastian@mail.uni-paderborn.de \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=mst@redhat.com \ --cc=palmer@dabbelt.com \ --cc=pbonzini@redhat.com \ --cc=pburton@wavecomp.com \ --cc=peter.maydell@linaro.org \ --cc=philmd@redhat.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=rth@twiddle.net \ --cc=sagark@eecs.berkeley.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.