* [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-12 20:05 ` Alistair Francis
0 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-10-12 20:05 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: wens, mripard, alistair23, Alistair Francis
Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
connections.
Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
.../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index 124b0b030b28..49c37b21ab36 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -56,6 +56,10 @@
aliases {
ethernet0 = &emac;
serial0 = &uart0;
+ serial1 = &uart1;
+ serial2 = &uart2;
+ serial3 = &uart3;
+ serial4 = &uart4;
};
chosen {
@@ -280,6 +284,27 @@
};
};
+/* On Pi-2 connector */
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+ status = "disabled";
+};
+
+/* On Euler connector */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+ status = "disabled";
+};
+
+/* On Euler connector, RTS/CTS optional */
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart4_pins>;
+ status = "disabled";
+};
+
&usb_otg {
dr_mode = "host";
status = "okay";
--
2.23.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-12 20:05 ` Alistair Francis
0 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-10-12 20:05 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: alistair23, wens, Alistair Francis, mripard
Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
connections.
Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
.../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
index 124b0b030b28..49c37b21ab36 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
@@ -56,6 +56,10 @@
aliases {
ethernet0 = &emac;
serial0 = &uart0;
+ serial1 = &uart1;
+ serial2 = &uart2;
+ serial3 = &uart3;
+ serial4 = &uart4;
};
chosen {
@@ -280,6 +284,27 @@
};
};
+/* On Pi-2 connector */
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+ status = "disabled";
+};
+
+/* On Euler connector */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+ status = "disabled";
+};
+
+/* On Euler connector, RTS/CTS optional */
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart4_pins>;
+ status = "disabled";
+};
+
&usb_otg {
dr_mode = "host";
status = "okay";
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-10-12 20:05 ` Alistair Francis
@ 2019-10-16 14:49 ` Maxime Ripard
-1 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-10-16 14:49 UTC (permalink / raw)
To: Alistair Francis; +Cc: linux-kernel, linux-arm-kernel, wens, alistair23
[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]
Hi,
On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> connections.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 124b0b030b28..49c37b21ab36 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -56,6 +56,10 @@
> aliases {
> ethernet0 = &emac;
> serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + serial4 = &uart4;
> };
>
> chosen {
> @@ -280,6 +284,27 @@
> };
> };
>
> +/* On Pi-2 connector */
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector */
> +&uart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart3_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector, RTS/CTS optional */
> +&uart4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart4_pins>;
> + status = "disabled";
> +};
Since these are all the default muxing, maybe we should just set that
in the DTSI?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-16 14:49 ` Maxime Ripard
0 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-10-16 14:49 UTC (permalink / raw)
To: Alistair Francis; +Cc: alistair23, wens, linux-kernel, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1407 bytes --]
Hi,
On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> connections.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> index 124b0b030b28..49c37b21ab36 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> @@ -56,6 +56,10 @@
> aliases {
> ethernet0 = &emac;
> serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + serial4 = &uart4;
> };
>
> chosen {
> @@ -280,6 +284,27 @@
> };
> };
>
> +/* On Pi-2 connector */
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector */
> +&uart3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart3_pins>;
> + status = "disabled";
> +};
> +
> +/* On Euler connector, RTS/CTS optional */
> +&uart4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart4_pins>;
> + status = "disabled";
> +};
Since these are all the default muxing, maybe we should just set that
in the DTSI?
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-10-16 14:49 ` Maxime Ripard
@ 2019-10-16 14:54 ` Chen-Yu Tsai
-1 siblings, 0 replies; 16+ messages in thread
From: Chen-Yu Tsai @ 2019-10-16 14:54 UTC (permalink / raw)
To: Maxime Ripard
Cc: Alistair Francis, linux-kernel, linux-arm-kernel, alistair23
On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
>
> Hi,
>
> On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > connections.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > ---
> > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > index 124b0b030b28..49c37b21ab36 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > @@ -56,6 +56,10 @@
> > aliases {
> > ethernet0 = &emac;
> > serial0 = &uart0;
> > + serial1 = &uart1;
> > + serial2 = &uart2;
> > + serial3 = &uart3;
> > + serial4 = &uart4;
> > };
> >
> > chosen {
> > @@ -280,6 +284,27 @@
> > };
> > };
> >
> > +/* On Pi-2 connector */
> > +&uart2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart2_pins>;
> > + status = "disabled";
> > +};
> > +
> > +/* On Euler connector */
> > +&uart3 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart3_pins>;
> > + status = "disabled";
> > +};
> > +
> > +/* On Euler connector, RTS/CTS optional */
> > +&uart4 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart4_pins>;
> > + status = "disabled";
> > +};
>
> Since these are all the default muxing, maybe we should just set that
> in the DTSI?
Maybe not, since people may want to only use RX/TX, and leave the other
two pins for GPIO?
ChenYu
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-16 14:54 ` Chen-Yu Tsai
0 siblings, 0 replies; 16+ messages in thread
From: Chen-Yu Tsai @ 2019-10-16 14:54 UTC (permalink / raw)
To: Maxime Ripard
Cc: alistair23, Alistair Francis, linux-kernel, linux-arm-kernel
On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
>
> Hi,
>
> On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > connections.
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > ---
> > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > index 124b0b030b28..49c37b21ab36 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > @@ -56,6 +56,10 @@
> > aliases {
> > ethernet0 = &emac;
> > serial0 = &uart0;
> > + serial1 = &uart1;
> > + serial2 = &uart2;
> > + serial3 = &uart3;
> > + serial4 = &uart4;
> > };
> >
> > chosen {
> > @@ -280,6 +284,27 @@
> > };
> > };
> >
> > +/* On Pi-2 connector */
> > +&uart2 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart2_pins>;
> > + status = "disabled";
> > +};
> > +
> > +/* On Euler connector */
> > +&uart3 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart3_pins>;
> > + status = "disabled";
> > +};
> > +
> > +/* On Euler connector, RTS/CTS optional */
> > +&uart4 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&uart4_pins>;
> > + status = "disabled";
> > +};
>
> Since these are all the default muxing, maybe we should just set that
> in the DTSI?
Maybe not, since people may want to only use RX/TX, and leave the other
two pins for GPIO?
ChenYu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-10-16 14:54 ` Chen-Yu Tsai
@ 2019-10-16 16:10 ` Alistair Francis
-1 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-10-16 16:10 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Maxime Ripard, Alistair Francis, linux-kernel, linux-arm-kernel
On Wed, Oct 16, 2019 at 7:54 AM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > Hi,
> >
> > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > connections.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > index 124b0b030b28..49c37b21ab36 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > @@ -56,6 +56,10 @@
> > > aliases {
> > > ethernet0 = &emac;
> > > serial0 = &uart0;
> > > + serial1 = &uart1;
> > > + serial2 = &uart2;
> > > + serial3 = &uart3;
> > > + serial4 = &uart4;
> > > };
> > >
> > > chosen {
> > > @@ -280,6 +284,27 @@
> > > };
> > > };
> > >
> > > +/* On Pi-2 connector */
> > > +&uart2 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart2_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector */
> > > +&uart3 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart3_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector, RTS/CTS optional */
> > > +&uart4 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart4_pins>;
> > > + status = "disabled";
> > > +};
> >
> > Since these are all the default muxing, maybe we should just set that
> > in the DTSI?
>
> Maybe not, since people may want to only use RX/TX, and leave the other
> two pins for GPIO?
I think this makes the most sense for the default.
Alistair
>
> ChenYu
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-16 16:10 ` Alistair Francis
0 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-10-16 16:10 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: linux-arm-kernel, Alistair Francis, linux-kernel, Maxime Ripard
On Wed, Oct 16, 2019 at 7:54 AM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > Hi,
> >
> > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > connections.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > index 124b0b030b28..49c37b21ab36 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > @@ -56,6 +56,10 @@
> > > aliases {
> > > ethernet0 = &emac;
> > > serial0 = &uart0;
> > > + serial1 = &uart1;
> > > + serial2 = &uart2;
> > > + serial3 = &uart3;
> > > + serial4 = &uart4;
> > > };
> > >
> > > chosen {
> > > @@ -280,6 +284,27 @@
> > > };
> > > };
> > >
> > > +/* On Pi-2 connector */
> > > +&uart2 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart2_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector */
> > > +&uart3 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart3_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector, RTS/CTS optional */
> > > +&uart4 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart4_pins>;
> > > + status = "disabled";
> > > +};
> >
> > Since these are all the default muxing, maybe we should just set that
> > in the DTSI?
>
> Maybe not, since people may want to only use RX/TX, and leave the other
> two pins for GPIO?
I think this makes the most sense for the default.
Alistair
>
> ChenYu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-10-16 14:54 ` Chen-Yu Tsai
@ 2019-10-21 11:17 ` Maxime Ripard
-1 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-10-21 11:17 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Alistair Francis, linux-kernel, linux-arm-kernel, alistair23
[-- Attachment #1: Type: text/plain, Size: 2003 bytes --]
Hi,
On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > connections.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > index 124b0b030b28..49c37b21ab36 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > @@ -56,6 +56,10 @@
> > > aliases {
> > > ethernet0 = &emac;
> > > serial0 = &uart0;
> > > + serial1 = &uart1;
> > > + serial2 = &uart2;
> > > + serial3 = &uart3;
> > > + serial4 = &uart4;
> > > };
> > >
> > > chosen {
> > > @@ -280,6 +284,27 @@
> > > };
> > > };
> > >
> > > +/* On Pi-2 connector */
> > > +&uart2 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart2_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector */
> > > +&uart3 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart3_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector, RTS/CTS optional */
> > > +&uart4 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart4_pins>;
> > > + status = "disabled";
> > > +};
> >
> > Since these are all the default muxing, maybe we should just set that
> > in the DTSI?
>
> Maybe not, since people may want to only use RX/TX, and leave the other
> two pins for GPIO?
Right, I'll apply that patch.
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-10-21 11:17 ` Maxime Ripard
0 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-10-21 11:17 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: alistair23, Alistair Francis, linux-kernel, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2003 bytes --]
Hi,
On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > connections.
> > >
> > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > ---
> > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > index 124b0b030b28..49c37b21ab36 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > @@ -56,6 +56,10 @@
> > > aliases {
> > > ethernet0 = &emac;
> > > serial0 = &uart0;
> > > + serial1 = &uart1;
> > > + serial2 = &uart2;
> > > + serial3 = &uart3;
> > > + serial4 = &uart4;
> > > };
> > >
> > > chosen {
> > > @@ -280,6 +284,27 @@
> > > };
> > > };
> > >
> > > +/* On Pi-2 connector */
> > > +&uart2 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart2_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector */
> > > +&uart3 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart3_pins>;
> > > + status = "disabled";
> > > +};
> > > +
> > > +/* On Euler connector, RTS/CTS optional */
> > > +&uart4 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart4_pins>;
> > > + status = "disabled";
> > > +};
> >
> > Since these are all the default muxing, maybe we should just set that
> > in the DTSI?
>
> Maybe not, since people may want to only use RX/TX, and leave the other
> two pins for GPIO?
Right, I'll apply that patch.
Thanks!
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-10-21 11:17 ` Maxime Ripard
@ 2019-11-05 19:27 ` Alistair Francis
-1 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-11-05 19:27 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> Hi,
>
> On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > connections.
> > > >
> > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > ---
> > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > 1 file changed, 25 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > index 124b0b030b28..49c37b21ab36 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > @@ -56,6 +56,10 @@
> > > > aliases {
> > > > ethernet0 = &emac;
> > > > serial0 = &uart0;
> > > > + serial1 = &uart1;
> > > > + serial2 = &uart2;
> > > > + serial3 = &uart3;
> > > > + serial4 = &uart4;
> > > > };
> > > >
> > > > chosen {
> > > > @@ -280,6 +284,27 @@
> > > > };
> > > > };
> > > >
> > > > +/* On Pi-2 connector */
> > > > +&uart2 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart2_pins>;
> > > > + status = "disabled";
> > > > +};
> > > > +
> > > > +/* On Euler connector */
> > > > +&uart3 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart3_pins>;
> > > > + status = "disabled";
> > > > +};
> > > > +
> > > > +/* On Euler connector, RTS/CTS optional */
> > > > +&uart4 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart4_pins>;
> > > > + status = "disabled";
> > > > +};
> > >
> > > Since these are all the default muxing, maybe we should just set that
> > > in the DTSI?
> >
> > Maybe not, since people may want to only use RX/TX, and leave the other
> > two pins for GPIO?
>
> Right, I'll apply that patch.
Ping, just want to make sure this has been applied/will be applied.
Alistair
>
> Thanks!
> Maxime
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-11-05 19:27 ` Alistair Francis
0 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-11-05 19:27 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> Hi,
>
> On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > connections.
> > > >
> > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > ---
> > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > 1 file changed, 25 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > index 124b0b030b28..49c37b21ab36 100644
> > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > @@ -56,6 +56,10 @@
> > > > aliases {
> > > > ethernet0 = &emac;
> > > > serial0 = &uart0;
> > > > + serial1 = &uart1;
> > > > + serial2 = &uart2;
> > > > + serial3 = &uart3;
> > > > + serial4 = &uart4;
> > > > };
> > > >
> > > > chosen {
> > > > @@ -280,6 +284,27 @@
> > > > };
> > > > };
> > > >
> > > > +/* On Pi-2 connector */
> > > > +&uart2 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart2_pins>;
> > > > + status = "disabled";
> > > > +};
> > > > +
> > > > +/* On Euler connector */
> > > > +&uart3 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart3_pins>;
> > > > + status = "disabled";
> > > > +};
> > > > +
> > > > +/* On Euler connector, RTS/CTS optional */
> > > > +&uart4 {
> > > > + pinctrl-names = "default";
> > > > + pinctrl-0 = <&uart4_pins>;
> > > > + status = "disabled";
> > > > +};
> > >
> > > Since these are all the default muxing, maybe we should just set that
> > > in the DTSI?
> >
> > Maybe not, since people may want to only use RX/TX, and leave the other
> > two pins for GPIO?
>
> Right, I'll apply that patch.
Ping, just want to make sure this has been applied/will be applied.
Alistair
>
> Thanks!
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-11-05 19:27 ` Alistair Francis
@ 2019-11-06 11:52 ` Maxime Ripard
-1 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-11-06 11:52 UTC (permalink / raw)
To: Alistair Francis
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2521 bytes --]
On Tue, Nov 05, 2019 at 11:27:42AM -0800, Alistair Francis wrote:
> On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > Hi,
> >
> > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > > connections.
> > > > >
> > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > > ---
> > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > > 1 file changed, 25 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > index 124b0b030b28..49c37b21ab36 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > @@ -56,6 +56,10 @@
> > > > > aliases {
> > > > > ethernet0 = &emac;
> > > > > serial0 = &uart0;
> > > > > + serial1 = &uart1;
> > > > > + serial2 = &uart2;
> > > > > + serial3 = &uart3;
> > > > > + serial4 = &uart4;
> > > > > };
> > > > >
> > > > > chosen {
> > > > > @@ -280,6 +284,27 @@
> > > > > };
> > > > > };
> > > > >
> > > > > +/* On Pi-2 connector */
> > > > > +&uart2 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart2_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > > > +
> > > > > +/* On Euler connector */
> > > > > +&uart3 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart3_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > > > +
> > > > > +/* On Euler connector, RTS/CTS optional */
> > > > > +&uart4 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart4_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > >
> > > > Since these are all the default muxing, maybe we should just set that
> > > > in the DTSI?
> > >
> > > Maybe not, since people may want to only use RX/TX, and leave the other
> > > two pins for GPIO?
> >
> > Right, I'll apply that patch.
>
> Ping, just want to make sure this has been applied/will be applied.
This has been applied, and was part of the PR for 5.5 sent last week
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-11-06 11:52 ` Maxime Ripard
0 siblings, 0 replies; 16+ messages in thread
From: Maxime Ripard @ 2019-11-06 11:52 UTC (permalink / raw)
To: Alistair Francis
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2521 bytes --]
On Tue, Nov 05, 2019 at 11:27:42AM -0800, Alistair Francis wrote:
> On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
> >
> > Hi,
> >
> > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > > connections.
> > > > >
> > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > > ---
> > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > > 1 file changed, 25 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > index 124b0b030b28..49c37b21ab36 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > @@ -56,6 +56,10 @@
> > > > > aliases {
> > > > > ethernet0 = &emac;
> > > > > serial0 = &uart0;
> > > > > + serial1 = &uart1;
> > > > > + serial2 = &uart2;
> > > > > + serial3 = &uart3;
> > > > > + serial4 = &uart4;
> > > > > };
> > > > >
> > > > > chosen {
> > > > > @@ -280,6 +284,27 @@
> > > > > };
> > > > > };
> > > > >
> > > > > +/* On Pi-2 connector */
> > > > > +&uart2 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart2_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > > > +
> > > > > +/* On Euler connector */
> > > > > +&uart3 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart3_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > > > +
> > > > > +/* On Euler connector, RTS/CTS optional */
> > > > > +&uart4 {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <&uart4_pins>;
> > > > > + status = "disabled";
> > > > > +};
> > > >
> > > > Since these are all the default muxing, maybe we should just set that
> > > > in the DTSI?
> > >
> > > Maybe not, since people may want to only use RX/TX, and leave the other
> > > two pins for GPIO?
> >
> > Right, I'll apply that patch.
>
> Ping, just want to make sure this has been applied/will be applied.
This has been applied, and was part of the PR for 5.5 sent last week
Maxime
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
2019-11-06 11:52 ` Maxime Ripard
@ 2019-11-06 21:45 ` Alistair Francis
-1 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-11-06 21:45 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
On Wed, Nov 6, 2019 at 3:52 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> On Tue, Nov 05, 2019 at 11:27:42AM -0800, Alistair Francis wrote:
> > On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > > > connections.
> > > > > >
> > > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > > > ---
> > > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > > > 1 file changed, 25 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > index 124b0b030b28..49c37b21ab36 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > @@ -56,6 +56,10 @@
> > > > > > aliases {
> > > > > > ethernet0 = &emac;
> > > > > > serial0 = &uart0;
> > > > > > + serial1 = &uart1;
> > > > > > + serial2 = &uart2;
> > > > > > + serial3 = &uart3;
> > > > > > + serial4 = &uart4;
> > > > > > };
> > > > > >
> > > > > > chosen {
> > > > > > @@ -280,6 +284,27 @@
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > +/* On Pi-2 connector */
> > > > > > +&uart2 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart2_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > > > +
> > > > > > +/* On Euler connector */
> > > > > > +&uart3 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart3_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > > > +
> > > > > > +/* On Euler connector, RTS/CTS optional */
> > > > > > +&uart4 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart4_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > >
> > > > > Since these are all the default muxing, maybe we should just set that
> > > > > in the DTSI?
> > > >
> > > > Maybe not, since people may want to only use RX/TX, and leave the other
> > > > two pins for GPIO?
> > >
> > > Right, I'll apply that patch.
> >
> > Ping, just want to make sure this has been applied/will be applied.
>
> This has been applied, and was part of the PR for 5.5 sent last week
Thanks :)
Alistair
>
> Maxime
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3
@ 2019-11-06 21:45 ` Alistair Francis
0 siblings, 0 replies; 16+ messages in thread
From: Alistair Francis @ 2019-11-06 21:45 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, Alistair Francis, linux-kernel, linux-arm-kernel
On Wed, Nov 6, 2019 at 3:52 AM Maxime Ripard <mripard@kernel.org> wrote:
>
> On Tue, Nov 05, 2019 at 11:27:42AM -0800, Alistair Francis wrote:
> > On Mon, Oct 21, 2019 at 4:17 AM Maxime Ripard <mripard@kernel.org> wrote:
> > >
> > > Hi,
> > >
> > > On Wed, Oct 16, 2019 at 10:54:27PM +0800, Chen-Yu Tsai wrote:
> > > > On Wed, Oct 16, 2019 at 10:49 PM Maxime Ripard <mripard@kernel.org> wrote:
> > > > > On Sat, Oct 12, 2019 at 01:05:24PM -0700, Alistair Francis wrote:
> > > > > > Follow what the sun50i-a64-pine64.dts does and expose all 5 serial
> > > > > > connections.
> > > > > >
> > > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > > > > > ---
> > > > > > .../allwinner/sun50i-a64-sopine-baseboard.dts | 25 +++++++++++++++++++
> > > > > > 1 file changed, 25 insertions(+)
> > > > > >
> > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > index 124b0b030b28..49c37b21ab36 100644
> > > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts
> > > > > > @@ -56,6 +56,10 @@
> > > > > > aliases {
> > > > > > ethernet0 = &emac;
> > > > > > serial0 = &uart0;
> > > > > > + serial1 = &uart1;
> > > > > > + serial2 = &uart2;
> > > > > > + serial3 = &uart3;
> > > > > > + serial4 = &uart4;
> > > > > > };
> > > > > >
> > > > > > chosen {
> > > > > > @@ -280,6 +284,27 @@
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > +/* On Pi-2 connector */
> > > > > > +&uart2 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart2_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > > > +
> > > > > > +/* On Euler connector */
> > > > > > +&uart3 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart3_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > > > +
> > > > > > +/* On Euler connector, RTS/CTS optional */
> > > > > > +&uart4 {
> > > > > > + pinctrl-names = "default";
> > > > > > + pinctrl-0 = <&uart4_pins>;
> > > > > > + status = "disabled";
> > > > > > +};
> > > > >
> > > > > Since these are all the default muxing, maybe we should just set that
> > > > > in the DTSI?
> > > >
> > > > Maybe not, since people may want to only use RX/TX, and leave the other
> > > > two pins for GPIO?
> > >
> > > Right, I'll apply that patch.
> >
> > Ping, just want to make sure this has been applied/will be applied.
>
> This has been applied, and was part of the PR for 5.5 sent last week
Thanks :)
Alistair
>
> Maxime
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-11-06 21:51 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-12 20:05 [PATCH] arm64: dts: sun50i: sopine-baseboard: Expose serial1, serial2 and serial3 Alistair Francis
2019-10-12 20:05 ` Alistair Francis
2019-10-16 14:49 ` Maxime Ripard
2019-10-16 14:49 ` Maxime Ripard
2019-10-16 14:54 ` Chen-Yu Tsai
2019-10-16 14:54 ` Chen-Yu Tsai
2019-10-16 16:10 ` Alistair Francis
2019-10-16 16:10 ` Alistair Francis
2019-10-21 11:17 ` Maxime Ripard
2019-10-21 11:17 ` Maxime Ripard
2019-11-05 19:27 ` Alistair Francis
2019-11-05 19:27 ` Alistair Francis
2019-11-06 11:52 ` Maxime Ripard
2019-11-06 11:52 ` Maxime Ripard
2019-11-06 21:45 ` Alistair Francis
2019-11-06 21:45 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.