From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chen Fan <fan.chen@mediatek.com>,
Howard Chen <ibanezchen@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver
Date: Wed, 18 Mar 2015 12:29:43 +0530 [thread overview]
Message-ID: <CAKohpon8kXzfeKUUwrRhuei0cY9iVbMHfBjDwXW=M2SAYHdtYQ@mail.gmail.com> (raw)
In-Reply-To: <CALx668U7EoiMB8D0Num5w9oC0zZkC55uKaSOLrrBhKnLXUtoOQ@mail.gmail.com>
On 12 March 2015 at 16:45, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> The voltages of the two regulators need to be always under a limitation:
> 100mV < Vsram - Vproc < 200mV
> For now, I just calculate the OPPs of Vsram from OPPs of Vproc.
>
> Another thing I should mention, if the voltage difference of two adjacent
> OPPs is greater than 100mV, we need to set the regulator to some
> voltages which are not in OPP table considering the limitation above.
> I think that will make it more difficult to model such flow in a generic
> framework.
Actually the problem is that OPP tables are insufficient for such cases,
and we are adding work-arounds to fix that. Though it will get fixed
with the new bindings we are adding.
I am confused on what we should be doing here. Even if you write
your own driver, you will be abusing DT with incorrect information.
Even if you go around adding a new driver, I would like you to fallback
to cpufreq-dt ones the new OPP bindings are in place.
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pi-Cheng Chen <pi-cheng.chen@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chen Fan <fan.chen@mediatek.com>,
Howard Chen <ibanezchen@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Joe.C" <yingjoe.chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@li
Subject: Re: [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver
Date: Wed, 18 Mar 2015 12:29:43 +0530 [thread overview]
Message-ID: <CAKohpon8kXzfeKUUwrRhuei0cY9iVbMHfBjDwXW=M2SAYHdtYQ@mail.gmail.com> (raw)
In-Reply-To: <CALx668U7EoiMB8D0Num5w9oC0zZkC55uKaSOLrrBhKnLXUtoOQ@mail.gmail.com>
On 12 March 2015 at 16:45, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> The voltages of the two regulators need to be always under a limitation:
> 100mV < Vsram - Vproc < 200mV
> For now, I just calculate the OPPs of Vsram from OPPs of Vproc.
>
> Another thing I should mention, if the voltage difference of two adjacent
> OPPs is greater than 100mV, we need to set the regulator to some
> voltages which are not in OPP table considering the limitation above.
> I think that will make it more difficult to model such flow in a generic
> framework.
Actually the problem is that OPP tables are insufficient for such cases,
and we are adding work-arounds to fix that. Though it will get fixed
with the new bindings we are adding.
I am confused on what we should be doing here. Even if you write
your own driver, you will be abusing DT with incorrect information.
Even if you go around adding a new driver, I would like you to fallback
to cpufreq-dt ones the new OPP bindings are in place.
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver
Date: Wed, 18 Mar 2015 12:29:43 +0530 [thread overview]
Message-ID: <CAKohpon8kXzfeKUUwrRhuei0cY9iVbMHfBjDwXW=M2SAYHdtYQ@mail.gmail.com> (raw)
In-Reply-To: <CALx668U7EoiMB8D0Num5w9oC0zZkC55uKaSOLrrBhKnLXUtoOQ@mail.gmail.com>
On 12 March 2015 at 16:45, Pi-Cheng Chen <pi-cheng.chen@linaro.org> wrote:
> The voltages of the two regulators need to be always under a limitation:
> 100mV < Vsram - Vproc < 200mV
> For now, I just calculate the OPPs of Vsram from OPPs of Vproc.
>
> Another thing I should mention, if the voltage difference of two adjacent
> OPPs is greater than 100mV, we need to set the regulator to some
> voltages which are not in OPP table considering the limitation above.
> I think that will make it more difficult to model such flow in a generic
> framework.
Actually the problem is that OPP tables are insufficient for such cases,
and we are adding work-arounds to fix that. Though it will get fixed
with the new bindings we are adding.
I am confused on what we should be doing here. Even if you write
your own driver, you will be abusing DT with incorrect information.
Even if you go around adding a new driver, I would like you to fallback
to cpufreq-dt ones the new OPP bindings are in place.
next prev parent reply other threads:[~2015-03-18 6:59 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 8:49 [PATCH v2 0/4] cpufreq: add cpufreq driver for Mediatek MT8173 SoC pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
2015-03-04 8:49 ` [PATCH v2 1/4] cpufreq-dt: add clock domain and intermediate frequency support pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
2015-03-04 10:15 ` Viresh Kumar
2015-03-04 10:15 ` Viresh Kumar
2015-03-04 10:15 ` Viresh Kumar
2015-03-04 10:17 ` Viresh Kumar
2015-03-04 10:17 ` Viresh Kumar
2015-03-04 10:17 ` Viresh Kumar
2015-03-05 3:32 ` Pi-Cheng Chen
2015-03-05 3:32 ` Pi-Cheng Chen
2015-03-05 3:32 ` Pi-Cheng Chen
2015-03-05 3:58 ` Viresh Kumar
2015-03-05 3:58 ` Viresh Kumar
2015-03-05 3:58 ` Viresh Kumar
2015-03-05 7:28 ` Pi-Cheng Chen
2015-03-05 7:28 ` Pi-Cheng Chen
2015-03-05 7:28 ` Pi-Cheng Chen
2015-03-04 8:49 ` [PATCH v2 2/4] cpufreq: dt-bindings: add bindings for mtk-cpufreq driver pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
2015-03-04 10:29 ` Viresh Kumar
2015-03-04 10:29 ` Viresh Kumar
2015-03-04 10:29 ` Viresh Kumar
2015-03-04 8:49 ` [PATCH v2 3/4] cpufreq: mediatek: add Mediatek cpufreq driver pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
2015-03-04 11:09 ` Viresh Kumar
2015-03-04 11:09 ` Viresh Kumar
2015-03-04 11:09 ` Viresh Kumar
2015-03-05 7:27 ` Pi-Cheng Chen
2015-03-05 7:27 ` Pi-Cheng Chen
2015-03-05 7:27 ` Pi-Cheng Chen
2015-03-05 9:55 ` Viresh Kumar
2015-03-05 9:55 ` Viresh Kumar
2015-03-05 9:55 ` Viresh Kumar
2015-03-06 5:49 ` Pi-Cheng Chen
2015-03-06 5:49 ` Pi-Cheng Chen
2015-03-06 5:49 ` Pi-Cheng Chen
2015-03-10 2:50 ` Viresh Kumar
2015-03-10 2:50 ` Viresh Kumar
2015-03-10 2:50 ` Viresh Kumar
2015-03-11 10:53 ` Mark Brown
2015-03-11 10:53 ` Mark Brown
2015-03-11 10:53 ` Mark Brown
2015-03-11 11:03 ` Viresh Kumar
2015-03-11 11:03 ` Viresh Kumar
2015-03-11 11:03 ` Viresh Kumar
2015-03-11 11:42 ` Lucas Stach
2015-03-11 11:42 ` Lucas Stach
2015-03-11 11:42 ` Lucas Stach
2015-03-11 11:46 ` Viresh Kumar
2015-03-11 11:46 ` Viresh Kumar
2015-03-11 11:46 ` Viresh Kumar
2015-03-11 12:46 ` Mark Brown
2015-03-11 12:46 ` Mark Brown
2015-03-11 12:46 ` Mark Brown
2015-03-11 12:45 ` Mark Brown
2015-03-11 12:45 ` Mark Brown
2015-03-11 12:45 ` Mark Brown
2015-03-12 9:28 ` Viresh Kumar
2015-03-12 9:28 ` Viresh Kumar
2015-03-12 9:28 ` Viresh Kumar
2015-03-12 11:15 ` Pi-Cheng Chen
2015-03-12 11:15 ` Pi-Cheng Chen
2015-03-12 11:15 ` Pi-Cheng Chen
2015-03-18 6:59 ` Viresh Kumar [this message]
2015-03-18 6:59 ` Viresh Kumar
2015-03-18 6:59 ` Viresh Kumar
2015-03-09 16:28 ` Russell King - ARM Linux
2015-03-09 16:28 ` Russell King - ARM Linux
2015-03-10 1:57 ` Pi-Cheng Chen
2015-03-10 1:57 ` Pi-Cheng Chen
2015-03-10 1:57 ` Pi-Cheng Chen
2015-03-04 8:49 ` [PATCH v2 4/4] ARM64: dts: mediatek: add cpufreq dts for MT8173 SoC pi-cheng.chen
2015-03-04 8:49 ` pi-cheng.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpon8kXzfeKUUwrRhuei0cY9iVbMHfBjDwXW=M2SAYHdtYQ@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fan.chen@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ibanezchen@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=pi-cheng.chen@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@free-electrons.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.