From: Rob Herring <robh+dt@kernel.org> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Hans Verkuil <hans.verkuil@cisco.com>, Sakari Ailus <sakari.ailus@linux.intel.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Linux Media Mailing List <linux-media@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, Frank Rowand <frowand.list@gmail.com> Subject: Re: [PATCH v2 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Date: Mon, 28 Jan 2019 10:17:09 -0600 [thread overview] Message-ID: <CAL_JsqKOyr3nbXozTqBsEAQGw2bPsBGvFpJ_X7S-izdjTWxK=g@mail.gmail.com> (raw) In-Reply-To: <f6b6adf84c58e0de605d0a23dd559fee011f380c.1548687041.git-series.maxime.ripard@bootlin.com> On Mon, Jan 28, 2019 at 8:52 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > The Allwinner A10 CMOS Sensor Interface is a camera capture interface also > used in later (A10s, A13, A20, R8 and GR8) SoCs. > > On some SoCs, like the A10, there's multiple instances of that controller, > with one instance supporting more channels and having an ISP. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > --- > Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > new file mode 100644 > index 000000000000..f550fefa074f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR X11) X11 is generally wrong because it is specific to X Consortium. MIT is what you want. The core bindings are using 'GPL-2.0 OR BSD-2-Clause'. I don't think it really matters whether we have a mixture of MIT and BSD, but if you don't have a reason to deviate, I wouldn't. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/allwinner,sun4i-a10-csi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner A10 CMOS Sensor Interface (CSI) Device Tree Bindings > + > +maintainers: > + - Chen-Yu Tsai <wens@csie.org> > + - Maxime Ripard <maxime.ripard@bootlin.com> > + > +properties: > + compatible: > + oneOf: > + - description: Allwinner A10 CSI0 Controller > + items: > + - const: allwinner,sun4i-a10-csi0 > + > + - description: Allwinner A20 CSI0 Controller > + items: > + - const: allwinner,sun7i-a20-csi0 You may want to use 'enum' here if you will have more to add later. > + - const: allwinner,sun4i-a10-csi0 > + > + reg: > + description: The base address and size of the memory-mapped region IMO, we don't need to define what 'reg' is everywhere. > + maxItems: 1 > + > + interrupts: > + description: The interrupt associated to this IP Same here. > + maxItems: 1 > + > + clocks: > + minItems: 4 > + maxItems: 4 No need for these. We count 'items' and add them automatically. You only need them if the size is variable. > + items: > + - description: The CSI interface clock > + - description: The CSI module clock > + - description: The CSI ISP clock > + - description: The CSI DRAM clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 Same here. > + items: > + - const: bus > + - const: mod > + - const: isp > + - const: ram > + > + resets: > + description: The reset line driver this IP > + maxItems: 1 > + > + pinctrl-0: true No defined length? I guess we generally allow a variable number of entries. > + > + pinctrl-names: > + description: > + When present, must have one state named "default" that sets up > + pins for ordinary operations. > + minItems: 1 > + maxItems: 1 > + items: > + - const: default A single entry can be simplified to just 'const: default' under pinctrl-names. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +# The media OF-graph binding hasn't been described yet > +# additionalProperties: false > -- > git-series 0.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh+dt@kernel.org> To: Maxime Ripard <maxime.ripard@bootlin.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Sakari Ailus <sakari.ailus@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrzej Hajda <a.hajda@samsung.com>, Chen-Yu Tsai <wens@csie.org>, Hans Verkuil <hans.verkuil@cisco.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Frank Rowand <frowand.list@gmail.com>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Linux Media Mailing List <linux-media@vger.kernel.org> Subject: Re: [PATCH v2 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Date: Mon, 28 Jan 2019 10:17:09 -0600 [thread overview] Message-ID: <CAL_JsqKOyr3nbXozTqBsEAQGw2bPsBGvFpJ_X7S-izdjTWxK=g@mail.gmail.com> (raw) In-Reply-To: <f6b6adf84c58e0de605d0a23dd559fee011f380c.1548687041.git-series.maxime.ripard@bootlin.com> On Mon, Jan 28, 2019 at 8:52 AM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > The Allwinner A10 CMOS Sensor Interface is a camera capture interface also > used in later (A10s, A13, A20, R8 and GR8) SoCs. > > On some SoCs, like the A10, there's multiple instances of that controller, > with one instance supporting more channels and having an ISP. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > --- > Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > new file mode 100644 > index 000000000000..f550fefa074f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR X11) X11 is generally wrong because it is specific to X Consortium. MIT is what you want. The core bindings are using 'GPL-2.0 OR BSD-2-Clause'. I don't think it really matters whether we have a mixture of MIT and BSD, but if you don't have a reason to deviate, I wouldn't. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/allwinner,sun4i-a10-csi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner A10 CMOS Sensor Interface (CSI) Device Tree Bindings > + > +maintainers: > + - Chen-Yu Tsai <wens@csie.org> > + - Maxime Ripard <maxime.ripard@bootlin.com> > + > +properties: > + compatible: > + oneOf: > + - description: Allwinner A10 CSI0 Controller > + items: > + - const: allwinner,sun4i-a10-csi0 > + > + - description: Allwinner A20 CSI0 Controller > + items: > + - const: allwinner,sun7i-a20-csi0 You may want to use 'enum' here if you will have more to add later. > + - const: allwinner,sun4i-a10-csi0 > + > + reg: > + description: The base address and size of the memory-mapped region IMO, we don't need to define what 'reg' is everywhere. > + maxItems: 1 > + > + interrupts: > + description: The interrupt associated to this IP Same here. > + maxItems: 1 > + > + clocks: > + minItems: 4 > + maxItems: 4 No need for these. We count 'items' and add them automatically. You only need them if the size is variable. > + items: > + - description: The CSI interface clock > + - description: The CSI module clock > + - description: The CSI ISP clock > + - description: The CSI DRAM clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 Same here. > + items: > + - const: bus > + - const: mod > + - const: isp > + - const: ram > + > + resets: > + description: The reset line driver this IP > + maxItems: 1 > + > + pinctrl-0: true No defined length? I guess we generally allow a variable number of entries. > + > + pinctrl-names: > + description: > + When present, must have one state named "default" that sets up > + pins for ordinary operations. > + minItems: 1 > + maxItems: 1 > + items: > + - const: default A single entry can be simplified to just 'const: default' under pinctrl-names. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +# The media OF-graph binding hasn't been described yet > +# additionalProperties: false > -- > git-series 0.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-28 16:17 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-28 14:52 [PATCH v2 0/5] media: Allwinner A10 CSI support Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-28 14:52 ` [PATCH v2 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-28 16:17 ` Rob Herring [this message] 2019-01-28 16:17 ` Rob Herring 2019-01-28 16:17 ` Rob Herring 2019-01-29 11:52 ` Sakari Ailus 2019-01-29 11:52 ` Sakari Ailus 2019-01-29 11:52 ` Sakari Ailus 2019-01-28 14:52 ` [PATCH v2 2/5] media: sunxi: Refactor the Makefile and Kconfig Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-28 14:52 ` [PATCH v2 3/5] media: sunxi: Add A10 CSI driver Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-29 12:39 ` Sakari Ailus 2019-01-29 12:39 ` Sakari Ailus 2019-02-06 21:16 ` Maxime Ripard 2019-02-06 21:16 ` Maxime Ripard 2019-02-08 23:17 ` Sakari Ailus 2019-02-08 23:17 ` Sakari Ailus 2019-02-06 22:59 ` Ezequiel Garcia 2019-02-06 22:59 ` Ezequiel Garcia 2019-02-08 20:19 ` Maxime Ripard 2019-02-08 20:19 ` Maxime Ripard 2019-01-28 14:52 ` [PATCH v2 4/5] ARM: dts: sun7i: Add CSI0 controller Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard 2019-01-28 14:52 ` [PATCH v2 5/5] DO NOT MERGE: ARM: dts: bananapi: Add Camera support Maxime Ripard 2019-01-28 14:52 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqKOyr3nbXozTqBsEAQGw2bPsBGvFpJ_X7S-izdjTWxK=g@mail.gmail.com' \ --to=robh+dt@kernel.org \ --cc=a.hajda@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=hans.verkuil@cisco.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=mchehab@kernel.org \ --cc=sakari.ailus@linux.intel.com \ --cc=thomas.petazzoni@bootlin.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.