From: Sergio Paracuellos <sergio.paracuellos@gmail.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: Vinod Koul <vkoul@kernel.org>, "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Greg KH <gregkh@linuxfoundation.org>, Kishon Vijay Abraham I <kishon@ti.com>, Rob Herring <robh+dt@kernel.org>, NeilBrown <neil@brown.name> Subject: Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY Date: Mon, 30 Nov 2020 15:34:26 +0100 [thread overview] Message-ID: <CAMhs-H-yNWbO0vWBU2B6BfnZ0j8=p2G9ZQh-3aOxjQDEhMxVRQ@mail.gmail.com> (raw) In-Reply-To: <20201130121506.GB2767@kadam> Hi Dan, On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 reg) > > > > +{ > > > > + regmap_write(phy->regmap, reg, val); > > > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > > > This is because name was the dummy names are a bit shorter :) but if > > it is also necessary I will use directly regmap_ functions. > > At least don't swap the last two arguments around. You are right. I don't really know why I changed the order there but those have been deleted in applied series. > > regards, > dan carpenter Best regards, Sergio Paracuellos >
WARNING: multiple messages have this Message-ID (diff)
From: Sergio Paracuellos <sergio.paracuellos@gmail.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Greg KH <gregkh@linuxfoundation.org>, Kishon Vijay Abraham I <kishon@ti.com>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, NeilBrown <neil@brown.name> Subject: Re: [PATCH v4 2/4] phy: ralink: Add PHY driver for MT7621 PCIe PHY Date: Mon, 30 Nov 2020 15:34:26 +0100 [thread overview] Message-ID: <CAMhs-H-yNWbO0vWBU2B6BfnZ0j8=p2G9ZQh-3aOxjQDEhMxVRQ@mail.gmail.com> (raw) In-Reply-To: <20201130121506.GB2767@kadam> Hi Dan, On Mon, Nov 30, 2020 at 1:15 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Thu, Nov 19, 2020 at 07:05:22AM +0100, Sergio Paracuellos wrote: > > > > +static inline void phy_write(struct mt7621_pci_phy *phy, u32 val, u32 reg) > > > > +{ > > > > + regmap_write(phy->regmap, reg, val); > > > > > > Why not use regmap_ calls directly and avoid the dummy wrappers..? > > > > This is because name was the dummy names are a bit shorter :) but if > > it is also necessary I will use directly regmap_ functions. > > At least don't swap the last two arguments around. You are right. I don't really know why I changed the order there but those have been deleted in applied series. > > regards, > dan carpenter Best regards, Sergio Paracuellos > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-11-30 14:35 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-31 12:22 [PATCH v4 0/4] MT7621 PCIe PHY Sergio Paracuellos 2020-10-31 12:22 ` Sergio Paracuellos 2020-10-31 12:22 ` [PATCH v4 1/4] dt-bindings: phy: Add binding for Mediatek " Sergio Paracuellos 2020-10-31 12:22 ` Sergio Paracuellos 2020-11-04 22:30 ` Rob Herring 2020-11-04 22:30 ` Rob Herring 2020-10-31 12:22 ` [PATCH v4 2/4] phy: ralink: Add PHY driver for " Sergio Paracuellos 2020-10-31 12:22 ` Sergio Paracuellos 2020-11-19 5:30 ` Vinod Koul 2020-11-19 5:30 ` Vinod Koul 2020-11-19 6:05 ` Sergio Paracuellos 2020-11-19 6:05 ` Sergio Paracuellos 2020-11-30 12:15 ` Dan Carpenter 2020-11-30 12:15 ` Dan Carpenter 2020-11-30 14:34 ` Sergio Paracuellos [this message] 2020-11-30 14:34 ` Sergio Paracuellos 2020-10-31 12:22 ` [PATCH v4 3/4] MAINTAINERS: add MT7621 PHY PCI maintainer Sergio Paracuellos 2020-10-31 12:22 ` Sergio Paracuellos 2020-10-31 12:22 ` [PATCH v4 4/4] staging: mt7621-pci-phy: remove driver from staging Sergio Paracuellos 2020-10-31 12:22 ` Sergio Paracuellos 2020-11-06 9:43 ` Greg KH 2020-11-06 9:43 ` Greg KH 2020-11-10 12:14 ` [PATCH v4 0/4] MT7621 PCIe PHY Sergio Paracuellos 2020-11-10 12:14 ` Sergio Paracuellos
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAMhs-H-yNWbO0vWBU2B6BfnZ0j8=p2G9ZQh-3aOxjQDEhMxVRQ@mail.gmail.com' \ --to=sergio.paracuellos@gmail.com \ --cc=dan.carpenter@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=kishon@ti.com \ --cc=neil@brown.name \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.