All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
@ 2017-04-25 17:36 Geert Uytterhoeven
  2017-04-26  7:13 ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-04-25 17:36 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, linux-clk, Geert Uytterhoeven

If the R-Car RST driver is not included, compile-testing R-Car clock
drivers fails with a link error:

    undefined reference to `rcar_rst_read_mode_pins'

To fix this, provide a dummy version.  Use the exact same test logic as
in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
control compilation of the R-Car RST driver.

Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
This isn't an issue now, but it does prevent enabling compile-testing of
the R-Car clock drivers.  As this is a dependency between two different
subsystems, I think this patch should be fast-tracked.

The #ifdef condition will be revised later, when the R-Car RST driver
gains its own Kconfig symbol.
---
 include/linux/soc/renesas/rcar-rst.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
index a18e0783946b66ec..787e7ad53d45f61c 100644
--- a/include/linux/soc/renesas/rcar-rst.h
+++ b/include/linux/soc/renesas/rcar-rst.h
@@ -1,6 +1,11 @@
 #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
 #define __LINUX_SOC_RENESAS_RCAR_RST_H__
 
+#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
+    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
 int rcar_rst_read_mode_pins(u32 *mode);
+#else
+static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
+#endif
 
 #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-25 17:36 [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Geert Uytterhoeven
@ 2017-04-26  7:13 ` Simon Horman
  2017-04-26  7:34   ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2017-04-26  7:13 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc, linux-clk

On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> If the R-Car RST driver is not included, compile-testing R-Car clock
> drivers fails with a link error:
> 
>     undefined reference to `rcar_rst_read_mode_pins'
> 
> To fix this, provide a dummy version.  Use the exact same test logic as
> in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> control compilation of the R-Car RST driver.

Adding a Kconfig symbol would be a bit cleaner IMHO.

> 
> Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This isn't an issue now, but it does prevent enabling compile-testing of
> the R-Car clock drivers.  As this is a dependency between two different
> subsystems, I think this patch should be fast-tracked.
> 
> The #ifdef condition will be revised later, when the R-Car RST driver
> gains its own Kconfig symbol.
> ---
>  include/linux/soc/renesas/rcar-rst.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
> index a18e0783946b66ec..787e7ad53d45f61c 100644
> --- a/include/linux/soc/renesas/rcar-rst.h
> +++ b/include/linux/soc/renesas/rcar-rst.h
> @@ -1,6 +1,11 @@
>  #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
>  #define __LINUX_SOC_RENESAS_RCAR_RST_H__
>  
> +#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
> +    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
>  int rcar_rst_read_mode_pins(u32 *mode);
> +#else
> +static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
> +#endif
>  
>  #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-26  7:13 ` Simon Horman
@ 2017-04-26  7:34   ` Simon Horman
  2017-04-26 12:35     ` Geert Uytterhoeven
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2017-04-26  7:34 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc, linux-clk

On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> > If the R-Car RST driver is not included, compile-testing R-Car clock
> > drivers fails with a link error:
> > 
> >     undefined reference to `rcar_rst_read_mode_pins'
> > 
> > To fix this, provide a dummy version.  Use the exact same test logic as
> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> > control compilation of the R-Car RST driver.
> 
> Adding a Kconfig symbol would be a bit cleaner IMHO.

I now see you are doing so in other patches :)

> > Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > This isn't an issue now, but it does prevent enabling compile-testing of
> > the R-Car clock drivers.  As this is a dependency between two different
> > subsystems, I think this patch should be fast-tracked.
> > 
> > The #ifdef condition will be revised later, when the R-Car RST driver
> > gains its own Kconfig symbol.
> > ---
> >  include/linux/soc/renesas/rcar-rst.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
> > index a18e0783946b66ec..787e7ad53d45f61c 100644
> > --- a/include/linux/soc/renesas/rcar-rst.h
> > +++ b/include/linux/soc/renesas/rcar-rst.h
> > @@ -1,6 +1,11 @@
> >  #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
> >  #define __LINUX_SOC_RENESAS_RCAR_RST_H__
> >  
> > +#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
> > +    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
> >  int rcar_rst_read_mode_pins(u32 *mode);
> > +#else
> > +static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
> > +#endif
> >  
> >  #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
> > -- 
> > 2.7.4
> > 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-26  7:34   ` Simon Horman
@ 2017-04-26 12:35     ` Geert Uytterhoeven
  2017-04-28  5:14       ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-04-26 12:35 UTC (permalink / raw)
  To: Simon Horman; +Cc: Geert Uytterhoeven, Magnus Damm, Linux-Renesas, linux-clk

Hi Simon,

On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
>> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
>> > If the R-Car RST driver is not included, compile-testing R-Car clock
>> > drivers fails with a link error:
>> >
>> >     undefined reference to `rcar_rst_read_mode_pins'
>> >
>> > To fix this, provide a dummy version.  Use the exact same test logic as
>> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
>> > control compilation of the R-Car RST driver.
>>
>> Adding a Kconfig symbol would be a bit cleaner IMHO.
>
> I now see you are doing so in other patches :)

Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
a Kconfig file yet, and introducing a Kconfig symbol would thus be more
intrusive.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-26 12:35     ` Geert Uytterhoeven
@ 2017-04-28  5:14       ` Simon Horman
  2017-04-28  7:28         ` Geert Uytterhoeven
  0 siblings, 1 reply; 9+ messages in thread
From: Simon Horman @ 2017-04-28  5:14 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Geert Uytterhoeven, Magnus Damm, Linux-Renesas, linux-clk

On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
> >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> >> > If the R-Car RST driver is not included, compile-testing R-Car clock
> >> > drivers fails with a link error:
> >> >
> >> >     undefined reference to `rcar_rst_read_mode_pins'
> >> >
> >> > To fix this, provide a dummy version.  Use the exact same test logic as
> >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> >> > control compilation of the R-Car RST driver.
> >>
> >> Adding a Kconfig symbol would be a bit cleaner IMHO.
> >
> > I now see you are doing so in other patches :)
> 
> Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
> a Kconfig file yet, and introducing a Kconfig symbol would thus be more
> intrusive.

Thanks. Given that it doesn't appear that the problem resolved by this fix
manifests at this time I have queued it up for v4.13 rather than as a fix
for v4.12. Let me know if you'd like me to revisit that decision.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-28  5:14       ` Simon Horman
@ 2017-04-28  7:28         ` Geert Uytterhoeven
  2017-04-28  8:01           ` Simon Horman
  0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-04-28  7:28 UTC (permalink / raw)
  To: Simon Horman; +Cc: Geert Uytterhoeven, Magnus Damm, Linux-Renesas, linux-clk

Hi Simon,

On Fri, Apr 28, 2017 at 7:14 AM, Simon Horman <horms@verge.net.au> wrote:
> On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote:
>> On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@verge.net.au> wrote:
>> > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
>> >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
>> >> > If the R-Car RST driver is not included, compile-testing R-Car clock
>> >> > drivers fails with a link error:
>> >> >
>> >> >     undefined reference to `rcar_rst_read_mode_pins'
>> >> >
>> >> > To fix this, provide a dummy version.  Use the exact same test logic as
>> >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
>> >> > control compilation of the R-Car RST driver.
>> >>
>> >> Adding a Kconfig symbol would be a bit cleaner IMHO.
>> >
>> > I now see you are doing so in other patches :)
>>
>> Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
>> a Kconfig file yet, and introducing a Kconfig symbol would thus be more
>> intrusive.
>
> Thanks. Given that it doesn't appear that the problem resolved by this fix
> manifests at this time I have queued it up for v4.13 rather than as a fix
> for v4.12. Let me know if you'd like me to revisit that decision.

I had hoped you could still queue it as a fix for v4.12...

This is one of the blockers for enabling compile-testing of the R-Car clock
drivers in v4.13.  Of course some of the other blockers may not make v4.12
neither.

Instead of  postponing it to v4.13, you could as well drop it, and wait for
the better solution in "[RFC] soc: renesas: Rework Kconfig and Makefile
logic".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-04-28  7:28         ` Geert Uytterhoeven
@ 2017-04-28  8:01           ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2017-04-28  8:01 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Geert Uytterhoeven, Magnus Damm, Linux-Renesas, linux-clk

On Fri, Apr 28, 2017 at 09:28:20AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Apr 28, 2017 at 7:14 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Apr 26, 2017 at 02:35:58PM +0200, Geert Uytterhoeven wrote:
> >> On Wed, Apr 26, 2017 at 9:34 AM, Simon Horman <horms@verge.net.au> wrote:
> >> > On Wed, Apr 26, 2017 at 09:13:06AM +0200, Simon Horman wrote:
> >> >> On Tue, Apr 25, 2017 at 07:36:25PM +0200, Geert Uytterhoeven wrote:
> >> >> > If the R-Car RST driver is not included, compile-testing R-Car clock
> >> >> > drivers fails with a link error:
> >> >> >
> >> >> >     undefined reference to `rcar_rst_read_mode_pins'
> >> >> >
> >> >> > To fix this, provide a dummy version.  Use the exact same test logic as
> >> >> > in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
> >> >> > control compilation of the R-Car RST driver.
> >> >>
> >> >> Adding a Kconfig symbol would be a bit cleaner IMHO.
> >> >
> >> > I now see you are doing so in other patches :)
> >>
> >> Indeed. I went with this quick fix, as drivers/soc/renesas doesn't have
> >> a Kconfig file yet, and introducing a Kconfig symbol would thus be more
> >> intrusive.
> >
> > Thanks. Given that it doesn't appear that the problem resolved by this fix
> > manifests at this time I have queued it up for v4.13 rather than as a fix
> > for v4.12. Let me know if you'd like me to revisit that decision.
> 
> I had hoped you could still queue it as a fix for v4.12...

Sure, I'll see what I can do.

> This is one of the blockers for enabling compile-testing of the R-Car clock
> drivers in v4.13.  Of course some of the other blockers may not make v4.12
> neither.
> 
> Instead of  postponing it to v4.13, you could as well drop it, and wait for
> the better solution in "[RFC] soc: renesas: Rework Kconfig and Makefile
> logic".
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
  2017-05-02  8:35 [GIT PULL] Renesas ARM Based SoC Fixes for v4.12 Simon Horman
@ 2017-05-02  8:35   ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2017-05-02  8:35 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: linux-arm-kernel, Magnus Damm, Geert Uytterhoeven, Simon Horman

From: Geert Uytterhoeven <geert+renesas@glider.be>

If the R-Car RST driver is not included, compile-testing R-Car clock
drivers fails with a link error:

    undefined reference to `rcar_rst_read_mode_pins'

To fix this, provide a dummy version.  Use the exact same test logic as
in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
control compilation of the R-Car RST driver.

Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 include/linux/soc/renesas/rcar-rst.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
index a18e0783946b..787e7ad53d45 100644
--- a/include/linux/soc/renesas/rcar-rst.h
+++ b/include/linux/soc/renesas/rcar-rst.h
@@ -1,6 +1,11 @@
 #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
 #define __LINUX_SOC_RENESAS_RCAR_RST_H__
 
+#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
+    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
 int rcar_rst_read_mode_pins(u32 *mode);
+#else
+static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
+#endif
 
 #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing
@ 2017-05-02  8:35   ` Simon Horman
  0 siblings, 0 replies; 9+ messages in thread
From: Simon Horman @ 2017-05-02  8:35 UTC (permalink / raw)
  To: linux-arm-kernel

From: Geert Uytterhoeven <geert+renesas@glider.be>

If the R-Car RST driver is not included, compile-testing R-Car clock
drivers fails with a link error:

    undefined reference to `rcar_rst_read_mode_pins'

To fix this, provide a dummy version.  Use the exact same test logic as
in drivers/soc/renesas/Makefile, as there is no Kconfig symbol (yet) to
control compilation of the R-Car RST driver.

Fixes: 527c02f66d263d2e ("soc: renesas: Add R-Car RST driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 include/linux/soc/renesas/rcar-rst.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/soc/renesas/rcar-rst.h b/include/linux/soc/renesas/rcar-rst.h
index a18e0783946b..787e7ad53d45 100644
--- a/include/linux/soc/renesas/rcar-rst.h
+++ b/include/linux/soc/renesas/rcar-rst.h
@@ -1,6 +1,11 @@
 #ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__
 #define __LINUX_SOC_RENESAS_RCAR_RST_H__
 
+#if defined(CONFIG_ARCH_RCAR_GEN1) || defined(CONFIG_ARCH_RCAR_GEN2) || \
+    defined(CONFIG_ARCH_R8A7795) || defined(CONFIG_ARCH_R8A7796)
 int rcar_rst_read_mode_pins(u32 *mode);
+#else
+static inline int rcar_rst_read_mode_pins(u32 *mode) { return -ENODEV; }
+#endif
 
 #endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-05-02  8:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 17:36 [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Geert Uytterhoeven
2017-04-26  7:13 ` Simon Horman
2017-04-26  7:34   ` Simon Horman
2017-04-26 12:35     ` Geert Uytterhoeven
2017-04-28  5:14       ` Simon Horman
2017-04-28  7:28         ` Geert Uytterhoeven
2017-04-28  8:01           ` Simon Horman
2017-05-02  8:35 [GIT PULL] Renesas ARM Based SoC Fixes for v4.12 Simon Horman
2017-05-02  8:35 ` [PATCH] soc: renesas: Provide dummy rcar_rst_read_mode_pins() for compile-testing Simon Horman
2017-05-02  8:35   ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.