* [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII
@ 2021-02-10 13:27 ` Geert Uytterhoeven
0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2021-02-10 13:27 UTC (permalink / raw)
To: Linus Walleij, Lars Povlsen, Steen Hegelund, Alexandre Belloni
Cc: UNGLinuxDriver, linux-gpio, linux-arm-kernel, linux-mips,
linux-kernel, Geert Uytterhoeven
the Microsemi/Microchip Serial GPIO device is present only Microsemi
VCore III and Microchip Sparx5 SoCs. Hence add a dependency on
ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this
driver when configuring a kernel without support for these SoCs.
Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -353,8 +353,8 @@ config PINCTRL_OCELOT
config PINCTRL_MICROCHIP_SGPIO
bool "Pinctrl driver for Microsemi/Microchip Serial GPIO"
- depends on OF
- depends on HAS_IOMEM
+ depends on OF && HAS_IOMEM
+ depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST
select GPIOLIB
select GPIOLIB_IRQCHIP
select GENERIC_PINCONF
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 13:27 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 13:27 UTC (permalink / raw) To: Linus Walleij, Lars Povlsen, Steen Hegelund, Alexandre Belloni Cc: Geert Uytterhoeven, linux-kernel, linux-mips, linux-gpio, UNGLinuxDriver, linux-arm-kernel the Microsemi/Microchip Serial GPIO device is present only Microsemi VCore III and Microchip Sparx5 SoCs. Hence add a dependency on ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this driver when configuring a kernel without support for these SoCs. Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pinctrl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -353,8 +353,8 @@ config PINCTRL_OCELOT config PINCTRL_MICROCHIP_SGPIO bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" - depends on OF - depends on HAS_IOMEM + depends on OF && HAS_IOMEM + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST select GPIOLIB select GPIOLIB_IRQCHIP select GENERIC_PINCONF -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 13:27 ` Geert Uytterhoeven @ 2021-02-10 13:45 ` Lars Povlsen -1 siblings, 0 replies; 14+ messages in thread From: Lars Povlsen @ 2021-02-10 13:45 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linus Walleij, Lars Povlsen, Steen Hegelund, Alexandre Belloni, UNGLinuxDriver, linux-gpio, linux-arm-kernel, linux-mips, linux-kernel Geert Uytterhoeven writes: > the Microsemi/Microchip Serial GPIO device is present only Microsemi > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > driver when configuring a kernel without support for these SoCs. > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/pinctrl/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > config PINCTRL_MICROCHIP_SGPIO > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > - depends on OF > - depends on HAS_IOMEM > + depends on OF && HAS_IOMEM > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > select GPIOLIB > select GPIOLIB_IRQCHIP > select GENERIC_PINCONF Geert, Thank you for your patch. Unfortunately, it makes it impossible to use the driver across PCIe - which is a specifically desired configuration. Could you add CONFIG_PCI to the || chain? Cheers, -- Lars Povlsen, Microchip ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 13:45 ` Lars Povlsen 0 siblings, 0 replies; 14+ messages in thread From: Lars Povlsen @ 2021-02-10 13:45 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Alexandre Belloni, linux-kernel, Linus Walleij, linux-mips, UNGLinuxDriver, linux-gpio, linux-arm-kernel, Steen Hegelund, Lars Povlsen Geert Uytterhoeven writes: > the Microsemi/Microchip Serial GPIO device is present only Microsemi > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > driver when configuring a kernel without support for these SoCs. > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/pinctrl/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > config PINCTRL_MICROCHIP_SGPIO > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > - depends on OF > - depends on HAS_IOMEM > + depends on OF && HAS_IOMEM > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > select GPIOLIB > select GPIOLIB_IRQCHIP > select GENERIC_PINCONF Geert, Thank you for your patch. Unfortunately, it makes it impossible to use the driver across PCIe - which is a specifically desired configuration. Could you add CONFIG_PCI to the || chain? Cheers, -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 13:45 ` Lars Povlsen @ 2021-02-10 13:53 ` Geert Uytterhoeven -1 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 13:53 UTC (permalink / raw) To: Lars Povlsen Cc: Linus Walleij, Steen Hegelund, Alexandre Belloni, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List Hi Lars, On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > Geert Uytterhoeven writes: > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > driver when configuring a kernel without support for these SoCs. > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > drivers/pinctrl/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > config PINCTRL_MICROCHIP_SGPIO > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > - depends on OF > > - depends on HAS_IOMEM > > + depends on OF && HAS_IOMEM > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > select GPIOLIB > > select GPIOLIB_IRQCHIP > > select GENERIC_PINCONF > > Thank you for your patch. Unfortunately, it makes it impossible to use > the driver across PCIe - which is a specifically desired configuration. > > Could you add CONFIG_PCI to the || chain? Sure. Is PCIe the only other transport over which the register can be accessed? Or can this also be done over e.g. SPI, like on Ocelot[1]? [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 13:53 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 13:53 UTC (permalink / raw) To: Lars Povlsen Cc: Alexandre Belloni, Linux Kernel Mailing List, Linus Walleij, open list:BROADCOM NVRAM DRIVER, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Steen Hegelund, Linux ARM Hi Lars, On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > Geert Uytterhoeven writes: > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > driver when configuring a kernel without support for these SoCs. > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > drivers/pinctrl/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > --- a/drivers/pinctrl/Kconfig > > +++ b/drivers/pinctrl/Kconfig > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > config PINCTRL_MICROCHIP_SGPIO > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > - depends on OF > > - depends on HAS_IOMEM > > + depends on OF && HAS_IOMEM > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > select GPIOLIB > > select GPIOLIB_IRQCHIP > > select GENERIC_PINCONF > > Thank you for your patch. Unfortunately, it makes it impossible to use > the driver across PCIe - which is a specifically desired configuration. > > Could you add CONFIG_PCI to the || chain? Sure. Is PCIe the only other transport over which the register can be accessed? Or can this also be done over e.g. SPI, like on Ocelot[1]? [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 13:53 ` Geert Uytterhoeven @ 2021-02-10 14:17 ` Alexandre Belloni -1 siblings, 0 replies; 14+ messages in thread From: Alexandre Belloni @ 2021-02-10 14:17 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Lars Povlsen, Linus Walleij, Steen Hegelund, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > > Geert Uytterhoeven writes: > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > driver when configuring a kernel without support for these SoCs. > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > drivers/pinctrl/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > --- a/drivers/pinctrl/Kconfig > > > +++ b/drivers/pinctrl/Kconfig > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > - depends on OF > > > - depends on HAS_IOMEM > > > + depends on OF && HAS_IOMEM > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > select GPIOLIB > > > select GPIOLIB_IRQCHIP > > > select GENERIC_PINCONF > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > the driver across PCIe - which is a specifically desired configuration. > > > > Could you add CONFIG_PCI to the || chain? > > Sure. > > Is PCIe the only other transport over which the register can be accessed? > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) so this is also available over SPI. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 14:17 ` Alexandre Belloni 0 siblings, 0 replies; 14+ messages in thread From: Alexandre Belloni @ 2021-02-10 14:17 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Linux Kernel Mailing List, Linus Walleij, open list:BROADCOM NVRAM DRIVER, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Lars Povlsen, Steen Hegelund, Linux ARM On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > Hi Lars, > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > > Geert Uytterhoeven writes: > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > driver when configuring a kernel without support for these SoCs. > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > drivers/pinctrl/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > --- a/drivers/pinctrl/Kconfig > > > +++ b/drivers/pinctrl/Kconfig > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > - depends on OF > > > - depends on HAS_IOMEM > > > + depends on OF && HAS_IOMEM > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > select GPIOLIB > > > select GPIOLIB_IRQCHIP > > > select GENERIC_PINCONF > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > the driver across PCIe - which is a specifically desired configuration. > > > > Could you add CONFIG_PCI to the || chain? > > Sure. > > Is PCIe the only other transport over which the register can be accessed? > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) so this is also available over SPI. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 14:17 ` Alexandre Belloni @ 2021-02-10 14:21 ` Geert Uytterhoeven -1 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 14:21 UTC (permalink / raw) To: Alexandre Belloni Cc: Lars Povlsen, Linus Walleij, Steen Hegelund, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List Hi Alexandre, On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > > > Geert Uytterhoeven writes: > > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > > driver when configuring a kernel without support for these SoCs. > > > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > drivers/pinctrl/Kconfig | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > > --- a/drivers/pinctrl/Kconfig > > > > +++ b/drivers/pinctrl/Kconfig > > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > > - depends on OF > > > > - depends on HAS_IOMEM > > > > + depends on OF && HAS_IOMEM > > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > > select GPIOLIB > > > > select GPIOLIB_IRQCHIP > > > > select GENERIC_PINCONF > > > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > > the driver across PCIe - which is a specifically desired configuration. > > > > > > Could you add CONFIG_PCI to the || chain? > > > > Sure. > > > > Is PCIe the only other transport over which the register can be accessed? > > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > > > > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) > so this is also available over SPI. Hence would you consider depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST acceptable? Or would that be futile, as must systems have PCI and/or SPI enabled anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 14:21 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 14:21 UTC (permalink / raw) To: Alexandre Belloni Cc: Linux Kernel Mailing List, Linus Walleij, open list:BROADCOM NVRAM DRIVER, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Lars Povlsen, Steen Hegelund, Linux ARM Hi Alexandre, On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > > > Geert Uytterhoeven writes: > > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > > > > driver when configuring a kernel without support for these SoCs. > > > > > > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > drivers/pinctrl/Kconfig | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > > > > --- a/drivers/pinctrl/Kconfig > > > > +++ b/drivers/pinctrl/Kconfig > > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > > > > > > > > config PINCTRL_MICROCHIP_SGPIO > > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > > > > - depends on OF > > > > - depends on HAS_IOMEM > > > > + depends on OF && HAS_IOMEM > > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > > > > select GPIOLIB > > > > select GPIOLIB_IRQCHIP > > > > select GENERIC_PINCONF > > > > > > Thank you for your patch. Unfortunately, it makes it impossible to use > > > the driver across PCIe - which is a specifically desired configuration. > > > > > > Could you add CONFIG_PCI to the || chain? > > > > Sure. > > > > Is PCIe the only other transport over which the register can be accessed? > > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > > > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > > > > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) > so this is also available over SPI. Hence would you consider depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST acceptable? Or would that be futile, as must systems have PCI and/or SPI enabled anyway? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 14:21 ` Geert Uytterhoeven @ 2021-02-10 14:24 ` Lars Povlsen -1 siblings, 0 replies; 14+ messages in thread From: Lars Povlsen @ 2021-02-10 14:24 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Alexandre Belloni, Lars Povlsen, Linus Walleij, Steen Hegelund, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List Geert Uytterhoeven writes: > Hi Alexandre, > > On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: >> On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: >> > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: >> > > Geert Uytterhoeven writes: >> > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi >> > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on >> > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this >> > > > driver when configuring a kernel without support for these SoCs. >> > > > >> > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") >> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> > > > --- >> > > > drivers/pinctrl/Kconfig | 4 ++-- >> > > > 1 file changed, 2 insertions(+), 2 deletions(-) >> > > > >> > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >> > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 >> > > > --- a/drivers/pinctrl/Kconfig >> > > > +++ b/drivers/pinctrl/Kconfig >> > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT >> > > > >> > > > config PINCTRL_MICROCHIP_SGPIO >> > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" >> > > > - depends on OF >> > > > - depends on HAS_IOMEM >> > > > + depends on OF && HAS_IOMEM >> > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST >> > > > select GPIOLIB >> > > > select GPIOLIB_IRQCHIP >> > > > select GENERIC_PINCONF >> > > >> > > Thank you for your patch. Unfortunately, it makes it impossible to use >> > > the driver across PCIe - which is a specifically desired configuration. >> > > >> > > Could you add CONFIG_PCI to the || chain? >> > >> > Sure. >> > >> > Is PCIe the only other transport over which the register can be accessed? >> > Or can this also be done over e.g. SPI, like on Ocelot[1]? >> > >> > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ >> > >> >> Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) >> so this is also available over SPI. > > Hence would you consider > > depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST > > acceptable? Or would that be futile, as must systems have PCI and/or > SPI enabled anyway? > > Gr{oetje,eeting}s, > > Geert Yes, that would be fine, but as you say - not have a lot of impact. Up to you... ---Lars -- Lars Povlsen, Microchip ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 14:24 ` Lars Povlsen 0 siblings, 0 replies; 14+ messages in thread From: Lars Povlsen @ 2021-02-10 14:24 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Alexandre Belloni, Linux Kernel Mailing List, Steen Hegelund, open list:BROADCOM NVRAM DRIVER, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, Linus Walleij, Lars Povlsen Geert Uytterhoeven writes: > Hi Alexandre, > > On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: >> On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: >> > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: >> > > Geert Uytterhoeven writes: >> > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi >> > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on >> > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this >> > > > driver when configuring a kernel without support for these SoCs. >> > > > >> > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") >> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> > > > --- >> > > > drivers/pinctrl/Kconfig | 4 ++-- >> > > > 1 file changed, 2 insertions(+), 2 deletions(-) >> > > > >> > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >> > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 >> > > > --- a/drivers/pinctrl/Kconfig >> > > > +++ b/drivers/pinctrl/Kconfig >> > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT >> > > > >> > > > config PINCTRL_MICROCHIP_SGPIO >> > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" >> > > > - depends on OF >> > > > - depends on HAS_IOMEM >> > > > + depends on OF && HAS_IOMEM >> > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST >> > > > select GPIOLIB >> > > > select GPIOLIB_IRQCHIP >> > > > select GENERIC_PINCONF >> > > >> > > Thank you for your patch. Unfortunately, it makes it impossible to use >> > > the driver across PCIe - which is a specifically desired configuration. >> > > >> > > Could you add CONFIG_PCI to the || chain? >> > >> > Sure. >> > >> > Is PCIe the only other transport over which the register can be accessed? >> > Or can this also be done over e.g. SPI, like on Ocelot[1]? >> > >> > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ >> > >> >> Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) >> so this is also available over SPI. > > Hence would you consider > > depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST > > acceptable? Or would that be futile, as must systems have PCI and/or > SPI enabled anyway? > > Gr{oetje,eeting}s, > > Geert Yes, that would be fine, but as you say - not have a lot of impact. Up to you... ---Lars -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII 2021-02-10 14:24 ` Lars Povlsen @ 2021-02-10 14:28 ` Geert Uytterhoeven -1 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 14:28 UTC (permalink / raw) To: Lars Povlsen Cc: Alexandre Belloni, Linus Walleij, Steen Hegelund, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linux ARM, open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List Hi Lars, On Wed, Feb 10, 2021 at 3:24 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > Geert Uytterhoeven writes: > > On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni > > <alexandre.belloni@bootlin.com> wrote: > >> On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > >> > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > >> > > Geert Uytterhoeven writes: > >> > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > >> > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > >> > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > >> > > > driver when configuring a kernel without support for these SoCs. > >> > > > > >> > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > >> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > > > --- > >> > > > drivers/pinctrl/Kconfig | 4 ++-- > >> > > > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > > > >> > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >> > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > >> > > > --- a/drivers/pinctrl/Kconfig > >> > > > +++ b/drivers/pinctrl/Kconfig > >> > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > >> > > > > >> > > > config PINCTRL_MICROCHIP_SGPIO > >> > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > >> > > > - depends on OF > >> > > > - depends on HAS_IOMEM > >> > > > + depends on OF && HAS_IOMEM > >> > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > >> > > > select GPIOLIB > >> > > > select GPIOLIB_IRQCHIP > >> > > > select GENERIC_PINCONF > >> > > > >> > > Thank you for your patch. Unfortunately, it makes it impossible to use > >> > > the driver across PCIe - which is a specifically desired configuration. > >> > > > >> > > Could you add CONFIG_PCI to the || chain? > >> > > >> > Sure. > >> > > >> > Is PCIe the only other transport over which the register can be accessed? > >> > Or can this also be done over e.g. SPI, like on Ocelot[1]? > >> > > >> > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > >> > > >> > >> Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) > >> so this is also available over SPI. > > > > Hence would you consider > > > > depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST > > > > acceptable? Or would that be futile, as must systems have PCI and/or > > SPI enabled anyway? > > > > Gr{oetje,eeting}s, > > > > Geert > > Yes, that would be fine, but as you say - not have a lot of impact. > > Up to you... OK, I'll drop this. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII @ 2021-02-10 14:28 ` Geert Uytterhoeven 0 siblings, 0 replies; 14+ messages in thread From: Geert Uytterhoeven @ 2021-02-10 14:28 UTC (permalink / raw) To: Lars Povlsen Cc: Alexandre Belloni, Linux Kernel Mailing List, Steen Hegelund, open list:BROADCOM NVRAM DRIVER, Microchip Linux Driver Support, open list:GPIO SUBSYSTEM, Linus Walleij, Linux ARM Hi Lars, On Wed, Feb 10, 2021 at 3:24 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > Geert Uytterhoeven writes: > > On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni > > <alexandre.belloni@bootlin.com> wrote: > >> On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: > >> > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen <lars.povlsen@microchip.com> wrote: > >> > > Geert Uytterhoeven writes: > >> > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi > >> > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on > >> > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this > >> > > > driver when configuring a kernel without support for these SoCs. > >> > > > > >> > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") > >> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > > > --- > >> > > > drivers/pinctrl/Kconfig | 4 ++-- > >> > > > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > > > >> > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > >> > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 > >> > > > --- a/drivers/pinctrl/Kconfig > >> > > > +++ b/drivers/pinctrl/Kconfig > >> > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT > >> > > > > >> > > > config PINCTRL_MICROCHIP_SGPIO > >> > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" > >> > > > - depends on OF > >> > > > - depends on HAS_IOMEM > >> > > > + depends on OF && HAS_IOMEM > >> > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST > >> > > > select GPIOLIB > >> > > > select GPIOLIB_IRQCHIP > >> > > > select GENERIC_PINCONF > >> > > > >> > > Thank you for your patch. Unfortunately, it makes it impossible to use > >> > > the driver across PCIe - which is a specifically desired configuration. > >> > > > >> > > Could you add CONFIG_PCI to the || chain? > >> > > >> > Sure. > >> > > >> > Is PCIe the only other transport over which the register can be accessed? > >> > Or can this also be done over e.g. SPI, like on Ocelot[1]? > >> > > >> > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ > >> > > >> > >> Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) > >> so this is also available over SPI. > > > > Hence would you consider > > > > depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST > > > > acceptable? Or would that be futile, as must systems have PCI and/or > > SPI enabled anyway? > > > > Gr{oetje,eeting}s, > > > > Geert > > Yes, that would be fine, but as you say - not have a lot of impact. > > Up to you... OK, I'll drop this. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-02-10 14:29 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-02-10 13:27 [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII Geert Uytterhoeven 2021-02-10 13:27 ` Geert Uytterhoeven 2021-02-10 13:45 ` Lars Povlsen 2021-02-10 13:45 ` Lars Povlsen 2021-02-10 13:53 ` Geert Uytterhoeven 2021-02-10 13:53 ` Geert Uytterhoeven 2021-02-10 14:17 ` Alexandre Belloni 2021-02-10 14:17 ` Alexandre Belloni 2021-02-10 14:21 ` Geert Uytterhoeven 2021-02-10 14:21 ` Geert Uytterhoeven 2021-02-10 14:24 ` Lars Povlsen 2021-02-10 14:24 ` Lars Povlsen 2021-02-10 14:28 ` Geert Uytterhoeven 2021-02-10 14:28 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.