* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-08 12:46 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-08 12:46 UTC (permalink / raw) To: Rob Herring, Mark Rutland Cc: Simon Horman, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>; + status = "disabled"; + }; + + i2c7: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-08 12:46 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-08 12:46 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -436,6 +439,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg CPG_MOD 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
[parent not found: <1502196418-31341-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>]
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-08 12:46 ` Biju Das (?) @ 2017-08-09 8:56 ` Simon Horman -1 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-09 8:56 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Tue, Aug 08, 2017 at 01:46:58PM +0100, Biju Das wrote: > Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > --- > This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html Process comments as per those for "[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support". Patch itself looks good to me. > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 14222c72..5c2b140 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -436,6 +439,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg CPG_MOD 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial@e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-09 8:56 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-09 8:56 UTC (permalink / raw) To: linux-arm-kernel On Tue, Aug 08, 2017 at 01:46:58PM +0100, Biju Das wrote: > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html Process comments as per those for "[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support". Patch itself looks good to me. > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 14222c72..5c2b140 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -436,6 +439,58 @@ > status = "disabled"; > }; > > + i2c6: i2c at e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg CPG_MOD 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c at e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c at e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial at e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-09 8:56 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-09 8:56 UTC (permalink / raw) To: Biju Das Cc: Rob Herring, Mark Rutland, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On Tue, Aug 08, 2017 at 01:46:58PM +0100, Biju Das wrote: > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html Process comments as per those for "[PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support". Patch itself looks good to me. > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 14222c72..5c2b140 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -436,6 +439,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg CPG_MOD 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial@e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-08 12:46 ` Biju Das @ 2017-08-09 9:17 ` Sergei Shtylyov -1 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-09 9:17 UTC (permalink / raw) To: Biju Das, Rob Herring, Mark Rutland Cc: Simon Horman, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On 8/8/2017 3:46 PM, Biju Das wrote: > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 14222c72..5c2b140 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi [...] > @@ -436,6 +439,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { I'd use iic0 as the label. > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg CPG_MOD 926>; CPG_MOD not needed here, it's not a "clocks" prop. [...] MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-09 9:17 ` Sergei Shtylyov 0 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-09 9:17 UTC (permalink / raw) To: linux-arm-kernel On 8/8/2017 3:46 PM, Biju Das wrote: > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 14222c72..5c2b140 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi [...] > @@ -436,6 +439,58 @@ > status = "disabled"; > }; > > + i2c6: i2c at e60b0000 { I'd use iic0 as the label. > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg CPG_MOD 926>; CPG_MOD not needed here, it's not a "clocks" prop. [...] MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <12d923ba-184c-ef59-f27b-41a7592a5f93-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-09 9:17 ` Sergei Shtylyov (?) @ 2017-08-09 9:21 ` Biju Das -1 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-09 9:21 UTC (permalink / raw) To: Sergei Shtylyov, Rob Herring, Mark Rutland Cc: Simon Horman, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2378 bytes --] > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: 09 August 2017 10:17 > To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com> > Cc: Simon Horman <horms@verge.net.au>; Wolfram Sang <wsa@the- > dreams.de>; Magnus Damm <magnus.damm@gmail.com>; Russell King > <linux@armlinux.org.uk>; Chris Paterson <Chris.Paterson2@renesas.com>; > devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi > > On 8/8/2017 3:46 PM, Biju Das wrote: > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > This patch has been tested against Linux-next tag 20170727 and renesas-dev > branch. > > This patch depends on > > https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > > @@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > > > > +i2c6: i2c@e60b0000 { > > I'd use iic0 as the label. > > > +/* doesn't need pinmux */ > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,iic-r8a7743", > > + "renesas,rcar-gen2-iic", > > + "renesas,rmobile-iic"; > > +reg = <0 0xe60b0000 0 0x425>; > > +interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 926>; > > +dmas = <&dmac0 0x77>, <&dmac0 0x78>, > > + <&dmac1 0x77>, <&dmac1 0x78>; > > +dma-names = "tx", "rx", "tx", "rx"; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. Thanks Sergie, I will correct this. [>] > [...] > > MBR, Sergei Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·zøœzÚÞz)í…æèw*\x1fjg¬±¨\x1e¶‰šŽŠÝ¢j.ïÛ°\½½MŽúgjÌæa×\x02››–' ™©Þ¢¸\f¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾\a«‘êçzZ+ƒùšŽŠÝ¢j"ú!¶i ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-09 9:21 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-09 9:21 UTC (permalink / raw) To: linux-arm-kernel > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov at cogentembedded.com] > Sent: 09 August 2017 10:17 > To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com> > Cc: Simon Horman <horms@verge.net.au>; Wolfram Sang <wsa@the- > dreams.de>; Magnus Damm <magnus.damm@gmail.com>; Russell King > <linux@armlinux.org.uk>; Chris Paterson <Chris.Paterson2@renesas.com>; > devicetree at vger.kernel.org; linux-renesas-soc at vger.kernel.org; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi > > On 8/8/2017 3:46 PM, Biju Das wrote: > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > This patch has been tested against Linux-next tag 20170727 and renesas-dev > branch. > > This patch depends on > > https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > > @@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > > > > +i2c6: i2c at e60b0000 { > > I'd use iic0 as the label. > > > +/* doesn't need pinmux */ > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,iic-r8a7743", > > + "renesas,rcar-gen2-iic", > > + "renesas,rmobile-iic"; > > +reg = <0 0xe60b0000 0 0x425>; > > +interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 926>; > > +dmas = <&dmac0 0x77>, <&dmac0 0x78>, > > + <&dmac1 0x77>, <&dmac1 0x78>; > > +dma-names = "tx", "rx", "tx", "rx"; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. Thanks Sergie, I will correct this. [>] > [...] > > MBR, Sergei Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 46+ messages in thread
* RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-09 9:21 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-09 9:21 UTC (permalink / raw) To: Sergei Shtylyov, Rob Herring, Mark Rutland Cc: Simon Horman, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: 09 August 2017 10:17 > To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com> > Cc: Simon Horman <horms@verge.net.au>; Wolfram Sang <wsa@the- > dreams.de>; Magnus Damm <magnus.damm@gmail.com>; Russell King > <linux@armlinux.org.uk>; Chris Paterson <Chris.Paterson2@renesas.com>; > devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi > > On 8/8/2017 3:46 PM, Biju Das wrote: > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > --- > > This patch has been tested against Linux-next tag 20170727 and renesas-dev > branch. > > This patch depends on > > https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > > @@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > > > > +i2c6: i2c@e60b0000 { > > I'd use iic0 as the label. > > > +/* doesn't need pinmux */ > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,iic-r8a7743", > > + "renesas,rcar-gen2-iic", > > + "renesas,rmobile-iic"; > > +reg = <0 0xe60b0000 0 0x425>; > > +interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 926>; > > +dmas = <&dmac0 0x77>, <&dmac0 0x78>, > > + <&dmac1 0x77>, <&dmac1 0x78>; > > +dma-names = "tx", "rx", "tx", "rx"; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. Thanks Sergie, I will correct this. [>] > [...] > > MBR, Sergei Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709. ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-09 9:17 ` Sergei Shtylyov (?) @ 2017-08-10 8:01 ` Simon Horman -1 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-10 8:01 UTC (permalink / raw) To: Sergei Shtylyov Cc: Biju Das, Rob Herring, Mark Rutland, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote: > On 8/8/2017 3:46 PM, Biju Das wrote: > > >Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > >--- > >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > >index 14222c72..5c2b140 100644 > >--- a/arch/arm/boot/dts/r8a7743.dtsi > >+++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > >@@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > >+ i2c6: i2c@e60b0000 { > > I'd use iic0 as the label. I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > >+ /* doesn't need pinmux */ > >+ #address-cells = <1>; > >+ #size-cells = <0>; > >+ compatible = "renesas,iic-r8a7743", > >+ "renesas,rcar-gen2-iic", > >+ "renesas,rmobile-iic"; > >+ reg = <0 0xe60b0000 0 0x425>; > >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > >+ clocks = <&cpg CPG_MOD 926>; > >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>, > >+ <&dmac1 0x77>, <&dmac1 0x78>; > >+ dma-names = "tx", "rx", "tx", "rx"; > >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > >+ resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 8:01 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-10 8:01 UTC (permalink / raw) To: linux-arm-kernel On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote: > On 8/8/2017 3:46 PM, Biju Das wrote: > > >Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >--- > >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > >index 14222c72..5c2b140 100644 > >--- a/arch/arm/boot/dts/r8a7743.dtsi > >+++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > >@@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > >+ i2c6: i2c at e60b0000 { > > I'd use iic0 as the label. I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > >+ /* doesn't need pinmux */ > >+ #address-cells = <1>; > >+ #size-cells = <0>; > >+ compatible = "renesas,iic-r8a7743", > >+ "renesas,rcar-gen2-iic", > >+ "renesas,rmobile-iic"; > >+ reg = <0 0xe60b0000 0 0x425>; > >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > >+ clocks = <&cpg CPG_MOD 926>; > >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>, > >+ <&dmac1 0x77>, <&dmac1 0x78>; > >+ dma-names = "tx", "rx", "tx", "rx"; > >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > >+ resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. > > [...] > > MBR, Sergei > ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 8:01 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-10 8:01 UTC (permalink / raw) To: Sergei Shtylyov Cc: Biju Das, Rob Herring, Mark Rutland, Wolfram Sang, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote: > On 8/8/2017 3:46 PM, Biju Das wrote: > > >Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >--- > >This patch has been tested against Linux-next tag 20170727 and renesas-dev branch. > >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html > > > > arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 55 insertions(+) > > > >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > >index 14222c72..5c2b140 100644 > >--- a/arch/arm/boot/dts/r8a7743.dtsi > >+++ b/arch/arm/boot/dts/r8a7743.dtsi > [...] > >@@ -436,6 +439,58 @@ > > status = "disabled"; > > }; > >+ i2c6: i2c@e60b0000 { > > I'd use iic0 as the label. I have no preference here other than that we try to be consistent in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > >+ /* doesn't need pinmux */ > >+ #address-cells = <1>; > >+ #size-cells = <0>; > >+ compatible = "renesas,iic-r8a7743", > >+ "renesas,rcar-gen2-iic", > >+ "renesas,rmobile-iic"; > >+ reg = <0 0xe60b0000 0 0x425>; > >+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > >+ clocks = <&cpg CPG_MOD 926>; > >+ dmas = <&dmac0 0x77>, <&dmac0 0x78>, > >+ <&dmac1 0x77>, <&dmac1 0x78>; > >+ dma-names = "tx", "rx", "tx", "rx"; > >+ power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > >+ resets = <&cpg CPG_MOD 926>; > > CPG_MOD not needed here, it's not a "clocks" prop. > > [...] > > MBR, Sergei > ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <20170810080121.GE16647-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-10 8:01 ` Simon Horman (?) @ 2017-08-10 11:24 ` Wolfram Sang -1 siblings, 0 replies; 46+ messages in thread From: Wolfram Sang @ 2017-08-10 11:24 UTC (permalink / raw) To: Simon Horman Cc: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Magnus Damm, Russell King, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 508 bytes --] > > >+ i2c6: i2c@e60b0000 { > > > > I'd use iic0 as the label. > > I have no preference here other than that we try to be consistent > in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment "/* The memory map in the User's Manual maps the cores to bus numbers */" exists in r8a7791.dtsi. Dunno the manual of this SoC here. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 11:24 ` Wolfram Sang 0 siblings, 0 replies; 46+ messages in thread From: Wolfram Sang @ 2017-08-10 11:24 UTC (permalink / raw) To: linux-arm-kernel > > >+ i2c6: i2c at e60b0000 { > > > > I'd use iic0 as the label. > > I have no preference here other than that we try to be consistent > in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment "/* The memory map in the User's Manual maps the cores to bus numbers */" exists in r8a7791.dtsi. Dunno the manual of this SoC here. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170810/bb3d03e1/attachment.sig> ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 11:24 ` Wolfram Sang 0 siblings, 0 replies; 46+ messages in thread From: Wolfram Sang @ 2017-08-10 11:24 UTC (permalink / raw) To: Simon Horman Cc: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Magnus Damm, Russell King, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 508 bytes --] > > >+ i2c6: i2c@e60b0000 { > > > > I'd use iic0 as the label. > > I have no preference here other than that we try to be consistent > in DT for different R-Car SoCs. Wolfram, do you have an opinion on this? Back then, for M2-W, I decided to go with the schematics/datasheets. And those mentioned i2c6 rather than iic0. For that reason, the comment "/* The memory map in the User's Manual maps the cores to bus numbers */" exists in r8a7791.dtsi. Dunno the manual of this SoC here. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 46+ messages in thread
* RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-10 11:24 ` Wolfram Sang (?) @ 2017-08-10 13:49 ` Chris Paterson -1 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-10 13:49 UTC (permalink / raw) To: Wolfram Sang, Simon Horman Cc: Mark Rutland, devicetree, Sergei Shtylyov, Magnus Damm, Russell King, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel Hello, > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: 10 August 2017 12:24 > > > > > >+ i2c6: i2c@e60b0000 { > > > > > > I'd use iic0 as the label. > > > > I have no preference here other than that we try to be consistent in > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > Back then, for M2-W, I decided to go with the schematics/datasheets. > And those mentioned i2c6 rather than iic0. For that reason, the comment The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. > > "/* The memory map in the User's Manual maps the cores to bus numbers */" > > exists in r8a7791.dtsi. Dunno the manual of this SoC here. The manual for r8a7743 uses the same terminology as the r8a7791 manuals. Kind regards, Chris ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 13:49 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-10 13:49 UTC (permalink / raw) To: linux-arm-kernel Hello, > From: Wolfram Sang [mailto:wsa at the-dreams.de] > Sent: 10 August 2017 12:24 > > > > > >+ i2c6: i2c at e60b0000 { > > > > > > I'd use iic0 as the label. > > > > I have no preference here other than that we try to be consistent in > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > Back then, for M2-W, I decided to go with the schematics/datasheets. > And those mentioned i2c6 rather than iic0. For that reason, the comment The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. > > "/* The memory map in the User's Manual maps the cores to bus numbers */" > > exists in r8a7791.dtsi. Dunno the manual of this SoC here. The manual for r8a7743 uses the same terminology as the r8a7791 manuals. Kind regards, Chris ^ permalink raw reply [flat|nested] 46+ messages in thread
* RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-10 13:49 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-10 13:49 UTC (permalink / raw) To: Wolfram Sang, Simon Horman Cc: Sergei Shtylyov, Biju Das, Rob Herring, Mark Rutland, Magnus Damm, Russell King, devicetree, linux-renesas-soc, linux-arm-kernel Hello, > From: Wolfram Sang [mailto:wsa@the-dreams.de] > Sent: 10 August 2017 12:24 > > > > > >+ i2c6: i2c@e60b0000 { > > > > > > I'd use iic0 as the label. > > > > I have no preference here other than that we try to be consistent in > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > Back then, for M2-W, I decided to go with the schematics/datasheets. > And those mentioned i2c6 rather than iic0. For that reason, the comment The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. > > "/* The memory map in the User's Manual maps the cores to bus numbers */" > > exists in r8a7791.dtsi. Dunno the manual of this SoC here. The manual for r8a7743 uses the same terminology as the r8a7791 manuals. Kind regards, Chris ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-10 13:49 ` Chris Paterson @ 2017-08-11 8:48 ` Simon Horman -1 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-11 8:48 UTC (permalink / raw) To: Chris Paterson Cc: Wolfram Sang, Mark Rutland, devicetree, Sergei Shtylyov, Magnus Damm, Russell King, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel On Thu, Aug 10, 2017 at 01:49:05PM +0000, Chris Paterson wrote: > Hello, > > > From: Wolfram Sang [mailto:wsa@the-dreams.de] > > Sent: 10 August 2017 12:24 > > > > > > > > >+ i2c6: i2c@e60b0000 { > > > > > > > > I'd use iic0 as the label. > > > > > > I have no preference here other than that we try to be consistent in > > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > > > Back then, for M2-W, I decided to go with the schematics/datasheets. > > And those mentioned i2c6 rather than iic0. For that reason, the comment > > The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. +1 > > "/* The memory map in the User's Manual maps the cores to bus numbers */" > > > > exists in r8a7791.dtsi. Dunno the manual of this SoC here. > > The manual for r8a7743 uses the same terminology as the r8a7791 manuals. ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-11 8:48 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-11 8:48 UTC (permalink / raw) To: linux-arm-kernel On Thu, Aug 10, 2017 at 01:49:05PM +0000, Chris Paterson wrote: > Hello, > > > From: Wolfram Sang [mailto:wsa at the-dreams.de] > > Sent: 10 August 2017 12:24 > > > > > > > > >+ i2c6: i2c at e60b0000 { > > > > > > > > I'd use iic0 as the label. > > > > > > I have no preference here other than that we try to be consistent in > > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? > > > > Back then, for M2-W, I decided to go with the schematics/datasheets. > > And those mentioned i2c6 rather than iic0. For that reason, the comment > > The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. +1 > > "/* The memory map in the User's Manual maps the cores to bus numbers */" > > > > exists in r8a7791.dtsi. Dunno the manual of this SoC here. > > The manual for r8a7743 uses the same terminology as the r8a7791 manuals. ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-10 13:49 ` Chris Paterson @ 2017-08-14 14:15 ` Geert Uytterhoeven -1 siblings, 0 replies; 46+ messages in thread From: Geert Uytterhoeven @ 2017-08-14 14:15 UTC (permalink / raw) To: Chris Paterson Cc: Wolfram Sang, Simon Horman, Mark Rutland, devicetree, Sergei Shtylyov, Magnus Damm, Russell King, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel On Thu, Aug 10, 2017 at 3:49 PM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: Wolfram Sang [mailto:wsa@the-dreams.de] >> Sent: 10 August 2017 12:24 >> >> >> > > >+ i2c6: i2c@e60b0000 { >> > > >> > > I'd use iic0 as the label. Sergei: I assume you meant "iic3"? ;-) >> > >> > I have no preference here other than that we try to be consistent in >> > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? >> >> Back then, for M2-W, I decided to go with the schematics/datasheets. >> And those mentioned i2c6 rather than iic0. For that reason, the comment > > The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. > >> >> "/* The memory map in the User's Manual maps the cores to bus numbers */" >> >> exists in r8a7791.dtsi. Dunno the manual of this SoC here. > > The manual for r8a7743 uses the same terminology as the r8a7791 manuals. The pinctrl section does, indeed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-14 14:15 ` Geert Uytterhoeven 0 siblings, 0 replies; 46+ messages in thread From: Geert Uytterhoeven @ 2017-08-14 14:15 UTC (permalink / raw) To: linux-arm-kernel On Thu, Aug 10, 2017 at 3:49 PM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: Wolfram Sang [mailto:wsa at the-dreams.de] >> Sent: 10 August 2017 12:24 >> >> >> > > >+ i2c6: i2c at e60b0000 { >> > > >> > > I'd use iic0 as the label. Sergei: I assume you meant "iic3"? ;-) >> > >> > I have no preference here other than that we try to be consistent in >> > DT for different R-Car SoCs. Wolfram, do you have an opinion on this? >> >> Back then, for M2-W, I decided to go with the schematics/datasheets. >> And those mentioned i2c6 rather than iic0. For that reason, the comment > > The M2 schematics still use i2c6, and for consistency I'd vote to use the same with RZ/G1M. > >> >> "/* The memory map in the User's Manual maps the cores to bus numbers */" >> >> exists in r8a7791.dtsi. Dunno the manual of this SoC here. > > The manual for r8a7743 uses the same terminology as the r8a7791 manuals. The pinctrl section does, indeed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-14 14:15 ` Geert Uytterhoeven @ 2017-08-22 12:20 ` Sergei Shtylyov -1 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-22 12:20 UTC (permalink / raw) To: Geert Uytterhoeven, Chris Paterson Cc: Wolfram Sang, Simon Horman, Mark Rutland, devicetree, Magnus Damm, Russell King, Biju Das, linux-renesas-soc, Rob Herring, linux-arm-kernel Hello! On 08/14/2017 05:15 PM, Geert Uytterhoeven wrote: >>> From: Wolfram Sang [mailto:wsa@the-dreams.de] >>> Sent: 10 August 2017 12:24 >>> >>> >>>>>> + i2c6: i2c@e60b0000 { >>>>> >>>>> I'd use iic0 as the label. > > Sergei: I assume you meant "iic3"? ;-) After having a look at the manual, yes. :-) [...] > Gr{oetje,eeting}s, > > Geert MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-08-22 12:20 ` Sergei Shtylyov 0 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-22 12:20 UTC (permalink / raw) To: linux-arm-kernel Hello! On 08/14/2017 05:15 PM, Geert Uytterhoeven wrote: >>> From: Wolfram Sang [mailto:wsa at the-dreams.de] >>> Sent: 10 August 2017 12:24 >>> >>> >>>>>> + i2c6: i2c at e60b0000 { >>>>> >>>>> I'd use iic0 as the label. > > Sergei: I assume you meant "iic3"? ;-) After having a look at the manual, yes. :-) [...] > Gr{oetje,eeting}s, > > Geert MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi 2017-08-09 9:17 ` Sergei Shtylyov (?) @ 2017-08-14 9:53 ` Biju Das -1 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-14 9:53 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Sergei Shtylyov, Wolfram Sang, Simon Horman, Magnus Damm, Chris Paterson, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Biju Das Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> --- v1-->v2 Corrected the resets property for i2c6 device node. This patch is compiled against renesas-devel tag renesas-devel-20170814-v4.13-rc5. arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index ce80a26..480950f 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-14 9:53 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-14 9:53 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- v1-->v2 Corrected the resets property for i2c6 device node. This patch is compiled against renesas-devel tag renesas-devel-20170814-v4.13-rc5. arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index ce80a26..480950f 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-14 9:53 ` Biju Das 0 siblings, 0 replies; 46+ messages in thread From: Biju Das @ 2017-08-14 9:53 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Russell King Cc: Sergei Shtylyov, Wolfram Sang, Simon Horman, Magnus Damm, Chris Paterson, devicetree, linux-renesas-soc, linux-arm-kernel, Biju Das Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- v1-->v2 Corrected the resets property for i2c6 device node. This patch is compiled against renesas-devel tag renesas-devel-20170814-v4.13-rc5. arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index ce80a26..480950f 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
* RE: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi 2017-08-14 9:53 ` Biju Das (?) @ 2017-08-22 9:10 ` Chris Paterson -1 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-22 9:10 UTC (permalink / raw) To: Sergei Shtylyov, Wolfram Sang, Geert Uytterhoeven, Simon Horman Cc: Mark Rutland, Magnus Damm, devicetree, linux-renesas-soc, Rob Herring, linux-arm-kernel, Biju Das, Russell King Hello reviewers, > From: Biju Das [mailto:biju.das@bp.renesas.com] > Sent: 14 August 2017 10:53 > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > v1-->v2 > Corrected the resets property for i2c6 device node. Are you happy with this version of the patch? Or is the discussion for moving to 'iic' still alive? Thanks, Chris > > This patch is compiled against renesas-devel tag renesas-devel-20170814- > v4.13-rc5. > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index ce80a26..480950f 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -411,6 +414,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial@e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-22 9:10 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-22 9:10 UTC (permalink / raw) To: linux-arm-kernel Hello reviewers, > From: Biju Das [mailto:biju.das at bp.renesas.com] > Sent: 14 August 2017 10:53 > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > v1-->v2 > Corrected the resets property for i2c6 device node. Are you happy with this version of the patch? Or is the discussion for moving to 'iic' still alive? Thanks, Chris > > This patch is compiled against renesas-devel tag renesas-devel-20170814- > v4.13-rc5. > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index ce80a26..480950f 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -411,6 +414,58 @@ > status = "disabled"; > }; > > + i2c6: i2c at e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c at e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c at e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial at e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 ^ permalink raw reply [flat|nested] 46+ messages in thread
* RE: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-22 9:10 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-22 9:10 UTC (permalink / raw) To: Sergei Shtylyov, Wolfram Sang, Biju Das, Geert Uytterhoeven, Simon Horman Cc: Mark Rutland, Magnus Damm, devicetree, linux-renesas-soc, Rob Herring, linux-arm-kernel, Biju Das, Russell King Hello reviewers, > From: Biju Das [mailto:biju.das@bp.renesas.com] > Sent: 14 August 2017 10:53 > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > v1-->v2 > Corrected the resets property for i2c6 device node. Are you happy with this version of the patch? Or is the discussion for moving to 'iic' still alive? Thanks, Chris > > This patch is compiled against renesas-devel tag renesas-devel-20170814- > v4.13-rc5. > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index ce80a26..480950f 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -411,6 +414,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial@e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1 ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <TY1PR06MB07027D9A55FBFE2D591CEDCFB7840-/PRLmSCtZ14u2TXDOttQZW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi 2017-08-22 9:10 ` Chris Paterson (?) @ 2017-08-22 12:23 ` Sergei Shtylyov -1 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-22 12:23 UTC (permalink / raw) To: Chris Paterson, Wolfram Sang, Biju Das, Geert Uytterhoeven, Simon Horman Cc: Mark Rutland, Magnus Damm, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King On 08/22/2017 12:10 PM, Chris Paterson wrote: >> From: Biju Das [mailto:biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org] >> Sent: 14 August 2017 10:53 >> >> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> >> --- >> v1-->v2 >> Corrected the resets property for i2c6 device node. > > Are you happy with this version of the patch? > > Or is the discussion for moving to 'iic' still alive? Yes, appears so. I'd like the labels to be named iic<n>. > Thanks, Chris MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-22 12:23 ` Sergei Shtylyov 0 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-22 12:23 UTC (permalink / raw) To: linux-arm-kernel On 08/22/2017 12:10 PM, Chris Paterson wrote: >> From: Biju Das [mailto:biju.das at bp.renesas.com] >> Sent: 14 August 2017 10:53 >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> --- >> v1-->v2 >> Corrected the resets property for i2c6 device node. > > Are you happy with this version of the patch? > > Or is the discussion for moving to 'iic' still alive? Yes, appears so. I'd like the labels to be named iic<n>. > Thanks, Chris MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-22 12:23 ` Sergei Shtylyov 0 siblings, 0 replies; 46+ messages in thread From: Sergei Shtylyov @ 2017-08-22 12:23 UTC (permalink / raw) To: Chris Paterson, Wolfram Sang, Biju Das, Geert Uytterhoeven, Simon Horman Cc: Mark Rutland, Magnus Damm, devicetree, linux-renesas-soc, Rob Herring, linux-arm-kernel, Russell King On 08/22/2017 12:10 PM, Chris Paterson wrote: >> From: Biju Das [mailto:biju.das@bp.renesas.com] >> Sent: 14 August 2017 10:53 >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> --- >> v1-->v2 >> Corrected the resets property for i2c6 device node. > > Are you happy with this version of the patch? > > Or is the discussion for moving to 'iic' still alive? Yes, appears so. I'd like the labels to be named iic<n>. > Thanks, Chris MBR, Sergei ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <b7434757-b151-5971-2b5f-525eeaf11467-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi 2017-08-22 12:23 ` Sergei Shtylyov (?) @ 2017-08-30 7:32 ` Simon Horman -1 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-30 7:32 UTC (permalink / raw) To: Sergei Shtylyov Cc: Chris Paterson, Wolfram Sang, Biju Das, Geert Uytterhoeven, Mark Rutland, Magnus Damm, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > >>From: Biju Das [mailto:biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org] > >>Sent: 14 August 2017 10:53 > >> > >>Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > >>--- > >>v1-->v2 > >> Corrected the resets property for i2c6 device node. > > > >Are you happy with this version of the patch? > > > >Or is the discussion for moving to 'iic' still alive? > > Yes, appears so. I'd like the labels to be named iic<n>. Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-30 7:32 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-30 7:32 UTC (permalink / raw) To: linux-arm-kernel On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > >>From: Biju Das [mailto:biju.das at bp.renesas.com] > >>Sent: 14 August 2017 10:53 > >> > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >>--- > >>v1-->v2 > >> Corrected the resets property for i2c6 device node. > > > >Are you happy with this version of the patch? > > > >Or is the discussion for moving to 'iic' still alive? > > Yes, appears so. I'd like the labels to be named iic<n>. Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready. ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-30 7:32 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-08-30 7:32 UTC (permalink / raw) To: Sergei Shtylyov Cc: Chris Paterson, Wolfram Sang, Biju Das, Geert Uytterhoeven, Mark Rutland, Magnus Damm, devicetree, linux-renesas-soc, Rob Herring, linux-arm-kernel, Russell King On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > >>From: Biju Das [mailto:biju.das@bp.renesas.com] > >>Sent: 14 August 2017 10:53 > >> > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >>--- > >>v1-->v2 > >> Corrected the resets property for i2c6 device node. > > > >Are you happy with this version of the patch? > > > >Or is the discussion for moving to 'iic' still alive? > > Yes, appears so. I'd like the labels to be named iic<n>. Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready. ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <20170830073214.GL10398-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]
* RE: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi 2017-08-30 7:32 ` Simon Horman (?) @ 2017-08-30 7:46 ` Chris Paterson -1 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-30 7:46 UTC (permalink / raw) To: Simon Horman, Sergei Shtylyov Cc: Wolfram Sang, Biju Das, Geert Uytterhoeven, Mark Rutland, Magnus Damm, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Rob Herring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Russell King > From: Simon Horman [mailto:horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org] > Sent: 30 August 2017 08:32 > > On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > > > >>From: Biju Das [mailto:biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org] > > >>Sent: 14 August 2017 10:53 > > >> > > >>Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > >>--- > > >>v1-->v2 > > >> Corrected the resets property for i2c6 device node. > > > > > >Are you happy with this version of the patch? > > > > > >Or is the discussion for moving to 'iic' still alive? > > > > Yes, appears so. I'd like the labels to be named iic<n>. > > Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 > when you are ready. Sure, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-30 7:46 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-30 7:46 UTC (permalink / raw) To: linux-arm-kernel > From: Simon Horman [mailto:horms at verge.net.au] > Sent: 30 August 2017 08:32 > > On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > > > >>From: Biju Das [mailto:biju.das at bp.renesas.com] > > >>Sent: 14 August 2017 10:53 > > >> > > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > >>--- > > >>v1-->v2 > > >> Corrected the resets property for i2c6 device node. > > > > > >Are you happy with this version of the patch? > > > > > >Or is the discussion for moving to 'iic' still alive? > > > > Yes, appears so. I'd like the labels to be named iic<n>. > > Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 > when you are ready. Sure, thanks. ^ permalink raw reply [flat|nested] 46+ messages in thread
* RE: [PATCH v2] ARM: dts: r8a7743: add IIC cores to dtsi @ 2017-08-30 7:46 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-08-30 7:46 UTC (permalink / raw) To: Simon Horman, Sergei Shtylyov Cc: Wolfram Sang, Biju Das, Geert Uytterhoeven, Mark Rutland, Magnus Damm, devicetree, linux-renesas-soc, Rob Herring, linux-arm-kernel, Russell King > From: Simon Horman [mailto:horms@verge.net.au] > Sent: 30 August 2017 08:32 > > On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > > > >>From: Biju Das [mailto:biju.das@bp.renesas.com] > > >>Sent: 14 August 2017 10:53 > > >> > > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > >>--- > > >>v1-->v2 > > >> Corrected the resets property for i2c6 device node. > > > > > >Are you happy with this version of the patch? > > > > > >Or is the discussion for moving to 'iic' still alive? > > > > Yes, appears so. I'd like the labels to be named iic<n>. > > Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 > when you are ready. Sure, thanks. ^ permalink raw reply [flat|nested] 46+ messages in thread
[parent not found: <1502704398-28378-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>]
* [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-08-14 9:53 ` Biju Das (?) @ 2017-09-06 13:52 ` Chris Paterson -1 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-09-06 13:52 UTC (permalink / raw) To: Simon Horman, Biju Das, Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov Cc: Magnus Damm, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Chris Paterson From: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Signed-off-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> --- v2->v3 - Renamed lables to use iic instead of i2c. v1->v2 - Corrected the resets property for i2c6 device node. This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. DT bindings has been accepted by Wolfram: https://patchwork.kernel.org/patch/9888119 arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 665a515..266c5ec 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &iic0; + i2c7 = &iic1; + i2c8 = &iic3; }; cpus { @@ -436,6 +439,58 @@ status = "disabled"; }; + iic0: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + iic1: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + + iic3: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 46+ messages in thread
* [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-09-06 13:52 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-09-06 13:52 UTC (permalink / raw) To: linux-arm-kernel From: Biju Das <biju.das@bp.renesas.com> Signed-off-by: Biju Das <biju.das@bp.renesas.com> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> --- v2->v3 - Renamed lables to use iic instead of i2c. v1->v2 - Corrected the resets property for i2c6 device node. This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. DT bindings has been accepted by Wolfram: https://patchwork.kernel.org/patch/9888119 arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 665a515..266c5ec 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &iic0; + i2c7 = &iic1; + i2c8 = &iic3; }; cpus { @@ -436,6 +439,58 @@ status = "disabled"; }; + iic0: i2c at e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + iic1: i2c at e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + + iic3: i2c at e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + scifa0: serial at e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
* [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-09-06 13:52 ` Chris Paterson 0 siblings, 0 replies; 46+ messages in thread From: Chris Paterson @ 2017-09-06 13:52 UTC (permalink / raw) To: Simon Horman, Biju Das, Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov Cc: Magnus Damm, linux-renesas-soc, devicetree, linux-arm-kernel, Chris Paterson From: Biju Das <biju.das@bp.renesas.com> Signed-off-by: Biju Das <biju.das@bp.renesas.com> Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> --- v2->v3 - Renamed lables to use iic instead of i2c. v1->v2 - Corrected the resets property for i2c6 device node. This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. DT bindings has been accepted by Wolfram: https://patchwork.kernel.org/patch/9888119 arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 665a515..266c5ec 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &iic0; + i2c7 = &iic1; + i2c8 = &iic3; }; cpus { @@ -436,6 +439,58 @@ status = "disabled"; }; + iic0: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + iic1: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + + iic3: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 46+ messages in thread
[parent not found: <1504705926-31625-1-git-send-email-chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi 2017-09-06 13:52 ` Chris Paterson (?) @ 2017-09-11 7:25 ` Simon Horman -1 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-09-11 7:25 UTC (permalink / raw) To: Chris Paterson Cc: Biju Das, Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov, Magnus Damm, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, Sep 06, 2017 at 02:52:06PM +0100, Chris Paterson wrote: > From: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > > Signed-off-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> > Signed-off-by: Chris Paterson <chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > --- > v2->v3 > - Renamed lables to use iic instead of i2c. > > v1->v2 > - Corrected the resets property for i2c6 device node. > > This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. > > DT bindings has been accepted by Wolfram: > https://patchwork.kernel.org/patch/9888119 Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-09-11 7:25 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-09-11 7:25 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 06, 2017 at 02:52:06PM +0100, Chris Paterson wrote: > From: Biju Das <biju.das@bp.renesas.com> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > --- > v2->v3 > - Renamed lables to use iic instead of i2c. > > v1->v2 > - Corrected the resets property for i2c6 device node. > > This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. > > DT bindings has been accepted by Wolfram: > https://patchwork.kernel.org/patch/9888119 Thanks, applied. ^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH v3] ARM: dts: r8a7743: Add IIC cores to dtsi @ 2017-09-11 7:25 ` Simon Horman 0 siblings, 0 replies; 46+ messages in thread From: Simon Horman @ 2017-09-11 7:25 UTC (permalink / raw) To: Chris Paterson Cc: Biju Das, Rob Herring, Mark Rutland, Russell King, Sergei Shtylyov, Magnus Damm, linux-renesas-soc, devicetree, linux-arm-kernel On Wed, Sep 06, 2017 at 02:52:06PM +0100, Chris Paterson wrote: > From: Biju Das <biju.das@bp.renesas.com> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > --- > v2->v3 > - Renamed lables to use iic instead of i2c. > > v1->v2 > - Corrected the resets property for i2c6 device node. > > This patch is based on renesas-devel tag renesas-devel-20170905-v4.13. > > DT bindings has been accepted by Wolfram: > https://patchwork.kernel.org/patch/9888119 Thanks, applied. ^ permalink raw reply [flat|nested] 46+ messages in thread
end of thread, other threads:[~2017-09-11 7:25 UTC | newest]
Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 12:46 [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi Biju Das
2017-08-08 12:46 ` Biju Das
[not found] ` <1502196418-31341-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-08-09 8:56 ` Simon Horman
2017-08-09 8:56 ` Simon Horman
2017-08-09 8:56 ` Simon Horman
2017-08-09 9:17 ` Sergei Shtylyov
2017-08-09 9:17 ` Sergei Shtylyov
[not found] ` <12d923ba-184c-ef59-f27b-41a7592a5f93-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-08-09 9:21 ` Biju Das
2017-08-09 9:21 ` Biju Das
2017-08-09 9:21 ` Biju Das
2017-08-10 8:01 ` Simon Horman
2017-08-10 8:01 ` Simon Horman
2017-08-10 8:01 ` Simon Horman
[not found] ` <20170810080121.GE16647-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 11:24 ` Wolfram Sang
2017-08-10 13:49 ` Chris Paterson
2017-08-10 13:49 ` Chris Paterson
2017-08-10 13:49 ` Chris Paterson
2017-08-11 8:48 ` Simon Horman
2017-08-11 8:48 ` Simon Horman
2017-08-14 14:15 ` Geert Uytterhoeven
2017-08-14 14:15 ` Geert Uytterhoeven
2017-08-22 12:20 ` Sergei Shtylyov
2017-08-22 12:20 ` Sergei Shtylyov
2017-08-14 9:53 ` [PATCH v2] ARM: dts: r8a7743: add " Biju Das
2017-08-14 9:53 ` Biju Das
2017-08-14 9:53 ` Biju Das
2017-08-22 9:10 ` Chris Paterson
2017-08-22 9:10 ` Chris Paterson
2017-08-22 9:10 ` Chris Paterson
[not found] ` <TY1PR06MB07027D9A55FBFE2D591CEDCFB7840-/PRLmSCtZ14u2TXDOttQZW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-08-22 12:23 ` Sergei Shtylyov
2017-08-22 12:23 ` Sergei Shtylyov
2017-08-22 12:23 ` Sergei Shtylyov
[not found] ` <b7434757-b151-5971-2b5f-525eeaf11467-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-08-30 7:32 ` Simon Horman
2017-08-30 7:32 ` Simon Horman
2017-08-30 7:32 ` Simon Horman
[not found] ` <20170830073214.GL10398-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2017-08-30 7:46 ` Chris Paterson
2017-08-30 7:46 ` Chris Paterson
2017-08-30 7:46 ` Chris Paterson
[not found] ` <1502704398-28378-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-09-06 13:52 ` [PATCH v3] ARM: dts: r8a7743: Add " Chris Paterson
2017-09-06 13:52 ` Chris Paterson
2017-09-06 13:52 ` Chris Paterson
[not found] ` <1504705926-31625-1-git-send-email-chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2017-09-11 7:25 ` Simon Horman
2017-09-11 7:25 ` Simon Horman
2017-09-11 7:25 ` Simon Horman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.