* [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
@ 2021-12-29 19:18 Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Laurent Pinchart @ 2021-12-29 19:18 UTC (permalink / raw)
To: linux-renesas-soc
Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm
Endpoints node must have a remote-endpoint property, as endpoints only
exist to model a link between ports. Drop the empty lvds endpoints from
SoC dtsi files, then should be instead declared in the board dts or in
overlays.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
11 files changed, 28 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 6f4fffacfca2..9a8c1bd923af 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
index 0f7bdfc90a0d..8912c1665ed9 100644
--- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
@@ -2616,8 +2616,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index d597772c4c37..263f39fb8ad9 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1910,8 +1910,6 @@ lvds0_in: endpoint {
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
@@ -1937,8 +1935,6 @@ lvds1_in: endpoint {
port@1 {
reg = <1>;
- lvds1_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 379a1300272b..02b35e68a3fa 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -2891,8 +2891,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
index 1768a3e6bb8d..0919d8f540c4 100644
--- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
@@ -3362,8 +3362,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
index 2bd8169735d3..221ee1ec415d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
@@ -2959,8 +2959,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 08df75606430..5f3046eee365 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 517892cf6294..ad021b2703ab 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -1190,8 +1190,6 @@ lvds0_in: endpoint {
};
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 6347d15e66b6..29f1161da957 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1567,8 +1567,6 @@ lvds0_in: endpoint {
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 0ea300a8147d..735c46217835 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -2059,8 +2059,6 @@ lvds0_in: endpoint {
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
@@ -2086,8 +2084,6 @@ lvds1_in: endpoint {
port@1 {
reg = <1>;
- lvds1_out: endpoint {
- };
};
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 16ad5fc23a67..759505bd1a44 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -1380,8 +1380,6 @@ lvds0_in: endpoint {
port@1 {
reg = <1>;
- lvds0_out: endpoint {
- };
};
};
};
@@ -1407,8 +1405,6 @@ lvds1_in: endpoint {
port@1 {
reg = <1>;
- lvds1_out: endpoint {
- };
};
};
};
base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
@ 2021-12-29 19:18 ` Laurent Pinchart
2022-01-26 11:10 ` Geert Uytterhoeven
2022-02-21 14:26 ` Kieran Bingham
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
2022-02-21 14:17 ` Kieran Bingham
2 siblings, 2 replies; 9+ messages in thread
From: Laurent Pinchart @ 2021-12-29 19:18 UTC (permalink / raw)
To: linux-renesas-soc
Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm
Endpoints node must have a remote-endpoint property, as endpoints only
exist to model a link between ports. Drop the empty rgb output endpoints
from SoC dtsi files, and declare them in the board dts instead.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
.../boot/dts/renesas/beacon-renesom-baseboard.dtsi | 10 ++++++++--
arch/arm64/boot/dts/renesas/draak.dtsi | 2 +-
arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 2 +-
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77961.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 --
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 --
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
17 files changed, 12 insertions(+), 30 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
index 2692cc64bff6..1465adc43580 100644
--- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
+++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
@@ -272,8 +272,14 @@ &can1 {
status = "okay";
};
-&du_out_rgb {
- remote-endpoint = <&rgb_panel>;
+&du {
+ ports {
+ port@0 {
+ du_out_rgb: endpoint {
+ remote-endpoint = <&rgb_panel>;
+ };
+ };
+ };
};
&ehci0 {
diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
index eb0327c0df48..b09f06086840 100644
--- a/arch/arm64/boot/dts/renesas/draak.dtsi
+++ b/arch/arm64/boot/dts/renesas/draak.dtsi
@@ -285,7 +285,7 @@ &du {
ports {
port@0 {
- endpoint {
+ du_out_rgb: endpoint {
remote-endpoint = <&adv7123_in>;
};
};
diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi
index 67231c8576c5..9e6093524682 100644
--- a/arch/arm64/boot/dts/renesas/ebisu.dtsi
+++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi
@@ -356,7 +356,7 @@ &du {
ports {
port@0 {
- endpoint {
+ du_out_rgb: endpoint {
remote-endpoint = <&adv7123_in>;
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 9a8c1bd923af..6105316ccac2 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2733,8 +2733,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
index 8912c1665ed9..7cdf009b1ee6 100644
--- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
@@ -2578,8 +2578,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index 4e72e4f2bab0..5a6ea08ffd2b 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -172,7 +172,7 @@ &du {
ports {
port@0 {
- endpoint {
+ du_out_rgb: endpoint {
remote-endpoint = <&tda19988_in>;
};
};
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 263f39fb8ad9..8b875b212a48 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1867,8 +1867,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 02b35e68a3fa..b9ab5cb01419 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -2853,8 +2853,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
index 0919d8f540c4..b88af4c90f33 100644
--- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
@@ -3318,8 +3318,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
index 221ee1ec415d..5e12e80d115e 100644
--- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
@@ -2921,8 +2921,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
index ba9358abebb2..4df8ffa84461 100644
--- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
@@ -2706,8 +2706,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 5f3046eee365..454e95222acf 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -2733,8 +2733,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
reg = <1>;
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index ad021b2703ab..dc11845625c4 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -1156,8 +1156,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
index 29f1161da957..53d0e6b4b75e 100644
--- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -1532,8 +1532,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 735c46217835..f49173045232 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -2016,8 +2016,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 759505bd1a44..3237ff4e5c77 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -1337,8 +1337,6 @@ ports {
port@0 {
reg = <0>;
- du_out_rgb: endpoint {
- };
};
port@1 {
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index bf37777dca31..0b0b1fc3a270 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -385,7 +385,7 @@ &du {
ports {
port@0 {
- endpoint {
+ du_out_rgb: endpoint {
remote-endpoint = <&adv7123_in>;
};
};
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
@ 2022-01-10 10:10 ` Geert Uytterhoeven
2022-01-10 11:24 ` Laurent Pinchart
2022-02-21 14:10 ` Laurent Pinchart
2022-02-21 14:17 ` Kieran Bingham
2 siblings, 2 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2022-01-10 10:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Magnus Damm
Hi Laurent,
On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty lvds endpoints from
> SoC dtsi files, then should be instead declared in the board dts or in
> overlays.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thanks for your patch!
I'm interested in hearing Rob's opinion about the general idea...
> ---
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> 11 files changed, 28 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 6f4fffacfca2..9a8c1bd923af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
As there are several DTS files that refer to this label, this change
will break them?
> base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
Why does this depend on a commit in drm-next?
DTS changes are supposed to go in through renesas-devel and soc.
> prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
While Google does not index by commit ID or patch ID, at least the
base-commit can be found easily in linux-next. But even with some
scripting, the prerequisites cannot. What are these prerequisites?
Do you have lore links?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
@ 2022-01-10 11:24 ` Laurent Pinchart
2022-01-10 12:07 ` Geert Uytterhoeven
2022-02-21 14:10 ` Laurent Pinchart
1 sibling, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2022-01-10 11:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Magnus Damm
Hi Geert,
On Mon, Jan 10, 2022 at 11:10:59AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart wrote:
> > Endpoints node must have a remote-endpoint property, as endpoints only
> > exist to model a link between ports. Drop the empty lvds endpoints from
> > SoC dtsi files, then should be instead declared in the board dts or in
> > overlays.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks for your patch!
> I'm interested in hearing Rob's opinion about the general idea...
Me too :-)
> > ---
> > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> > 11 files changed, 28 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index 6f4fffacfca2..9a8c1bd923af 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> > };
> > port@1 {
> > reg = <1>;
> > - lvds0_out: endpoint {
> > - };
>
> As there are several DTS files that refer to this label, this change
> will break them?
While files are you referring to ?
> > base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
>
> Why does this depend on a commit in drm-next?
> DTS changes are supposed to go in through renesas-devel and soc.
Because it happens to have been developed there, that's all. There's no
specific reason.
> > prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> > prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> > prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> > prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> > prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> > prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
>
> While Google does not index by commit ID or patch ID, at least the
> base-commit can be found easily in linux-next. But even with some
> scripting, the prerequisites cannot. What are these prerequisites?
> Do you have lore links?
Probably something completely unrelated that I had in my tree when
generating the series. You can likely ignore that, sorry for the noise.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
2022-01-10 11:24 ` Laurent Pinchart
@ 2022-01-10 12:07 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2022-01-10 12:07 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Magnus Damm
Hi Laurent,
On Mon, Jan 10, 2022 at 12:24 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Mon, Jan 10, 2022 at 11:10:59AM +0100, Geert Uytterhoeven wrote:
> > On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart wrote:
> > > Endpoints node must have a remote-endpoint property, as endpoints only
> > > exist to model a link between ports. Drop the empty lvds endpoints from
> > > SoC dtsi files, then should be instead declared in the board dts or in
> > > overlays.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > Thanks for your patch!
> > I'm interested in hearing Rob's opinion about the general idea...
>
> Me too :-)
>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> > > 11 files changed, 28 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > index 6f4fffacfca2..9a8c1bd923af 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > > @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> > > };
> > > port@1 {
> > > reg = <1>;
> > > - lvds0_out: endpoint {
> > > - };
> >
> > As there are several DTS files that refer to this label, this change
> > will break them?
>
> While files are you referring to ?
The various board files.
Seems like I was slightly misled by your fake prerequisites.
Upon closer inspection, the board files do not rely on the labels in
the SoC .dtsi files, but (re)define their own, matching the former.
So everything is fine.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
> >
> > Why does this depend on a commit in drm-next?
> > DTS changes are supposed to go in through renesas-devel and soc.
>
> Because it happens to have been developed there, that's all. There's no
> specific reason.
>
> > > prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> > > prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> > > prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> > > prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> > > prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> > > prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
> >
> > While Google does not index by commit ID or patch ID, at least the
> > base-commit can be found easily in linux-next. But even with some
> > scripting, the prerequisites cannot. What are these prerequisites?
> > Do you have lore links?
>
> Probably something completely unrelated that I had in my tree when
> generating the series. You can likely ignore that, sorry for the noise.
OK.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
@ 2022-01-26 11:10 ` Geert Uytterhoeven
2022-02-21 14:26 ` Kieran Bingham
1 sibling, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2022-01-26 11:10 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring, Geert Uytterhoeven, Magnus Damm
Hi Laurent,
On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty rgb output endpoints
> from SoC dtsi files, and declare them in the board dts instead.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
If we go this route, ulcb-kf.dtsi needs a similar change as
beacon-renesom-baseboard.dtsi.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
2022-01-10 11:24 ` Laurent Pinchart
@ 2022-02-21 14:10 ` Laurent Pinchart
1 sibling, 0 replies; 9+ messages in thread
From: Laurent Pinchart @ 2022-02-21 14:10 UTC (permalink / raw)
To: Rob Herring
Cc: Geert Uytterhoeven, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Magnus Damm
On Mon, Jan 10, 2022 at 11:10:59AM +0100, Geert Uytterhoeven wrote:
> On Wed, Dec 29, 2021 at 8:18 PM Laurent Pinchart wrote:
> > Endpoints node must have a remote-endpoint property, as endpoints only
> > exist to model a link between ports. Drop the empty lvds endpoints from
> > SoC dtsi files, then should be instead declared in the board dts or in
> > overlays.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks for your patch!
> I'm interested in hearing Rob's opinion about the general idea...
Let's see if Rob could find a few cycles to spare then :-)
> > ---
> > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> > 11 files changed, 28 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index 6f4fffacfca2..9a8c1bd923af 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> > };
> > port@1 {
> > reg = <1>;
> > - lvds0_out: endpoint {
> > - };
>
> As there are several DTS files that refer to this label, this change
> will break them?
>
> > base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
>
> Why does this depend on a commit in drm-next?
> DTS changes are supposed to go in through renesas-devel and soc.
>
> > prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> > prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> > prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> > prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> > prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> > prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
>
> While Google does not index by commit ID or patch ID, at least the
> base-commit can be found easily in linux-next. But even with some
> scripting, the prerequisites cannot. What are these prerequisites?
> Do you have lore links?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
@ 2022-02-21 14:17 ` Kieran Bingham
2 siblings, 0 replies; 9+ messages in thread
From: Kieran Bingham @ 2022-02-21 14:17 UTC (permalink / raw)
To: Laurent Pinchart, linux-renesas-soc
Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm
Hi Laurent,
Quoting Laurent Pinchart (2021-12-29 19:18:37)
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty lvds endpoints from
> SoC dtsi files, then should be instead declared in the board dts or in
> overlays.
Aha, I was hit by this recently(ish) too, as trying to declare things
that are not yet connected as placeholders was ending up generating
warnings for me.
It's a pain, as having the label placeholder makes it easier to connect
to the endpoint later. But this was failing validation otherwise for me,
so I presume it's the correct thing to do. Seems we're still hoping for
some feedback from Rob on this, but it's fine with me.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 ----
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 4 ----
> 11 files changed, 28 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 6f4fffacfca2..9a8c1bd923af 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 0f7bdfc90a0d..8912c1665ed9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -2616,8 +2616,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index d597772c4c37..263f39fb8ad9 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -1910,8 +1910,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -1937,8 +1935,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 379a1300272b..02b35e68a3fa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -2891,8 +2891,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 1768a3e6bb8d..0919d8f540c4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3362,8 +3362,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index 2bd8169735d3..221ee1ec415d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2959,8 +2959,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 08df75606430..5f3046eee365 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2771,8 +2771,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 517892cf6294..ad021b2703ab 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1190,8 +1190,6 @@ lvds0_in: endpoint {
> };
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 6347d15e66b6..29f1161da957 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1567,8 +1567,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 0ea300a8147d..735c46217835 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -2059,8 +2059,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -2086,8 +2084,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 16ad5fc23a67..759505bd1a44 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1380,8 +1380,6 @@ lvds0_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds0_out: endpoint {
> - };
> };
> };
> };
> @@ -1407,8 +1405,6 @@ lvds1_in: endpoint {
>
> port@1 {
> reg = <1>;
> - lvds1_out: endpoint {
> - };
> };
> };
> };
>
> base-commit: 2b534e90a1e31c7fc9536b512b72274cc3575f4c
> prerequisite-patch-id: 98434eb22c020924bc338316e54a7b42ea339e9f
> prerequisite-patch-id: ce261c9865255051f2c2107a930b0f15ce862703
> prerequisite-patch-id: 500ab746415c5421e41128c2b0db35987d8d7a49
> prerequisite-patch-id: ad2d5ad025f9cfa0dc453d7e0b2aa96b4514afd7
> prerequisite-patch-id: ac76bcc0f7b278863e362db083a7d64bbd0bd030
> prerequisite-patch-id: c7a7c3a6b9dbbae18a768160db70d7010ea71ca5
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
2022-01-26 11:10 ` Geert Uytterhoeven
@ 2022-02-21 14:26 ` Kieran Bingham
1 sibling, 0 replies; 9+ messages in thread
From: Kieran Bingham @ 2022-02-21 14:26 UTC (permalink / raw)
To: Laurent Pinchart, linux-renesas-soc
Cc: devicetree, Rob Herring, Geert Uytterhoeven, Magnus Damm
Quoting Laurent Pinchart (2021-12-29 19:18:38)
> Endpoints node must have a remote-endpoint property, as endpoints only
> exist to model a link between ports. Drop the empty rgb output endpoints
> from SoC dtsi files, and declare them in the board dts instead.
>
Ah yes, it was when I was adding the DSI output endpoints. I also ended
up ommitting any placeholders. So again, removing still seems the
consistent thing to do for now.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> .../boot/dts/renesas/beacon-renesom-baseboard.dtsi | 10 ++++++++--
> arch/arm64/boot/dts/renesas/draak.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/ebisu.dtsi | 2 +-
> arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 2 +-
> arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77961.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 --
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 --
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
> 17 files changed, 12 insertions(+), 30 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> index 2692cc64bff6..1465adc43580 100644
> --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi
> @@ -272,8 +272,14 @@ &can1 {
> status = "okay";
> };
>
> -&du_out_rgb {
> - remote-endpoint = <&rgb_panel>;
> +&du {
> + ports {
> + port@0 {
Would there be any benefit to labelling the ports for convenience?
Probably not enough, and it would only be there as a shorthand to be
able to still get to the endpoint which would still need it's own label
I think... so I think this is fine as is anyway.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> + du_out_rgb: endpoint {
> + remote-endpoint = <&rgb_panel>;
> + };
> + };
> + };
> };
>
> &ehci0 {
> diff --git a/arch/arm64/boot/dts/renesas/draak.dtsi b/arch/arm64/boot/dts/renesas/draak.dtsi
> index eb0327c0df48..b09f06086840 100644
> --- a/arch/arm64/boot/dts/renesas/draak.dtsi
> +++ b/arch/arm64/boot/dts/renesas/draak.dtsi
> @@ -285,7 +285,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi
> index 67231c8576c5..9e6093524682 100644
> --- a/arch/arm64/boot/dts/renesas/ebisu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi
> @@ -356,7 +356,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index 9a8c1bd923af..6105316ccac2 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2733,8 +2733,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 8912c1665ed9..7cdf009b1ee6 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -2578,8 +2578,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index 4e72e4f2bab0..5a6ea08ffd2b 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -172,7 +172,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&tda19988_in>;
> };
> };
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index 263f39fb8ad9..8b875b212a48 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -1867,8 +1867,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 02b35e68a3fa..b9ab5cb01419 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -2853,8 +2853,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 0919d8f540c4..b88af4c90f33 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -3318,8 +3318,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index 221ee1ec415d..5e12e80d115e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -2921,8 +2921,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index ba9358abebb2..4df8ffa84461 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -2706,8 +2706,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 5f3046eee365..454e95222acf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2733,8 +2733,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
> port@1 {
> reg = <1>;
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index ad021b2703ab..dc11845625c4 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1156,8 +1156,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index 29f1161da957..53d0e6b4b75e 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -1532,8 +1532,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 735c46217835..f49173045232 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -2016,8 +2016,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 759505bd1a44..3237ff4e5c77 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -1337,8 +1337,6 @@ ports {
>
> port@0 {
> reg = <0>;
> - du_out_rgb: endpoint {
> - };
> };
>
> port@1 {
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index bf37777dca31..0b0b1fc3a270 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -385,7 +385,7 @@ &du {
>
> ports {
> port@0 {
> - endpoint {
> + du_out_rgb: endpoint {
> remote-endpoint = <&adv7123_in>;
> };
> };
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-02-21 14:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-29 19:18 [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Laurent Pinchart
2021-12-29 19:18 ` [PATCH 2/2] arm64: dts: renesas: Remove empty rgb output endpoints Laurent Pinchart
2022-01-26 11:10 ` Geert Uytterhoeven
2022-02-21 14:26 ` Kieran Bingham
2022-01-10 10:10 ` [PATCH 1/2] arm64: dts: renesas: Remove empty lvds endpoints Geert Uytterhoeven
2022-01-10 11:24 ` Laurent Pinchart
2022-01-10 12:07 ` Geert Uytterhoeven
2022-02-21 14:10 ` Laurent Pinchart
2022-02-21 14:17 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.